[libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

[libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

[xen.org]

[-- Attachment #1: Type: text/plain, Size: 3107 bytes --]

flight 33157 libvirt running [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/33157/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64-libvirt             <none executed>              queued
 test-amd64-i386-libvirt         <none executed>              queued
 test-amd64-amd64-libvirt        <none executed>              queued
 build-armhf-libvirt           5 libvirt-build             fail REGR. vs. 32648
 build-i386-libvirt            5 libvirt-build             fail REGR. vs. 32648
 build-amd64                   2 hosts-allocate           running [st=running!]
 build-amd64-pvops             2 hosts-allocate           running [st=running!]

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              18ec863d19bdaf517e26642f794b7ee4d1d2c53f
baseline version:
 libvirt              2360fe5d24175835d3f5fd1c7e8e6e13addab629

------------------------------------------------------------
People who touched revisions under test:
  Cedric Bosdonnat <cbosdonnat@suse.com>
  Chunyan Liu <cyliu@suse.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Daniel P. Berrange <berrange@redhat.com>
  Eric Blake <eblake@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Kiarie Kahurani <davidkiarie4@gmail.com>
  Luyao Huang <lhuang@redhat.com>
  Nehal J Wani <nehaljw.kkd1@gmail.com>
  Pavel Hrdina <phrdina@redhat.com>
------------------------------------------------------------

jobs:
 build-amd64                                                  preparing
 build-armhf                                                  pass
 build-i386                                                   pass
 build-amd64-libvirt                                          queued
 build-armhf-libvirt                                          fail
 build-i386-libvirt                                           fail
 build-amd64-pvops                                            preparing
 build-armhf-pvops                                            pass
 build-i386-pvops                                             pass
 test-amd64-amd64-libvirt                                     queued
 test-armhf-armhf-libvirt                                     blocked
 test-amd64-i386-libvirt                                      queued


------------------------------------------------------------
sg-report-flight on osstest.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images

Logs, config files, etc. are available at
    http://www.chiark.greenend.org.uk/~xensrcts/logs

Test harness code can be found at
    http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary

broken-job build-amd64-libvirt queued
broken-job test-amd64-i386-libvirt queued
broken-job test-amd64-amd64-libvirt queued
broken build-amd64 hosts-allocate running
broken build-amd64-pvops hosts-allocate running

Not pushing.

(No revision log; it would be 377 lines long.)


[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

[Jim Fehlig]

xen.org wrote:
> flight 33157 libvirt running [real]
> http://www.chiark.greenend.org.uk/~xensrcts/logs/33157/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  build-amd64-libvirt             <none executed>              queued
>  test-amd64-i386-libvirt         <none executed>              queued
>  test-amd64-amd64-libvirt        <none executed>              queued
>  build-armhf-libvirt           5 libvirt-build             fail REGR. vs. 32648
>  build-i386-libvirt            5 libvirt-build             fail REGR. vs. 32648
>   

The build failure here was

make[2]: *** No rule to make target `xenconfig/xen_xl_disk.h', needed by
`all'. Stop.

Now fixed with libvirt commits edacdb3d and 533349ff.

Regards,
Jim

Re: [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

[Ian Campbell]

On Thu, 2015-01-08 at 09:37 -0700, Jim Fehlig wrote:
> xen.org wrote:
> > flight 33157 libvirt running [real]
> > http://www.chiark.greenend.org.uk/~xensrcts/logs/33157/
> >
> > Regressions :-(
> >
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> >  build-amd64-libvirt             <none executed>              queued
> >  test-amd64-i386-libvirt         <none executed>              queued
> >  test-amd64-amd64-libvirt        <none executed>              queued
> >  build-armhf-libvirt           5 libvirt-build             fail REGR. vs. 32648
> >  build-i386-libvirt            5 libvirt-build             fail REGR. vs. 32648
> >   
> 
> The build failure here was
> 
> make[2]: *** No rule to make target `xenconfig/xen_xl_disk.h', needed by
> `all'. Stop.
> 
> Now fixed with libvirt commits edacdb3d and 533349ff.

Great, thanks for the heads up.

It looks like libvirt has imported the disk syntax parser stuff from
xen.git/tools/libxl/libxlu_disk_l.l? Why not just use libxlu.so which
Xen ships containing that code? We do so pretty much exactly because we
thought it would be useful to libvirt...

I must confess that I thought you already did use libxlu...

Ian.

Re: [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

[Jim Fehlig]

Ian Campbell wrote:
> On Thu, 2015-01-08 at 09:37 -0700, Jim Fehlig wrote:
>   
>> xen.org wrote:
>>     
>>> flight 33157 libvirt running [real]
>>> http://www.chiark.greenend.org.uk/~xensrcts/logs/33157/
>>>
>>> Regressions :-(
>>>
>>> Tests which did not succeed and are blocking,
>>> including tests which could not be run:
>>>  build-amd64-libvirt             <none executed>              queued
>>>  test-amd64-i386-libvirt         <none executed>              queued
>>>  test-amd64-amd64-libvirt        <none executed>              queued
>>>  build-armhf-libvirt           5 libvirt-build             fail REGR. vs. 32648
>>>  build-i386-libvirt            5 libvirt-build             fail REGR. vs. 32648
>>>   
>>>       
>> The build failure here was
>>
>> make[2]: *** No rule to make target `xenconfig/xen_xl_disk.h', needed by
>> `all'. Stop.
>>
>> Now fixed with libvirt commits edacdb3d and 533349ff.
>>     
>
> Great, thanks for the heads up.
>
> It looks like libvirt has imported the disk syntax parser stuff from
> xen.git/tools/libxl/libxlu_disk_l.l?

Yes.

> Why not just use libxlu.so which
> Xen ships containing that code? We do so pretty much exactly because we
> thought it would be useful to libvirt...
>   

Because I didn't know :-(.  And yes, it would be useful to libvirt, and
would have saved myself and others considerable time.  In hindsight, I
should have cc'd xen-devel on the original patch series.  I think Wei
was the only Xen tools dev to review the series, and he too missed your
suggestion.

> I must confess that I thought you already did use libxlu...
>   

No, not directly.  But I will be doing so now.  I should try to revert
all this nonsense and use libxlu before it ends up in the next libvirt
release.

Thanks a lot Ian!

Regards,
Jim

Re: [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

[Jim Fehlig]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

Jim Fehlig wrote:
> Ian Campbell wrote:
>
>   
>> I must confess that I thought you already did use libxlu...
>>   
>>     
>
> No, not directly.  But I will be doing so now.  I should try to revert
> all this nonsense and use libxlu before it ends up in the next libvirt
> release.
>   

Hmm, I don't think that is going to be possible since libxlutil.h has
never been installed :-(.  I guess something like the below (untested)
patch would have been necessary long ago.  Changing libvirt to use
libxlutil would break a lot of builds where the distro's existing
xen-devel package is missing libxlutil.h.

Regards,
Jim

[-- Attachment #2: install-libxlutil.h.patch --]
[-- Type: text/x-diff, Size: 1204 bytes --]

>From 3425c1cef21d0295fa8fbf9465ea7273b717f637 Mon Sep 17 00:00:00 2001
From: Jim Fehlig <jfehlig@suse.com>
Date: Thu, 8 Jan 2015 14:43:28 -0700
Subject: [PATCH] Install libxlutil.h

libxlutil.{a,so} are installed, but not the corresponding header
file.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---
 tools/libxl/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index df08c8a..0fe2868 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -266,7 +266,7 @@ install: all
 	$(SYMLINK_SHLIB) libxlutil.so.$(XLUMAJOR).$(XLUMINOR) $(DESTDIR)$(LIBDIR)/libxlutil.so.$(XLUMAJOR)
 	$(SYMLINK_SHLIB) libxlutil.so.$(XLUMAJOR) $(DESTDIR)$(LIBDIR)/libxlutil.so
 	$(INSTALL_DATA) libxlutil.a $(DESTDIR)$(LIBDIR)
-	$(INSTALL_DATA) libxl.h libxl_event.h libxl_json.h _libxl_types.h _libxl_types_json.h _libxl_list.h libxl_utils.h libxl_uuid.h $(DESTDIR)$(INCLUDEDIR)
+	$(INSTALL_DATA) libxl.h libxl_event.h libxl_json.h _libxl_types.h _libxl_types_json.h _libxl_list.h libxl_utils.h libxl_uuid.h libxlutil.h $(DESTDIR)$(INCLUDEDIR)
 	$(INSTALL_DATA) bash-completion $(DESTDIR)$(BASH_COMPLETION_DIR)/xl.sh
 
 .PHONY: clean
-- 
1.8.0.1


[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

[Jim Fehlig]

Jim Fehlig wrote:
> Jim Fehlig wrote:
>   
>> Ian Campbell wrote:
>>
>>   
>>     
>>> I must confess that I thought you already did use libxlu...
>>>   
>>>     
>>>       
>> No, not directly.  But I will be doing so now.  I should try to revert
>> all this nonsense and use libxlu before it ends up in the next libvirt
>> release.
>>   
>>     
>
> Hmm, I don't think that is going to be possible since libxlutil.h has
> never been installed :-(.

That's a bit pessimistic.  I could always add something like the
following hack to libvirt

typedef struct XLU_Config XLU_Config;

extern XLU_Config *xlu_cfg_init(FILE *report,
                                const char *report_filename);

extern int xlu_disk_parse(XLU_Config *cfg,
                          int nspecs,
                          const char *const *specs,
                          libxl_device_disk *disk);

Regards,
Jim

Re: [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

[Ian Campbell]

On Thu, 2015-01-08 at 14:56 -0700, Jim Fehlig wrote:
> Jim Fehlig wrote:
> > Ian Campbell wrote:
> >
> >   
> >> I must confess that I thought you already did use libxlu...
> >>   
> >>     
> >
> > No, not directly.  But I will be doing so now.  I should try to revert
> > all this nonsense and use libxlu before it ends up in the next libvirt
> > release.
> >   
> 
> Hmm, I don't think that is going to be possible since libxlutil.h has
> never been installed :-(.  I guess something like the below (untested)
> patch would have been necessary long ago.  Changing libvirt to use
> libxlutil would break a lot of builds where the distro's existing
> xen-devel package is missing libxlutil.h.

Whoops, yes, how embarrassing!

Acked-by: Ian Campbell <ian.campbell@citrix.com>

And of course it should be backported to everywhere.

Later:
On Thu, 2015-01-08 at 22:59 -0700, Jim Fehlig wrote:
[...]
> That's a bit pessimistic.  I could always add something like the
> following hack to libvirt

I'd say that if you combine that with an AC_CHECK_HEADERS([libxlutil.h])
in configure.ac and wrap the hack in #ifndef HAVE_LIBXLUTIL_H that
wouldn't be too aweful a hack.

> 
> typedef struct XLU_Config XLU_Config;
> 
> extern XLU_Config *xlu_cfg_init(FILE *report,
>                                 const char *report_filename);
> 
> extern int xlu_disk_parse(XLU_Config *cfg,
>                           int nspecs,
>                           const char *const *specs,
>                           libxl_device_disk *disk);
> 
> Regards,
> Jim
> 
> 

Re: [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 1132 bytes --]

On Thu, 2015-01-08 at 14:56 -0700, Jim Fehlig wrote:
> Jim Fehlig wrote:
> > No, not directly.  But I will be doing so now.  I should try to revert
> > all this nonsense and use libxlu before it ends up in the next libvirt
> > release.
> >   
> 
> Hmm, I don't think that is going to be possible since libxlutil.h has
> never been installed :-(.  
>
Wow... That's bad! :-/

> From 3425c1cef21d0295fa8fbf9465ea7273b717f637 Mon Sep 17 00:00:00 2001
> From: Jim Fehlig <jfehlig@suse.com>
> Date: Thu, 8 Jan 2015 14:43:28 -0700
> Subject: [PATCH] Install libxlutil.h
>
> libxlutil.{a,so} are installed, but not the corresponding header
> file.
>
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
>
FWIW, Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

BTW, would backporting this patch makes things at least a bit better?

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

[Jim Fehlig]

Dario Faggioli wrote:
> On Thu, 2015-01-08 at 14:56 -0700, Jim Fehlig wrote:
>   
>> Jim Fehlig wrote:
>>     
>>> No, not directly.  But I will be doing so now.  I should try to revert
>>> all this nonsense and use libxlu before it ends up in the next libvirt
>>> release.
>>>   
>>>       
>> Hmm, I don't think that is going to be possible since libxlutil.h has
>> never been installed :-(.  
>>
>>     
> Wow... That's bad! :-/
>
>   
>> From 3425c1cef21d0295fa8fbf9465ea7273b717f637 Mon Sep 17 00:00:00 2001
>> From: Jim Fehlig <jfehlig@suse.com>
>> Date: Thu, 8 Jan 2015 14:43:28 -0700
>> Subject: [PATCH] Install libxlutil.h
>>
>> libxlutil.{a,so} are installed, but not the corresponding header
>> file.
>>
>> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
>>
>>     
> FWIW, Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
>
> BTW, would backporting this patch makes things at least a bit better?
>   

Yes.  As Ian noted, it should be backported everywhere.  But I'll also
provide a workaround in libvirt.

Regards,
Jim

Re: [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

[Ian Campbell]

On Thu, 2015-01-08 at 14:56 -0700, Jim Fehlig wrote:
> From 3425c1cef21d0295fa8fbf9465ea7273b717f637 Mon Sep 17 00:00:00 2001
> From: Jim Fehlig <jfehlig@suse.com>
> Date: Thu, 8 Jan 2015 14:43:28 -0700
> Subject: [PATCH] Install libxlutil.h
> 
> libxlutil.{a,so} are installed, but not the corresponding header
> file.
> 
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>

Nearly missed actually applying this one, sorry. Now done, thanks.

Ian: This should be backported everywhere please.

Ian.

Re: [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

[Ian Jackson]

Ian Campbell writes ("Re: [Xen-devel] [libvirt test] 33157: regressions -	trouble: blocked/fail/pass/preparing/queued"):
> Ian: This should be backported everywhere please.

Noted, thanks.

Ian.