From: Eric Dumazet <eric.dumazet@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Stephen Hemminger <stephen@networkplumber.org>,
Network Development <netdev@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)
Date: Sun, 01 Nov 2015 18:14:43 -0800 [thread overview]
Message-ID: <1446430483.6254.114.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <20151102002421.GP22011@ZenIV.linux.org.uk>
On Mon, 2015-11-02 at 00:24 +0000, Al Viro wrote:
> This ought to be a bit cleaner. Eric, could you test the variant below on your
> setup?
Sure !
5 runs of :
lpaa24:~# taskset ff0ff ./opensock -t 16 -n 10000000 -l 10
total = 4386311
total = 4560402
total = 4437309
total = 4516227
total = 4478778
With 48 threads :
./opensock -t 48 -n 10000000 -l 10
total = 4940245
total = 4848513
total = 4813153
total = 4813946
total = 5127804
Perf output taken on the 16 threads run :
74.71% opensock opensock [.] memset
|
--- memset
5.64% opensock [kernel.kallsyms] [k] queued_spin_lock_slowpath
|
--- queued_spin_lock_slowpath
|
|--99.89%-- _raw_spin_lock
| |
| |--52.74%-- __close_fd
| | sys_close
| | entry_SYSCALL_64_fastpath
| | __libc_close
| | |
| | --100.00%-- 0x0
| |
| |--46.97%-- __alloc_fd
| | get_unused_fd_flags
| | sock_map_fd
| | sys_socket
| | entry_SYSCALL_64_fastpath
| | __socket
| | |
| | --100.00%-- 0x0
| --0.30%-- [...]
--0.11%-- [...]
1.69% opensock [kernel.kallsyms] [k] _raw_spin_lock
|
--- _raw_spin_lock
|
|--27.37%-- get_unused_fd_flags
| sock_map_fd
| sys_socket
| entry_SYSCALL_64_fastpath
| __socket
|
|--22.40%-- sys_close
| entry_SYSCALL_64_fastpath
| __libc_close
|
|--15.79%-- cache_alloc_refill
| |
| |--99.27%-- kmem_cache_alloc
| | |
| | |--81.25%-- sk_prot_alloc
| | | sk_alloc
| | | inet_create
| | | __sock_create
| | | sock_create
| | | sys_socket
| | | entry_SYSCALL_64_fastpath
| | | __socket
| | |
| | |--9.08%-- sock_alloc_inode
| | | alloc_inode
| | | new_inode_pseudo
| | | sock_alloc
| | | __sock_create
| | | sock_create
| | | sys_socket
| | | entry_SYSCALL_64_fastpath
| | | __socket
| | |
| | |--4.98%-- __d_alloc
| | | d_alloc_pseudo
| | | sock_alloc_file
| | | sock_map_fd
| | | sys_socket
| | | entry_SYSCALL_64_fastpath
| | | __socket
| | |
| | --4.69%-- get_empty_filp
| | alloc_file
| | sock_alloc_file
| | sock_map_fd
| | sys_socket
| | entry_SYSCALL_64_fastpath
| | __socket
| |
| --0.73%-- kmem_cache_alloc_trace
| sock_alloc_inode
| alloc_inode
| new_inode_pseudo
| sock_alloc
| __sock_create
| sock_create
| sys_socket
| entry_SYSCALL_64_fastpath
| __socket
|
|--10.80%-- sock_alloc_file
| sock_map_fd
| sys_socket
| entry_SYSCALL_64_fastpath
| __socket
|
|--7.47%-- sock_alloc
| __sock_create
| sock_create
| sys_socket
| entry_SYSCALL_64_fastpath
| __socket
|
|--6.96%-- kmem_cache_alloc
| |
| |--72.94%-- sk_prot_alloc
| | sk_alloc
| | inet_create
| | __sock_create
| | sock_create
| | sys_socket
| | entry_SYSCALL_64_fastpath
| | __socket
| |
| |--15.51%-- sock_alloc_inode
| | alloc_inode
| | new_inode_pseudo
| | sock_alloc
| | __sock_create
| | sock_create
| | sys_socket
| | entry_SYSCALL_64_fastpath
| | __socket
| |
| |--7.59%-- get_empty_filp
| | alloc_file
| | sock_alloc_file
| | sock_map_fd
| | sys_socket
| | entry_SYSCALL_64_fastpath
| | __socket
| |
| --3.96%-- __d_alloc
| d_alloc_pseudo
| sock_alloc_file
| sock_map_fd
| sys_socket
| entry_SYSCALL_64_fastpath
| __socket
|
|--3.74%-- d_instantiate
| sock_alloc_file
| sock_map_fd
| sys_socket
| entry_SYSCALL_64_fastpath
| __socket
|
|--2.03%-- iput
| __dentry_kill
| dput
| __fput
| ____fput
| task_work_run
| prepare_exit_to_usermode
| syscall_return_slowpath
| int_ret_from_sys_call
| __libc_close
|
|--0.60%-- __fsnotify_inode_delete
| __destroy_inode
| destroy_inode
| evict
| iput
| __dentry_kill
| dput
| __fput
| ____fput
| task_work_run
| prepare_exit_to_usermode
| syscall_return_slowpath
| int_ret_from_sys_call
| __libc_close
|
|--0.55%-- evict
| iput
| __dentry_kill
| dput
| __fput
| ____fput
| task_work_run
| prepare_exit_to_usermode
| syscall_return_slowpath
| int_ret_from_sys_call
| __libc_close
|
|--0.53%-- inet_release
| sock_release
| sock_close
| __fput
| ____fput
| task_work_run
| prepare_exit_to_usermode
| syscall_return_slowpath
| int_ret_from_sys_call
| __libc_close
|
|--0.51%-- __fput
| ____fput
| task_work_run
| prepare_exit_to_usermode
| syscall_return_slowpath
Perf taken on the 48 threads run :
48.34% opensock [kernel.kallsyms] [k] queued_spin_lock_slowpath
|
--- queued_spin_lock_slowpath
|
|--99.93%-- _raw_spin_lock
| |
| |--50.11%-- __close_fd
| | sys_close
| | entry_SYSCALL_64_fastpath
| | __libc_close
| | |
| | --100.00%-- 0x0
| |
| |--49.85%-- __alloc_fd
| | get_unused_fd_flags
| | sock_map_fd
| | sys_socket
| | entry_SYSCALL_64_fastpath
| | __socket
| | |
| | --100.00%-- 0x0
| --0.03%-- [...]
--0.07%-- [...]
41.03% opensock opensock [.] memset
|
--- memset
0.69% opensock [kernel.kallsyms] [k] _raw_spin_lock
|
--- _raw_spin_lock
|
|--30.22%-- sys_close
| entry_SYSCALL_64_fastpath
| __libc_close
| |
| --100.00%-- 0x0
|
|--30.15%-- get_unused_fd_flags
| sock_map_fd
| sys_socket
| entry_SYSCALL_64_fastpath
| __socket
|
|--14.61%-- cache_alloc_refill
| |
next prev parent reply other threads:[~2015-11-02 2:14 UTC|newest]
Thread overview: 138+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 16:59 Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3) Stephen Hemminger
2015-10-19 23:33 ` Eric Dumazet
2015-10-20 1:12 ` Alan Burlison
2015-10-20 1:45 ` Eric Dumazet
2015-10-20 9:59 ` Alan Burlison
2015-10-20 11:24 ` David Miller
2015-10-20 11:39 ` Alan Burlison
2015-10-20 13:19 ` Fw: " Eric Dumazet
2015-10-20 13:45 ` Alan Burlison
2015-10-20 15:30 ` Eric Dumazet
2015-10-20 18:31 ` Alan Burlison
2015-10-20 18:42 ` Eric Dumazet
2015-10-21 10:25 ` David Laight
2015-10-21 10:49 ` Alan Burlison
2015-10-21 11:28 ` Eric Dumazet
2015-10-21 13:03 ` Alan Burlison
2015-10-21 13:29 ` Eric Dumazet
2015-10-21 3:49 ` Al Viro
2015-10-21 14:38 ` Alan Burlison
2015-10-21 15:30 ` David Miller
2015-10-21 16:04 ` Casper.Dik
2015-10-21 21:18 ` Eric Dumazet
2015-10-21 21:28 ` Al Viro
2015-10-21 16:32 ` Fw: " Eric Dumazet
2015-10-21 18:51 ` Al Viro
2015-10-21 20:33 ` Casper.Dik
2015-10-22 4:21 ` Al Viro
2015-10-22 10:55 ` Alan Burlison
2015-10-22 18:16 ` Al Viro
2015-10-22 20:15 ` Alan Burlison
2015-11-02 10:03 ` David Laight
2015-11-02 10:29 ` Al Viro
2015-10-21 22:28 ` Alan Burlison
2015-10-22 1:29 ` David Miller
2015-10-22 4:17 ` Alan Burlison
2015-10-22 4:44 ` Al Viro
2015-10-22 6:03 ` Al Viro
2015-10-22 6:34 ` Casper.Dik
2015-10-22 17:21 ` Al Viro
2015-10-22 18:24 ` Casper.Dik
2015-10-22 19:07 ` Al Viro
2015-10-22 19:51 ` Casper.Dik
2015-10-22 21:57 ` Al Viro
2015-10-23 9:52 ` Casper.Dik
2015-10-23 13:02 ` Eric Dumazet
2015-10-23 13:20 ` Casper.Dik
2015-10-23 13:48 ` Eric Dumazet
2015-10-23 14:13 ` Eric Dumazet
2015-10-23 13:35 ` Alan Burlison
2015-10-23 14:21 ` Eric Dumazet
2015-10-23 15:46 ` Alan Burlison
2015-10-23 16:00 ` Eric Dumazet
2015-10-23 16:07 ` Alan Burlison
2015-10-23 16:19 ` Eric Dumazet
2015-10-23 16:40 ` Alan Burlison
2015-10-23 17:47 ` Eric Dumazet
2015-10-23 17:59 ` [PATCH net-next] af_unix: do not report POLLOUT on listeners Eric Dumazet
2015-10-25 13:45 ` David Miller
2015-10-24 2:30 ` [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3) Al Viro
2015-10-27 9:08 ` Casper.Dik
2015-10-27 10:52 ` Alan Burlison
2015-10-27 12:01 ` Eric Dumazet
2015-10-27 12:27 ` Alan Burlison
2015-10-27 12:44 ` Eric Dumazet
2015-10-27 13:42 ` David Miller
2015-10-27 13:37 ` Alan Burlison
2015-10-27 13:59 ` David Miller
2015-10-27 14:13 ` Alan Burlison
2015-10-27 14:39 ` David Miller
2015-10-27 14:39 ` Alan Burlison
2015-10-27 15:04 ` David Miller
2015-10-27 15:53 ` Alan Burlison
2015-10-27 23:17 ` Al Viro
2015-10-28 0:13 ` Eric Dumazet
2015-10-28 12:35 ` Al Viro
2015-10-28 13:24 ` Eric Dumazet
2015-10-28 14:47 ` Eric Dumazet
2015-10-28 21:13 ` Al Viro
2015-10-28 21:44 ` Eric Dumazet
2015-10-28 22:33 ` Al Viro
2015-10-28 23:08 ` Eric Dumazet
2015-10-29 0:15 ` Al Viro
2015-10-29 3:29 ` Eric Dumazet
2015-10-29 4:16 ` Al Viro
2015-10-29 12:35 ` Eric Dumazet
2015-10-29 13:48 ` Eric Dumazet
2015-10-30 17:18 ` Linus Torvalds
2015-10-30 21:02 ` Al Viro
2015-10-30 21:23 ` Linus Torvalds
2015-10-30 21:50 ` Linus Torvalds
2015-10-30 22:33 ` Al Viro
2015-10-30 23:52 ` Linus Torvalds
2015-10-31 0:09 ` Al Viro
2015-10-31 15:59 ` Eric Dumazet
2015-10-31 19:34 ` Al Viro
2015-10-31 19:54 ` Linus Torvalds
2015-10-31 20:29 ` Al Viro
2015-11-02 0:24 ` Al Viro
2015-11-02 0:59 ` Linus Torvalds
2015-11-02 2:14 ` Eric Dumazet [this message]
2015-11-02 6:22 ` Al Viro
2015-10-31 20:45 ` Eric Dumazet
2015-10-31 21:23 ` Linus Torvalds
2015-10-31 21:51 ` Al Viro
2015-10-31 22:34 ` Eric Dumazet
2015-10-31 1:07 ` Eric Dumazet
2015-10-28 16:04 ` Alan Burlison
2015-10-29 14:58 ` David Holland
2015-10-29 15:18 ` Alan Burlison
2015-10-29 16:01 ` David Holland
2015-10-29 16:15 ` Alan Burlison
2015-10-29 17:07 ` Al Viro
2015-10-29 17:12 ` Alan Burlison
2015-10-30 1:54 ` David Miller
2015-10-30 1:55 ` David Miller
2015-10-30 5:44 ` David Holland
2015-10-30 17:43 ` David Laight
2015-10-30 21:09 ` Al Viro
2015-11-04 15:54 ` David Laight
2015-11-04 16:27 ` Al Viro
2015-11-06 15:07 ` David Laight
2015-11-06 19:31 ` Al Viro
2015-10-22 6:51 ` Casper.Dik
2015-10-22 11:18 ` Alan Burlison
2015-10-22 11:15 ` Alan Burlison
2015-10-22 6:15 ` Casper.Dik
2015-10-22 11:30 ` Eric Dumazet
2015-10-22 11:58 ` Alan Burlison
2015-10-22 12:10 ` Eric Dumazet
2015-10-22 13:12 ` David Miller
2015-10-22 13:14 ` Alan Burlison
2015-10-22 17:05 ` Al Viro
2015-10-22 17:39 ` Alan Burlison
2015-10-22 18:56 ` Al Viro
2015-10-22 19:50 ` Casper.Dik
2015-10-23 17:09 ` Al Viro
2015-10-23 18:30 ` Fw: " David Holland
2015-10-23 19:51 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446430483.6254.114.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.