From: Minchan Kim <minchan@kernel.org> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk <mtk.manpages@gmail.com>, linux-api@vger.kernel.org, Hugh Dickins <hughd@google.com>, Johannes Weiner <hannes@cmpxchg.org>, Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Jason Evans <je@fb.com>, Daniel Micay <danielmicay@gmail.com>, "Kirill A. Shutemov" <kirill@shutemov.name>, Shaohua Li <shli@kernel.org>, Michal Hocko <mhocko@suse.cz>, yalin.wang2010@gmail.com, Minchan Kim <minchan@kernel.org>, Michal Hocko <mhocko@suse.com> Subject: [PATCH v2 06/13] mm: clear PG_dirty to mark page freeable Date: Wed, 4 Nov 2015 10:26:00 +0900 [thread overview] Message-ID: <1446600367-7976-7-git-send-email-minchan@kernel.org> (raw) In-Reply-To: <1446600367-7976-1-git-send-email-minchan@kernel.org> Basically, MADV_FREE relies on dirty bit in page table entry to decide whether VM allows to discard the page or not. IOW, if page table entry includes marked dirty bit, VM shouldn't discard the page. However, as a example, if swap-in by read fault happens, page table entry doesn't have dirty bit so MADV_FREE could discard the page wrongly. For avoiding the problem, MADV_FREE did more checks with PageDirty and PageSwapCache. It worked out because swapped-in page lives on swap cache and since it is evicted from the swap cache, the page has PG_dirty flag. So both page flags check effectively prevent wrong discarding by MADV_FREE. However, a problem in above logic is that swapped-in page has PG_dirty still after they are removed from swap cache so VM cannot consider the page as freeable any more even if madvise_free is called in future. Look at below example for detail. ptr = malloc(); memset(ptr); .. .. .. heavy memory pressure so all of pages are swapped out .. .. var = *ptr; -> a page swapped-in and could be removed from swapcache. Then, page table doesn't mark dirty bit and page descriptor includes PG_dirty .. .. madvise_free(ptr); -> It doesn't clear PG_dirty of the page. .. .. .. .. heavy memory pressure again. .. In this time, VM cannot discard the page because the page .. has *PG_dirty* To solve the problem, this patch clears PG_dirty if only the page is owned exclusively by current process when madvise is called because PG_dirty represents ptes's dirtiness in several processes so we could clear it only if we own it exclusively. Acked-by: Michal Hocko <mhocko@suse.com> Acked-by: Hugh Dickins <hughd@google.com> Signed-off-by: Minchan Kim <minchan@kernel.org> --- mm/madvise.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 3462a3ca9690..4e67ba0b1104 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -304,11 +304,19 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, if (!page) continue; - if (PageSwapCache(page)) { + if (PageSwapCache(page) || PageDirty(page)) { if (!trylock_page(page)) continue; + /* + * If page is shared with others, we couldn't clear + * PG_dirty of the page. + */ + if (page_count(page) != 1 + !!PageSwapCache(page)) { + unlock_page(page); + continue; + } - if (!try_to_free_swap(page)) { + if (PageSwapCache(page) && !try_to_free_swap(page)) { unlock_page(page); continue; } -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk <mtk.manpages@gmail.com>, linux-api@vger.kernel.org, Hugh Dickins <hughd@google.com>, Johannes Weiner <hannes@cmpxchg.org>, Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Jason Evans <je@fb.com>, Daniel Micay <danielmicay@gmail.com>, "Kirill A. Shutemov" <kirill@shutemov.name>, Shaohua Li <shli@kernel.org>, Michal Hocko <mhocko@suse.cz>, yalin.wang2010@gmail.com, Minchan Kim <minchan@kernel.org>, Michal Hocko <mhocko@suse.com> Subject: [PATCH v2 06/13] mm: clear PG_dirty to mark page freeable Date: Wed, 4 Nov 2015 10:26:00 +0900 [thread overview] Message-ID: <1446600367-7976-7-git-send-email-minchan@kernel.org> (raw) In-Reply-To: <1446600367-7976-1-git-send-email-minchan@kernel.org> Basically, MADV_FREE relies on dirty bit in page table entry to decide whether VM allows to discard the page or not. IOW, if page table entry includes marked dirty bit, VM shouldn't discard the page. However, as a example, if swap-in by read fault happens, page table entry doesn't have dirty bit so MADV_FREE could discard the page wrongly. For avoiding the problem, MADV_FREE did more checks with PageDirty and PageSwapCache. It worked out because swapped-in page lives on swap cache and since it is evicted from the swap cache, the page has PG_dirty flag. So both page flags check effectively prevent wrong discarding by MADV_FREE. However, a problem in above logic is that swapped-in page has PG_dirty still after they are removed from swap cache so VM cannot consider the page as freeable any more even if madvise_free is called in future. Look at below example for detail. ptr = malloc(); memset(ptr); .. .. .. heavy memory pressure so all of pages are swapped out .. .. var = *ptr; -> a page swapped-in and could be removed from swapcache. Then, page table doesn't mark dirty bit and page descriptor includes PG_dirty .. .. madvise_free(ptr); -> It doesn't clear PG_dirty of the page. .. .. .. .. heavy memory pressure again. .. In this time, VM cannot discard the page because the page .. has *PG_dirty* To solve the problem, this patch clears PG_dirty if only the page is owned exclusively by current process when madvise is called because PG_dirty represents ptes's dirtiness in several processes so we could clear it only if we own it exclusively. Acked-by: Michal Hocko <mhocko@suse.com> Acked-by: Hugh Dickins <hughd@google.com> Signed-off-by: Minchan Kim <minchan@kernel.org> --- mm/madvise.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 3462a3ca9690..4e67ba0b1104 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -304,11 +304,19 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, if (!page) continue; - if (PageSwapCache(page)) { + if (PageSwapCache(page) || PageDirty(page)) { if (!trylock_page(page)) continue; + /* + * If page is shared with others, we couldn't clear + * PG_dirty of the page. + */ + if (page_count(page) != 1 + !!PageSwapCache(page)) { + unlock_page(page); + continue; + } - if (!try_to_free_swap(page)) { + if (PageSwapCache(page) && !try_to_free_swap(page)) { unlock_page(page); continue; } -- 1.9.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-04 1:29 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-04 1:25 [PATCH v2 00/13] MADV_FREE support Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:25 ` [PATCH v2 01/13] mm: support madvise(MADV_FREE) Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 2:16 ` Sergey Senozhatsky 2015-11-04 2:16 ` Sergey Senozhatsky 2015-11-04 2:16 ` Sergey Senozhatsky 2015-11-04 23:39 ` Minchan Kim 2015-11-04 23:39 ` Minchan Kim 2015-11-04 23:39 ` Minchan Kim 2015-11-05 3:41 ` Sergey Senozhatsky 2015-11-05 3:41 ` Sergey Senozhatsky 2015-11-05 3:41 ` Sergey Senozhatsky 2015-11-04 2:29 ` Sergey Senozhatsky 2015-11-04 2:29 ` Sergey Senozhatsky 2015-11-04 23:40 ` Minchan Kim 2015-11-04 23:40 ` Minchan Kim 2015-11-04 23:40 ` Minchan Kim 2015-11-04 3:41 ` Andy Lutomirski 2015-11-04 3:41 ` Andy Lutomirski 2015-11-04 3:41 ` Andy Lutomirski 2015-11-04 5:50 ` Daniel Micay 2015-11-04 5:53 ` Daniel Micay 2015-11-04 5:53 ` Daniel Micay 2015-11-04 6:04 ` Daniel Micay 2015-11-04 18:23 ` Andy Lutomirski 2015-11-04 18:23 ` Andy Lutomirski 2015-11-04 22:05 ` Daniel Micay 2015-11-05 18:17 ` Shaohua Li 2015-11-05 18:17 ` Shaohua Li 2015-11-05 18:17 ` Shaohua Li 2015-11-05 20:13 ` Daniel Micay 2015-11-05 20:14 ` Daniel Micay 2015-11-05 20:14 ` Daniel Micay 2015-11-05 0:13 ` Minchan Kim 2015-11-05 0:13 ` Minchan Kim 2015-11-05 0:13 ` Minchan Kim 2015-11-05 0:42 ` Andy Lutomirski 2015-11-05 0:42 ` Andy Lutomirski 2015-11-05 0:56 ` Minchan Kim 2015-11-05 0:56 ` Minchan Kim 2015-11-05 1:29 ` Andy Lutomirski 2015-11-05 1:29 ` Andy Lutomirski 2015-11-05 1:48 ` Minchan Kim 2015-11-05 1:48 ` Minchan Kim 2015-11-05 1:48 ` Minchan Kim 2015-11-04 20:00 ` Shaohua Li 2015-11-04 20:00 ` Shaohua Li 2015-11-04 20:00 ` Shaohua Li 2015-11-04 21:16 ` Daniel Micay 2015-11-04 21:16 ` Daniel Micay 2015-11-04 21:29 ` Daniel Micay 2015-11-04 21:29 ` Daniel Micay 2015-11-04 21:43 ` Andy Lutomirski 2015-11-04 21:43 ` Andy Lutomirski 2015-11-05 1:33 ` Minchan Kim 2015-11-05 1:33 ` Minchan Kim 2015-11-05 1:33 ` Minchan Kim 2015-11-05 1:37 ` Minchan Kim 2015-11-05 1:37 ` Minchan Kim 2015-11-05 1:37 ` Minchan Kim 2015-12-01 22:30 ` John Stultz 2015-12-01 22:30 ` John Stultz 2015-11-04 1:25 ` [PATCH v2 02/13] mm: define MADV_FREE for some arches Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:25 ` [PATCH v2 03/13] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:25 ` [PATCH v2 04/13] mm: free swp_entry in madvise_free Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:25 ` [PATCH v2 05/13] mm: move lazily freed pages to inactive list Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:26 ` Minchan Kim [this message] 2015-11-04 1:26 ` [PATCH v2 06/13] mm: clear PG_dirty to mark page freeable Minchan Kim 2015-11-04 1:26 ` [PATCH v2 07/13] mm: mark stable page dirty in KSM Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` [PATCH v2 08/13] x86: add pmd_[dirty|mkclean] for THP Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` [PATCH v2 09/13] sparc: " Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` [PATCH v2 10/13] powerpc: " Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` [PATCH v2 11/13] arm: add pmd_mkclean " Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` [PATCH v2 12/13] arm64: " Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` [PATCH v2 13/13] mm: don't split THP page when syscall is called Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-12-05 11:10 ` [PATCH v2 00/13] MADV_FREE support Pavel Machek 2015-12-05 11:10 ` Pavel Machek 2015-12-05 15:51 ` Daniel Micay 2015-12-05 15:51 ` Daniel Micay
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1446600367-7976-7-git-send-email-minchan@kernel.org \ --to=minchan@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=danielmicay@gmail.com \ --cc=hannes@cmpxchg.org \ --cc=hughd@google.com \ --cc=je@fb.com \ --cc=kirill@shutemov.name \ --cc=kosaki.motohiro@jp.fujitsu.com \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@suse.com \ --cc=mhocko@suse.cz \ --cc=mtk.manpages@gmail.com \ --cc=riel@redhat.com \ --cc=shli@kernel.org \ --cc=yalin.wang2010@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.