From: Minchan Kim <minchan@kernel.org> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk <mtk.manpages@gmail.com>, linux-api@vger.kernel.org, Hugh Dickins <hughd@google.com>, Johannes Weiner <hannes@cmpxchg.org>, Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Jason Evans <je@fb.com>, Daniel Micay <danielmicay@gmail.com>, "Kirill A. Shutemov" <kirill@shutemov.name>, Shaohua Li <shli@kernel.org>, Michal Hocko <mhocko@suse.cz>, yalin.wang2010@gmail.com, Minchan Kim <minchan@kernel.org> Subject: [PATCH v2 07/13] mm: mark stable page dirty in KSM Date: Wed, 4 Nov 2015 10:26:01 +0900 [thread overview] Message-ID: <1446600367-7976-8-git-send-email-minchan@kernel.org> (raw) In-Reply-To: <1446600367-7976-1-git-send-email-minchan@kernel.org> The MADV_FREE patchset changes page reclaim to simply free a clean anonymous page with no dirty ptes, instead of swapping it out; but KSM uses clean write-protected ptes to reference the stable ksm page. So be sure to mark that page dirty, so it's never mistakenly discarded. [hughd: adjusted comments] Acked-by: Hugh Dickins <hughd@google.com> Signed-off-by: Minchan Kim <minchan@kernel.org> --- mm/ksm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/ksm.c b/mm/ksm.c index 7ee101eaacdf..18d2b7afecff 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -1053,6 +1053,12 @@ static int try_to_merge_one_page(struct vm_area_struct *vma, */ set_page_stable_node(page, NULL); mark_page_accessed(page); + /* + * Page reclaim just frees a clean page with no dirty + * ptes: make sure that the ksm page would be swapped. + */ + if (!PageDirty(page)) + SetPageDirty(page); err = 0; } else if (pages_identical(page, kpage)) err = replace_page(vma, page, kpage, orig_pte); -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk <mtk.manpages@gmail.com>, linux-api@vger.kernel.org, Hugh Dickins <hughd@google.com>, Johannes Weiner <hannes@cmpxchg.org>, Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Jason Evans <je@fb.com>, Daniel Micay <danielmicay@gmail.com>, "Kirill A. Shutemov" <kirill@shutemov.name>, Shaohua Li <shli@kernel.org>, Michal Hocko <mhocko@suse.cz>, yalin.wang2010@gmail.com, Minchan Kim <minchan@kernel.org> Subject: [PATCH v2 07/13] mm: mark stable page dirty in KSM Date: Wed, 4 Nov 2015 10:26:01 +0900 [thread overview] Message-ID: <1446600367-7976-8-git-send-email-minchan@kernel.org> (raw) In-Reply-To: <1446600367-7976-1-git-send-email-minchan@kernel.org> The MADV_FREE patchset changes page reclaim to simply free a clean anonymous page with no dirty ptes, instead of swapping it out; but KSM uses clean write-protected ptes to reference the stable ksm page. So be sure to mark that page dirty, so it's never mistakenly discarded. [hughd: adjusted comments] Acked-by: Hugh Dickins <hughd@google.com> Signed-off-by: Minchan Kim <minchan@kernel.org> --- mm/ksm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/ksm.c b/mm/ksm.c index 7ee101eaacdf..18d2b7afecff 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -1053,6 +1053,12 @@ static int try_to_merge_one_page(struct vm_area_struct *vma, */ set_page_stable_node(page, NULL); mark_page_accessed(page); + /* + * Page reclaim just frees a clean page with no dirty + * ptes: make sure that the ksm page would be swapped. + */ + if (!PageDirty(page)) + SetPageDirty(page); err = 0; } else if (pages_identical(page, kpage)) err = replace_page(vma, page, kpage, orig_pte); -- 1.9.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-04 1:26 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-04 1:25 [PATCH v2 00/13] MADV_FREE support Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:25 ` [PATCH v2 01/13] mm: support madvise(MADV_FREE) Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 2:16 ` Sergey Senozhatsky 2015-11-04 2:16 ` Sergey Senozhatsky 2015-11-04 2:16 ` Sergey Senozhatsky 2015-11-04 23:39 ` Minchan Kim 2015-11-04 23:39 ` Minchan Kim 2015-11-04 23:39 ` Minchan Kim 2015-11-05 3:41 ` Sergey Senozhatsky 2015-11-05 3:41 ` Sergey Senozhatsky 2015-11-05 3:41 ` Sergey Senozhatsky 2015-11-04 2:29 ` Sergey Senozhatsky 2015-11-04 2:29 ` Sergey Senozhatsky 2015-11-04 23:40 ` Minchan Kim 2015-11-04 23:40 ` Minchan Kim 2015-11-04 23:40 ` Minchan Kim 2015-11-04 3:41 ` Andy Lutomirski 2015-11-04 3:41 ` Andy Lutomirski 2015-11-04 3:41 ` Andy Lutomirski 2015-11-04 5:50 ` Daniel Micay 2015-11-04 5:53 ` Daniel Micay 2015-11-04 5:53 ` Daniel Micay 2015-11-04 6:04 ` Daniel Micay 2015-11-04 18:23 ` Andy Lutomirski 2015-11-04 18:23 ` Andy Lutomirski 2015-11-04 22:05 ` Daniel Micay 2015-11-05 18:17 ` Shaohua Li 2015-11-05 18:17 ` Shaohua Li 2015-11-05 18:17 ` Shaohua Li 2015-11-05 20:13 ` Daniel Micay 2015-11-05 20:14 ` Daniel Micay 2015-11-05 20:14 ` Daniel Micay 2015-11-05 0:13 ` Minchan Kim 2015-11-05 0:13 ` Minchan Kim 2015-11-05 0:13 ` Minchan Kim 2015-11-05 0:42 ` Andy Lutomirski 2015-11-05 0:42 ` Andy Lutomirski 2015-11-05 0:56 ` Minchan Kim 2015-11-05 0:56 ` Minchan Kim 2015-11-05 1:29 ` Andy Lutomirski 2015-11-05 1:29 ` Andy Lutomirski 2015-11-05 1:48 ` Minchan Kim 2015-11-05 1:48 ` Minchan Kim 2015-11-05 1:48 ` Minchan Kim 2015-11-04 20:00 ` Shaohua Li 2015-11-04 20:00 ` Shaohua Li 2015-11-04 20:00 ` Shaohua Li 2015-11-04 21:16 ` Daniel Micay 2015-11-04 21:16 ` Daniel Micay 2015-11-04 21:29 ` Daniel Micay 2015-11-04 21:29 ` Daniel Micay 2015-11-04 21:43 ` Andy Lutomirski 2015-11-04 21:43 ` Andy Lutomirski 2015-11-05 1:33 ` Minchan Kim 2015-11-05 1:33 ` Minchan Kim 2015-11-05 1:33 ` Minchan Kim 2015-11-05 1:37 ` Minchan Kim 2015-11-05 1:37 ` Minchan Kim 2015-11-05 1:37 ` Minchan Kim 2015-12-01 22:30 ` John Stultz 2015-12-01 22:30 ` John Stultz 2015-11-04 1:25 ` [PATCH v2 02/13] mm: define MADV_FREE for some arches Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:25 ` [PATCH v2 03/13] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:25 ` [PATCH v2 04/13] mm: free swp_entry in madvise_free Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:25 ` [PATCH v2 05/13] mm: move lazily freed pages to inactive list Minchan Kim 2015-11-04 1:25 ` Minchan Kim 2015-11-04 1:26 ` [PATCH v2 06/13] mm: clear PG_dirty to mark page freeable Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` Minchan Kim [this message] 2015-11-04 1:26 ` [PATCH v2 07/13] mm: mark stable page dirty in KSM Minchan Kim 2015-11-04 1:26 ` [PATCH v2 08/13] x86: add pmd_[dirty|mkclean] for THP Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` [PATCH v2 09/13] sparc: " Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` [PATCH v2 10/13] powerpc: " Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` [PATCH v2 11/13] arm: add pmd_mkclean " Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` [PATCH v2 12/13] arm64: " Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-11-04 1:26 ` [PATCH v2 13/13] mm: don't split THP page when syscall is called Minchan Kim 2015-11-04 1:26 ` Minchan Kim 2015-12-05 11:10 ` [PATCH v2 00/13] MADV_FREE support Pavel Machek 2015-12-05 11:10 ` Pavel Machek 2015-12-05 15:51 ` Daniel Micay 2015-12-05 15:51 ` Daniel Micay
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1446600367-7976-8-git-send-email-minchan@kernel.org \ --to=minchan@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=danielmicay@gmail.com \ --cc=hannes@cmpxchg.org \ --cc=hughd@google.com \ --cc=je@fb.com \ --cc=kirill@shutemov.name \ --cc=kosaki.motohiro@jp.fujitsu.com \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@suse.cz \ --cc=mtk.manpages@gmail.com \ --cc=riel@redhat.com \ --cc=shli@kernel.org \ --cc=yalin.wang2010@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.