All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Wuerfel <anton.wuerfel@fau.de>
To: linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	"James E.J. Bottomley" <jejb@parisc-linux.org>,
	Helge Deller <deller@gmx.de>,
	Peter Hurley <peter@hurleysoftware.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Qipeng Zha <qipeng.zha@intel.com>,
	Desmond Liu <desmondl@broadcom.com>,
	Wang Long <long.wanglong@huawei.com>,
	Matt Redfearn <matt.redfearn@imgtec.com>,
	Paul Burton <paul.burton@imgtec.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Peter Hung <hpeter@gmail.com>,
	Soeren Grunewald <soeren.grunewald@desy.de>,
	Adam Lee <adam.lee@canonical.com>,
	"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
	Mans Rullgard <mans@mansr.com>,
	linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-kernel@i4.cs.fau.de, Anton Wuerfel <anto
Subject: [PATCH 11/11] tty: serial: 8250: Delete commented code
Date: Wed, 16 Dec 2015 16:36:17 +0100	[thread overview]
Message-ID: <1450280177-4460-12-git-send-email-anton.wuerfel@fau.de> (raw)
In-Reply-To: <1450280177-4460-1-git-send-email-anton.wuerfel@fau.de>

This patch removes code which has been commented out. It serves no
documentary purposes and decreases the readability of the remaining cod=
e.
=46urthermore the comment style causes checkpatch warnings. If this cod=
e
should ever be needed again, git keeps track of it.

Signed-off-by: Anton W=C3=BCrfel <anton.wuerfel@fau.de>
Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
CC: linux-kernel@i4.cs.fau.de
---
 drivers/tty/serial/8250/8250_pci.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/82=
50/8250_pci.c
index 3bc0303..9136f0f 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -4928,16 +4928,9 @@ static struct pci_device_id serial_pci_tbl[] =3D=
 {
 	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
 		0x1208, 0x0004, 0, 0,
 		pbn_b0_4_921600 },
-/*	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
-		0x1402, 0x0002, 0, 0,
-		pbn_b0_2_921600 }, */
-/*	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
-		0x1404, 0x0004, 0, 0,
-		pbn_b0_4_921600 }, */
 	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF1,
 		0x1208, 0x0004, 0, 0,
 		pbn_b0_4_921600 },
-
 	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF2,
 		0x1204, 0x0004, 0, 0,
 		pbn_b0_4_921600 },
--=20
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Anton Wuerfel <anton.wuerfel@fau.de>
To: linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	"James E.J. Bottomley" <jejb@parisc-linux.org>,
	Helge Deller <deller@gmx.de>,
	Peter Hurley <peter@hurleysoftware.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Qipeng Zha <qipeng.zha@intel.com>,
	Desmond Liu <desmondl@broadcom.com>,
	Wang Long <long.wanglong@huawei.com>,
	Matt Redfearn <matt.redfearn@imgtec.com>,
	Paul Burton <paul.burton@imgtec.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Peter Hung <hpeter@gmail.com>,
	Soeren Grunewald <soeren.grunewald@desy.de>,
	Adam Lee <adam.lee@canonical.com>,
	"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
	Mans Rullgard <mans@mansr.com>,
	linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-kernel@i4.cs.fau.de, Anton Wuerfel <anton.wuerfel@fau.de>,
	Phillip Raffeck <phillip.raffeck@fau.de>
Subject: [PATCH 11/11] tty: serial: 8250: Delete commented code
Date: Wed, 16 Dec 2015 16:36:17 +0100	[thread overview]
Message-ID: <1450280177-4460-12-git-send-email-anton.wuerfel@fau.de> (raw)
In-Reply-To: <1450280177-4460-1-git-send-email-anton.wuerfel@fau.de>

This patch removes code which has been commented out. It serves no
documentary purposes and decreases the readability of the remaining code.
Furthermore the comment style causes checkpatch warnings. If this code
should ever be needed again, git keeps track of it.

Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
CC: linux-kernel@i4.cs.fau.de
---
 drivers/tty/serial/8250/8250_pci.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 3bc0303..9136f0f 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -4928,16 +4928,9 @@ static struct pci_device_id serial_pci_tbl[] = {
 	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
 		0x1208, 0x0004, 0, 0,
 		pbn_b0_4_921600 },
-/*	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
-		0x1402, 0x0002, 0, 0,
-		pbn_b0_2_921600 }, */
-/*	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
-		0x1404, 0x0004, 0, 0,
-		pbn_b0_4_921600 }, */
 	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF1,
 		0x1208, 0x0004, 0, 0,
 		pbn_b0_4_921600 },
-
 	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF2,
 		0x1204, 0x0004, 0, 0,
 		pbn_b0_4_921600 },
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: Anton Wuerfel <anton.wuerfel@fau.de>
To: linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	"James E.J. Bottomley" <jejb@parisc-linux.org>,
	Helge Deller <deller@gmx.de>,
	Peter Hurley <peter@hurleysoftware.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Qipeng Zha <qipeng.zha@intel.com>,
	Desmond Liu <desmondl@broadcom.com>,
	Wang Long <long.wanglong@huawei.com>,
	Matt Redfearn <matt.redfearn@imgtec.com>,
	Paul Burton <paul.burton@imgtec.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Peter Hung <hpeter@gmail.com>,
	Soeren Grunewald <soeren.grunewald@desy.de>,
	Adam Lee <adam.lee@canonical.com>,
	"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
	Mans Rullgard <mans@mansr.com>,
	linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-kernel@i4.cs.fau.de, Anton Wuerfel <anto>
Subject: [PATCH 11/11] tty: serial: 8250: Delete commented code
Date: Wed, 16 Dec 2015 16:36:17 +0100	[thread overview]
Message-ID: <1450280177-4460-12-git-send-email-anton.wuerfel@fau.de> (raw)
In-Reply-To: <1450280177-4460-1-git-send-email-anton.wuerfel@fau.de>

This patch removes code which has been commented out. It serves no
documentary purposes and decreases the readability of the remaining code.
Furthermore the comment style causes checkpatch warnings. If this code
should ever be needed again, git keeps track of it.

Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
CC: linux-kernel@i4.cs.fau.de
---
 drivers/tty/serial/8250/8250_pci.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 3bc0303..9136f0f 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -4928,16 +4928,9 @@ static struct pci_device_id serial_pci_tbl[] = {
 	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
 		0x1208, 0x0004, 0, 0,
 		pbn_b0_4_921600 },
-/*	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
-		0x1402, 0x0002, 0, 0,
-		pbn_b0_2_921600 }, */
-/*	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF0,
-		0x1404, 0x0004, 0, 0,
-		pbn_b0_4_921600 }, */
 	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF1,
 		0x1208, 0x0004, 0, 0,
 		pbn_b0_4_921600 },
-
 	{	PCI_VENDOR_ID_KORENIX, PCI_DEVICE_ID_KORENIX_JETCARDF2,
 		0x1204, 0x0004, 0, 0,
 		pbn_b0_4_921600 },
-- 
1.9.1

  parent reply	other threads:[~2015-12-16 15:36 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 15:36 [PATCH 00/11] tty: serial: 8250: Fix checkpatch warnings Anton Wuerfel
2015-12-16 15:36 ` Anton Wuerfel
2015-12-16 15:36 ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 01/11] tty: serial: 8250: Fix whitespace errors Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 16:43   ` Peter Hurley
2015-12-16 16:43     ` Peter Hurley
2015-12-16 16:43     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 02/11] tty: serial: 8250: Fix indentation warnings Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 16:49   ` Peter Hurley
2015-12-16 16:49     ` Peter Hurley
2015-12-16 16:49     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 03/11] tty: serial: 8250: Fix braces after struct Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 04/11] tty: serial: 8250: Fix multiline comment style Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 16:52   ` Peter Hurley
2015-12-16 16:52     ` Peter Hurley
2015-12-16 16:52     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 05/11] tty: serial: 8250: Remove else after return Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 06/11] tty: serial: 8250: Move EXPORT_SYMBOL to function Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 17:06   ` Peter Hurley
2015-12-16 17:06     ` Peter Hurley
2015-12-16 17:06     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 07/11] tty: serial: 8250: Fix line continuation warning Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 08/11] tty: serial: 8250: Add parentheses to macro Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-17 15:16   ` Andy Shevchenko
2015-12-17 15:16     ` Andy Shevchenko
2015-12-18 11:36     ` anton.wuerfel
2015-12-18 11:36       ` anton.wuerfel
2015-12-18 12:35       ` Andy Shevchenko
2015-12-18 12:35         ` Andy Shevchenko
2015-12-16 15:36 ` [PATCH 09/11] tty: serial: 8250: Fix multi-line strings Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 10/11] tty: serial: 8250: Replace printk by pr_* Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 17:00   ` Peter Hurley
2015-12-16 17:00     ` Peter Hurley
2015-12-16 17:00     ` Peter Hurley
2015-12-16 15:36 ` Anton Wuerfel [this message]
2015-12-16 15:36   ` [PATCH 11/11] tty: serial: 8250: Delete commented code Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 17:05   ` Peter Hurley
2015-12-16 17:05     ` Peter Hurley
2015-12-16 17:05     ` Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450280177-4460-12-git-send-email-anton.wuerfel@fau.de \
    --to=anton.wuerfel@fau.de \
    --cc=adam.lee@canonical.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=deller@gmx.de \
    --cc=desmondl@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=hpeter@gmail.com \
    --cc=jejb@parisc-linux.org \
    --cc=jslaby@suse.com \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=long.wanglong@huawei.com \
    --cc=mail@maciej.szmigiero.name \
    --cc=mans@mansr.com \
    --cc=matt.redfearn@imgtec.com \
    --cc=paul.burton@imgtec.com \
    --cc=peter@hurleysoftware.com \
    --cc=qipeng.zha@intel.com \
    --cc=ralf@linux-mips.org \
    --cc=soeren.grunewald@desy.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.