All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Anton Wuerfel <anton.wuerfel@fau.de>, linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	"James E.J. Bottomley" <jejb@parisc-linux.org>,
	Helge Deller <deller@gmx.de>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Qipeng Zha <qipeng.zha@intel.com>,
	Desmond Liu <desmondl@broadcom.com>,
	Wang Long <long.wanglong@huawei.com>,
	Matt Redfearn <matt.redfearn@imgtec.com>,
	Paul Burton <paul.burton@imgtec.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Peter Hung <hpeter@gmail.com>,
	Soeren Grunewald <soeren.grunewald@desy.de>,
	Adam Lee <adam.lee@canonical.com>,
	"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
	Mans Rullgard <mans@mansr.com>,
	linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-kernel@i4.cs.fau.de,
	Phillip Raffeck <phillip.raffeck@fau.de>
Subject: Re: [PATCH 06/11] tty: serial: 8250: Move EXPORT_SYMBOL to function
Date: Wed, 16 Dec 2015 09:06:47 -0800	[thread overview]
Message-ID: <56719A27.4060102@hurleysoftware.com> (raw)
In-Reply-To: <1450280177-4460-7-git-send-email-anton.wuerfel@fau.de>

On 12/16/2015 07:36 AM, Anton Wuerfel wrote:
> This patch moves EXPORT_SYMBOL macros directly after the definition o=
f
> the corresponding symbol to remove checkpatch warnings.

Ok.


> Signed-off-by: Anton W=C3=BCrfel <anton.wuerfel@fau.de>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
> CC: linux-kernel@i4.cs.fau.de
> ---
>  drivers/tty/serial/8250/8250_core.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial=
/8250/8250_core.c
> index 89a20c9..67147b2 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -764,6 +764,7 @@ void serial8250_suspend_port(int line)
> =20
>  	uart_suspend_port(&serial8250_reg, port);
>  }
> +EXPORT_SYMBOL(serial8250_suspend_port);
> =20
>  /**
>   *	serial8250_resume_port - resume one serial port
> @@ -789,6 +790,7 @@ void serial8250_resume_port(int line)
>  	}
>  	uart_resume_port(&serial8250_reg, port);
>  }
> +EXPORT_SYMBOL(serial8250_resume_port);
> =20
>  /*
>   * Register a set of serial devices attached to a platform device.  =
The
> @@ -1168,9 +1170,6 @@ static void __exit serial8250_exit(void)
>  module_init(serial8250_init);
>  module_exit(serial8250_exit);
> =20
> -EXPORT_SYMBOL(serial8250_suspend_port);
> -EXPORT_SYMBOL(serial8250_resume_port);
> -
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("Generic 8250/16x50 serial driver");
> =20
>=20

--
To unsubscribe from this list: send the line "unsubscribe linux-parisc"=
 in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Peter Hurley <peter@hurleysoftware.com>
To: Anton Wuerfel <anton.wuerfel@fau.de>, linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	"James E.J. Bottomley" <jejb@parisc-linux.org>,
	Helge Deller <deller@gmx.de>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Qipeng Zha <qipeng.zha@intel.com>,
	Desmond Liu <desmondl@broadcom.com>,
	Wang Long <long.wanglong@huawei.com>,
	Matt Redfearn <matt.redfearn@imgtec.com>,
	Paul Burton <paul.burton@imgtec.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Peter Hung <hpeter@gmail.com>,
	Soeren Grunewald <soeren.grunewald@desy.de>,
	Adam Lee <adam.lee@canonical.com>,
	"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
	Mans Rullgard <mans@mansr.com>,
	linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-kernel@i4.cs.fau.de,
	Phillip Raffeck <phillip.raffeck@fau.de>
Subject: Re: [PATCH 06/11] tty: serial: 8250: Move EXPORT_SYMBOL to function
Date: Wed, 16 Dec 2015 09:06:47 -0800	[thread overview]
Message-ID: <56719A27.4060102@hurleysoftware.com> (raw)
In-Reply-To: <1450280177-4460-7-git-send-email-anton.wuerfel@fau.de>

On 12/16/2015 07:36 AM, Anton Wuerfel wrote:
> This patch moves EXPORT_SYMBOL macros directly after the definition of
> the corresponding symbol to remove checkpatch warnings.

Ok.


> Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
> CC: linux-kernel@i4.cs.fau.de
> ---
>  drivers/tty/serial/8250/8250_core.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 89a20c9..67147b2 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -764,6 +764,7 @@ void serial8250_suspend_port(int line)
>  
>  	uart_suspend_port(&serial8250_reg, port);
>  }
> +EXPORT_SYMBOL(serial8250_suspend_port);
>  
>  /**
>   *	serial8250_resume_port - resume one serial port
> @@ -789,6 +790,7 @@ void serial8250_resume_port(int line)
>  	}
>  	uart_resume_port(&serial8250_reg, port);
>  }
> +EXPORT_SYMBOL(serial8250_resume_port);
>  
>  /*
>   * Register a set of serial devices attached to a platform device.  The
> @@ -1168,9 +1170,6 @@ static void __exit serial8250_exit(void)
>  module_init(serial8250_init);
>  module_exit(serial8250_exit);
>  
> -EXPORT_SYMBOL(serial8250_suspend_port);
> -EXPORT_SYMBOL(serial8250_resume_port);
> -
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("Generic 8250/16x50 serial driver");
>  
> 


WARNING: multiple messages have this Message-ID (diff)
From: Peter Hurley <peter@hurleysoftware.com>
To: Anton Wuerfel <anton.wuerfel@fau.de>, linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	"James E.J. Bottomley" <jejb@parisc-linux.org>,
	Helge Deller <deller@gmx.de>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Qipeng Zha <qipeng.zha@intel.com>,
	Desmond Liu <desmondl@broadcom.com>,
	Wang Long <long.wanglong@huawei.com>,
	Matt Redfearn <matt.redfearn@imgtec.com>,
	Paul Burton <paul.burton@imgtec.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Peter Hung <hpeter@gmail.com>,
	Soeren Grunewald <soeren.grunewald@desy.de>,
	Adam Lee <adam.lee@canonical.com>,
	"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
	Mans Rullgard <mans@mansr.com>,
	linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-kernel@i4.cs.fau.de,
	Phillip Raffeck <phillip.raffeck@fau.de>
Subject: Re: [PATCH 06/11] tty: serial: 8250: Move EXPORT_SYMBOL to function
Date: Wed, 16 Dec 2015 09:06:47 -0800	[thread overview]
Message-ID: <56719A27.4060102@hurleysoftware.com> (raw)
In-Reply-To: <1450280177-4460-7-git-send-email-anton.wuerfel@fau.de>

On 12/16/2015 07:36 AM, Anton Wuerfel wrote:
> This patch moves EXPORT_SYMBOL macros directly after the definition of
> the corresponding symbol to remove checkpatch warnings.

Ok.


> Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
> CC: linux-kernel@i4.cs.fau.de
> ---
>  drivers/tty/serial/8250/8250_core.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 89a20c9..67147b2 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -764,6 +764,7 @@ void serial8250_suspend_port(int line)
>  
>  	uart_suspend_port(&serial8250_reg, port);
>  }
> +EXPORT_SYMBOL(serial8250_suspend_port);
>  
>  /**
>   *	serial8250_resume_port - resume one serial port
> @@ -789,6 +790,7 @@ void serial8250_resume_port(int line)
>  	}
>  	uart_resume_port(&serial8250_reg, port);
>  }
> +EXPORT_SYMBOL(serial8250_resume_port);
>  
>  /*
>   * Register a set of serial devices attached to a platform device.  The
> @@ -1168,9 +1170,6 @@ static void __exit serial8250_exit(void)
>  module_init(serial8250_init);
>  module_exit(serial8250_exit);
>  
> -EXPORT_SYMBOL(serial8250_suspend_port);
> -EXPORT_SYMBOL(serial8250_resume_port);
> -
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("Generic 8250/16x50 serial driver");
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-12-16 17:06 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 15:36 [PATCH 00/11] tty: serial: 8250: Fix checkpatch warnings Anton Wuerfel
2015-12-16 15:36 ` Anton Wuerfel
2015-12-16 15:36 ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 01/11] tty: serial: 8250: Fix whitespace errors Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 16:43   ` Peter Hurley
2015-12-16 16:43     ` Peter Hurley
2015-12-16 16:43     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 02/11] tty: serial: 8250: Fix indentation warnings Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 16:49   ` Peter Hurley
2015-12-16 16:49     ` Peter Hurley
2015-12-16 16:49     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 03/11] tty: serial: 8250: Fix braces after struct Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 04/11] tty: serial: 8250: Fix multiline comment style Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 16:52   ` Peter Hurley
2015-12-16 16:52     ` Peter Hurley
2015-12-16 16:52     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 05/11] tty: serial: 8250: Remove else after return Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 06/11] tty: serial: 8250: Move EXPORT_SYMBOL to function Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 17:06   ` Peter Hurley [this message]
2015-12-16 17:06     ` Peter Hurley
2015-12-16 17:06     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 07/11] tty: serial: 8250: Fix line continuation warning Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 08/11] tty: serial: 8250: Add parentheses to macro Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-17 15:16   ` Andy Shevchenko
2015-12-17 15:16     ` Andy Shevchenko
2015-12-18 11:36     ` anton.wuerfel
2015-12-18 11:36       ` anton.wuerfel
2015-12-18 12:35       ` Andy Shevchenko
2015-12-18 12:35         ` Andy Shevchenko
2015-12-16 15:36 ` [PATCH 09/11] tty: serial: 8250: Fix multi-line strings Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 10/11] tty: serial: 8250: Replace printk by pr_* Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 17:00   ` Peter Hurley
2015-12-16 17:00     ` Peter Hurley
2015-12-16 17:00     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 11/11] tty: serial: 8250: Delete commented code Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 17:05   ` Peter Hurley
2015-12-16 17:05     ` Peter Hurley
2015-12-16 17:05     ` Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56719A27.4060102@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=adam.lee@canonical.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=anton.wuerfel@fau.de \
    --cc=deller@gmx.de \
    --cc=desmondl@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=hpeter@gmail.com \
    --cc=jejb@parisc-linux.org \
    --cc=jslaby@suse.com \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=long.wanglong@huawei.com \
    --cc=mail@maciej.szmigiero.name \
    --cc=mans@mansr.com \
    --cc=matt.redfearn@imgtec.com \
    --cc=paul.burton@imgtec.com \
    --cc=phillip.raffeck@fau.de \
    --cc=qipeng.zha@intel.com \
    --cc=ralf@linux-mips.org \
    --cc=soeren.grunewald@desy.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.