* [PATCH] hpet: drop stale link
@ 2016-02-01 11:32 Michael S. Tsirkin
2016-02-03 10:53 ` Ingo Molnar
2016-02-10 20:14 ` Jonathan Corbet
0 siblings, 2 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2016-02-01 11:32 UTC (permalink / raw)
To: linux-kernel
Cc: Thomas Gleixner, Clemens Ladisch, Jonathan Corbet, Ingo Molnar,
H. Peter Anvin, x86, Arnd Bergmann, Greg Kroah-Hartman,
linux-doc
Looks like the HPET spec at intel.com got moved.
It isn't hard to find so drop the link, just mention
the revision assumed.
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
drivers/char/hpet.c | 2 +-
Documentation/timers/hpet.txt | 2 +-
arch/x86/Kconfig | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index 240b6cf..86c5f4d 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -42,7 +42,7 @@
/*
* The High Precision Event Timer driver.
* This driver is closely modelled after the rtc.c driver.
- * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+ * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
*/
#define HPET_USER_FREQ (64)
#define HPET_DRIFT (500)
diff --git a/Documentation/timers/hpet.txt b/Documentation/timers/hpet.txt
index 767392f..f24e978 100644
--- a/Documentation/timers/hpet.txt
+++ b/Documentation/timers/hpet.txt
@@ -3,7 +3,7 @@
The High Precision Event Timer (HPET) hardware follows a specification
by Intel and Microsoft which can be found at
- http://www.intel.com/hardwaredesign/hpetspec_1.pdf
+http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
Each HPET has one fixed-rate counter (at 10+ MHz, hence "High Precision")
and up to 32 comparators. Normally three or more comparators are provided,
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 9af2e63..f32faba 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -778,7 +778,7 @@ config HPET_TIMER
The HPET provides a stable time base on SMP
systems, unlike the TSC, but it is more expensive to access,
as it is off-chip. You can find the HPET spec at
- <http://www.intel.com/hardwaredesign/hpetspec_1.pdf>.
+ <http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf>.
You can safely choose Y here. However, HPET will only be
activated if the platform and the BIOS support this feature.
--
MST
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] hpet: drop stale link
2016-02-01 11:32 [PATCH] hpet: drop stale link Michael S. Tsirkin
@ 2016-02-03 10:53 ` Ingo Molnar
2016-02-03 11:54 ` Michael S. Tsirkin
2016-02-10 20:14 ` Jonathan Corbet
1 sibling, 1 reply; 5+ messages in thread
From: Ingo Molnar @ 2016-02-03 10:53 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: linux-kernel, Thomas Gleixner, Clemens Ladisch, Jonathan Corbet,
Ingo Molnar, H. Peter Anvin, x86, Arnd Bergmann,
Greg Kroah-Hartman, linux-doc
* Michael S. Tsirkin <mst@redhat.com> wrote:
> Looks like the HPET spec at intel.com got moved.
> It isn't hard to find so drop the link, just mention
> the revision assumed.
>
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/char/hpet.c | 2 +-
> Documentation/timers/hpet.txt | 2 +-
> arch/x86/Kconfig | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> index 240b6cf..86c5f4d 100644
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -42,7 +42,7 @@
> /*
> * The High Precision Event Timer driver.
> * This driver is closely modelled after the rtc.c driver.
> - * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
> + * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
> */
> #define HPET_USER_FREQ (64)
> #define HPET_DRIFT (500)
> diff --git a/Documentation/timers/hpet.txt b/Documentation/timers/hpet.txt
> index 767392f..f24e978 100644
> --- a/Documentation/timers/hpet.txt
> +++ b/Documentation/timers/hpet.txt
> @@ -3,7 +3,7 @@
> The High Precision Event Timer (HPET) hardware follows a specification
> by Intel and Microsoft which can be found at
>
> - http://www.intel.com/hardwaredesign/hpetspec_1.pdf
> +http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
>
> Each HPET has one fixed-rate counter (at 10+ MHz, hence "High Precision")
> and up to 32 comparators. Normally three or more comparators are provided,
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 9af2e63..f32faba 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -778,7 +778,7 @@ config HPET_TIMER
> The HPET provides a stable time base on SMP
> systems, unlike the TSC, but it is more expensive to access,
> as it is off-chip. You can find the HPET spec at
> - <http://www.intel.com/hardwaredesign/hpetspec_1.pdf>.
> + <http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf>.
>
> You can safely choose Y here. However, HPET will only be
> activated if the platform and the BIOS support this feature.
In fact we can also remove the link from this Kconfig entry, as it's highly
unlikely that a user doing kernel configuration would want to start reading a
spec.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hpet: drop stale link
2016-02-03 10:53 ` Ingo Molnar
@ 2016-02-03 11:54 ` Michael S. Tsirkin
0 siblings, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2016-02-03 11:54 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Thomas Gleixner, Clemens Ladisch, Jonathan Corbet,
Ingo Molnar, H. Peter Anvin, x86, Arnd Bergmann,
Greg Kroah-Hartman, linux-doc
On Wed, Feb 03, 2016 at 11:53:07AM +0100, Ingo Molnar wrote:
>
> * Michael S. Tsirkin <mst@redhat.com> wrote:
>
> > Looks like the HPET spec at intel.com got moved.
> > It isn't hard to find so drop the link, just mention
> > the revision assumed.
> >
> > Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > drivers/char/hpet.c | 2 +-
> > Documentation/timers/hpet.txt | 2 +-
> > arch/x86/Kconfig | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> > index 240b6cf..86c5f4d 100644
> > --- a/drivers/char/hpet.c
> > +++ b/drivers/char/hpet.c
> > @@ -42,7 +42,7 @@
> > /*
> > * The High Precision Event Timer driver.
> > * This driver is closely modelled after the rtc.c driver.
> > - * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
> > + * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
> > */
> > #define HPET_USER_FREQ (64)
> > #define HPET_DRIFT (500)
> > diff --git a/Documentation/timers/hpet.txt b/Documentation/timers/hpet.txt
> > index 767392f..f24e978 100644
> > --- a/Documentation/timers/hpet.txt
> > +++ b/Documentation/timers/hpet.txt
> > @@ -3,7 +3,7 @@
> > The High Precision Event Timer (HPET) hardware follows a specification
> > by Intel and Microsoft which can be found at
> >
> > - http://www.intel.com/hardwaredesign/hpetspec_1.pdf
> > +http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
> >
> > Each HPET has one fixed-rate counter (at 10+ MHz, hence "High Precision")
> > and up to 32 comparators. Normally three or more comparators are provided,
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 9af2e63..f32faba 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -778,7 +778,7 @@ config HPET_TIMER
> > The HPET provides a stable time base on SMP
> > systems, unlike the TSC, but it is more expensive to access,
> > as it is off-chip. You can find the HPET spec at
> > - <http://www.intel.com/hardwaredesign/hpetspec_1.pdf>.
> > + <http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf>.
> >
> > You can safely choose Y here. However, HPET will only be
> > activated if the platform and the BIOS support this feature.
>
> In fact we can also remove the link from this Kconfig entry, as it's highly
> unlikely that a user doing kernel configuration would want to start reading a
> spec.
>
> Thanks,
>
> Ingo
Hmm looks like the patch does not match the description.
Maybe I forgot to commit, or something.
Sorry - will repost.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hpet: drop stale link
2016-02-01 11:32 [PATCH] hpet: drop stale link Michael S. Tsirkin
2016-02-03 10:53 ` Ingo Molnar
@ 2016-02-10 20:14 ` Jonathan Corbet
2016-02-10 23:08 ` Michael S. Tsirkin
1 sibling, 1 reply; 5+ messages in thread
From: Jonathan Corbet @ 2016-02-10 20:14 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: linux-kernel, Thomas Gleixner, Clemens Ladisch, Ingo Molnar,
H. Peter Anvin, x86, Arnd Bergmann, Greg Kroah-Hartman,
linux-doc
On Mon, 1 Feb 2016 13:32:56 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> Looks like the HPET spec at intel.com got moved.
> It isn't hard to find so drop the link, just mention
> the revision assumed.
Hmm...what I see suggests this patch doesn't do that...
> - * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
> + * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
>
..?
jon
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hpet: drop stale link
2016-02-10 20:14 ` Jonathan Corbet
@ 2016-02-10 23:08 ` Michael S. Tsirkin
0 siblings, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2016-02-10 23:08 UTC (permalink / raw)
To: Jonathan Corbet
Cc: linux-kernel, Thomas Gleixner, Clemens Ladisch, Ingo Molnar,
H. Peter Anvin, x86, Arnd Bergmann, Greg Kroah-Hartman,
linux-doc
On Wed, Feb 10, 2016 at 01:14:14PM -0700, Jonathan Corbet wrote:
> On Mon, 1 Feb 2016 13:32:56 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > Looks like the HPET spec at intel.com got moved.
> > It isn't hard to find so drop the link, just mention
> > the revision assumed.
>
> Hmm...what I see suggests this patch doesn't do that...
>
> > - * http://www.intel.com/hardwaredesign/hpetspec_1.pdf
> > + * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf
> >
>
> ..?
>
> jon
Did it again: edit code, run git commit --amend and edited commit log
but forgot -a so new code didn't get included in the commit,
run git format-patch and then send-email without reviewing the
result :(
Sorry about that - posted v2 which does what it says.
--
MST
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-10 23:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-01 11:32 [PATCH] hpet: drop stale link Michael S. Tsirkin
2016-02-03 10:53 ` Ingo Molnar
2016-02-03 11:54 ` Michael S. Tsirkin
2016-02-10 20:14 ` Jonathan Corbet
2016-02-10 23:08 ` Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.