From: Stefan Agner <stefan@agner.ch> To: shawnguo@kernel.org, mturquette@baylibre.com, sboyd@codeaurora.org Cc: kernel@pengutronix.de, sergeimir@emcraft.com, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Stefan Agner <stefan@agner.ch> Subject: [PATCH 16/18] ARM: vf610: PM: enable Suspend-to-RAM only if hardware fixes are in place Date: Wed, 9 Mar 2016 18:16:57 -0800 [thread overview] Message-ID: <1457576219-7971-17-git-send-email-stefan@agner.ch> (raw) In-Reply-To: <1457576219-7971-1-git-send-email-stefan@agner.ch> To use self-refresh mode for DDR3 SDRAM memory in LPSTOPx mode, the hardware need to have pull-ups/downs populated on RESET/CKE line of the DDR memory. Read the device tree property which indicates whether a given board has such resistors populated. Signed-off-by: Stefan Agner <stefan@agner.ch> --- arch/arm/mach-imx/pm-vf610.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/pm-vf610.c b/arch/arm/mach-imx/pm-vf610.c index ecc7c9c..3da93e9 100644 --- a/arch/arm/mach-imx/pm-vf610.c +++ b/arch/arm/mach-imx/pm-vf610.c @@ -93,6 +93,7 @@ static void __iomem *suspend_ocram_base; static void (*vf610_suspend_in_ocram_fn)(void __iomem *ocram_vbase); +static bool has_cke_reset_pulls; #ifdef DEBUG static void __iomem *uart_membase; @@ -382,7 +383,8 @@ static int vf610_pm_enter(suspend_state_t state) static int vf610_pm_valid(suspend_state_t state) { - return (state == PM_SUSPEND_STANDBY || state == PM_SUSPEND_MEM); + return (state == PM_SUSPEND_STANDBY || + (state == PM_SUSPEND_MEM && has_cke_reset_pulls)); } static const struct platform_suspend_ops vf610_pm_ops = { @@ -476,6 +478,19 @@ static int __init vf610_suspend_init(const struct vf610_pm_socdata *socdata) return ret; #endif + node = of_find_compatible_node(NULL, NULL, socdata->ddrmc_compat); + if (node) { + has_cke_reset_pulls = + of_property_read_bool(node, "fsl,has-cke-reset-pulls"); + + of_node_put(node); + } + + if (has_cke_reset_pulls) + pr_info("PM: CKE/RESET pulls available, enable Suspend-to-RAM\n"); + else + pr_info("PM: No CKE/RESET pulls, disable Suspend-to-RAM\n"); + suspend_set_ops(&vf610_pm_ops); node = of_find_compatible_node(NULL, NULL, "mmio-sram"); -- 2.7.2
WARNING: multiple messages have this Message-ID (diff)
From: stefan@agner.ch (Stefan Agner) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 16/18] ARM: vf610: PM: enable Suspend-to-RAM only if hardware fixes are in place Date: Wed, 9 Mar 2016 18:16:57 -0800 [thread overview] Message-ID: <1457576219-7971-17-git-send-email-stefan@agner.ch> (raw) In-Reply-To: <1457576219-7971-1-git-send-email-stefan@agner.ch> To use self-refresh mode for DDR3 SDRAM memory in LPSTOPx mode, the hardware need to have pull-ups/downs populated on RESET/CKE line of the DDR memory. Read the device tree property which indicates whether a given board has such resistors populated. Signed-off-by: Stefan Agner <stefan@agner.ch> --- arch/arm/mach-imx/pm-vf610.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/pm-vf610.c b/arch/arm/mach-imx/pm-vf610.c index ecc7c9c..3da93e9 100644 --- a/arch/arm/mach-imx/pm-vf610.c +++ b/arch/arm/mach-imx/pm-vf610.c @@ -93,6 +93,7 @@ static void __iomem *suspend_ocram_base; static void (*vf610_suspend_in_ocram_fn)(void __iomem *ocram_vbase); +static bool has_cke_reset_pulls; #ifdef DEBUG static void __iomem *uart_membase; @@ -382,7 +383,8 @@ static int vf610_pm_enter(suspend_state_t state) static int vf610_pm_valid(suspend_state_t state) { - return (state == PM_SUSPEND_STANDBY || state == PM_SUSPEND_MEM); + return (state == PM_SUSPEND_STANDBY || + (state == PM_SUSPEND_MEM && has_cke_reset_pulls)); } static const struct platform_suspend_ops vf610_pm_ops = { @@ -476,6 +478,19 @@ static int __init vf610_suspend_init(const struct vf610_pm_socdata *socdata) return ret; #endif + node = of_find_compatible_node(NULL, NULL, socdata->ddrmc_compat); + if (node) { + has_cke_reset_pulls = + of_property_read_bool(node, "fsl,has-cke-reset-pulls"); + + of_node_put(node); + } + + if (has_cke_reset_pulls) + pr_info("PM: CKE/RESET pulls available, enable Suspend-to-RAM\n"); + else + pr_info("PM: No CKE/RESET pulls, disable Suspend-to-RAM\n"); + suspend_set_ops(&vf610_pm_ops); node = of_find_compatible_node(NULL, NULL, "mmio-sram"); -- 2.7.2
next prev parent reply other threads:[~2016-03-10 2:17 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-10 2:16 [PATCH 00/18] ARM: vf610: Suspend/resume with self-refresh mode Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 01/18] irqchip: vf610-gpc: add Vybrid GPC IRQ controller Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-11 3:41 ` Marc Zyngier 2016-03-11 3:41 ` Marc Zyngier 2016-03-11 3:41 ` Marc Zyngier 2016-03-11 18:11 ` Stefan Agner 2016-03-11 18:11 ` Stefan Agner 2016-03-11 18:11 ` Stefan Agner 2016-03-12 0:21 ` Marc Zyngier 2016-03-12 0:21 ` Marc Zyngier 2016-03-31 8:07 ` Shawn Guo 2016-03-31 8:07 ` Shawn Guo 2016-03-10 2:16 ` [PATCH 02/18] ARM: dts: vf610: add GPC as new interrupt parent Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-31 8:21 ` Shawn Guo 2016-03-31 8:21 ` Shawn Guo 2016-03-31 17:53 ` Stefan Agner 2016-03-31 17:53 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 03/18] ARM: dts: vf610-colibri: GPIO wakeup key Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-31 8:19 ` Shawn Guo 2016-03-31 8:19 ` Shawn Guo 2016-03-31 17:55 ` Stefan Agner 2016-03-31 17:55 ` Stefan Agner 2016-03-31 17:55 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 04/18] ARM: dts: vf610: add on-chip SRAM Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-31 8:33 ` Shawn Guo 2016-03-31 8:33 ` Shawn Guo 2016-03-31 17:57 ` Stefan Agner 2016-03-31 17:57 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 05/18] ARM: dts: vf610: add modules required for PM Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-31 8:34 ` Shawn Guo 2016-03-31 8:34 ` Shawn Guo 2016-03-31 8:34 ` Shawn Guo 2016-03-10 2:16 ` [PATCH 06/18] ARM: imx: clk-gate2: allow custom gate configuration Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-31 11:37 ` Shawn Guo 2016-03-31 11:37 ` Shawn Guo 2016-03-31 17:59 ` Stefan Agner 2016-03-31 17:59 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 07/18] ARM: imx: clk-vf610: leave DDR clock on Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 08/18] ARM: clk: add WKPU unit Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-16 1:13 ` Stephen Boyd 2016-03-16 1:13 ` Stephen Boyd 2016-03-10 2:16 ` [PATCH 09/18] ARM: vf610: clk: add suspend/resume support Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-31 11:39 ` Shawn Guo 2016-03-31 11:39 ` Shawn Guo 2016-03-10 2:16 ` [PATCH 10/18] tty: serial: fsl_lpuart: support suspend/resume Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-31 11:41 ` Shawn Guo 2016-03-31 11:41 ` Shawn Guo 2016-03-10 2:16 ` [PATCH 11/18] pinctrl: pinctrl-imx: implement suspend/resume Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 12/18] gpio: vf610: add system PM suspend/resume Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 13/18] ARM: dts: vf610: add WKPU connection to GPIO Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 14/18] gpio: vf610: add support for WKPU unit Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-17 20:00 ` Rob Herring 2016-03-17 20:00 ` Rob Herring 2016-03-17 22:12 ` Stefan Agner 2016-03-17 22:12 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 15/18] ARM: vf610: PM: initial suspend/resume support Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 21:19 ` kbuild test robot 2016-03-10 21:19 ` kbuild test robot 2016-03-10 21:19 ` kbuild test robot 2016-04-01 2:25 ` Shawn Guo 2016-04-01 2:25 ` Shawn Guo 2016-04-01 6:40 ` Stefan Agner 2016-04-01 6:40 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner [this message] 2016-03-10 2:16 ` [PATCH 16/18] ARM: vf610: PM: enable Suspend-to-RAM only if hardware fixes are in place Stefan Agner 2016-03-10 2:16 ` [PATCH 17/18] Documentation: dt: add Vybrid DDR memory controller bindings Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-18 16:10 ` Rob Herring 2016-03-18 16:10 ` Rob Herring 2016-03-10 2:16 ` [PATCH 18/18] ARM: vf610: PM: enable SNVS access Stefan Agner 2016-03-10 2:16 ` Stefan Agner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1457576219-7971-17-git-send-email-stefan@agner.ch \ --to=stefan@agner.ch \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=jason@lakedaemon.net \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=mturquette@baylibre.com \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@codeaurora.org \ --cc=sergeimir@emcraft.com \ --cc=shawnguo@kernel.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.