From: Rob Herring <robh@kernel.org> To: Stefan Agner <stefan@agner.ch> Cc: shawnguo@kernel.org, mturquette@baylibre.com, sboyd@codeaurora.org, kernel@pengutronix.de, sergeimir@emcraft.com, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 14/18] gpio: vf610: add support for WKPU unit Date: Thu, 17 Mar 2016 15:00:54 -0500 [thread overview] Message-ID: <20160317200054.GA3799@rob-hp-laptop> (raw) In-Reply-To: <1457576219-7971-15-git-send-email-stefan@agner.ch> On Wed, Mar 09, 2016 at 06:16:55PM -0800, Stefan Agner wrote: > WKPU unit support within the VF610 GPIO driver. The WKPU unit allows > some GPIO to be the wakeup source from lowest power modes LPSTOPx. > The relationship between the GPIO banks and the WKPU GPIO numbering > can be derived from the device tree property fsl,gpio-wakeup. > > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > .../devicetree/bindings/gpio/gpio-vf610.txt | 6 + > drivers/gpio/gpio-vf610.c | 151 +++++++++++++++++++++ > 2 files changed, 157 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-vf610.txt b/Documentation/devicetree/bindings/gpio/gpio-vf610.txt > index 436cc99..985ddfd 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-vf610.txt > +++ b/Documentation/devicetree/bindings/gpio/gpio-vf610.txt > @@ -22,6 +22,12 @@ Required properties for GPIO node: > 4 = active high level-sensitive. > 8 = active low level-sensitive. > > +Option properties: Optional > +- fsl,gpio-wakeup : map GPIOs to WKPU unit, 3 argument cells per phandle phandle to what? > + cell 1: First GPIO (relative to the GPIO block) > + cell 2: First GPIO of the WKPU unit > + cell 3: Number of consecutive GPIO's An interrupt-map could work here instead even though I'm guessing you don't make the WKPU an interrupt parent. Your table would look something like this: <WKPU# <&gpio> GPIO#> > + > Note: Each GPIO port should have an alias correctly numbered in "aliases" > node. > > diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c > index 1a022be..650a41a 100644 > --- a/drivers/gpio/gpio-vf610.c > +++ b/drivers/gpio/gpio-vf610.c The WKPU seems to purely be an interrupt controller. Perhaps you should use stacked irq domain here. Then it would not be tied into the GPIO controller at all. Rob
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 14/18] gpio: vf610: add support for WKPU unit Date: Thu, 17 Mar 2016 15:00:54 -0500 [thread overview] Message-ID: <20160317200054.GA3799@rob-hp-laptop> (raw) In-Reply-To: <1457576219-7971-15-git-send-email-stefan@agner.ch> On Wed, Mar 09, 2016 at 06:16:55PM -0800, Stefan Agner wrote: > WKPU unit support within the VF610 GPIO driver. The WKPU unit allows > some GPIO to be the wakeup source from lowest power modes LPSTOPx. > The relationship between the GPIO banks and the WKPU GPIO numbering > can be derived from the device tree property fsl,gpio-wakeup. > > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > .../devicetree/bindings/gpio/gpio-vf610.txt | 6 + > drivers/gpio/gpio-vf610.c | 151 +++++++++++++++++++++ > 2 files changed, 157 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-vf610.txt b/Documentation/devicetree/bindings/gpio/gpio-vf610.txt > index 436cc99..985ddfd 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-vf610.txt > +++ b/Documentation/devicetree/bindings/gpio/gpio-vf610.txt > @@ -22,6 +22,12 @@ Required properties for GPIO node: > 4 = active high level-sensitive. > 8 = active low level-sensitive. > > +Option properties: Optional > +- fsl,gpio-wakeup : map GPIOs to WKPU unit, 3 argument cells per phandle phandle to what? > + cell 1: First GPIO (relative to the GPIO block) > + cell 2: First GPIO of the WKPU unit > + cell 3: Number of consecutive GPIO's An interrupt-map could work here instead even though I'm guessing you don't make the WKPU an interrupt parent. Your table would look something like this: <WKPU# <&gpio> GPIO#> > + > Note: Each GPIO port should have an alias correctly numbered in "aliases" > node. > > diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c > index 1a022be..650a41a 100644 > --- a/drivers/gpio/gpio-vf610.c > +++ b/drivers/gpio/gpio-vf610.c The WKPU seems to purely be an interrupt controller. Perhaps you should use stacked irq domain here. Then it would not be tied into the GPIO controller at all. Rob
next prev parent reply other threads:[~2016-03-17 20:01 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-10 2:16 [PATCH 00/18] ARM: vf610: Suspend/resume with self-refresh mode Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 01/18] irqchip: vf610-gpc: add Vybrid GPC IRQ controller Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-11 3:41 ` Marc Zyngier 2016-03-11 3:41 ` Marc Zyngier 2016-03-11 3:41 ` Marc Zyngier 2016-03-11 18:11 ` Stefan Agner 2016-03-11 18:11 ` Stefan Agner 2016-03-11 18:11 ` Stefan Agner 2016-03-12 0:21 ` Marc Zyngier 2016-03-12 0:21 ` Marc Zyngier 2016-03-31 8:07 ` Shawn Guo 2016-03-31 8:07 ` Shawn Guo 2016-03-10 2:16 ` [PATCH 02/18] ARM: dts: vf610: add GPC as new interrupt parent Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-31 8:21 ` Shawn Guo 2016-03-31 8:21 ` Shawn Guo 2016-03-31 17:53 ` Stefan Agner 2016-03-31 17:53 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 03/18] ARM: dts: vf610-colibri: GPIO wakeup key Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-31 8:19 ` Shawn Guo 2016-03-31 8:19 ` Shawn Guo 2016-03-31 17:55 ` Stefan Agner 2016-03-31 17:55 ` Stefan Agner 2016-03-31 17:55 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 04/18] ARM: dts: vf610: add on-chip SRAM Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-31 8:33 ` Shawn Guo 2016-03-31 8:33 ` Shawn Guo 2016-03-31 17:57 ` Stefan Agner 2016-03-31 17:57 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 05/18] ARM: dts: vf610: add modules required for PM Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-31 8:34 ` Shawn Guo 2016-03-31 8:34 ` Shawn Guo 2016-03-31 8:34 ` Shawn Guo 2016-03-10 2:16 ` [PATCH 06/18] ARM: imx: clk-gate2: allow custom gate configuration Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-31 11:37 ` Shawn Guo 2016-03-31 11:37 ` Shawn Guo 2016-03-31 17:59 ` Stefan Agner 2016-03-31 17:59 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 07/18] ARM: imx: clk-vf610: leave DDR clock on Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 08/18] ARM: clk: add WKPU unit Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-16 1:13 ` Stephen Boyd 2016-03-16 1:13 ` Stephen Boyd 2016-03-10 2:16 ` [PATCH 09/18] ARM: vf610: clk: add suspend/resume support Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-31 11:39 ` Shawn Guo 2016-03-31 11:39 ` Shawn Guo 2016-03-10 2:16 ` [PATCH 10/18] tty: serial: fsl_lpuart: support suspend/resume Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-31 11:41 ` Shawn Guo 2016-03-31 11:41 ` Shawn Guo 2016-03-10 2:16 ` [PATCH 11/18] pinctrl: pinctrl-imx: implement suspend/resume Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 12/18] gpio: vf610: add system PM suspend/resume Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 13/18] ARM: dts: vf610: add WKPU connection to GPIO Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 14/18] gpio: vf610: add support for WKPU unit Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-17 20:00 ` Rob Herring [this message] 2016-03-17 20:00 ` Rob Herring 2016-03-17 22:12 ` Stefan Agner 2016-03-17 22:12 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 15/18] ARM: vf610: PM: initial suspend/resume support Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 21:19 ` kbuild test robot 2016-03-10 21:19 ` kbuild test robot 2016-03-10 21:19 ` kbuild test robot 2016-04-01 2:25 ` Shawn Guo 2016-04-01 2:25 ` Shawn Guo 2016-04-01 6:40 ` Stefan Agner 2016-04-01 6:40 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 16/18] ARM: vf610: PM: enable Suspend-to-RAM only if hardware fixes are in place Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` [PATCH 17/18] Documentation: dt: add Vybrid DDR memory controller bindings Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-10 2:16 ` Stefan Agner 2016-03-18 16:10 ` Rob Herring 2016-03-18 16:10 ` Rob Herring 2016-03-10 2:16 ` [PATCH 18/18] ARM: vf610: PM: enable SNVS access Stefan Agner 2016-03-10 2:16 ` Stefan Agner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160317200054.GA3799@rob-hp-laptop \ --to=robh@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=jason@lakedaemon.net \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=mturquette@baylibre.com \ --cc=pawel.moll@arm.com \ --cc=sboyd@codeaurora.org \ --cc=sergeimir@emcraft.com \ --cc=shawnguo@kernel.org \ --cc=stefan@agner.ch \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.