From: Ming Lei <ming.lei@canonical.com> To: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@infradead.org>, Al Viro <viro@zeniv.linux.org.uk>, Anton Altaparmakov <anton@tuxera.com>, xfs@oss.sgi.com, Dave Chinner <david@fromorbit.com>, drbd-dev@lists.linbit.com, Philipp Reisner <philipp.reisner@linbit.com>, Lars Ellenberg <lars.ellenberg@linbit.com>, Boaz Harrosh <boaz@plexistor.com>, Ming Lei <ming.lei@canonical.com> Subject: [PATCH 7/8] block: drbd: avoid to use BIO_MAX_SIZE Date: Tue, 22 Mar 2016 14:12:28 +0800 [thread overview] Message-ID: <1458627149-12988-8-git-send-email-ming.lei@canonical.com> (raw) In-Reply-To: <1458627149-12988-1-git-send-email-ming.lei@canonical.com> drbd is the only user of BIO_MAX_SIZE, so use BIO_MAX_PAGES instead. Signed-off-by: Ming Lei <ming.lei@canonical.com> --- drivers/block/drbd/drbd_int.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h index c227fd4..10bfff1 100644 --- a/drivers/block/drbd/drbd_int.h +++ b/drivers/block/drbd/drbd_int.h @@ -1327,14 +1327,14 @@ struct bm_extent { #endif #endif -/* BIO_MAX_SIZE is 256 * PAGE_CACHE_SIZE, +/* Estimate max bio size as 256 * PAGE_CACHE_SIZE, * so for typical PAGE_CACHE_SIZE of 4k, that is (1<<20) Byte. * Since we may live in a mixed-platform cluster, * we limit us to a platform agnostic constant here for now. * A followup commit may allow even bigger BIO sizes, * once we thought that through. */ #define DRBD_MAX_BIO_SIZE (1U << 20) -#if DRBD_MAX_BIO_SIZE > BIO_MAX_SIZE +#if DRBD_MAX_BIO_SIZE > (BIO_MAX_PAGES << PAGE_CACHE_SHIFT) #error Architecture not supported: DRBD_MAX_BIO_SIZE > BIO_MAX_SIZE #endif #define DRBD_MAX_BIO_SIZE_SAFE (1U << 12) /* Works always = 4k */ -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@canonical.com> To: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org Cc: Christoph Hellwig <hch@infradead.org>, Boaz Harrosh <boaz@plexistor.com>, Ming Lei <ming.lei@canonical.com>, Philipp Reisner <philipp.reisner@linbit.com>, xfs@oss.sgi.com, linux-block@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>, Lars Ellenberg <lars.ellenberg@linbit.com>, Anton Altaparmakov <anton@tuxera.com>, drbd-dev@lists.linbit.com Subject: [PATCH 7/8] block: drbd: avoid to use BIO_MAX_SIZE Date: Tue, 22 Mar 2016 14:12:28 +0800 [thread overview] Message-ID: <1458627149-12988-8-git-send-email-ming.lei@canonical.com> (raw) In-Reply-To: <1458627149-12988-1-git-send-email-ming.lei@canonical.com> drbd is the only user of BIO_MAX_SIZE, so use BIO_MAX_PAGES instead. Signed-off-by: Ming Lei <ming.lei@canonical.com> --- drivers/block/drbd/drbd_int.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h index c227fd4..10bfff1 100644 --- a/drivers/block/drbd/drbd_int.h +++ b/drivers/block/drbd/drbd_int.h @@ -1327,14 +1327,14 @@ struct bm_extent { #endif #endif -/* BIO_MAX_SIZE is 256 * PAGE_CACHE_SIZE, +/* Estimate max bio size as 256 * PAGE_CACHE_SIZE, * so for typical PAGE_CACHE_SIZE of 4k, that is (1<<20) Byte. * Since we may live in a mixed-platform cluster, * we limit us to a platform agnostic constant here for now. * A followup commit may allow even bigger BIO sizes, * once we thought that through. */ #define DRBD_MAX_BIO_SIZE (1U << 20) -#if DRBD_MAX_BIO_SIZE > BIO_MAX_SIZE +#if DRBD_MAX_BIO_SIZE > (BIO_MAX_PAGES << PAGE_CACHE_SHIFT) #error Architecture not supported: DRBD_MAX_BIO_SIZE > BIO_MAX_SIZE #endif #define DRBD_MAX_BIO_SIZE_SAFE (1U << 12) /* Works always = 4k */ -- 1.9.1 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-22 6:14 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-22 6:12 [PATCH 0/8] block: prepare for multipage bvecs Ming Lei 2016-03-22 6:12 ` Ming Lei 2016-03-22 6:12 ` [PATCH 1/8] block: move bvec iterator into include/linux/bvec_iter.h Ming Lei 2016-03-22 6:12 ` Ming Lei 2016-03-29 7:26 ` Christoph Hellwig 2016-03-29 7:26 ` Christoph Hellwig 2016-03-29 8:53 ` Ming Lei 2016-03-29 8:53 ` Ming Lei 2016-03-22 6:12 ` [PATCH 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK Ming Lei 2016-03-22 6:12 ` Ming Lei 2016-03-29 7:26 ` Christoph Hellwig 2016-03-29 7:26 ` Christoph Hellwig 2016-03-22 6:12 ` [PATCH 3/8] block: mark 1st parameter of bvec_iter_advance as const Ming Lei 2016-03-22 6:12 ` Ming Lei 2016-03-29 7:26 ` Christoph Hellwig 2016-03-29 7:26 ` Christoph Hellwig 2016-03-22 6:12 ` [PATCH 4/8] iov_iter: use bvec iterator to implement iterate_bvec() Ming Lei 2016-03-22 6:12 ` Ming Lei 2016-03-29 7:27 ` Christoph Hellwig 2016-03-29 7:27 ` Christoph Hellwig 2016-03-22 6:12 ` [PATCH 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES Ming Lei 2016-03-22 6:12 ` Ming Lei 2016-03-29 7:29 ` Christoph Hellwig 2016-03-29 7:29 ` Christoph Hellwig 2016-03-22 6:12 ` [PATCH 6/8] block: bio: remove BIO_MAX_SECTORS Ming Lei 2016-03-22 6:12 ` Ming Lei 2016-03-29 7:29 ` Christoph Hellwig 2016-03-29 7:29 ` Christoph Hellwig 2016-03-22 6:12 ` Ming Lei [this message] 2016-03-22 6:12 ` [PATCH 7/8] block: drbd: avoid to use BIO_MAX_SIZE Ming Lei 2016-03-29 7:31 ` Christoph Hellwig 2016-03-29 7:31 ` Christoph Hellwig 2016-03-29 8:09 ` Lars Ellenberg 2016-03-29 8:09 ` Lars Ellenberg 2016-03-22 6:12 ` [PATCH 8/8] block: bio: remove BIO_MAX_SIZE Ming Lei 2016-03-22 6:12 ` Ming Lei 2016-03-29 7:31 ` Christoph Hellwig 2016-03-29 7:31 ` Christoph Hellwig 2016-03-29 1:33 ` [PATCH 0/8] block: prepare for multipage bvecs Ming Lei 2016-03-29 1:33 ` Ming Lei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1458627149-12988-8-git-send-email-ming.lei@canonical.com \ --to=ming.lei@canonical.com \ --cc=anton@tuxera.com \ --cc=axboe@kernel.dk \ --cc=boaz@plexistor.com \ --cc=david@fromorbit.com \ --cc=drbd-dev@lists.linbit.com \ --cc=hch@infradead.org \ --cc=lars.ellenberg@linbit.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=philipp.reisner@linbit.com \ --cc=viro@zeniv.linux.org.uk \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.