From: Ming Lei <ming.lei@canonical.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-block@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Anton Altaparmakov <anton@tuxera.com>,
xfs@oss.sgi.com, Dave Chinner <david@fromorbit.com>,
drbd-dev@lists.linbit.com,
Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Boaz Harrosh <boaz@plexistor.com>
Subject: Re: [PATCH 1/8] block: move bvec iterator into include/linux/bvec_iter.h
Date: Tue, 29 Mar 2016 16:53:22 +0800 [thread overview]
Message-ID: <CACVXFVOmyJJjuNNyH89VM3jwVJA0zkA1H-JZtHoX1stxov4C2A@mail.gmail.com> (raw)
In-Reply-To: <20160329072617.GB18920@infradead.org>
On Tue, Mar 29, 2016 at 3:26 PM, Christoph Hellwig <hch@infradead.org> wrote:
>> --- a/include/linux/bio.h
>> +++ b/include/linux/bio.h
>> @@ -31,6 +31,7 @@
>>
>> /* struct bio, bio_vec and BIO_* flags are defined in blk_types.h */
>> #include <linux/blk_types.h>
>> +#include <linux/bvec_iter.h>
>>
>> #define BIO_DEBUG
>>
>> @@ -40,10 +41,6 @@
>> #define BIO_BUG_ON
>> #endif
>>
>> -#define BIO_MAX_PAGES 256
>> -#define BIO_MAX_SIZE (BIO_MAX_PAGES << PAGE_CACHE_SHIFT)
>> -#define BIO_MAX_SECTORS (BIO_MAX_SIZE >> 9)
>
> I see no reason why these should be moved out of bio.h.
You are right, these should be kept in bio.h.
Thanks for your review!
>
> Otherwise this looks fine to me.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-block" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@canonical.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>, Boaz Harrosh <boaz@plexistor.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
xfs@oss.sgi.com, linux-block@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
Anton Altaparmakov <anton@tuxera.com>,
drbd-dev@lists.linbit.com
Subject: Re: [PATCH 1/8] block: move bvec iterator into include/linux/bvec_iter.h
Date: Tue, 29 Mar 2016 16:53:22 +0800 [thread overview]
Message-ID: <CACVXFVOmyJJjuNNyH89VM3jwVJA0zkA1H-JZtHoX1stxov4C2A@mail.gmail.com> (raw)
In-Reply-To: <20160329072617.GB18920@infradead.org>
On Tue, Mar 29, 2016 at 3:26 PM, Christoph Hellwig <hch@infradead.org> wrote:
>> --- a/include/linux/bio.h
>> +++ b/include/linux/bio.h
>> @@ -31,6 +31,7 @@
>>
>> /* struct bio, bio_vec and BIO_* flags are defined in blk_types.h */
>> #include <linux/blk_types.h>
>> +#include <linux/bvec_iter.h>
>>
>> #define BIO_DEBUG
>>
>> @@ -40,10 +41,6 @@
>> #define BIO_BUG_ON
>> #endif
>>
>> -#define BIO_MAX_PAGES 256
>> -#define BIO_MAX_SIZE (BIO_MAX_PAGES << PAGE_CACHE_SHIFT)
>> -#define BIO_MAX_SECTORS (BIO_MAX_SIZE >> 9)
>
> I see no reason why these should be moved out of bio.h.
You are right, these should be kept in bio.h.
Thanks for your review!
>
> Otherwise this looks fine to me.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-block" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-29 8:53 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 6:12 [PATCH 0/8] block: prepare for multipage bvecs Ming Lei
2016-03-22 6:12 ` Ming Lei
2016-03-22 6:12 ` [PATCH 1/8] block: move bvec iterator into include/linux/bvec_iter.h Ming Lei
2016-03-22 6:12 ` Ming Lei
2016-03-29 7:26 ` Christoph Hellwig
2016-03-29 7:26 ` Christoph Hellwig
2016-03-29 8:53 ` Ming Lei [this message]
2016-03-29 8:53 ` Ming Lei
2016-03-22 6:12 ` [PATCH 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK Ming Lei
2016-03-22 6:12 ` Ming Lei
2016-03-29 7:26 ` Christoph Hellwig
2016-03-29 7:26 ` Christoph Hellwig
2016-03-22 6:12 ` [PATCH 3/8] block: mark 1st parameter of bvec_iter_advance as const Ming Lei
2016-03-22 6:12 ` Ming Lei
2016-03-29 7:26 ` Christoph Hellwig
2016-03-29 7:26 ` Christoph Hellwig
2016-03-22 6:12 ` [PATCH 4/8] iov_iter: use bvec iterator to implement iterate_bvec() Ming Lei
2016-03-22 6:12 ` Ming Lei
2016-03-29 7:27 ` Christoph Hellwig
2016-03-29 7:27 ` Christoph Hellwig
2016-03-22 6:12 ` [PATCH 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES Ming Lei
2016-03-22 6:12 ` Ming Lei
2016-03-29 7:29 ` Christoph Hellwig
2016-03-29 7:29 ` Christoph Hellwig
2016-03-22 6:12 ` [PATCH 6/8] block: bio: remove BIO_MAX_SECTORS Ming Lei
2016-03-22 6:12 ` Ming Lei
2016-03-29 7:29 ` Christoph Hellwig
2016-03-29 7:29 ` Christoph Hellwig
2016-03-22 6:12 ` [PATCH 7/8] block: drbd: avoid to use BIO_MAX_SIZE Ming Lei
2016-03-22 6:12 ` Ming Lei
2016-03-29 7:31 ` Christoph Hellwig
2016-03-29 7:31 ` Christoph Hellwig
2016-03-29 8:09 ` Lars Ellenberg
2016-03-29 8:09 ` Lars Ellenberg
2016-03-22 6:12 ` [PATCH 8/8] block: bio: remove BIO_MAX_SIZE Ming Lei
2016-03-22 6:12 ` Ming Lei
2016-03-29 7:31 ` Christoph Hellwig
2016-03-29 7:31 ` Christoph Hellwig
2016-03-29 1:33 ` [PATCH 0/8] block: prepare for multipage bvecs Ming Lei
2016-03-29 1:33 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACVXFVOmyJJjuNNyH89VM3jwVJA0zkA1H-JZtHoX1stxov4C2A@mail.gmail.com \
--to=ming.lei@canonical.com \
--cc=anton@tuxera.com \
--cc=axboe@kernel.dk \
--cc=boaz@plexistor.com \
--cc=david@fromorbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@infradead.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.