All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@canonical.com>
To: Jens Axboe <axboe@kernel.dk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: linux-block@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Anton Altaparmakov <anton@tuxera.com>,
	xfs@oss.sgi.com, Dave Chinner <david@fromorbit.com>,
	drbd-dev@lists.linbit.com,
	Philipp Reisner <philipp.reisner@linbit.com>,
	Lars Ellenberg <lars.ellenberg@linbit.com>,
	Boaz Harrosh <boaz@plexistor.com>
Subject: Re: [PATCH 0/8] block: prepare for multipage bvecs
Date: Tue, 29 Mar 2016 09:33:13 +0800	[thread overview]
Message-ID: <CACVXFVPABFW=dnv_g6noXg5w-sdTTBxaickn8HSLSCd8KJcd0A@mail.gmail.com> (raw)
In-Reply-To: <1458627149-12988-1-git-send-email-ming.lei@canonical.com>

On Tue, Mar 22, 2016 at 2:12 PM, Ming Lei <ming.lei@canonical.com> wrote:
> Hi,
>
> Interests[1] have been shown in multipage bvecs, so this patchset
> try to prepare for the support and do two things:
>
> 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(),
> then we can drop the non-standard way for iterating bvec
>
> 2) remove BIO_MAX_SECTORS & BIO_MAX_SIZE, and now there is only
> one user for each. Once multipage bvecs is introduced, one bio
> may hold lots of sectors, and we should always use sort of BIO_MAX_VECS
> which should be introduced in future and is similiar with current
> BIO_MAX_PAGES.
>
> xfstests(-a auto) have been run and no regression found by this
> patchset against linus v4.5+.

Hi Jens,

Looks no one objects this patchset, and the change of iov_iter.c
is a good cleanup too, so what do you think of the patchset?

Thanks,
Ming

>
>  drivers/block/drbd/drbd_int.h |  4 +--
>  fs/xfs/xfs_buf.c              |  2 +-
>  include/linux/bio.h           | 55 +------------------------------
>  include/linux/blk_types.h     |  4 +--
>  include/linux/bvec_iter.h     | 77 +++++++++++++++++++++++++++++++++++++++++++
>  lib/iov_iter.c                | 31 +++++++----------
>  6 files changed, 94 insertions(+), 79 deletions(-)
>
>
> [1], http://marc.info/?w=2&r=1&s=++[LSF%2FMM+ATTEND]+block%3A+multipage+bvecs&q=t
>
>
> Thanks,
> Ming
>

WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@canonical.com>
To: Jens Axboe <axboe@kernel.dk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Boaz Harrosh <boaz@plexistor.com>,
	Philipp Reisner <philipp.reisner@linbit.com>,
	xfs@oss.sgi.com, linux-block@vger.kernel.org,
	Al Viro <viro@zeniv.linux.org.uk>,
	Lars Ellenberg <lars.ellenberg@linbit.com>,
	Anton Altaparmakov <anton@tuxera.com>,
	drbd-dev@lists.linbit.com
Subject: Re: [PATCH 0/8] block: prepare for multipage bvecs
Date: Tue, 29 Mar 2016 09:33:13 +0800	[thread overview]
Message-ID: <CACVXFVPABFW=dnv_g6noXg5w-sdTTBxaickn8HSLSCd8KJcd0A@mail.gmail.com> (raw)
In-Reply-To: <1458627149-12988-1-git-send-email-ming.lei@canonical.com>

On Tue, Mar 22, 2016 at 2:12 PM, Ming Lei <ming.lei@canonical.com> wrote:
> Hi,
>
> Interests[1] have been shown in multipage bvecs, so this patchset
> try to prepare for the support and do two things:
>
> 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(),
> then we can drop the non-standard way for iterating bvec
>
> 2) remove BIO_MAX_SECTORS & BIO_MAX_SIZE, and now there is only
> one user for each. Once multipage bvecs is introduced, one bio
> may hold lots of sectors, and we should always use sort of BIO_MAX_VECS
> which should be introduced in future and is similiar with current
> BIO_MAX_PAGES.
>
> xfstests(-a auto) have been run and no regression found by this
> patchset against linus v4.5+.

Hi Jens,

Looks no one objects this patchset, and the change of iov_iter.c
is a good cleanup too, so what do you think of the patchset?

Thanks,
Ming

>
>  drivers/block/drbd/drbd_int.h |  4 +--
>  fs/xfs/xfs_buf.c              |  2 +-
>  include/linux/bio.h           | 55 +------------------------------
>  include/linux/blk_types.h     |  4 +--
>  include/linux/bvec_iter.h     | 77 +++++++++++++++++++++++++++++++++++++++++++
>  lib/iov_iter.c                | 31 +++++++----------
>  6 files changed, 94 insertions(+), 79 deletions(-)
>
>
> [1], http://marc.info/?w=2&r=1&s=++[LSF%2FMM+ATTEND]+block%3A+multipage+bvecs&q=t
>
>
> Thanks,
> Ming
>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2016-03-29  1:33 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22  6:12 [PATCH 0/8] block: prepare for multipage bvecs Ming Lei
2016-03-22  6:12 ` Ming Lei
2016-03-22  6:12 ` [PATCH 1/8] block: move bvec iterator into include/linux/bvec_iter.h Ming Lei
2016-03-22  6:12   ` Ming Lei
2016-03-29  7:26   ` Christoph Hellwig
2016-03-29  7:26     ` Christoph Hellwig
2016-03-29  8:53     ` Ming Lei
2016-03-29  8:53       ` Ming Lei
2016-03-22  6:12 ` [PATCH 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK Ming Lei
2016-03-22  6:12   ` Ming Lei
2016-03-29  7:26   ` Christoph Hellwig
2016-03-29  7:26     ` Christoph Hellwig
2016-03-22  6:12 ` [PATCH 3/8] block: mark 1st parameter of bvec_iter_advance as const Ming Lei
2016-03-22  6:12   ` Ming Lei
2016-03-29  7:26   ` Christoph Hellwig
2016-03-29  7:26     ` Christoph Hellwig
2016-03-22  6:12 ` [PATCH 4/8] iov_iter: use bvec iterator to implement iterate_bvec() Ming Lei
2016-03-22  6:12   ` Ming Lei
2016-03-29  7:27   ` Christoph Hellwig
2016-03-29  7:27     ` Christoph Hellwig
2016-03-22  6:12 ` [PATCH 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES Ming Lei
2016-03-22  6:12   ` Ming Lei
2016-03-29  7:29   ` Christoph Hellwig
2016-03-29  7:29     ` Christoph Hellwig
2016-03-22  6:12 ` [PATCH 6/8] block: bio: remove BIO_MAX_SECTORS Ming Lei
2016-03-22  6:12   ` Ming Lei
2016-03-29  7:29   ` Christoph Hellwig
2016-03-29  7:29     ` Christoph Hellwig
2016-03-22  6:12 ` [PATCH 7/8] block: drbd: avoid to use BIO_MAX_SIZE Ming Lei
2016-03-22  6:12   ` Ming Lei
2016-03-29  7:31   ` Christoph Hellwig
2016-03-29  7:31     ` Christoph Hellwig
2016-03-29  8:09     ` Lars Ellenberg
2016-03-29  8:09       ` Lars Ellenberg
2016-03-22  6:12 ` [PATCH 8/8] block: bio: remove BIO_MAX_SIZE Ming Lei
2016-03-22  6:12   ` Ming Lei
2016-03-29  7:31   ` Christoph Hellwig
2016-03-29  7:31     ` Christoph Hellwig
2016-03-29  1:33 ` Ming Lei [this message]
2016-03-29  1:33   ` [PATCH 0/8] block: prepare for multipage bvecs Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACVXFVPABFW=dnv_g6noXg5w-sdTTBxaickn8HSLSCd8KJcd0A@mail.gmail.com' \
    --to=ming.lei@canonical.com \
    --cc=anton@tuxera.com \
    --cc=axboe@kernel.dk \
    --cc=boaz@plexistor.com \
    --cc=david@fromorbit.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=hch@infradead.org \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipp.reisner@linbit.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.