From: Jisheng Zhang <jszhang@marvell.com> To: <mathias.nyman@intel.com>, <gregkh@linuxfoundation.org> Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <yendapally.reddy@broadcom.com>, Jisheng Zhang <jszhang@marvell.com> Subject: [RESEND PATCH v2 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists Date: Tue, 26 Apr 2016 20:57:36 +0800 [thread overview] Message-ID: <1461675460-2295-4-git-send-email-jszhang@marvell.com> (raw) In-Reply-To: <1461675460-2295-1-git-send-email-jszhang@marvell.com> Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the usb_phy for usb3, but it forgets to shutdown/init the usb_phy in the suspend/resume path. This patch fixes this issue by adding missing usb_phy related calls. Signed-off-by: Jisheng Zhang <jszhang@marvell.com> --- drivers/usb/host/xhci-plat.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index 9ff89e9..fbd23fd 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -313,6 +313,7 @@ static int xhci_plat_suspend(struct device *dev) if (ret) return ret; + usb_phy_shutdown(xhci->shared_hcd->usb_phy); clk_disable_unprepare(xhci->clk); return ret; @@ -328,6 +329,10 @@ static int xhci_plat_resume(struct device *dev) if (ret) return ret; + ret = usb_phy_init(xhci->shared_hcd->usb_phy); + if (ret) + return ret; + return xhci_resume(xhci, 0); } -- 2.8.1
WARNING: multiple messages have this Message-ID (diff)
From: jszhang@marvell.com (Jisheng Zhang) To: linux-arm-kernel@lists.infradead.org Subject: [RESEND PATCH v2 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists Date: Tue, 26 Apr 2016 20:57:36 +0800 [thread overview] Message-ID: <1461675460-2295-4-git-send-email-jszhang@marvell.com> (raw) In-Reply-To: <1461675460-2295-1-git-send-email-jszhang@marvell.com> Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the usb_phy for usb3, but it forgets to shutdown/init the usb_phy in the suspend/resume path. This patch fixes this issue by adding missing usb_phy related calls. Signed-off-by: Jisheng Zhang <jszhang@marvell.com> --- drivers/usb/host/xhci-plat.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index 9ff89e9..fbd23fd 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -313,6 +313,7 @@ static int xhci_plat_suspend(struct device *dev) if (ret) return ret; + usb_phy_shutdown(xhci->shared_hcd->usb_phy); clk_disable_unprepare(xhci->clk); return ret; @@ -328,6 +329,10 @@ static int xhci_plat_resume(struct device *dev) if (ret) return ret; + ret = usb_phy_init(xhci->shared_hcd->usb_phy); + if (ret) + return ret; + return xhci_resume(xhci, 0); } -- 2.8.1
next prev parent reply other threads:[~2016-04-26 13:04 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-26 12:57 [RESEND PATCH v2 0/7] usb: xhci-plat: support generic PHY and vbus regulator Jisheng Zhang 2016-04-26 12:57 ` Jisheng Zhang 2016-04-26 12:57 ` [RESEND PATCH v2 1/7] usb: xhci: plat: Fix suspend/resume when the optional clk exists Jisheng Zhang 2016-04-26 12:57 ` Jisheng Zhang 2016-04-27 5:25 ` Felipe Balbi 2016-04-27 5:25 ` Felipe Balbi 2016-04-27 5:46 ` Jisheng Zhang 2016-04-27 5:46 ` Jisheng Zhang 2016-04-26 12:57 ` [RESEND PATCH v2 2/7] usb: xhci: plat: attach the usb_phy to the correct hcd Jisheng Zhang 2016-04-26 12:57 ` Jisheng Zhang 2016-04-27 5:29 ` Felipe Balbi 2016-04-27 5:29 ` Felipe Balbi 2016-04-27 5:59 ` Jisheng Zhang 2016-04-27 5:59 ` Jisheng Zhang 2016-04-27 6:19 ` Felipe Balbi 2016-04-27 6:19 ` Felipe Balbi 2016-04-26 12:57 ` Jisheng Zhang [this message] 2016-04-26 12:57 ` [RESEND PATCH v2 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists Jisheng Zhang 2016-04-27 5:30 ` Felipe Balbi 2016-04-27 5:30 ` Felipe Balbi 2016-04-26 12:57 ` [RESEND PATCH v2 4/7] usb: xhci: plat: sort the headers in alphabetic order Jisheng Zhang 2016-04-26 12:57 ` Jisheng Zhang 2016-04-26 12:57 ` [RESEND PATCH v2 5/7] usb: xhci: plat: Remove checks for optional clock in error/remove path Jisheng Zhang 2016-04-26 12:57 ` Jisheng Zhang 2016-04-27 5:33 ` Felipe Balbi 2016-04-27 5:33 ` Felipe Balbi 2016-04-27 6:33 ` Jisheng Zhang 2016-04-27 6:33 ` Jisheng Zhang 2016-04-27 7:19 ` Felipe Balbi 2016-04-27 7:19 ` Felipe Balbi 2016-04-26 12:57 ` [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support Jisheng Zhang 2016-04-26 12:57 ` Jisheng Zhang 2016-04-27 5:35 ` Felipe Balbi 2016-04-27 5:35 ` Felipe Balbi 2016-04-27 6:46 ` Jisheng Zhang 2016-04-27 6:46 ` Jisheng Zhang 2016-04-27 7:21 ` Felipe Balbi 2016-04-27 7:21 ` Felipe Balbi 2016-04-27 7:57 ` Heikki Krogerus 2016-04-27 7:57 ` Heikki Krogerus 2016-04-27 9:34 ` Felipe Balbi 2016-04-27 9:34 ` Felipe Balbi 2016-04-26 12:57 ` [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control Jisheng Zhang 2016-04-26 12:57 ` Jisheng Zhang 2016-04-27 5:37 ` Felipe Balbi 2016-04-27 5:37 ` Felipe Balbi 2016-04-27 9:57 ` Mark Brown 2016-04-27 9:57 ` Mark Brown 2016-04-27 10:25 ` Jisheng Zhang 2016-04-27 10:25 ` Jisheng Zhang 2016-04-27 13:24 ` Mark Brown 2016-04-27 13:24 ` Mark Brown 2016-04-27 10:25 ` Felipe Balbi 2016-04-27 10:25 ` Felipe Balbi 2016-04-27 10:35 ` Mark Brown 2016-04-27 10:35 ` Mark Brown 2016-04-27 10:38 ` Felipe Balbi 2016-04-27 10:38 ` Felipe Balbi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1461675460-2295-4-git-send-email-jszhang@marvell.com \ --to=jszhang@marvell.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mathias.nyman@intel.com \ --cc=yendapally.reddy@broadcom.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.