From: Mark Brown <broonie@kernel.org>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Jisheng Zhang <jszhang@marvell.com>,
mathias.nyman@linux.intel.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
yendapally.reddy@broadcom.com
Subject: Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control
Date: Wed, 27 Apr 2016 10:57:39 +0100 [thread overview]
Message-ID: <20160427095738.GG3217@sirena.org.uk> (raw)
In-Reply-To: <87bn4vpq7j.fsf@intel.com>
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
On Wed, Apr 27, 2016 at 08:37:20AM +0300, Felipe Balbi wrote:
> Jisheng Zhang <jszhang@marvell.com> writes:
> > + vbus = devm_regulator_get(&pdev->dev, "vbus");
> devm_regulator_get_optional() ??
Does USB work without a VBUS? Unless the answer is yes then I'd expect
this to be just a normal regulator_get().
>
> > + if (PTR_ERR(vbus) == -ENODEV) {
> > + vbus = NULL;
> > + } else if (IS_ERR(vbus)) {
> > + ret = PTR_ERR(vbus);
> > + goto disable_clk;
> > + } else if (vbus) {
> > + ret = regulator_enable(vbus);
> > + if (ret) {
> > + dev_err(&pdev->dev,
> > + "failed to enable usb vbus regulator: %d\n",
> > + ret);
> > + goto disable_clk;
> > + }
> > + }
This is all completely broken unless the supply is optional.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control
Date: Wed, 27 Apr 2016 10:57:39 +0100 [thread overview]
Message-ID: <20160427095738.GG3217@sirena.org.uk> (raw)
In-Reply-To: <87bn4vpq7j.fsf@intel.com>
On Wed, Apr 27, 2016 at 08:37:20AM +0300, Felipe Balbi wrote:
> Jisheng Zhang <jszhang@marvell.com> writes:
> > + vbus = devm_regulator_get(&pdev->dev, "vbus");
> devm_regulator_get_optional() ??
Does USB work without a VBUS? Unless the answer is yes then I'd expect
this to be just a normal regulator_get().
>
> > + if (PTR_ERR(vbus) == -ENODEV) {
> > + vbus = NULL;
> > + } else if (IS_ERR(vbus)) {
> > + ret = PTR_ERR(vbus);
> > + goto disable_clk;
> > + } else if (vbus) {
> > + ret = regulator_enable(vbus);
> > + if (ret) {
> > + dev_err(&pdev->dev,
> > + "failed to enable usb vbus regulator: %d\n",
> > + ret);
> > + goto disable_clk;
> > + }
> > + }
This is all completely broken unless the supply is optional.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160427/48c0861d/attachment.sig>
next prev parent reply other threads:[~2016-04-27 9:57 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 12:57 [RESEND PATCH v2 0/7] usb: xhci-plat: support generic PHY and vbus regulator Jisheng Zhang
2016-04-26 12:57 ` Jisheng Zhang
2016-04-26 12:57 ` [RESEND PATCH v2 1/7] usb: xhci: plat: Fix suspend/resume when the optional clk exists Jisheng Zhang
2016-04-26 12:57 ` Jisheng Zhang
2016-04-27 5:25 ` Felipe Balbi
2016-04-27 5:25 ` Felipe Balbi
2016-04-27 5:46 ` Jisheng Zhang
2016-04-27 5:46 ` Jisheng Zhang
2016-04-26 12:57 ` [RESEND PATCH v2 2/7] usb: xhci: plat: attach the usb_phy to the correct hcd Jisheng Zhang
2016-04-26 12:57 ` Jisheng Zhang
2016-04-27 5:29 ` Felipe Balbi
2016-04-27 5:29 ` Felipe Balbi
2016-04-27 5:59 ` Jisheng Zhang
2016-04-27 5:59 ` Jisheng Zhang
2016-04-27 6:19 ` Felipe Balbi
2016-04-27 6:19 ` Felipe Balbi
2016-04-26 12:57 ` [RESEND PATCH v2 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists Jisheng Zhang
2016-04-26 12:57 ` Jisheng Zhang
2016-04-27 5:30 ` Felipe Balbi
2016-04-27 5:30 ` Felipe Balbi
2016-04-26 12:57 ` [RESEND PATCH v2 4/7] usb: xhci: plat: sort the headers in alphabetic order Jisheng Zhang
2016-04-26 12:57 ` Jisheng Zhang
2016-04-26 12:57 ` [RESEND PATCH v2 5/7] usb: xhci: plat: Remove checks for optional clock in error/remove path Jisheng Zhang
2016-04-26 12:57 ` Jisheng Zhang
2016-04-27 5:33 ` Felipe Balbi
2016-04-27 5:33 ` Felipe Balbi
2016-04-27 6:33 ` Jisheng Zhang
2016-04-27 6:33 ` Jisheng Zhang
2016-04-27 7:19 ` Felipe Balbi
2016-04-27 7:19 ` Felipe Balbi
2016-04-26 12:57 ` [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support Jisheng Zhang
2016-04-26 12:57 ` Jisheng Zhang
2016-04-27 5:35 ` Felipe Balbi
2016-04-27 5:35 ` Felipe Balbi
2016-04-27 6:46 ` Jisheng Zhang
2016-04-27 6:46 ` Jisheng Zhang
2016-04-27 7:21 ` Felipe Balbi
2016-04-27 7:21 ` Felipe Balbi
2016-04-27 7:57 ` Heikki Krogerus
2016-04-27 7:57 ` Heikki Krogerus
2016-04-27 9:34 ` Felipe Balbi
2016-04-27 9:34 ` Felipe Balbi
2016-04-26 12:57 ` [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control Jisheng Zhang
2016-04-26 12:57 ` Jisheng Zhang
2016-04-27 5:37 ` Felipe Balbi
2016-04-27 5:37 ` Felipe Balbi
2016-04-27 9:57 ` Mark Brown [this message]
2016-04-27 9:57 ` Mark Brown
2016-04-27 10:25 ` Jisheng Zhang
2016-04-27 10:25 ` Jisheng Zhang
2016-04-27 13:24 ` Mark Brown
2016-04-27 13:24 ` Mark Brown
2016-04-27 10:25 ` Felipe Balbi
2016-04-27 10:25 ` Felipe Balbi
2016-04-27 10:35 ` Mark Brown
2016-04-27 10:35 ` Mark Brown
2016-04-27 10:38 ` Felipe Balbi
2016-04-27 10:38 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427095738.GG3217@sirena.org.uk \
--to=broonie@kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=yendapally.reddy@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.