All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Jisheng Zhang <jszhang@marvell.com>
Cc: mathias.nyman@intel.com, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	yendapally.reddy@broadcom.com
Subject: Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support
Date: Wed, 27 Apr 2016 12:34:07 +0300	[thread overview]
Message-ID: <87twinmm40.fsf@intel.com> (raw)
In-Reply-To: <20160427075751.GA3540@kuha.fi.intel.com>

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]


Hi,

Heikki Krogerus <heikki.krogerus@linux.intel.com> writes:
> On Tue, Apr 26, 2016 at 08:57:39PM +0800, Jisheng Zhang wrote:
>> @@ -232,22 +265,44 @@ static int xhci_plat_probe(struct platform_device *pdev)
>>  	if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
>>  		xhci->shared_hcd->can_do_streams = 1;
>>  
>> +	hcd->phy = devm_phy_get(&pdev->dev, "usb2-phy");
>> +	if (IS_ERR(hcd->phy)) {
>> +		ret = PTR_ERR(hcd->phy);
>> +		if (ret == -EPROBE_DEFER)
>> +			goto put_usb3_hcd;
>> +		hcd->phy = NULL;
>> +	}
>> +
>> +	phy = devm_phy_get(&pdev->dev, "usb-phy");
>
> "usb-phy" for what I understand is the USB3 PHY right?

that doesn't appear to be documented anywhere ;-)

> I was unable to find any definition for the phy names for example from
> Documentation/devicetree/bindings/usb/usb-xhci.txt, so I would say
> this needs to be "usb3-phy" and the phy names need to be defined
> somewhere.

yeah, usb3-phy sounds like a better name.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: felipe.balbi@linux.intel.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support
Date: Wed, 27 Apr 2016 12:34:07 +0300	[thread overview]
Message-ID: <87twinmm40.fsf@intel.com> (raw)
In-Reply-To: <20160427075751.GA3540@kuha.fi.intel.com>


Hi,

Heikki Krogerus <heikki.krogerus@linux.intel.com> writes:
> On Tue, Apr 26, 2016 at 08:57:39PM +0800, Jisheng Zhang wrote:
>> @@ -232,22 +265,44 @@ static int xhci_plat_probe(struct platform_device *pdev)
>>  	if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
>>  		xhci->shared_hcd->can_do_streams = 1;
>>  
>> +	hcd->phy = devm_phy_get(&pdev->dev, "usb2-phy");
>> +	if (IS_ERR(hcd->phy)) {
>> +		ret = PTR_ERR(hcd->phy);
>> +		if (ret == -EPROBE_DEFER)
>> +			goto put_usb3_hcd;
>> +		hcd->phy = NULL;
>> +	}
>> +
>> +	phy = devm_phy_get(&pdev->dev, "usb-phy");
>
> "usb-phy" for what I understand is the USB3 PHY right?

that doesn't appear to be documented anywhere ;-)

> I was unable to find any definition for the phy names for example from
> Documentation/devicetree/bindings/usb/usb-xhci.txt, so I would say
> this needs to be "usb3-phy" and the phy names need to be defined
> somewhere.

yeah, usb3-phy sounds like a better name.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160427/4946e7f5/attachment.sig>

  reply	other threads:[~2016-04-27  9:36 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 12:57 [RESEND PATCH v2 0/7] usb: xhci-plat: support generic PHY and vbus regulator Jisheng Zhang
2016-04-26 12:57 ` Jisheng Zhang
2016-04-26 12:57 ` [RESEND PATCH v2 1/7] usb: xhci: plat: Fix suspend/resume when the optional clk exists Jisheng Zhang
2016-04-26 12:57   ` Jisheng Zhang
2016-04-27  5:25   ` Felipe Balbi
2016-04-27  5:25     ` Felipe Balbi
2016-04-27  5:46     ` Jisheng Zhang
2016-04-27  5:46       ` Jisheng Zhang
2016-04-26 12:57 ` [RESEND PATCH v2 2/7] usb: xhci: plat: attach the usb_phy to the correct hcd Jisheng Zhang
2016-04-26 12:57   ` Jisheng Zhang
2016-04-27  5:29   ` Felipe Balbi
2016-04-27  5:29     ` Felipe Balbi
2016-04-27  5:59     ` Jisheng Zhang
2016-04-27  5:59       ` Jisheng Zhang
2016-04-27  6:19       ` Felipe Balbi
2016-04-27  6:19         ` Felipe Balbi
2016-04-26 12:57 ` [RESEND PATCH v2 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists Jisheng Zhang
2016-04-26 12:57   ` Jisheng Zhang
2016-04-27  5:30   ` Felipe Balbi
2016-04-27  5:30     ` Felipe Balbi
2016-04-26 12:57 ` [RESEND PATCH v2 4/7] usb: xhci: plat: sort the headers in alphabetic order Jisheng Zhang
2016-04-26 12:57   ` Jisheng Zhang
2016-04-26 12:57 ` [RESEND PATCH v2 5/7] usb: xhci: plat: Remove checks for optional clock in error/remove path Jisheng Zhang
2016-04-26 12:57   ` Jisheng Zhang
2016-04-27  5:33   ` Felipe Balbi
2016-04-27  5:33     ` Felipe Balbi
2016-04-27  6:33     ` Jisheng Zhang
2016-04-27  6:33       ` Jisheng Zhang
2016-04-27  7:19       ` Felipe Balbi
2016-04-27  7:19         ` Felipe Balbi
2016-04-26 12:57 ` [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support Jisheng Zhang
2016-04-26 12:57   ` Jisheng Zhang
2016-04-27  5:35   ` Felipe Balbi
2016-04-27  5:35     ` Felipe Balbi
2016-04-27  6:46     ` Jisheng Zhang
2016-04-27  6:46       ` Jisheng Zhang
2016-04-27  7:21       ` Felipe Balbi
2016-04-27  7:21         ` Felipe Balbi
2016-04-27  7:57   ` Heikki Krogerus
2016-04-27  7:57     ` Heikki Krogerus
2016-04-27  9:34     ` Felipe Balbi [this message]
2016-04-27  9:34       ` Felipe Balbi
2016-04-26 12:57 ` [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control Jisheng Zhang
2016-04-26 12:57   ` Jisheng Zhang
2016-04-27  5:37   ` Felipe Balbi
2016-04-27  5:37     ` Felipe Balbi
2016-04-27  9:57     ` Mark Brown
2016-04-27  9:57       ` Mark Brown
2016-04-27 10:25       ` Jisheng Zhang
2016-04-27 10:25         ` Jisheng Zhang
2016-04-27 13:24         ` Mark Brown
2016-04-27 13:24           ` Mark Brown
2016-04-27 10:25       ` Felipe Balbi
2016-04-27 10:25         ` Felipe Balbi
2016-04-27 10:35         ` Mark Brown
2016-04-27 10:35           ` Mark Brown
2016-04-27 10:38           ` Felipe Balbi
2016-04-27 10:38             ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twinmm40.fsf@intel.com \
    --to=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jszhang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=yendapally.reddy@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.