* [PATCH v2 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 soc @ 2016-06-30 1:27 ` Kefeng Wang 0 siblings, 0 replies; 13+ messages in thread From: Kefeng Wang @ 2016-06-30 1:27 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Jiri Slaby, linux-serial, linux-kernel, Andy Shevchenko, z.liuxinliang, guohanjun, linux-acpi, xuwei5, graeme.gregory, Kefeng Wang Make dw8250_set_termios() as the default set_termios callback for 8250 dw uart, correct me if I am wrong. Then add ACPI support for uart on Hisilicon Hip05 soc, be careful that it is not 16500 compatible. Meanwhile, set dw8250_serial_out32 to keep consistent between serial_out and serial_in in ACPI. Change since v1: - Use acpi_match_device() instead of acpi_dev_found(), limit the check to the device being probed and not a global search for whole DSDT (pointed by graeme.gregory@linaro.org) Kefeng Wang (2): serial: 8250_dw: make dw8250_set_termios as default set_termios callback serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc drivers/tty/serial/8250/8250_dw.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) -- 1.7.12.4 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 soc @ 2016-06-30 1:27 ` Kefeng Wang 0 siblings, 0 replies; 13+ messages in thread From: Kefeng Wang @ 2016-06-30 1:27 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Jiri Slaby, linux-serial, linux-kernel, Andy Shevchenko, z.liuxinliang, guohanjun, linux-acpi, xuwei5, graeme.gregory, Kefeng Wang Make dw8250_set_termios() as the default set_termios callback for 8250 dw uart, correct me if I am wrong. Then add ACPI support for uart on Hisilicon Hip05 soc, be careful that it is not 16500 compatible. Meanwhile, set dw8250_serial_out32 to keep consistent between serial_out and serial_in in ACPI. Change since v1: - Use acpi_match_device() instead of acpi_dev_found(), limit the check to the device being probed and not a global search for whole DSDT (pointed by graeme.gregory@linaro.org) Kefeng Wang (2): serial: 8250_dw: make dw8250_set_termios as default set_termios callback serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc drivers/tty/serial/8250/8250_dw.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) -- 1.7.12.4 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 1/2] serial: 8250_dw: make dw8250_set_termios as default set_termios callback 2016-06-30 1:27 ` Kefeng Wang @ 2016-06-30 1:27 ` Kefeng Wang -1 siblings, 0 replies; 13+ messages in thread From: Kefeng Wang @ 2016-06-30 1:27 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Jiri Slaby, linux-serial, linux-kernel, Andy Shevchenko, z.liuxinliang, guohanjun, linux-acpi, xuwei5, graeme.gregory, Kefeng Wang We can safely use dw8250_set_termios() as the default set_termios callback instead of serial8250_do_set_termios(), so do it. Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- drivers/tty/serial/8250/8250_dw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c index e199696..65f3da7 100644 --- a/drivers/tty/serial/8250/8250_dw.c +++ b/drivers/tty/serial/8250/8250_dw.c @@ -301,7 +301,6 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data) p->iotype = UPIO_MEM32; p->regshift = 2; p->serial_in = dw8250_serial_in32; - p->set_termios = dw8250_set_termios; /* So far none of there implement the Busy Functionality */ data->uart_16550_compatible = true; } @@ -309,7 +308,6 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data) /* Platforms with iDMA */ if (platform_get_resource_byname(to_platform_device(p->dev), IORESOURCE_MEM, "lpss_priv")) { - p->set_termios = dw8250_set_termios; data->dma.rx_param = p->dev->parent; data->dma.tx_param = p->dev->parent; data->dma.fn = dw8250_idma_filter; @@ -386,6 +384,7 @@ static int dw8250_probe(struct platform_device *pdev) p->iotype = UPIO_MEM; p->serial_in = dw8250_serial_in; p->serial_out = dw8250_serial_out; + p->set_termios = dw8250_set_termios; p->membase = devm_ioremap(&pdev->dev, regs->start, resource_size(regs)); if (!p->membase) -- 1.7.12.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2 1/2] serial: 8250_dw: make dw8250_set_termios as default set_termios callback @ 2016-06-30 1:27 ` Kefeng Wang 0 siblings, 0 replies; 13+ messages in thread From: Kefeng Wang @ 2016-06-30 1:27 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Jiri Slaby, linux-serial, linux-kernel, Andy Shevchenko, z.liuxinliang, guohanjun, linux-acpi, xuwei5, graeme.gregory, Kefeng Wang We can safely use dw8250_set_termios() as the default set_termios callback instead of serial8250_do_set_termios(), so do it. Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- drivers/tty/serial/8250/8250_dw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c index e199696..65f3da7 100644 --- a/drivers/tty/serial/8250/8250_dw.c +++ b/drivers/tty/serial/8250/8250_dw.c @@ -301,7 +301,6 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data) p->iotype = UPIO_MEM32; p->regshift = 2; p->serial_in = dw8250_serial_in32; - p->set_termios = dw8250_set_termios; /* So far none of there implement the Busy Functionality */ data->uart_16550_compatible = true; } @@ -309,7 +308,6 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data) /* Platforms with iDMA */ if (platform_get_resource_byname(to_platform_device(p->dev), IORESOURCE_MEM, "lpss_priv")) { - p->set_termios = dw8250_set_termios; data->dma.rx_param = p->dev->parent; data->dma.tx_param = p->dev->parent; data->dma.fn = dw8250_idma_filter; @@ -386,6 +384,7 @@ static int dw8250_probe(struct platform_device *pdev) p->iotype = UPIO_MEM; p->serial_in = dw8250_serial_in; p->serial_out = dw8250_serial_out; + p->set_termios = dw8250_set_termios; p->membase = devm_ioremap(&pdev->dev, regs->start, resource_size(regs)); if (!p->membase) -- 1.7.12.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc 2016-06-30 1:27 ` Kefeng Wang @ 2016-06-30 1:27 ` Kefeng Wang -1 siblings, 0 replies; 13+ messages in thread From: Kefeng Wang @ 2016-06-30 1:27 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Jiri Slaby, linux-serial, linux-kernel, Andy Shevchenko, z.liuxinliang, guohanjun, linux-acpi, xuwei5, graeme.gregory, Kefeng Wang Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful that it is not 16550 compatibal. Meanwhile, set dw8250_serial_out32 to keep consistent between serial_out and serial_in in ACPI. Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c index 65f3da7..096431b 100644 --- a/drivers/tty/serial/8250/8250_dw.c +++ b/drivers/tty/serial/8250/8250_dw.c @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan *chan, void *param) return param == chan->device->dev->parent; } +/* non 16550 compatible id list*/ +static const struct acpi_device_id non_16550_id_list[] = { + { "HISI0031", 0 }, + { }, +}; + static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data) { if (p->dev->of_node) { @@ -301,8 +307,10 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data) p->iotype = UPIO_MEM32; p->regshift = 2; p->serial_in = dw8250_serial_in32; - /* So far none of there implement the Busy Functionality */ - data->uart_16550_compatible = true; + p->serial_out = dw8250_serial_out32; + + if (!acpi_match_device(non_16550_id_list, p->dev)) + data->uart_16550_compatible = true; } /* Platforms with iDMA */ @@ -618,6 +626,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = { { "APMC0D08", 0}, { "AMD0020", 0 }, { "AMDI0020", 0 }, + { "HISI0031", 0 }, { }, }; MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match); -- 1.7.12.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc @ 2016-06-30 1:27 ` Kefeng Wang 0 siblings, 0 replies; 13+ messages in thread From: Kefeng Wang @ 2016-06-30 1:27 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Jiri Slaby, linux-serial, linux-kernel, Andy Shevchenko, z.liuxinliang, guohanjun, linux-acpi, xuwei5, graeme.gregory, Kefeng Wang Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful that it is not 16550 compatibal. Meanwhile, set dw8250_serial_out32 to keep consistent between serial_out and serial_in in ACPI. Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c index 65f3da7..096431b 100644 --- a/drivers/tty/serial/8250/8250_dw.c +++ b/drivers/tty/serial/8250/8250_dw.c @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan *chan, void *param) return param == chan->device->dev->parent; } +/* non 16550 compatible id list*/ +static const struct acpi_device_id non_16550_id_list[] = { + { "HISI0031", 0 }, + { }, +}; + static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data) { if (p->dev->of_node) { @@ -301,8 +307,10 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data) p->iotype = UPIO_MEM32; p->regshift = 2; p->serial_in = dw8250_serial_in32; - /* So far none of there implement the Busy Functionality */ - data->uart_16550_compatible = true; + p->serial_out = dw8250_serial_out32; + + if (!acpi_match_device(non_16550_id_list, p->dev)) + data->uart_16550_compatible = true; } /* Platforms with iDMA */ @@ -618,6 +626,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = { { "APMC0D08", 0}, { "AMD0020", 0 }, { "AMDI0020", 0 }, + { "HISI0031", 0 }, { }, }; MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match); -- 1.7.12.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc 2016-06-30 1:27 ` Kefeng Wang (?) @ 2016-06-30 9:38 ` Andy Shevchenko 2016-06-30 9:54 ` Andy Shevchenko -1 siblings, 1 reply; 13+ messages in thread From: Andy Shevchenko @ 2016-06-30 9:38 UTC (permalink / raw) To: Kefeng Wang, Greg Kroah-Hartman Cc: Jiri Slaby, linux-serial, linux-kernel, z.liuxinliang, guohanjun, linux-acpi, xuwei5, graeme.gregory On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote: > Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful > that it is not 16550 compatibal. > > Meanwhile, set dw8250_serial_out32 to keep consistent between > serial_out > and serial_in in ACPI. > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > --- > drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_dw.c > b/drivers/tty/serial/8250/8250_dw.c > index 65f3da7..096431b 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan > *chan, void *param) > return param == chan->device->dev->parent; > } > > +/* non 16550 compatible id list*/ > +static const struct acpi_device_id non_16550_id_list[] = { > + { "HISI0031", 0 }, > + { }, > +}; > + On first glance it looks redundant, see below. > static void dw8250_quirks(struct uart_port *p, struct dw8250_data > *data) > { > if (p->dev->of_node) { > @@ -301,8 +307,10 @@ static void dw8250_quirks(struct uart_port *p, > struct dw8250_data *data) > p->iotype = UPIO_MEM32; > p->regshift = 2; > p->serial_in = dw8250_serial_in32; > - /* So far none of there implement the Busy > Functionality */ > - data->uart_16550_compatible = true; > + p->serial_out = dw8250_serial_out32; > + > + if (!acpi_match_device(non_16550_id_list, p->dev)) > + data->uart_16550_compatible = true; > } > > /* Platforms with iDMA */ > @@ -618,6 +626,7 @@ static const struct acpi_device_id > dw8250_acpi_match[] = { > { "APMC0D08", 0}, > { "AMD0020", 0 }, > { "AMDI0020", 0 }, > + { "HISI0031", 0 }, So, we may put something instead of 0 here and consider it as a set of special quirks / setup instructions / etc. struct dw8250_dev_info { unsigned int uart_16550_compatible:1; }; static const struct dw8250_dev_info hisi_dev_info = { .uart_16550_compatible = 1, } ... { "HISI0031", (kernel_ulong_t)&hisi_dev_info }, ... And so on. > { }, > }; > MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match); -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc 2016-06-30 9:38 ` Andy Shevchenko @ 2016-06-30 9:54 ` Andy Shevchenko 0 siblings, 0 replies; 13+ messages in thread From: Andy Shevchenko @ 2016-06-30 9:54 UTC (permalink / raw) To: Kefeng Wang, Greg Kroah-Hartman Cc: Jiri Slaby, linux-serial, linux-kernel, z.liuxinliang, guohanjun, linux-acpi, xuwei5, graeme.gregory On Thu, 2016-06-30 at 12:38 +0300, Andy Shevchenko wrote: > On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote: > > Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful > > that it is not 16550 compatibal. > > > > Meanwhile, set dw8250_serial_out32 to keep consistent between > > serial_out > > and serial_in in ACPI. > > > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > > --- > > drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++-- > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/tty/serial/8250/8250_dw.c > > b/drivers/tty/serial/8250/8250_dw.c > > index 65f3da7..096431b 100644 > > --- a/drivers/tty/serial/8250/8250_dw.c > > +++ b/drivers/tty/serial/8250/8250_dw.c > > @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan > > *chan, void *param) > > return param == chan->device->dev->parent; > > } > > > > +/* non 16550 compatible id list*/ > > +static const struct acpi_device_id non_16550_id_list[] = { > > + { "HISI0031", 0 }, > > + { }, > > +}; > > + > > On first glance it looks redundant, see below. Oh, wait, this is still valid, but the better solution is to use device properties for the rest except yours! I will prepare patch later this week or at the beginning of next week if you are in hurry, otherwise I would postpone this a bit (anyway it will not make v4.8 cycle). -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc @ 2016-06-30 9:54 ` Andy Shevchenko 0 siblings, 0 replies; 13+ messages in thread From: Andy Shevchenko @ 2016-06-30 9:54 UTC (permalink / raw) To: Kefeng Wang, Greg Kroah-Hartman Cc: Jiri Slaby, linux-serial, linux-kernel, z.liuxinliang, guohanjun, linux-acpi, xuwei5, graeme.gregory On Thu, 2016-06-30 at 12:38 +0300, Andy Shevchenko wrote: > On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote: > > Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful > > that it is not 16550 compatibal. > > > > Meanwhile, set dw8250_serial_out32 to keep consistent between > > serial_out > > and serial_in in ACPI. > > > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > > --- > > drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++-- > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/tty/serial/8250/8250_dw.c > > b/drivers/tty/serial/8250/8250_dw.c > > index 65f3da7..096431b 100644 > > --- a/drivers/tty/serial/8250/8250_dw.c > > +++ b/drivers/tty/serial/8250/8250_dw.c > > @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan > > *chan, void *param) > > return param == chan->device->dev->parent; > > } > > > > +/* non 16550 compatible id list*/ > > +static const struct acpi_device_id non_16550_id_list[] = { > > + { "HISI0031", 0 }, > > + { }, > > +}; > > + > > On first glance it looks redundant, see below. Oh, wait, this is still valid, but the better solution is to use device properties for the rest except yours! I will prepare patch later this week or at the beginning of next week if you are in hurry, otherwise I would postpone this a bit (anyway it will not make v4.8 cycle). -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc 2016-06-30 9:54 ` Andy Shevchenko @ 2016-06-30 14:26 ` Kefeng Wang -1 siblings, 0 replies; 13+ messages in thread From: Kefeng Wang @ 2016-06-30 14:26 UTC (permalink / raw) To: Andy Shevchenko, Greg Kroah-Hartman Cc: Jiri Slaby, linux-serial, linux-kernel, z.liuxinliang, guohanjun, linux-acpi, xuwei5, graeme.gregory On 2016/6/30 17:54, Andy Shevchenko wrote: > On Thu, 2016-06-30 at 12:38 +0300, Andy Shevchenko wrote: >> On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote: >>> Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful >>> that it is not 16550 compatibal. >>> >>> Meanwhile, set dw8250_serial_out32 to keep consistent between >>> serial_out >>> and serial_in in ACPI. >>> >>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> >>> --- >>> drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++-- >>> 1 file changed, 11 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/tty/serial/8250/8250_dw.c >>> b/drivers/tty/serial/8250/8250_dw.c >>> index 65f3da7..096431b 100644 >>> --- a/drivers/tty/serial/8250/8250_dw.c >>> +++ b/drivers/tty/serial/8250/8250_dw.c >>> @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan >>> *chan, void *param) >>> return param == chan->device->dev->parent; >>> } >>> >>> +/* non 16550 compatible id list*/ >>> +static const struct acpi_device_id non_16550_id_list[] = { >>> + { "HISI0031", 0 }, >>> + { }, >>> +}; >>> + >> >> On first glance it looks redundant, see below. > > Oh, wait, this is still valid, but the better solution is to use device > properties for the rest except yours! Do you mean using something like static struct property_entry dw8250_properties[] = { PROPERTY_ENTRY_U32("reg-io-width", 4), PROPERTY_ENTRY_U32("reg-shift", 2), PROPERTY_ENTRY_BOOL("snps,uart-16550-compatible"), { }, }; then use platform_device_add_properties to add it to the device(16500 compatible), but for hisi, use another property_entry without PROPERTY_ENTRY_BOOL("snps,uart-16550-compatible")? Not clear about using device properties. > > I will prepare patch later this week or at the beginning of next week if > you are in hurry, otherwise I would postpone this a bit (anyway it will > not make v4.8 cycle). > Thanks, hope that it will come out soon. BRs, Kefeng ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc @ 2016-06-30 14:26 ` Kefeng Wang 0 siblings, 0 replies; 13+ messages in thread From: Kefeng Wang @ 2016-06-30 14:26 UTC (permalink / raw) To: Andy Shevchenko, Greg Kroah-Hartman Cc: Jiri Slaby, linux-serial, linux-kernel, z.liuxinliang, guohanjun, linux-acpi, xuwei5, graeme.gregory On 2016/6/30 17:54, Andy Shevchenko wrote: > On Thu, 2016-06-30 at 12:38 +0300, Andy Shevchenko wrote: >> On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote: >>> Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful >>> that it is not 16550 compatibal. >>> >>> Meanwhile, set dw8250_serial_out32 to keep consistent between >>> serial_out >>> and serial_in in ACPI. >>> >>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> >>> --- >>> drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++-- >>> 1 file changed, 11 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/tty/serial/8250/8250_dw.c >>> b/drivers/tty/serial/8250/8250_dw.c >>> index 65f3da7..096431b 100644 >>> --- a/drivers/tty/serial/8250/8250_dw.c >>> +++ b/drivers/tty/serial/8250/8250_dw.c >>> @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan >>> *chan, void *param) >>> return param == chan->device->dev->parent; >>> } >>> >>> +/* non 16550 compatible id list*/ >>> +static const struct acpi_device_id non_16550_id_list[] = { >>> + { "HISI0031", 0 }, >>> + { }, >>> +}; >>> + >> >> On first glance it looks redundant, see below. > > Oh, wait, this is still valid, but the better solution is to use device > properties for the rest except yours! Do you mean using something like static struct property_entry dw8250_properties[] = { PROPERTY_ENTRY_U32("reg-io-width", 4), PROPERTY_ENTRY_U32("reg-shift", 2), PROPERTY_ENTRY_BOOL("snps,uart-16550-compatible"), { }, }; then use platform_device_add_properties to add it to the device(16500 compatible), but for hisi, use another property_entry without PROPERTY_ENTRY_BOOL("snps,uart-16550-compatible")? Not clear about using device properties. > > I will prepare patch later this week or at the beginning of next week if > you are in hurry, otherwise I would postpone this a bit (anyway it will > not make v4.8 cycle). > Thanks, hope that it will come out soon. BRs, Kefeng ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc 2016-06-30 14:26 ` Kefeng Wang @ 2016-06-30 14:39 ` Andy Shevchenko -1 siblings, 0 replies; 13+ messages in thread From: Andy Shevchenko @ 2016-06-30 14:39 UTC (permalink / raw) To: Kefeng Wang, Greg Kroah-Hartman Cc: Jiri Slaby, linux-serial, linux-kernel, z.liuxinliang, guohanjun, linux-acpi, xuwei5, graeme.gregory On Thu, 2016-06-30 at 22:26 +0800, Kefeng Wang wrote: > > On 2016/6/30 17:54, Andy Shevchenko wrote: > > On Thu, 2016-06-30 at 12:38 +0300, Andy Shevchenko wrote: > > > On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote: > > > > Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful > > > > that it is not 16550 compatibal. > > > > > > > > Meanwhile, set dw8250_serial_out32 to keep consistent between > > > > serial_out > > > > and serial_in in ACPI. > > > > > > > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > > > > --- > > > > drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++-- > > > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/tty/serial/8250/8250_dw.c > > > > b/drivers/tty/serial/8250/8250_dw.c > > > > index 65f3da7..096431b 100644 > > > > --- a/drivers/tty/serial/8250/8250_dw.c > > > > +++ b/drivers/tty/serial/8250/8250_dw.c > > > > @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct > > > > dma_chan > > > > *chan, void *param) > > > > return param == chan->device->dev->parent; > > > > } > > > > > > > > +/* non 16550 compatible id list*/ > > > > +static const struct acpi_device_id non_16550_id_list[] = { > > > > + { "HISI0031", 0 }, > > > > + { }, > > > > +}; > > > > + > > > > > > On first glance it looks redundant, see below. > > > > Oh, wait, this is still valid, but the better solution is to use > > device > > properties for the rest except yours! > > Do you mean using something like > > static struct property_entry dw8250_properties[] = { > PROPERTY_ENTRY_U32("reg-io-width", 4), > PROPERTY_ENTRY_U32("reg-shift", 2), > PROPERTY_ENTRY_BOOL("snps,uart-16550-compatible"), > { }, > }; > > then use platform_device_add_properties to add it to the device(16500 > compatible), Correct for the existing devices. > > but for hisi, use another property_entry without > PROPERTY_ENTRY_BOOL("snps,uart-16550-compatible")? For HISI in case of alternate configuration you have to tweak _DSD in ACPI. > > Not clear about using device properties. Built-in device properties only for non-DT, non-ACPI devices. You may consider it as a successor of platform data. > > > > > I will prepare patch later this week or at the beginning of next > > week if > > you are in hurry, otherwise I would postpone this a bit (anyway it > > will > > not make v4.8 cycle). > > > > Thanks, hope that it will come out soon. > -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc @ 2016-06-30 14:39 ` Andy Shevchenko 0 siblings, 0 replies; 13+ messages in thread From: Andy Shevchenko @ 2016-06-30 14:39 UTC (permalink / raw) To: Kefeng Wang, Greg Kroah-Hartman Cc: Jiri Slaby, linux-serial, linux-kernel, z.liuxinliang, guohanjun, linux-acpi, xuwei5, graeme.gregory On Thu, 2016-06-30 at 22:26 +0800, Kefeng Wang wrote: > > On 2016/6/30 17:54, Andy Shevchenko wrote: > > On Thu, 2016-06-30 at 12:38 +0300, Andy Shevchenko wrote: > > > On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote: > > > > Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful > > > > that it is not 16550 compatibal. > > > > > > > > Meanwhile, set dw8250_serial_out32 to keep consistent between > > > > serial_out > > > > and serial_in in ACPI. > > > > > > > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > > > > --- > > > > drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++-- > > > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/tty/serial/8250/8250_dw.c > > > > b/drivers/tty/serial/8250/8250_dw.c > > > > index 65f3da7..096431b 100644 > > > > --- a/drivers/tty/serial/8250/8250_dw.c > > > > +++ b/drivers/tty/serial/8250/8250_dw.c > > > > @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct > > > > dma_chan > > > > *chan, void *param) > > > > return param == chan->device->dev->parent; > > > > } > > > > > > > > +/* non 16550 compatible id list*/ > > > > +static const struct acpi_device_id non_16550_id_list[] = { > > > > + { "HISI0031", 0 }, > > > > + { }, > > > > +}; > > > > + > > > > > > On first glance it looks redundant, see below. > > > > Oh, wait, this is still valid, but the better solution is to use > > device > > properties for the rest except yours! > > Do you mean using something like > > static struct property_entry dw8250_properties[] = { > PROPERTY_ENTRY_U32("reg-io-width", 4), > PROPERTY_ENTRY_U32("reg-shift", 2), > PROPERTY_ENTRY_BOOL("snps,uart-16550-compatible"), > { }, > }; > > then use platform_device_add_properties to add it to the device(16500 > compatible), Correct for the existing devices. > > but for hisi, use another property_entry without > PROPERTY_ENTRY_BOOL("snps,uart-16550-compatible")? For HISI in case of alternate configuration you have to tweak _DSD in ACPI. > > Not clear about using device properties. Built-in device properties only for non-DT, non-ACPI devices. You may consider it as a successor of platform data. > > > > > I will prepare patch later this week or at the beginning of next > > week if > > you are in hurry, otherwise I would postpone this a bit (anyway it > > will > > not make v4.8 cycle). > > > > Thanks, hope that it will come out soon. > -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2016-06-30 14:40 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-06-30 1:27 [PATCH v2 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 soc Kefeng Wang 2016-06-30 1:27 ` Kefeng Wang 2016-06-30 1:27 ` [PATCH v2 1/2] serial: 8250_dw: make dw8250_set_termios as default set_termios callback Kefeng Wang 2016-06-30 1:27 ` Kefeng Wang 2016-06-30 1:27 ` [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc Kefeng Wang 2016-06-30 1:27 ` Kefeng Wang 2016-06-30 9:38 ` Andy Shevchenko 2016-06-30 9:54 ` Andy Shevchenko 2016-06-30 9:54 ` Andy Shevchenko 2016-06-30 14:26 ` Kefeng Wang 2016-06-30 14:26 ` Kefeng Wang 2016-06-30 14:39 ` Andy Shevchenko 2016-06-30 14:39 ` Andy Shevchenko
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.