All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@techsingularity.net>
To: Andrew Morton <akpm@linux-foundation.org>, Linux-MM <linux-mm@kvack.org>
Cc: Rik van Riel <riel@surriel.com>, Vlastimil Babka <vbabka@suse.cz>,
	Johannes Weiner <hannes@cmpxchg.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Mel Gorman <mgorman@techsingularity.net>
Subject: [PATCH 05/31] mm, vmscan: have kswapd only scan based on the highest requested zone
Date: Fri,  1 Jul 2016 21:01:13 +0100	[thread overview]
Message-ID: <1467403299-25786-6-git-send-email-mgorman@techsingularity.net> (raw)
In-Reply-To: <1467403299-25786-1-git-send-email-mgorman@techsingularity.net>

kswapd checks all eligible zones to see if they need balancing even if it
was woken for a lower zone.  This made sense when we reclaimed on a
per-zone basis because we wanted to shrink zones fairly so avoid
age-inversion problems.  Ideally this is completely unnecessary when
reclaiming on a per-node basis.  In theory, there may still be anomalies
when all requests are for lower zones and very old pages are preserved in
higher zones but this should be the exceptional case.

Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
---
 mm/vmscan.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 766b36bec829..c6e61dae382b 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -3209,11 +3209,8 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int classzone_idx)
 
 		sc.nr_reclaimed = 0;
 
-		/*
-		 * Scan in the highmem->dma direction for the highest
-		 * zone which needs scanning
-		 */
-		for (i = pgdat->nr_zones - 1; i >= 0; i--) {
+		/* Scan from the highest requested zone to dma */
+		for (i = classzone_idx; i >= 0; i--) {
 			struct zone *zone = pgdat->node_zones + i;
 
 			if (!populated_zone(zone))
-- 
2.6.4

WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@techsingularity.net>
To: Andrew Morton <akpm@linux-foundation.org>, Linux-MM <linux-mm@kvack.org>
Cc: Rik van Riel <riel@surriel.com>, Vlastimil Babka <vbabka@suse.cz>,
	Johannes Weiner <hannes@cmpxchg.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Mel Gorman <mgorman@techsingularity.net>
Subject: [PATCH 05/31] mm, vmscan: have kswapd only scan based on the highest requested zone
Date: Fri,  1 Jul 2016 21:01:13 +0100	[thread overview]
Message-ID: <1467403299-25786-6-git-send-email-mgorman@techsingularity.net> (raw)
In-Reply-To: <1467403299-25786-1-git-send-email-mgorman@techsingularity.net>

kswapd checks all eligible zones to see if they need balancing even if it
was woken for a lower zone.  This made sense when we reclaimed on a
per-zone basis because we wanted to shrink zones fairly so avoid
age-inversion problems.  Ideally this is completely unnecessary when
reclaiming on a per-node basis.  In theory, there may still be anomalies
when all requests are for lower zones and very old pages are preserved in
higher zones but this should be the exceptional case.

Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
---
 mm/vmscan.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 766b36bec829..c6e61dae382b 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -3209,11 +3209,8 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int classzone_idx)
 
 		sc.nr_reclaimed = 0;
 
-		/*
-		 * Scan in the highmem->dma direction for the highest
-		 * zone which needs scanning
-		 */
-		for (i = pgdat->nr_zones - 1; i >= 0; i--) {
+		/* Scan from the highest requested zone to dma */
+		for (i = classzone_idx; i >= 0; i--) {
 			struct zone *zone = pgdat->node_zones + i;
 
 			if (!populated_zone(zone))
-- 
2.6.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2016-07-01 20:10 UTC|newest]

Thread overview: 181+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-01 20:01 [PATCH 00/31] Move LRU page reclaim from zones to nodes v8 Mel Gorman
2016-07-01 20:01 ` Mel Gorman
2016-07-01 20:01 ` [PATCH 01/31] mm, vmstat: add infrastructure for per-node vmstats Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-04 23:50   ` Minchan Kim
2016-07-04 23:50     ` Minchan Kim
2016-07-05  8:14     ` Mel Gorman
2016-07-05  8:14       ` Mel Gorman
2016-07-06  0:15       ` Minchan Kim
2016-07-06  0:15         ` Minchan Kim
2016-07-01 20:01 ` [PATCH 02/31] mm, vmscan: move lru_lock to the node Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-05  0:03   ` Minchan Kim
2016-07-05  0:03     ` Minchan Kim
2016-07-01 20:01 ` [PATCH 03/31] mm, vmscan: move LRU lists to node Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-05  1:19   ` Minchan Kim
2016-07-05  1:19     ` Minchan Kim
2016-07-05 10:14     ` Mel Gorman
2016-07-05 10:14       ` Mel Gorman
2016-07-01 20:01 ` [PATCH 04/31] mm, vmscan: begin reclaiming pages on a per-node basis Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-07  1:12   ` Joonsoo Kim
2016-07-07  1:12     ` Joonsoo Kim
2016-07-07  9:48     ` Mel Gorman
2016-07-07  9:48       ` Mel Gorman
2016-07-08  2:28       ` Joonsoo Kim
2016-07-08  2:28         ` Joonsoo Kim
2016-07-08 10:05         ` Mel Gorman
2016-07-08 10:05           ` Mel Gorman
2016-07-14  6:28           ` Joonsoo Kim
2016-07-14  6:28             ` Joonsoo Kim
2016-07-14  7:48             ` Vlastimil Babka
2016-07-14  7:48               ` Vlastimil Babka
2016-07-18  4:52               ` Joonsoo Kim
2016-07-18  4:52                 ` Joonsoo Kim
2016-07-18 12:11             ` Mel Gorman
2016-07-18 12:11               ` Mel Gorman
2016-07-18 14:27               ` Mel Gorman
2016-07-18 14:27                 ` Mel Gorman
2016-07-19  8:30                 ` Joonsoo Kim
2016-07-19  8:30                   ` Joonsoo Kim
2016-07-19 14:25                   ` Mel Gorman
2016-07-19 14:25                     ` Mel Gorman
2016-07-01 20:01 ` Mel Gorman [this message]
2016-07-01 20:01   ` [PATCH 05/31] mm, vmscan: have kswapd only scan based on the highest requested zone Mel Gorman
2016-07-01 20:01 ` [PATCH 06/31] mm, vmscan: make kswapd reclaim in terms of nodes Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 07/31] mm, vmscan: remove balance gap Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 08/31] mm, vmscan: simplify the logic deciding whether kswapd sleeps Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-05  5:59   ` Minchan Kim
2016-07-05  5:59     ` Minchan Kim
2016-07-05 10:26     ` Mel Gorman
2016-07-05 10:26       ` Mel Gorman
2016-07-06  0:30       ` Minchan Kim
2016-07-06  0:30         ` Minchan Kim
2016-07-06  8:31         ` Mel Gorman
2016-07-06  8:31           ` Mel Gorman
2016-07-07  5:51           ` Minchan Kim
2016-07-07  5:51             ` Minchan Kim
2016-07-07  9:56             ` Mel Gorman
2016-07-07  9:56               ` Mel Gorman
2016-07-07  1:20   ` Joonsoo Kim
2016-07-07  1:20     ` Joonsoo Kim
2016-07-07 10:17     ` Mel Gorman
2016-07-07 10:17       ` Mel Gorman
2016-07-08  2:44       ` Joonsoo Kim
2016-07-08  2:44         ` Joonsoo Kim
2016-07-08 10:11         ` Mel Gorman
2016-07-08 10:11           ` Mel Gorman
2016-07-14  5:23           ` Joonsoo Kim
2016-07-14  5:23             ` Joonsoo Kim
2016-07-14  8:32             ` Vlastimil Babka
2016-07-14  8:32               ` Vlastimil Babka
2016-07-18  5:07               ` Joonsoo Kim
2016-07-18  5:07                 ` Joonsoo Kim
2016-07-18  6:51                 ` Vlastimil Babka
2016-07-18  6:51                   ` Vlastimil Babka
2016-07-18  7:24                   ` Joonsoo Kim
2016-07-18  7:24                     ` Joonsoo Kim
2016-07-14  9:05             ` Mel Gorman
2016-07-14  9:05               ` Mel Gorman
2016-07-18  5:03               ` Joonsoo Kim
2016-07-18  5:03                 ` Joonsoo Kim
2016-07-01 20:01 ` [PATCH 09/31] mm, vmscan: by default have direct reclaim only shrink once per node Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-07  1:43   ` Joonsoo Kim
2016-07-07  1:43     ` Joonsoo Kim
2016-07-07 10:27     ` Mel Gorman
2016-07-07 10:27       ` Mel Gorman
2016-07-01 20:01 ` [PATCH 10/31] mm, vmscan: remove duplicate logic clearing node congestion and dirty state Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 11/31] mm: vmscan: do not reclaim from kswapd if there is any eligible zone Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-05  6:11   ` Minchan Kim
2016-07-05  6:11     ` Minchan Kim
2016-07-05 10:38     ` Mel Gorman
2016-07-05 10:38       ` Mel Gorman
2016-07-06  1:25       ` Minchan Kim
2016-07-06  1:25         ` Minchan Kim
2016-07-06  8:42         ` Mel Gorman
2016-07-06  8:42           ` Mel Gorman
2016-07-07  6:27           ` Minchan Kim
2016-07-07  6:27             ` Minchan Kim
2016-07-07 10:55             ` Mel Gorman
2016-07-07 10:55               ` Mel Gorman
2016-07-01 20:01 ` [PATCH 12/31] mm, vmscan: make shrink_node decisions more node-centric Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-05  6:24   ` Minchan Kim
2016-07-05  6:24     ` Minchan Kim
2016-07-05 10:40     ` Mel Gorman
2016-07-05 10:40       ` Mel Gorman
2016-07-01 20:01 ` [PATCH 13/31] mm, memcg: move memcg limit enforcement from zones to nodes Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 14/31] mm, workingset: make working set detection node-aware Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 15/31] mm, page_alloc: consider dirtyable memory in terms of nodes Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 16/31] mm: move page mapped accounting to the node Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 17/31] mm: rename NR_ANON_PAGES to NR_ANON_MAPPED Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 18/31] mm: move most file-based accounting to the node Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 19/31] mm: move vmscan writes and file write " Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 20/31] mm, vmscan: only wakeup kswapd once per node for the requested classzone Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-07  1:24   ` Joonsoo Kim
2016-07-07  1:24     ` Joonsoo Kim
2016-07-07 10:58     ` Mel Gorman
2016-07-07 10:58       ` Mel Gorman
2016-07-01 20:01 ` [PATCH 21/31] mm, page_alloc: Wake kswapd based on the highest eligible zone Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 22/31] mm: convert zone_reclaim to node_reclaim Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 23/31] mm, vmscan: Avoid passing in classzone_idx unnecessarily to shrink_node Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 24/31] mm, vmscan: Avoid passing in classzone_idx unnecessarily to compaction_ready Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 25/31] mm, vmscan: add classzone information to tracepoints Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 26/31] mm, page_alloc: remove fair zone allocation policy Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 27/31] mm: page_alloc: cache the last node whose dirty limit is reached Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 28/31] mm: vmstat: replace __count_zone_vm_events with a zone id equivalent Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 29/31] mm: vmstat: account per-zone stalls and pages skipped during reclaim Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 30/31] mm, vmstat: print node-based stats in zoneinfo file Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-01 20:01 ` [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-06  0:02   ` Minchan Kim
2016-07-06  0:02     ` Minchan Kim
2016-07-06  8:58     ` Mel Gorman
2016-07-06  8:58       ` Mel Gorman
2016-07-06  9:33       ` Mel Gorman
2016-07-06  9:33         ` Mel Gorman
2016-07-07  6:47       ` Minchan Kim
2016-07-07  6:47         ` Minchan Kim
2016-07-06 18:12   ` Dave Hansen
2016-07-06 18:12     ` Dave Hansen
2016-07-07 11:26     ` Mel Gorman
2016-07-07 11:26       ` Mel Gorman
2016-07-04  1:37 ` [PATCH 00/31] Move LRU page reclaim from zones to nodes v8 Minchan Kim
2016-07-04  1:37   ` Minchan Kim
2016-07-04  4:34   ` Mel Gorman
2016-07-04  4:34     ` Mel Gorman
2016-07-04  8:04     ` Minchan Kim
2016-07-04  8:04       ` Minchan Kim
2016-07-04  8:04       ` Minchan Kim
2016-07-04  9:55       ` Mel Gorman
2016-07-04  9:55         ` Mel Gorman
2016-07-06  1:51         ` Minchan Kim
2016-07-06  1:51           ` Minchan Kim
  -- strict thread matches above, loose matches on Subject: below --
2016-07-01 15:37 Mel Gorman
2016-07-01 15:37 ` [PATCH 05/31] mm, vmscan: have kswapd only scan based on the highest requested zone Mel Gorman
2016-07-01 15:37   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467403299-25786-6-git-send-email-mgorman@techsingularity.net \
    --to=mgorman@techsingularity.net \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@surriel.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.