From: Mel Gorman <mgorman@techsingularity.net> To: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Linux-MM <linux-mm@kvack.org>, Rik van Riel <riel@surriel.com>, Vlastimil Babka <vbabka@suse.cz>, Johannes Weiner <hannes@cmpxchg.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 08/31] mm, vmscan: simplify the logic deciding whether kswapd sleeps Date: Thu, 7 Jul 2016 11:17:01 +0100 [thread overview] Message-ID: <20160707101701.GR11498@techsingularity.net> (raw) In-Reply-To: <20160707012038.GB27987@js1304-P5Q-DELUXE> On Thu, Jul 07, 2016 at 10:20:39AM +0900, Joonsoo Kim wrote: > > @@ -3249,9 +3249,19 @@ static void kswapd_try_to_sleep(pg_data_t *pgdat, int order, > > > > prepare_to_wait(&pgdat->kswapd_wait, &wait, TASK_INTERRUPTIBLE); > > > > + /* > > + * If kswapd has not been woken recently, then kswapd goes fully > > + * to sleep. kcompactd may still need to wake if the original > > + * request was high-order. > > + */ > > + if (classzone_idx == -1) { > > + wakeup_kcompactd(pgdat, alloc_order, classzone_idx); > > + classzone_idx = MAX_NR_ZONES - 1; > > + goto full_sleep; > > + } > > Passing -1 to kcompactd would cause the problem? > No, it ends up doing a wakeup and then going back to sleep which is not what is required. I'll fix it. > > @@ -3390,12 +3386,24 @@ static int kswapd(void *p) > > * We can speed up thawing tasks if we don't call balance_pgdat > > * after returning from the refrigerator > > */ > > - if (!ret) { > > - trace_mm_vmscan_kswapd_wake(pgdat->node_id, order); > > + if (ret) > > + continue; > > > > - /* return value ignored until next patch */ > > - balance_pgdat(pgdat, order, classzone_idx); > > - } > > + /* > > + * Reclaim begins at the requested order but if a high-order > > + * reclaim fails then kswapd falls back to reclaiming for > > + * order-0. If that happens, kswapd will consider sleeping > > + * for the order it finished reclaiming at (reclaim_order) > > + * but kcompactd is woken to compact for the original > > + * request (alloc_order). > > + */ > > + trace_mm_vmscan_kswapd_wake(pgdat->node_id, alloc_order); > > + reclaim_order = balance_pgdat(pgdat, alloc_order, classzone_idx); > > + if (reclaim_order < alloc_order) > > + goto kswapd_try_sleep; > > This 'goto' would cause kswapd to sleep prematurely. We need to check > *new* pgdat->kswapd_order and classzone_idx even in this case. > It only matters if the next request coming is also high-order requests but one thing that needs to be avoided is kswapd staying awake periods of time constantly reclaiming for high-order pages. This is why the check means "If we reclaimed for high-order and failed, then consider sleeping now". If allocations still require it, they direct reclaim instead. "Fixing" this potentially causes reclaim storms from kswapd. > > @@ -3418,10 +3426,10 @@ void wakeup_kswapd(struct zone *zone, int order, enum zone_type classzone_idx) > > if (!cpuset_zone_allowed(zone, GFP_KERNEL | __GFP_HARDWALL)) > > return; > > pgdat = zone->zone_pgdat; > > - if (pgdat->kswapd_max_order < order) { > > - pgdat->kswapd_max_order = order; > > - pgdat->classzone_idx = min(pgdat->classzone_idx, classzone_idx); > > - } > > + if (pgdat->kswapd_classzone_idx == -1) > > + pgdat->kswapd_classzone_idx = classzone_idx; > > + pgdat->kswapd_classzone_idx = max(pgdat->kswapd_classzone_idx, classzone_idx); > > + pgdat->kswapd_order = max(pgdat->kswapd_order, order); > > Now, updating pgdat->skwapd_max_order and classzone_idx happens > unconditionally. Before your patch, it is only updated toward hard > constraint (e.g. higher order). > So? It's updating the request to suit the requirements of all pending allocation requests that woke kswapd. > And, I'd like to know why max() is used for classzone_idx rather than > min()? I think that kswapd should balance the lowest zone requested. > If there are two allocation requests -- one zone-constraned and the other zone-unconstrained, it does not make sense to have kswapd skip the pages usable for the zone-unconstrained and waste a load of CPU. You could argue that using min would satisfy the zone-constrained allocation faster but that's at the cost of delaying the zone-unconstrained allocation and wasting CPU. Bear in mind that using max may mean some lowmem pages get freed anyway due to LRU order. -- Mel Gorman SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@techsingularity.net> To: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Linux-MM <linux-mm@kvack.org>, Rik van Riel <riel@surriel.com>, Vlastimil Babka <vbabka@suse.cz>, Johannes Weiner <hannes@cmpxchg.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 08/31] mm, vmscan: simplify the logic deciding whether kswapd sleeps Date: Thu, 7 Jul 2016 11:17:01 +0100 [thread overview] Message-ID: <20160707101701.GR11498@techsingularity.net> (raw) In-Reply-To: <20160707012038.GB27987@js1304-P5Q-DELUXE> On Thu, Jul 07, 2016 at 10:20:39AM +0900, Joonsoo Kim wrote: > > @@ -3249,9 +3249,19 @@ static void kswapd_try_to_sleep(pg_data_t *pgdat, int order, > > > > prepare_to_wait(&pgdat->kswapd_wait, &wait, TASK_INTERRUPTIBLE); > > > > + /* > > + * If kswapd has not been woken recently, then kswapd goes fully > > + * to sleep. kcompactd may still need to wake if the original > > + * request was high-order. > > + */ > > + if (classzone_idx == -1) { > > + wakeup_kcompactd(pgdat, alloc_order, classzone_idx); > > + classzone_idx = MAX_NR_ZONES - 1; > > + goto full_sleep; > > + } > > Passing -1 to kcompactd would cause the problem? > No, it ends up doing a wakeup and then going back to sleep which is not what is required. I'll fix it. > > @@ -3390,12 +3386,24 @@ static int kswapd(void *p) > > * We can speed up thawing tasks if we don't call balance_pgdat > > * after returning from the refrigerator > > */ > > - if (!ret) { > > - trace_mm_vmscan_kswapd_wake(pgdat->node_id, order); > > + if (ret) > > + continue; > > > > - /* return value ignored until next patch */ > > - balance_pgdat(pgdat, order, classzone_idx); > > - } > > + /* > > + * Reclaim begins at the requested order but if a high-order > > + * reclaim fails then kswapd falls back to reclaiming for > > + * order-0. If that happens, kswapd will consider sleeping > > + * for the order it finished reclaiming at (reclaim_order) > > + * but kcompactd is woken to compact for the original > > + * request (alloc_order). > > + */ > > + trace_mm_vmscan_kswapd_wake(pgdat->node_id, alloc_order); > > + reclaim_order = balance_pgdat(pgdat, alloc_order, classzone_idx); > > + if (reclaim_order < alloc_order) > > + goto kswapd_try_sleep; > > This 'goto' would cause kswapd to sleep prematurely. We need to check > *new* pgdat->kswapd_order and classzone_idx even in this case. > It only matters if the next request coming is also high-order requests but one thing that needs to be avoided is kswapd staying awake periods of time constantly reclaiming for high-order pages. This is why the check means "If we reclaimed for high-order and failed, then consider sleeping now". If allocations still require it, they direct reclaim instead. "Fixing" this potentially causes reclaim storms from kswapd. > > @@ -3418,10 +3426,10 @@ void wakeup_kswapd(struct zone *zone, int order, enum zone_type classzone_idx) > > if (!cpuset_zone_allowed(zone, GFP_KERNEL | __GFP_HARDWALL)) > > return; > > pgdat = zone->zone_pgdat; > > - if (pgdat->kswapd_max_order < order) { > > - pgdat->kswapd_max_order = order; > > - pgdat->classzone_idx = min(pgdat->classzone_idx, classzone_idx); > > - } > > + if (pgdat->kswapd_classzone_idx == -1) > > + pgdat->kswapd_classzone_idx = classzone_idx; > > + pgdat->kswapd_classzone_idx = max(pgdat->kswapd_classzone_idx, classzone_idx); > > + pgdat->kswapd_order = max(pgdat->kswapd_order, order); > > Now, updating pgdat->skwapd_max_order and classzone_idx happens > unconditionally. Before your patch, it is only updated toward hard > constraint (e.g. higher order). > So? It's updating the request to suit the requirements of all pending allocation requests that woke kswapd. > And, I'd like to know why max() is used for classzone_idx rather than > min()? I think that kswapd should balance the lowest zone requested. > If there are two allocation requests -- one zone-constraned and the other zone-unconstrained, it does not make sense to have kswapd skip the pages usable for the zone-unconstrained and waste a load of CPU. You could argue that using min would satisfy the zone-constrained allocation faster but that's at the cost of delaying the zone-unconstrained allocation and wasting CPU. Bear in mind that using max may mean some lowmem pages get freed anyway due to LRU order. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-07-07 10:17 UTC|newest] Thread overview: 181+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-01 20:01 [PATCH 00/31] Move LRU page reclaim from zones to nodes v8 Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 01/31] mm, vmstat: add infrastructure for per-node vmstats Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-04 23:50 ` Minchan Kim 2016-07-04 23:50 ` Minchan Kim 2016-07-05 8:14 ` Mel Gorman 2016-07-05 8:14 ` Mel Gorman 2016-07-06 0:15 ` Minchan Kim 2016-07-06 0:15 ` Minchan Kim 2016-07-01 20:01 ` [PATCH 02/31] mm, vmscan: move lru_lock to the node Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-05 0:03 ` Minchan Kim 2016-07-05 0:03 ` Minchan Kim 2016-07-01 20:01 ` [PATCH 03/31] mm, vmscan: move LRU lists to node Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-05 1:19 ` Minchan Kim 2016-07-05 1:19 ` Minchan Kim 2016-07-05 10:14 ` Mel Gorman 2016-07-05 10:14 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 04/31] mm, vmscan: begin reclaiming pages on a per-node basis Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-07 1:12 ` Joonsoo Kim 2016-07-07 1:12 ` Joonsoo Kim 2016-07-07 9:48 ` Mel Gorman 2016-07-07 9:48 ` Mel Gorman 2016-07-08 2:28 ` Joonsoo Kim 2016-07-08 2:28 ` Joonsoo Kim 2016-07-08 10:05 ` Mel Gorman 2016-07-08 10:05 ` Mel Gorman 2016-07-14 6:28 ` Joonsoo Kim 2016-07-14 6:28 ` Joonsoo Kim 2016-07-14 7:48 ` Vlastimil Babka 2016-07-14 7:48 ` Vlastimil Babka 2016-07-18 4:52 ` Joonsoo Kim 2016-07-18 4:52 ` Joonsoo Kim 2016-07-18 12:11 ` Mel Gorman 2016-07-18 12:11 ` Mel Gorman 2016-07-18 14:27 ` Mel Gorman 2016-07-18 14:27 ` Mel Gorman 2016-07-19 8:30 ` Joonsoo Kim 2016-07-19 8:30 ` Joonsoo Kim 2016-07-19 14:25 ` Mel Gorman 2016-07-19 14:25 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 05/31] mm, vmscan: have kswapd only scan based on the highest requested zone Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 06/31] mm, vmscan: make kswapd reclaim in terms of nodes Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 07/31] mm, vmscan: remove balance gap Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 08/31] mm, vmscan: simplify the logic deciding whether kswapd sleeps Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-05 5:59 ` Minchan Kim 2016-07-05 5:59 ` Minchan Kim 2016-07-05 10:26 ` Mel Gorman 2016-07-05 10:26 ` Mel Gorman 2016-07-06 0:30 ` Minchan Kim 2016-07-06 0:30 ` Minchan Kim 2016-07-06 8:31 ` Mel Gorman 2016-07-06 8:31 ` Mel Gorman 2016-07-07 5:51 ` Minchan Kim 2016-07-07 5:51 ` Minchan Kim 2016-07-07 9:56 ` Mel Gorman 2016-07-07 9:56 ` Mel Gorman 2016-07-07 1:20 ` Joonsoo Kim 2016-07-07 1:20 ` Joonsoo Kim 2016-07-07 10:17 ` Mel Gorman [this message] 2016-07-07 10:17 ` Mel Gorman 2016-07-08 2:44 ` Joonsoo Kim 2016-07-08 2:44 ` Joonsoo Kim 2016-07-08 10:11 ` Mel Gorman 2016-07-08 10:11 ` Mel Gorman 2016-07-14 5:23 ` Joonsoo Kim 2016-07-14 5:23 ` Joonsoo Kim 2016-07-14 8:32 ` Vlastimil Babka 2016-07-14 8:32 ` Vlastimil Babka 2016-07-18 5:07 ` Joonsoo Kim 2016-07-18 5:07 ` Joonsoo Kim 2016-07-18 6:51 ` Vlastimil Babka 2016-07-18 6:51 ` Vlastimil Babka 2016-07-18 7:24 ` Joonsoo Kim 2016-07-18 7:24 ` Joonsoo Kim 2016-07-14 9:05 ` Mel Gorman 2016-07-14 9:05 ` Mel Gorman 2016-07-18 5:03 ` Joonsoo Kim 2016-07-18 5:03 ` Joonsoo Kim 2016-07-01 20:01 ` [PATCH 09/31] mm, vmscan: by default have direct reclaim only shrink once per node Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-07 1:43 ` Joonsoo Kim 2016-07-07 1:43 ` Joonsoo Kim 2016-07-07 10:27 ` Mel Gorman 2016-07-07 10:27 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 10/31] mm, vmscan: remove duplicate logic clearing node congestion and dirty state Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 11/31] mm: vmscan: do not reclaim from kswapd if there is any eligible zone Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-05 6:11 ` Minchan Kim 2016-07-05 6:11 ` Minchan Kim 2016-07-05 10:38 ` Mel Gorman 2016-07-05 10:38 ` Mel Gorman 2016-07-06 1:25 ` Minchan Kim 2016-07-06 1:25 ` Minchan Kim 2016-07-06 8:42 ` Mel Gorman 2016-07-06 8:42 ` Mel Gorman 2016-07-07 6:27 ` Minchan Kim 2016-07-07 6:27 ` Minchan Kim 2016-07-07 10:55 ` Mel Gorman 2016-07-07 10:55 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 12/31] mm, vmscan: make shrink_node decisions more node-centric Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-05 6:24 ` Minchan Kim 2016-07-05 6:24 ` Minchan Kim 2016-07-05 10:40 ` Mel Gorman 2016-07-05 10:40 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 13/31] mm, memcg: move memcg limit enforcement from zones to nodes Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 14/31] mm, workingset: make working set detection node-aware Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 15/31] mm, page_alloc: consider dirtyable memory in terms of nodes Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 16/31] mm: move page mapped accounting to the node Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 17/31] mm: rename NR_ANON_PAGES to NR_ANON_MAPPED Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 18/31] mm: move most file-based accounting to the node Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 19/31] mm: move vmscan writes and file write " Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 20/31] mm, vmscan: only wakeup kswapd once per node for the requested classzone Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-07 1:24 ` Joonsoo Kim 2016-07-07 1:24 ` Joonsoo Kim 2016-07-07 10:58 ` Mel Gorman 2016-07-07 10:58 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 21/31] mm, page_alloc: Wake kswapd based on the highest eligible zone Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 22/31] mm: convert zone_reclaim to node_reclaim Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 23/31] mm, vmscan: Avoid passing in classzone_idx unnecessarily to shrink_node Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 24/31] mm, vmscan: Avoid passing in classzone_idx unnecessarily to compaction_ready Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 25/31] mm, vmscan: add classzone information to tracepoints Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 26/31] mm, page_alloc: remove fair zone allocation policy Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 27/31] mm: page_alloc: cache the last node whose dirty limit is reached Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 28/31] mm: vmstat: replace __count_zone_vm_events with a zone id equivalent Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 29/31] mm: vmstat: account per-zone stalls and pages skipped during reclaim Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 30/31] mm, vmstat: print node-based stats in zoneinfo file Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-01 20:01 ` [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries Mel Gorman 2016-07-01 20:01 ` Mel Gorman 2016-07-06 0:02 ` Minchan Kim 2016-07-06 0:02 ` Minchan Kim 2016-07-06 8:58 ` Mel Gorman 2016-07-06 8:58 ` Mel Gorman 2016-07-06 9:33 ` Mel Gorman 2016-07-06 9:33 ` Mel Gorman 2016-07-07 6:47 ` Minchan Kim 2016-07-07 6:47 ` Minchan Kim 2016-07-06 18:12 ` Dave Hansen 2016-07-06 18:12 ` Dave Hansen 2016-07-07 11:26 ` Mel Gorman 2016-07-07 11:26 ` Mel Gorman 2016-07-04 1:37 ` [PATCH 00/31] Move LRU page reclaim from zones to nodes v8 Minchan Kim 2016-07-04 1:37 ` Minchan Kim 2016-07-04 4:34 ` Mel Gorman 2016-07-04 4:34 ` Mel Gorman 2016-07-04 8:04 ` Minchan Kim 2016-07-04 8:04 ` Minchan Kim 2016-07-04 8:04 ` Minchan Kim 2016-07-04 9:55 ` Mel Gorman 2016-07-04 9:55 ` Mel Gorman 2016-07-06 1:51 ` Minchan Kim 2016-07-06 1:51 ` Minchan Kim -- strict thread matches above, loose matches on Subject: below -- 2016-07-01 15:37 Mel Gorman 2016-07-01 15:37 ` [PATCH 08/31] mm, vmscan: simplify the logic deciding whether kswapd sleeps Mel Gorman 2016-07-01 15:37 ` Mel Gorman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160707101701.GR11498@techsingularity.net \ --to=mgorman@techsingularity.net \ --cc=akpm@linux-foundation.org \ --cc=hannes@cmpxchg.org \ --cc=iamjoonsoo.kim@lge.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=riel@surriel.com \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.