[PATCH v3 0/12] arm64: renesas: add H3ULCB board

[PATCH v3 0/12] arm64: renesas: add H3ULCB board

[Vladimir Barinov]

Hello,

This adds the folowing:
- R8A7795 SoC based H3ULCB low cost board device tree
- Document DT bindings

Vladimir Barinov (12):
[01/12] dt: arm: shmobile: add H3ULCB board DT bindings
[02/12] arm64: dts: h3ulcb: initial device tree
[03/12] arm64: dts: h3ulcb: enable SCIF clk and pins
[04/12] arm64: dts: h3ulcb: enable EthernetAVB
[05/12] arm64: dts: h3ulcb: enable GPIO leds
[06/12] arm64: dts: h3ulcb: enable SDHI0
[07/12] arm64: dts: h3ulcb: enable I2C2
[08/12] arm64: dts: h3ulcb: enable EXTALR clk
[09/12] arm64: dts: h3ulcb: enable WDT
[10/12] arm64: dts: h3ulcb: enable USB2 PHY of channel 1
[11/12] arm64: dts: h3ulcb: enable USB2.0 Host channel 1
[12/12] arm64: dts: h3ulcb: Sound SSI support

---
This patchset is against the 'kernel/git/horms/renesas.git' repo.

 arch/arm64/boot/dts/renesas/Makefile               |   2 +-
 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts     | 316 +++++++++++++++++++++++++
 Documentation/devicetree/bindings/arm/shmobile.txt |   2 ++
 3 files changed, 319 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 0/12] arm64: renesas: add H3ULCB board

[Vladimir Barinov]

Hello,

This adds the folowing:
- R8A7795 SoC based H3ULCB low cost board device tree
- Document DT bindings

Vladimir Barinov (12):
[01/12] dt: arm: shmobile: add H3ULCB board DT bindings
[02/12] arm64: dts: h3ulcb: initial device tree
[03/12] arm64: dts: h3ulcb: enable SCIF clk and pins
[04/12] arm64: dts: h3ulcb: enable EthernetAVB
[05/12] arm64: dts: h3ulcb: enable GPIO leds
[06/12] arm64: dts: h3ulcb: enable SDHI0
[07/12] arm64: dts: h3ulcb: enable I2C2
[08/12] arm64: dts: h3ulcb: enable EXTALR clk
[09/12] arm64: dts: h3ulcb: enable WDT
[10/12] arm64: dts: h3ulcb: enable USB2 PHY of channel 1
[11/12] arm64: dts: h3ulcb: enable USB2.0 Host channel 1
[12/12] arm64: dts: h3ulcb: Sound SSI support

---
This patchset is against the 'kernel/git/horms/renesas.git' repo.

 arch/arm64/boot/dts/renesas/Makefile               |   2 +-
 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts     | 316 +++++++++++++++++++++++++
 Documentation/devicetree/bindings/arm/shmobile.txt |   2 ++
 3 files changed, 319 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts

[PATCH v3 01/12] dt: arm: shmobile: add H3ULCB board DT bindings

[Vladimir Barinov]

Add H3ULCB Device tree bindings Documentation, listing it as a supported
board.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes in version 2:
- none
Changes in version 3:
- none

 Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
index 5484c31d..2f0b716 100644
--- a/Documentation/devicetree/bindings/arm/shmobile.txt
+++ b/Documentation/devicetree/bindings/arm/shmobile.txt
@@ -49,6 +49,8 @@ Boards:
     compatible = "renesas,genmai", "renesas,r7s72100"
   - Gose
     compatible = "renesas,gose", "renesas,r8a7793"
+  - H3ULCB (RTP0RC7795SKB00010S)
+    compatible = "renesas,h3ulcb", "renesas,r8a7795";
   - Henninger
     compatible = "renesas,henninger", "renesas,r8a7791"
   - Koelsch (RTP0RC7791SEB00010S)
-- 
1.9.1

[PATCH v3 02/12] arm64: dts: h3ulcb: initial device tree

[Vladimir Barinov]

Add the initial device tree for the R8A7795 SoC based H3ULCB low cost
board.

This commit supports the following peripherals:
- SCIF (console)

Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
Changes in version 2:
- removed bootargs property
- removed comment related to amixer
---
Changes in version 3:
- split the big patch v2 in small ones

 arch/arm64/boot/dts/renesas/Makefile           |  2 +-
 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 51 ++++++++++++++++++++++++++
 2 files changed, 52 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts

diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index 17139f7..eb72830 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -1,4 +1,4 @@
-dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb
+dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb r8a7795-h3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-salvator-x.dtb
 
 always		:= $(dtb-y)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
new file mode 100644
index 0000000..ecb9e11
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -0,0 +1,51 @@
+/*
+ * Device Tree Source for the H3ULCB board
+ *
+ * Copyright (C) 2016 Renesas Electronics Corp.
+ * Copyright (C) 2016 Cogent Embedded, Inc.
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2.  This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+/dts-v1/;
+#include "r8a7795.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+
+/ {
+	model = "Renesas H3ULCB board based on r8a7795";
+	compatible = "renesas,h3ulcb", "renesas,r8a7795";
+
+	aliases {
+		serial0 = &scif2;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory@48000000 {
+		device_type = "memory";
+		/* first 128MB is reserved for secure area. */
+		reg = <0x0 0x48000000 0x0 0x38000000>;
+	};
+};
+
+&extal_clk {
+	clock-frequency = <16666666>;
+};
+
+&pfc {
+	scif2_pins: scif2 {
+		groups = "scif2_data_a";
+		function = "scif2";
+	};
+};
+
+&scif2 {
+	pinctrl-0 = <&scif2_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 02/12] arm64: dts: h3ulcb: initial device tree

[Vladimir Barinov]

Add the initial device tree for the R8A7795 SoC based H3ULCB low cost
board.

This commit supports the following peripherals:
- SCIF (console)

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
Changes in version 2:
- removed bootargs property
- removed comment related to amixer
---
Changes in version 3:
- split the big patch v2 in small ones

 arch/arm64/boot/dts/renesas/Makefile           |  2 +-
 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 51 ++++++++++++++++++++++++++
 2 files changed, 52 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts

diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index 17139f7..eb72830 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -1,4 +1,4 @@
-dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb
+dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb r8a7795-h3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-salvator-x.dtb
 
 always		:= $(dtb-y)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
new file mode 100644
index 0000000..ecb9e11
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -0,0 +1,51 @@
+/*
+ * Device Tree Source for the H3ULCB board
+ *
+ * Copyright (C) 2016 Renesas Electronics Corp.
+ * Copyright (C) 2016 Cogent Embedded, Inc.
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2.  This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+/dts-v1/;
+#include "r8a7795.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+
+/ {
+	model = "Renesas H3ULCB board based on r8a7795";
+	compatible = "renesas,h3ulcb", "renesas,r8a7795";
+
+	aliases {
+		serial0 = &scif2;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory@48000000 {
+		device_type = "memory";
+		/* first 128MB is reserved for secure area. */
+		reg = <0x0 0x48000000 0x0 0x38000000>;
+	};
+};
+
+&extal_clk {
+	clock-frequency = <16666666>;
+};
+
+&pfc {
+	scif2_pins: scif2 {
+		groups = "scif2_data_a";
+		function = "scif2";
+	};
+};
+
+&scif2 {
+	pinctrl-0 = <&scif2_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
-- 
1.9.1

[PATCH v3 03/12] arm64: dts: h3ulcb: enable SCIF clk and pins

[Vladimir Barinov]

This enables the external crystal for the SCIF_CLK and its pinctrl, to
be used by the Baud Rate Generator for External Clock (BRG) on (H)SCIF.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
Changes in version 3:
- initially added

 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
index ecb9e11..67ce368 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -37,10 +37,18 @@
 };
 
 &pfc {
+	pinctrl-0 = <&scif_clk_pins>;
+	pinctrl-names = "default";
+
 	scif2_pins: scif2 {
 		groups = "scif2_data_a";
 		function = "scif2";
 	};
+
+	scif_clk_pins: scif_clk {
+		groups = "scif_clk_a";
+		function = "scif_clk";
+	};
 };
 
 &scif2 {
@@ -49,3 +57,8 @@
 
 	status = "okay";
 };
+
+&scif_clk {
+	clock-frequency = <14745600>;
+	status = "okay";
+};
-- 
1.9.1

[PATCH v3 04/12] arm64: dts: h3ulcb: enable EthernetAVB

[Vladimir Barinov]

This supports Ethernet AVB on H3ULCB board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
Changes in version 3:
- initially added

 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 32 ++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
index 67ce368..fb694b8 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -19,6 +19,7 @@
 
 	aliases {
 		serial0 = &scif2;
+		ethernet0 = &avb;
 	};
 
 	chosen {
@@ -49,6 +50,11 @@
 		groups = "scif_clk_a";
 		function = "scif_clk";
 	};
+
+	avb_pins: avb {
+		groups = "avb_mdc";
+		function = "avb";
+	};
 };
 
 &scif2 {
@@ -62,3 +68,29 @@
 	clock-frequency = <14745600>;
 	status = "okay";
 };
+
+&avb {
+	pinctrl-0 = <&avb_pins>;
+	pinctrl-names = "default";
+	renesas,no-ether-link;
+	phy-handle = <&phy0>;
+	status = "okay";
+
+	phy0: ethernet-phy@0 {
+		rxc-skew-ps = <900>;
+		rxdv-skew-ps = <0>;
+		rxd0-skew-ps = <0>;
+		rxd1-skew-ps = <0>;
+		rxd2-skew-ps = <0>;
+		rxd3-skew-ps = <0>;
+		txc-skew-ps = <900>;
+		txen-skew-ps = <0>;
+		txd0-skew-ps = <0>;
+		txd1-skew-ps = <0>;
+		txd2-skew-ps = <0>;
+		txd3-skew-ps = <0>;
+		reg = <0>;
+		interrupt-parent = <&gpio2>;
+		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+	};
+};
-- 
1.9.1

[PATCH v3 05/12] arm64: dts: h3ulcb: enable GPIO leds

[Vladimir Barinov]

This supports GPIO leds on H3ULCB board

Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
Changes in version 3:
- initially added

 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
index fb694b8..3329f78 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -31,6 +31,19 @@
 		/* first 128MB is reserved for secure area. */
 		reg = <0x0 0x48000000 0x0 0x38000000>;
 	};
+
+	leds {
+		compatible = "gpio-leds";
+		led4 {
+			gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
+		};
+		led5 {
+			gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
+		};
+		led6 {
+			gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>;
+		};
+	};
 };
 
 &extal_clk {
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 05/12] arm64: dts: h3ulcb: enable GPIO leds

[Vladimir Barinov]

This supports GPIO leds on H3ULCB board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
Changes in version 3:
- initially added

 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
index fb694b8..3329f78 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -31,6 +31,19 @@
 		/* first 128MB is reserved for secure area. */
 		reg = <0x0 0x48000000 0x0 0x38000000>;
 	};
+
+	leds {
+		compatible = "gpio-leds";
+		led4 {
+			gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
+		};
+		led5 {
+			gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
+		};
+		led6 {
+			gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>;
+		};
+	};
 };
 
 &extal_clk {
-- 
1.9.1

[PATCH v3 06/12] arm64: dts: h3ulcb: enable SDHI0

[Vladimir Barinov]

This supports SDHI0 on H3ULCB board SD card slot

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
Changes in version 3:
- initially added

 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 48 ++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
index 3329f78..5be0cf6 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -44,6 +44,30 @@
 			gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>;
 		};
 	};
+
+	vcc_sdhi0: regulator-vcc-sdhi0 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "SDHI0 Vcc";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&gpio5 2 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	vccq_sdhi0: regulator-vccq-sdhi0 {
+		compatible = "regulator-gpio";
+
+		regulator-name = "SDHI0 VccQ";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpios = <&gpio5 1 GPIO_ACTIVE_HIGH>;
+		gpios-states = <1>;
+		states = <3300000 1
+			  1800000 0>;
+	};
 };
 
 &extal_clk {
@@ -68,6 +92,18 @@
 		groups = "avb_mdc";
 		function = "avb";
 	};
+
+	sdhi0_pins_3v3: sd0_3v3 {
+		groups = "sdhi0_data4", "sdhi0_ctrl";
+		function = "sdhi0";
+		power-source = <3300>;
+	};
+
+	sdhi0_pins_1v8: sd0_1v8 {
+		groups = "sdhi0_data4", "sdhi0_ctrl";
+		function = "sdhi0";
+		power-source = <1800>;
+	};
 };
 
 &scif2 {
@@ -82,6 +118,18 @@
 	status = "okay";
 };
 
+&sdhi0 {
+	pinctrl-0 = <&sdhi0_pins_3v3>;
+	pinctrl-1 = <&sdhi0_pins_1v8>;
+	pinctrl-names = "default", "state_uhs";
+
+	vmmc-supply = <&vcc_sdhi0>;
+	vqmmc-supply = <&vccq_sdhi0>;
+	cd-gpios = <&gpio3 12 GPIO_ACTIVE_LOW>;
+	bus-width = <4>;
+	status = "okay";
+};
+
 &avb {
 	pinctrl-0 = <&avb_pins>;
 	pinctrl-names = "default";
-- 
1.9.1

[PATCH v3 07/12] arm64: dts: h3ulcb: enable I2C2

[Vladimir Barinov]

This supports I2C2 bus on H3ULCB board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
Changes in version 3:
- initially added

 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
index 5be0cf6..3682bcc 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -88,6 +88,11 @@
 		function = "scif_clk";
 	};
 
+	i2c2_pins: i2c2 {
+		groups = "i2c2_a";
+		function = "i2c2";
+	};
+
 	avb_pins: avb {
 		groups = "avb_mdc";
 		function = "avb";
@@ -118,6 +123,13 @@
 	status = "okay";
 };
 
+&i2c2 {
+	pinctrl-0 = <&i2c2_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
 &sdhi0 {
 	pinctrl-0 = <&sdhi0_pins_3v3>;
 	pinctrl-1 = <&sdhi0_pins_1v8>;
-- 
1.9.1

[PATCH v3 08/12] arm64: dts: h3ulcb: enable EXTALR clk

[Vladimir Barinov]

This enables EXTALR clock that can be used for the watchdog.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
Changes in version 3:
- initially added

 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
index 3682bcc..6936288 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -74,6 +74,10 @@
 	clock-frequency = <16666666>;
 };
 
+&extalr_clk {
+	clock-frequency = <32768>;
+};
+
 &pfc {
 	pinctrl-0 = <&scif_clk_pins>;
 	pinctrl-names = "default";
-- 
1.9.1

[PATCH v3 09/12] arm64: dts: h3ulcb: enable WDT

[Vladimir Barinov]

This supports watchdog timer for H3ULCB board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
Changes in version 3:
- initially added

 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
index 6936288..bc3d8d5 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -146,6 +146,11 @@
 	status = "okay";
 };
 
+&wdt0 {
+	timeout-sec = <60>;
+	status = "okay";
+};
+
 &avb {
 	pinctrl-0 = <&avb_pins>;
 	pinctrl-names = "default";
-- 
1.9.1

[PATCH v3 10/12] arm64: dts: h3ulcb: enable USB2 PHY of channel 1

[Vladimir Barinov]

This supports USB2 PHY channel #1 on H3ULCB board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
Changes in version 3:
- initially added

 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
index bc3d8d5..1750bb1 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -113,6 +113,10 @@
 		function = "sdhi0";
 		power-source = <1800>;
 	};
+	usb1_pins: usb1 {
+		groups = "usb1";
+		function = "usb1";
+	};
 };
 
 &scif2 {
@@ -176,3 +180,10 @@
 		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
 	};
 };
+
+&usb2_phy1 {
+	pinctrl-0 = <&usb1_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
-- 
1.9.1

[PATCH v3 11/12] arm64: dts: h3ulcb: enable USB2.0 Host channel 1

[Vladimir Barinov]

This supports USB2.0 Host channel 1 on H3ULCB board

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
Changes in version 3:
- initially added

 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
index 1750bb1..bbd7928 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -187,3 +187,11 @@
 
 	status = "okay";
 };
+
+&ehci1 {
+	status = "okay";
+};
+
+&ohci1 {
+	status = "okay";
+};
-- 
1.9.1

[PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support

[Vladimir Barinov]

This supports SSI sound for H3ULCB board.
SSI DMA mode used. CS2000 used as AUDIO_CLK_B.

Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
Changes in version 3:
- initially added

 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 115 +++++++++++++++++++++++++
 1 file changed, 115 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
index bbd7928..a254231 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -45,6 +45,12 @@
 		};
 	};
 
+	x12_clk: x12_clk {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <24576000>;
+	};
+
 	vcc_sdhi0: regulator-vcc-sdhi0 {
 		compatible = "regulator-fixed";
 
@@ -68,6 +74,28 @@
 		states = <3300000 1
 			  1800000 0>;
 	};
+
+	audio_clkout: audio_clkout {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <11289600>;
+	};
+
+	rsnd_ak4613: sound {
+		compatible = "simple-audio-card";
+
+		simple-audio-card,format = "left_j";
+		simple-audio-card,bitclock-master = <&sndcpu>;
+		simple-audio-card,frame-master = <&sndcpu>;
+
+		sndcpu: simple-audio-card,cpu {
+			sound-dai = <&rcar_sound>;
+		};
+
+		sndcodec: simple-audio-card,codec {
+			sound-dai = <&ak4613>;
+		};
+	};
 };
 
 &extal_clk {
@@ -113,6 +141,18 @@
 		function = "sdhi0";
 		power-source = <1800>;
 	};
+
+	sound_pins: sound {
+		groups = "ssi01239_ctrl", "ssi0_data", "ssi1_data_a";
+		function = "ssi";
+	};
+
+	sound_clk_pins: sound_clk {
+		groups = "audio_clk_a_a", "audio_clk_b_a", "audio_clk_c_a",
+			 "audio_clkout_a", "audio_clkout3_a";
+		function = "audio_clk";
+	};
+
 	usb1_pins: usb1 {
 		groups = "usb1";
 		function = "usb1";
@@ -136,6 +176,73 @@
 	pinctrl-names = "default";
 
 	status = "okay";
+
+	clock-frequency = <100000>;
+
+	ak4613: codec@10 {
+		compatible = "asahi-kasei,ak4613";
+		#sound-dai-cells = <0>;
+		reg = <0x10>;
+		clocks = <&rcar_sound 3>;
+
+		asahi-kasei,in1-single-end;
+		asahi-kasei,in2-single-end;
+		asahi-kasei,out1-single-end;
+		asahi-kasei,out2-single-end;
+		asahi-kasei,out3-single-end;
+		asahi-kasei,out4-single-end;
+		asahi-kasei,out5-single-end;
+		asahi-kasei,out6-single-end;
+	};
+
+	cs2000: clk_multiplier@4f {
+		#clock-cells = <0>;
+		compatible = "cirrus,cs2000-cp";
+		reg = <0x4f>;
+		clocks = <&audio_clkout>, <&x12_clk>;
+		clock-names = "clk_in", "ref_clk";
+
+		assigned-clocks = <&cs2000>;
+		assigned-clock-rates = <24576000>; /* 1/1 divide */
+	};
+};
+
+&rcar_sound {
+	pinctrl-0 = <&sound_pins &sound_clk_pins>;
+	pinctrl-names = "default";
+
+	/* Single DAI */
+	#sound-dai-cells = <0>;
+
+	/* audio_clkout0/1/2/3 */
+	#clock-cells = <1>;
+	clock-frequency = <11289600>;
+
+	status = "okay";
+
+	/* update <audio_clk_b> to <cs2000> */
+	clocks = <&cpg CPG_MOD 1005>,
+		 <&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>,
+		 <&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>,
+		 <&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>,
+		 <&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>,
+		 <&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>,
+		 <&cpg CPG_MOD 1022>, <&cpg CPG_MOD 1023>,
+		 <&cpg CPG_MOD 1024>, <&cpg CPG_MOD 1025>,
+		 <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>,
+		 <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>,
+		 <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>,
+		 <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>,
+		 <&audio_clk_a>, <&cs2000>,
+		 <&audio_clk_c>,
+		 <&cpg CPG_CORE R8A7795_CLK_S0D4>;
+
+	rcar_sound,dai {
+		dai0 {
+			playback = <&ssi0 &src0 &dvc0>;
+			capture  = <&ssi1 &src1 &dvc1>;
+		};
+	};
 };
 
 &sdhi0 {
@@ -150,11 +257,19 @@
 	status = "okay";
 };
 
+&ssi1 {
+	shared-pin;
+};
+
 &wdt0 {
 	timeout-sec = <60>;
 	status = "okay";
 };
 
+&audio_clk_a {
+	clock-frequency = <22579200>;
+};
+
 &avb {
 	pinctrl-0 = <&avb_pins>;
 	pinctrl-names = "default";
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support

[Vladimir Barinov]

This supports SSI sound for H3ULCB board.
SSI DMA mode used. CS2000 used as AUDIO_CLK_B.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
Changes in version 3:
- initially added

 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 115 +++++++++++++++++++++++++
 1 file changed, 115 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
index bbd7928..a254231 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -45,6 +45,12 @@
 		};
 	};
 
+	x12_clk: x12_clk {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <24576000>;
+	};
+
 	vcc_sdhi0: regulator-vcc-sdhi0 {
 		compatible = "regulator-fixed";
 
@@ -68,6 +74,28 @@
 		states = <3300000 1
 			  1800000 0>;
 	};
+
+	audio_clkout: audio_clkout {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <11289600>;
+	};
+
+	rsnd_ak4613: sound {
+		compatible = "simple-audio-card";
+
+		simple-audio-card,format = "left_j";
+		simple-audio-card,bitclock-master = <&sndcpu>;
+		simple-audio-card,frame-master = <&sndcpu>;
+
+		sndcpu: simple-audio-card,cpu {
+			sound-dai = <&rcar_sound>;
+		};
+
+		sndcodec: simple-audio-card,codec {
+			sound-dai = <&ak4613>;
+		};
+	};
 };
 
 &extal_clk {
@@ -113,6 +141,18 @@
 		function = "sdhi0";
 		power-source = <1800>;
 	};
+
+	sound_pins: sound {
+		groups = "ssi01239_ctrl", "ssi0_data", "ssi1_data_a";
+		function = "ssi";
+	};
+
+	sound_clk_pins: sound_clk {
+		groups = "audio_clk_a_a", "audio_clk_b_a", "audio_clk_c_a",
+			 "audio_clkout_a", "audio_clkout3_a";
+		function = "audio_clk";
+	};
+
 	usb1_pins: usb1 {
 		groups = "usb1";
 		function = "usb1";
@@ -136,6 +176,73 @@
 	pinctrl-names = "default";
 
 	status = "okay";
+
+	clock-frequency = <100000>;
+
+	ak4613: codec@10 {
+		compatible = "asahi-kasei,ak4613";
+		#sound-dai-cells = <0>;
+		reg = <0x10>;
+		clocks = <&rcar_sound 3>;
+
+		asahi-kasei,in1-single-end;
+		asahi-kasei,in2-single-end;
+		asahi-kasei,out1-single-end;
+		asahi-kasei,out2-single-end;
+		asahi-kasei,out3-single-end;
+		asahi-kasei,out4-single-end;
+		asahi-kasei,out5-single-end;
+		asahi-kasei,out6-single-end;
+	};
+
+	cs2000: clk_multiplier@4f {
+		#clock-cells = <0>;
+		compatible = "cirrus,cs2000-cp";
+		reg = <0x4f>;
+		clocks = <&audio_clkout>, <&x12_clk>;
+		clock-names = "clk_in", "ref_clk";
+
+		assigned-clocks = <&cs2000>;
+		assigned-clock-rates = <24576000>; /* 1/1 divide */
+	};
+};
+
+&rcar_sound {
+	pinctrl-0 = <&sound_pins &sound_clk_pins>;
+	pinctrl-names = "default";
+
+	/* Single DAI */
+	#sound-dai-cells = <0>;
+
+	/* audio_clkout0/1/2/3 */
+	#clock-cells = <1>;
+	clock-frequency = <11289600>;
+
+	status = "okay";
+
+	/* update <audio_clk_b> to <cs2000> */
+	clocks = <&cpg CPG_MOD 1005>,
+		 <&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>,
+		 <&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>,
+		 <&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>,
+		 <&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>,
+		 <&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>,
+		 <&cpg CPG_MOD 1022>, <&cpg CPG_MOD 1023>,
+		 <&cpg CPG_MOD 1024>, <&cpg CPG_MOD 1025>,
+		 <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>,
+		 <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>,
+		 <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>,
+		 <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>,
+		 <&audio_clk_a>, <&cs2000>,
+		 <&audio_clk_c>,
+		 <&cpg CPG_CORE R8A7795_CLK_S0D4>;
+
+	rcar_sound,dai {
+		dai0 {
+			playback = <&ssi0 &src0 &dvc0>;
+			capture  = <&ssi1 &src1 &dvc1>;
+		};
+	};
 };
 
 &sdhi0 {
@@ -150,11 +257,19 @@
 	status = "okay";
 };
 
+&ssi1 {
+	shared-pin;
+};
+
 &wdt0 {
 	timeout-sec = <60>;
 	status = "okay";
 };
 
+&audio_clk_a {
+	clock-frequency = <22579200>;
+};
+
 &avb {
 	pinctrl-0 = <&avb_pins>;
 	pinctrl-names = "default";
-- 
1.9.1

Re: [PATCH v3 02/12] arm64: dts: h3ulcb: initial device tree

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:02 PM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> Add the initial device tree for the R8A7795 SoC based H3ULCB low cost
> board.
>
> This commit supports the following peripherals:
> - SCIF (console)
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 02/12] arm64: dts: h3ulcb: initial device tree

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:02 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> Add the initial device tree for the R8A7795 SoC based H3ULCB low cost
> board.
>
> This commit supports the following peripherals:
> - SCIF (console)
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 03/12] arm64: dts: h3ulcb: enable SCIF clk and pins

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:02 PM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> This enables the external crystal for the SCIF_CLK and its pinctrl, to
> be used by the Baud Rate Generator for External Clock (BRG) on (H)SCIF.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 03/12] arm64: dts: h3ulcb: enable SCIF clk and pins

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:02 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This enables the external crystal for the SCIF_CLK and its pinctrl, to
> be used by the Baud Rate Generator for External Clock (BRG) on (H)SCIF.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 04/12] arm64: dts: h3ulcb: enable EthernetAVB

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:02 PM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> This supports Ethernet AVB on H3ULCB board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts

> @@ -62,3 +68,29 @@
>         clock-frequency = <14745600>;
>         status = "okay";
>  };
> +
> +&avb {
> +       pinctrl-0 = <&avb_pins>;
> +       pinctrl-names = "default";
> +       renesas,no-ether-link;
> +       phy-handle = <&phy0>;
> +       status = "okay";
> +
> +       phy0: ethernet-phy@0 {
> +               rxc-skew-ps = <900>;
> +               rxdv-skew-ps = <0>;
> +               rxd0-skew-ps = <0>;
> +               rxd1-skew-ps = <0>;
> +               rxd2-skew-ps = <0>;
> +               rxd3-skew-ps = <0>;
> +               txc-skew-ps = <900>;
> +               txen-skew-ps = <0>;
> +               txd0-skew-ps = <0>;
> +               txd1-skew-ps = <0>;
> +               txd2-skew-ps = <0>;
> +               txd3-skew-ps = <0>;
> +               reg = <0>;
> +               interrupt-parent = <&gpio2>;
> +               interrupts = <11 IRQ_TYPE_LEVEL_LOW>;

Just wondering (it's done the same way on Salvator-X) why this is using a
GPIO interrupt, and not the dedicated AVB_PHY_INT?

> +       };
> +};

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 04/12] arm64: dts: h3ulcb: enable EthernetAVB

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:02 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports Ethernet AVB on H3ULCB board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts

> @@ -62,3 +68,29 @@
>         clock-frequency = <14745600>;
>         status = "okay";
>  };
> +
> +&avb {
> +       pinctrl-0 = <&avb_pins>;
> +       pinctrl-names = "default";
> +       renesas,no-ether-link;
> +       phy-handle = <&phy0>;
> +       status = "okay";
> +
> +       phy0: ethernet-phy@0 {
> +               rxc-skew-ps = <900>;
> +               rxdv-skew-ps = <0>;
> +               rxd0-skew-ps = <0>;
> +               rxd1-skew-ps = <0>;
> +               rxd2-skew-ps = <0>;
> +               rxd3-skew-ps = <0>;
> +               txc-skew-ps = <900>;
> +               txen-skew-ps = <0>;
> +               txd0-skew-ps = <0>;
> +               txd1-skew-ps = <0>;
> +               txd2-skew-ps = <0>;
> +               txd3-skew-ps = <0>;
> +               reg = <0>;
> +               interrupt-parent = <&gpio2>;
> +               interrupts = <11 IRQ_TYPE_LEVEL_LOW>;

Just wondering (it's done the same way on Salvator-X) why this is using a
GPIO interrupt, and not the dedicated AVB_PHY_INT?

> +       };
> +};

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 05/12] arm64: dts: h3ulcb: enable GPIO leds

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> This supports GPIO leds on H3ULCB board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> @@ -31,6 +31,19 @@
>                 /* first 128MB is reserved for secure area. */
>                 reg = <0x0 0x48000000 0x0 0x38000000>;
>         };
> +
> +       leds {
> +               compatible = "gpio-leds";
> +               led4 {
> +                       gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
> +               };
> +               led5 {
> +                       gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
> +               };
> +               led6 {
> +                       gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>;
> +               };
> +       };

The LEDs share GPIOs with the switches. Unfortunately you cannot use both
at the same time.
Perhaps we want to configure one of them for the switch, to be used as a
wakeup-source?

The same applies to Salvator-X, where we haven't wired up the LEDs nor
switches (yet).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 05/12] arm64: dts: h3ulcb: enable GPIO leds

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports GPIO leds on H3ULCB board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> @@ -31,6 +31,19 @@
>                 /* first 128MB is reserved for secure area. */
>                 reg = <0x0 0x48000000 0x0 0x38000000>;
>         };
> +
> +       leds {
> +               compatible = "gpio-leds";
> +               led4 {
> +                       gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
> +               };
> +               led5 {
> +                       gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
> +               };
> +               led6 {
> +                       gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>;
> +               };
> +       };

The LEDs share GPIOs with the switches. Unfortunately you cannot use both
at the same time.
Perhaps we want to configure one of them for the switch, to be used as a
wakeup-source?

The same applies to Salvator-X, where we haven't wired up the LEDs nor
switches (yet).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 06/12] arm64: dts: h3ulcb: enable SDHI0

[Geert Uytterhoeven]

Hi Vladimir,

On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> This supports SDHI0 on H3ULCB board SD card slot
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts

> @@ -82,6 +118,18 @@
>         status = "okay";
>  };
>
> +&sdhi0 {
> +       pinctrl-0 = <&sdhi0_pins_3v3>;
> +       pinctrl-1 = <&sdhi0_pins_1v8>;
> +       pinctrl-names = "default", "state_uhs";
> +
> +       vmmc-supply = <&vcc_sdhi0>;
> +       vqmmc-supply = <&vccq_sdhi0>;
> +       cd-gpios = <&gpio3 12 GPIO_ACTIVE_LOW>;
> +       bus-width = <4>;
> +       status = "okay";
> +};

According to the schematics, SD0_WP is wired, so I think you want to add

    wp-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;

As you add UHS pins, I think you want to add

    sd-uhs-sdr50

too.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 06/12] arm64: dts: h3ulcb: enable SDHI0

[Geert Uytterhoeven]

Hi Vladimir,

On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports SDHI0 on H3ULCB board SD card slot
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts

> @@ -82,6 +118,18 @@
>         status = "okay";
>  };
>
> +&sdhi0 {
> +       pinctrl-0 = <&sdhi0_pins_3v3>;
> +       pinctrl-1 = <&sdhi0_pins_1v8>;
> +       pinctrl-names = "default", "state_uhs";
> +
> +       vmmc-supply = <&vcc_sdhi0>;
> +       vqmmc-supply = <&vccq_sdhi0>;
> +       cd-gpios = <&gpio3 12 GPIO_ACTIVE_LOW>;
> +       bus-width = <4>;
> +       status = "okay";
> +};

According to the schematics, SD0_WP is wired, so I think you want to add

    wp-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;

As you add UHS pins, I think you want to add

    sd-uhs-sdr50

too.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 07/12] arm64: dts: h3ulcb: enable I2C2

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> This supports I2C2 bus on H3ULCB board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 07/12] arm64: dts: h3ulcb: enable I2C2

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports I2C2 bus on H3ULCB board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 08/12] arm64: dts: h3ulcb: enable EXTALR clk

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> This enables EXTALR clock that can be used for the watchdog.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 08/12] arm64: dts: h3ulcb: enable EXTALR clk

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This enables EXTALR clock that can be used for the watchdog.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 09/12] arm64: dts: h3ulcb: enable WDT

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> This supports watchdog timer for H3ULCB board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 09/12] arm64: dts: h3ulcb: enable WDT

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports watchdog timer for H3ULCB board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 10/12] arm64: dts: h3ulcb: enable USB2 PHY of channel 1

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports USB2 PHY channel #1 on H3ULCB board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 11/12] arm64: dts: h3ulcb: enable USB2.0 Host channel 1

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:04 PM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> This supports USB2.0 Host channel 1 on H3ULCB board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 11/12] arm64: dts: h3ulcb: enable USB2.0 Host channel 1

[Geert Uytterhoeven]

On Wed, Aug 31, 2016 at 12:04 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This supports USB2.0 Host channel 1 on H3ULCB board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 0/12] arm64: renesas: add H3ULCB board

[Geert Uytterhoeven]

Hi Vladimir,

On Wed, Aug 31, 2016 at 12:01 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> This adds the folowing:
> - R8A7795 SoC based H3ULCB low cost board device tree
> - Document DT bindings

Thanks for your split series!

> Vladimir Barinov (12):
> [01/12] dt: arm: shmobile: add H3ULCB board DT bindings
> [02/12] arm64: dts: h3ulcb: initial device tree
> [03/12] arm64: dts: h3ulcb: enable SCIF clk and pins
> [04/12] arm64: dts: h3ulcb: enable EthernetAVB
> [05/12] arm64: dts: h3ulcb: enable GPIO leds
> [06/12] arm64: dts: h3ulcb: enable SDHI0
> [07/12] arm64: dts: h3ulcb: enable I2C2
> [08/12] arm64: dts: h3ulcb: enable EXTALR clk
> [09/12] arm64: dts: h3ulcb: enable WDT
> [10/12] arm64: dts: h3ulcb: enable USB2 PHY of channel 1
> [11/12] arm64: dts: h3ulcb: enable USB2.0 Host channel 1

I went through all of the above...

> [12/12] arm64: dts: h3ulcb: Sound SSI support

... but I'm leaving this one for Morimoto-san.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 04/12] arm64: dts: h3ulcb: enable EthernetAVB

[Sergei Shtylyov]

On 9/1/2016 10:48 AM, Geert Uytterhoeven wrote:

>> This supports Ethernet AVB on H3ULCB board
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
>> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>
>> @@ -62,3 +68,29 @@
>>         clock-frequency = <14745600>;
>>         status = "okay";
>>  };
>> +
>> +&avb {
>> +       pinctrl-0 = <&avb_pins>;
>> +       pinctrl-names = "default";
>> +       renesas,no-ether-link;
>> +       phy-handle = <&phy0>;
>> +       status = "okay";
>> +
>> +       phy0: ethernet-phy@0 {
>> +               rxc-skew-ps = <900>;
>> +               rxdv-skew-ps = <0>;
>> +               rxd0-skew-ps = <0>;
>> +               rxd1-skew-ps = <0>;
>> +               rxd2-skew-ps = <0>;
>> +               rxd3-skew-ps = <0>;
>> +               txc-skew-ps = <900>;
>> +               txen-skew-ps = <0>;
>> +               txd0-skew-ps = <0>;
>> +               txd1-skew-ps = <0>;
>> +               txd2-skew-ps = <0>;
>> +               txd3-skew-ps = <0>;
>> +               reg = <0>;
>> +               interrupt-parent = <&gpio2>;
>> +               interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
>
> Just wondering (it's done the same way on Salvator-X) why this is using a
> GPIO interrupt, and not the dedicated AVB_PHY_INT?

    AVB_PHY_INT isn't supported by the driver yet (due to the phylib's 
misfeature which has been fixed now). I simply lack the time to work on this 
support.

MBR, Sergei

Re: [PATCH v3 05/12] arm64: dts: h3ulcb: enable GPIO leds

[Vladimir Barinov]

Hi Geert,

Thank you for the review.

On 01.09.2016 10:52, Geert Uytterhoeven wrote:
> On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
> <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
>> This supports GPIO leds on H3ULCB board
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
>
>> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>> @@ -31,6 +31,19 @@
>>                  /* first 128MB is reserved for secure area. */
>>                  reg = <0x0 0x48000000 0x0 0x38000000>;
>>          };
>> +
>> +       leds {
>> +               compatible = "gpio-leds";
>> +               led4 {
>> +                       gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
>> +               };
>> +               led5 {
>> +                       gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
>> +               };
>> +               led6 {
>> +                       gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>;
>> +               };
>> +       };
> The LEDs share GPIOs with the switches. Unfortunately you cannot use both
> at the same time.
> Perhaps we want to configure one of them for the switch, to be used as a
> wakeup-source?
This is a good point.

I will respin this patch accordingly to your suggestion.

Regards,
Vladimir
>
> The same applies to Salvator-X, where we haven't wired up the LEDs nor
> switches (yet).
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 05/12] arm64: dts: h3ulcb: enable GPIO leds

[Vladimir Barinov]

Hi Geert,

Thank you for the review.

On 01.09.2016 10:52, Geert Uytterhoeven wrote:
> On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
>> This supports GPIO leds on H3ULCB board
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
>> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>> @@ -31,6 +31,19 @@
>>                  /* first 128MB is reserved for secure area. */
>>                  reg = <0x0 0x48000000 0x0 0x38000000>;
>>          };
>> +
>> +       leds {
>> +               compatible = "gpio-leds";
>> +               led4 {
>> +                       gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
>> +               };
>> +               led5 {
>> +                       gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
>> +               };
>> +               led6 {
>> +                       gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>;
>> +               };
>> +       };
> The LEDs share GPIOs with the switches. Unfortunately you cannot use both
> at the same time.
> Perhaps we want to configure one of them for the switch, to be used as a
> wakeup-source?
This is a good point.

I will respin this patch accordingly to your suggestion.

Regards,
Vladimir
>
> The same applies to Salvator-X, where we haven't wired up the LEDs nor
> switches (yet).
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds

Re: [PATCH v3 06/12] arm64: dts: h3ulcb: enable SDHI0

[Vladimir Barinov]

Hi Geert,

On 01.09.2016 11:11, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
>> This supports SDHI0 on H3ULCB board SD card slot
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Thanks for your patch!
>
>> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>> @@ -82,6 +118,18 @@
>>          status = "okay";
>>   };
>>
>> +&sdhi0 {
>> +       pinctrl-0 = <&sdhi0_pins_3v3>;
>> +       pinctrl-1 = <&sdhi0_pins_1v8>;
>> +       pinctrl-names = "default", "state_uhs";
>> +
>> +       vmmc-supply = <&vcc_sdhi0>;
>> +       vqmmc-supply = <&vccq_sdhi0>;
>> +       cd-gpios = <&gpio3 12 GPIO_ACTIVE_LOW>;
>> +       bus-width = <4>;
>> +       status = "okay";
>> +};
> According to the schematics, SD0_WP is wired, so I think you want to add
No, it is not wired (I look on rev0.40 and rev0.46).
The microSD card connector CN6 does not have WP on H3ULCB board.
>
>      wp-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
The GPIO GP_3_13 just pulled up to 3.3V power rail.
>
> As you add UHS pins, I think you want to add
>
>      sd-uhs-sdr50
>
> too.
Thank you for pointing to this.
Yes.
I will respin this patch with this added.

Regards,
Vladimir
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds

Re: [PATCH v3 0/12] arm64: renesas: add H3ULCB board

[Vladimir Barinov]

Hi Geert,

Thank you for the review!
I will wait for Morimoto-san review and respin the patch series 
accordingly to your comments.

Regards,
Vladimir

On 01.09.2016 11:39, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> On Wed, Aug 31, 2016 at 12:01 PM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
>> This adds the folowing:
>> - R8A7795 SoC based H3ULCB low cost board device tree
>> - Document DT bindings
> Thanks for your split series!
>
>> Vladimir Barinov (12):
>> [01/12] dt: arm: shmobile: add H3ULCB board DT bindings
>> [02/12] arm64: dts: h3ulcb: initial device tree
>> [03/12] arm64: dts: h3ulcb: enable SCIF clk and pins
>> [04/12] arm64: dts: h3ulcb: enable EthernetAVB
>> [05/12] arm64: dts: h3ulcb: enable GPIO leds
>> [06/12] arm64: dts: h3ulcb: enable SDHI0
>> [07/12] arm64: dts: h3ulcb: enable I2C2
>> [08/12] arm64: dts: h3ulcb: enable EXTALR clk
>> [09/12] arm64: dts: h3ulcb: enable WDT
>> [10/12] arm64: dts: h3ulcb: enable USB2 PHY of channel 1
>> [11/12] arm64: dts: h3ulcb: enable USB2.0 Host channel 1
> I went through all of the above...
>
>> [12/12] arm64: dts: h3ulcb: Sound SSI support
> ... but I'm leaving this one for Morimoto-san.
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds

Re: [PATCH v3 06/12] arm64: dts: h3ulcb: enable SDHI0

[Geert Uytterhoeven]

Hi Vladimir,

On Thu, Sep 1, 2016 at 12:41 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> On 01.09.2016 11:11, Geert Uytterhoeven wrote:
>>> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>>> @@ -82,6 +118,18 @@
>>>          status = "okay";
>>>   };
>>>
>>> +&sdhi0 {
>>> +       pinctrl-0 = <&sdhi0_pins_3v3>;
>>> +       pinctrl-1 = <&sdhi0_pins_1v8>;
>>> +       pinctrl-names = "default", "state_uhs";
>>> +
>>> +       vmmc-supply = <&vcc_sdhi0>;
>>> +       vqmmc-supply = <&vccq_sdhi0>;
>>> +       cd-gpios = <&gpio3 12 GPIO_ACTIVE_LOW>;
>>> +       bus-width = <4>;
>>> +       status = "okay";
>>> +};
>>
>> According to the schematics, SD0_WP is wired, so I think you want to add
>
> No, it is not wired (I look on rev0.40 and rev0.46).
> The microSD card connector CN6 does not have WP on H3ULCB board.
>>
>>      wp-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
>
> The GPIO GP_3_13 just pulled up to 3.3V power rail.

You're right, I missed that the signal goes to D3.3V instead of to the
connector.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 0/12] arm64: renesas: add H3ULCB board

[Simon Horman]

On Thu, Sep 01, 2016 at 10:39:04AM +0200, Geert Uytterhoeven wrote:
> Hi Vladimir,
> 
> On Wed, Aug 31, 2016 at 12:01 PM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
> > This adds the folowing:
> > - R8A7795 SoC based H3ULCB low cost board device tree
> > - Document DT bindings
> 
> Thanks for your split series!

Likewise. And thanks Geert for your review.


> > Vladimir Barinov (12):
> > [01/12] dt: arm: shmobile: add H3ULCB board DT bindings

I have queued up the above patch after renaming it
arm64: dts: h3ulcb: enable USB2.0 Host channel 1

> > [02/12] arm64: dts: h3ulcb: initial device tree
> > [03/12] arm64: dts: h3ulcb: enable SCIF clk and pins
> > [04/12] arm64: dts: h3ulcb: enable EthernetAVB
> > [05/12] arm64: dts: h3ulcb: enable GPIO leds
> > [06/12] arm64: dts: h3ulcb: enable SDHI0
> > [07/12] arm64: dts: h3ulcb: enable I2C2
> > [08/12] arm64: dts: h3ulcb: enable EXTALR clk
> > [09/12] arm64: dts: h3ulcb: enable WDT
> > [10/12] arm64: dts: h3ulcb: enable USB2 PHY of channel 1
> > [11/12] arm64: dts: h3ulcb: enable USB2.0 Host channel 1
> 
> I went through all of the above...

I have also queued up 02,03,04,07,08,09,11/12.

> > [12/12] arm64: dts: h3ulcb: Sound SSI support
> 
> ... but I'm leaving this one for Morimoto-san.

Re: [PATCH v3 0/12] arm64: renesas: add H3ULCB board

[Simon Horman]

On Thu, Sep 01, 2016 at 04:17:12PM +0200, Simon Horman wrote:
> On Thu, Sep 01, 2016 at 10:39:04AM +0200, Geert Uytterhoeven wrote:
> > Hi Vladimir,
> > 
> > On Wed, Aug 31, 2016 at 12:01 PM, Vladimir Barinov
> > <vladimir.barinov@cogentembedded.com> wrote:
> > > This adds the folowing:
> > > - R8A7795 SoC based H3ULCB low cost board device tree
> > > - Document DT bindings
> > 
> > Thanks for your split series!
> 
> Likewise. And thanks Geert for your review.
> 
> 
> > > Vladimir Barinov (12):
> > > [01/12] dt: arm: shmobile: add H3ULCB board DT bindings
> 
> I have queued up the above patch after renaming it
> arm64: dts: h3ulcb: enable USB2.0 Host channel 1

Cut an paste error (that is the parent commit in my tree).
I meant to say:

  arm64: dts: h3ulcb: add H3ULCB board DT bindings

> > > [02/12] arm64: dts: h3ulcb: initial device tree
> > > [03/12] arm64: dts: h3ulcb: enable SCIF clk and pins
> > > [04/12] arm64: dts: h3ulcb: enable EthernetAVB
> > > [05/12] arm64: dts: h3ulcb: enable GPIO leds
> > > [06/12] arm64: dts: h3ulcb: enable SDHI0
> > > [07/12] arm64: dts: h3ulcb: enable I2C2
> > > [08/12] arm64: dts: h3ulcb: enable EXTALR clk
> > > [09/12] arm64: dts: h3ulcb: enable WDT
> > > [10/12] arm64: dts: h3ulcb: enable USB2 PHY of channel 1
> > > [11/12] arm64: dts: h3ulcb: enable USB2.0 Host channel 1
> > 
> > I went through all of the above...
> 
> I have also queued up 02,03,04,07,08,09,11/12.
> 
> > > [12/12] arm64: dts: h3ulcb: Sound SSI support
> > 
> > ... but I'm leaving this one for Morimoto-san.
> 

Re: [PATCH v3 0/12] arm64: renesas: add H3ULCB board

[Geert Uytterhoeven]

Hi Simon,

On Thu, Sep 1, 2016 at 4:17 PM, Simon Horman <horms@verge.net.au> wrote:
>> > [01/12] dt: arm: shmobile: add H3ULCB board DT bindings
>
> I have queued up the above patch after renaming it
> arm64: dts: h3ulcb: enable USB2.0 Host channel 1
>
>> > [02/12] arm64: dts: h3ulcb: initial device tree
>> > [03/12] arm64: dts: h3ulcb: enable SCIF clk and pins
>> > [04/12] arm64: dts: h3ulcb: enable EthernetAVB
>> > [05/12] arm64: dts: h3ulcb: enable GPIO leds
>> > [06/12] arm64: dts: h3ulcb: enable SDHI0
>> > [07/12] arm64: dts: h3ulcb: enable I2C2
>> > [08/12] arm64: dts: h3ulcb: enable EXTALR clk
>> > [09/12] arm64: dts: h3ulcb: enable WDT
>> > [10/12] arm64: dts: h3ulcb: enable USB2 PHY of channel 1
>> > [11/12] arm64: dts: h3ulcb: enable USB2.0 Host channel 1
>>
>> I went through all of the above...
>
> I have also queued up 02,03,04,07,08,09,11/12.

Any specific reason you skipped 10/12? I'm afraid it's a prerequisite for
11/12.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support

[Kuninori Morimoto]

Hi Vladimir

> This supports SSI sound for H3ULCB board.
> SSI DMA mode used. CS2000 used as AUDIO_CLK_B.
> 
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

> +	audio_clkout: audio_clkout {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <11289600>;
> +	};

I think having commont for AUDIO_CLKOUT is better for user, like Salvator-X.
This "audio_clkout" is dummy. Actually, we don't need this dummy clock,
and we should use "<&rcar_sound 0>" as AUDIO_CLKOUT,
like AUDIO_CLKOUT3 as "<&rcar_sound 3>" which is used on ak4613. 
But Salvator-X and this ULCB board has very complex connection,
especially around CS2000.
This means cs2000 requests rcar_sound, and rcar_sound requests cs2000.
This audio_clkout exist to avoid probe dead-lock.
This is the reason why audio_clkout and rcar_sound::clock-frequency
has same value.

Re: [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support

[Kuninori Morimoto]

Hi Vladimir

> This supports SSI sound for H3ULCB board.
> SSI DMA mode used. CS2000 used as AUDIO_CLK_B.
> 
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

> +	audio_clkout: audio_clkout {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <11289600>;
> +	};

I think having commont for AUDIO_CLKOUT is better for user, like Salvator-X.
This "audio_clkout" is dummy. Actually, we don't need this dummy clock,
and we should use "<&rcar_sound 0>" as AUDIO_CLKOUT,
like AUDIO_CLKOUT3 as "<&rcar_sound 3>" which is used on ak4613. 
But Salvator-X and this ULCB board has very complex connection,
especially around CS2000.
This means cs2000 requests rcar_sound, and rcar_sound requests cs2000.
This audio_clkout exist to avoid probe dead-lock.
This is the reason why audio_clkout and rcar_sound::clock-frequency
has same value.

Re: [PATCH v3 0/12] arm64: renesas: add H3ULCB board

[Simon Horman]

On Thu, Sep 01, 2016 at 09:25:08PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Sep 1, 2016 at 4:17 PM, Simon Horman <horms@verge.net.au> wrote:
> >> > [01/12] dt: arm: shmobile: add H3ULCB board DT bindings
> >
> > I have queued up the above patch after renaming it
> > arm64: dts: h3ulcb: enable USB2.0 Host channel 1
> >
> >> > [02/12] arm64: dts: h3ulcb: initial device tree
> >> > [03/12] arm64: dts: h3ulcb: enable SCIF clk and pins
> >> > [04/12] arm64: dts: h3ulcb: enable EthernetAVB
> >> > [05/12] arm64: dts: h3ulcb: enable GPIO leds
> >> > [06/12] arm64: dts: h3ulcb: enable SDHI0
> >> > [07/12] arm64: dts: h3ulcb: enable I2C2
> >> > [08/12] arm64: dts: h3ulcb: enable EXTALR clk
> >> > [09/12] arm64: dts: h3ulcb: enable WDT
> >> > [10/12] arm64: dts: h3ulcb: enable USB2 PHY of channel 1
> >> > [11/12] arm64: dts: h3ulcb: enable USB2.0 Host channel 1
> >>
> >> I went through all of the above...
> >
> > I have also queued up 02,03,04,07,08,09,11/12.
> 
> Any specific reason you skipped 10/12? I'm afraid it's a prerequisite for
> 11/12.

Thanks for pointing that out, it is an oversight.
I have queued up 10/12 and plan to push a bit later today.

Re: [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support

[Simon Horman]

On Fri, Sep 02, 2016 at 01:19:49AM +0000, Kuninori Morimoto wrote:
> 
> Hi Vladimir
> 
> > This supports SSI sound for H3ULCB board.
> > SSI DMA mode used. CS2000 used as AUDIO_CLK_B.
> > 
> > Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> > ---
> 
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> 
> > +	audio_clkout: audio_clkout {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <11289600>;
> > +	};
> 
> I think having commont for AUDIO_CLKOUT is better for user, like Salvator-X.
> This "audio_clkout" is dummy. Actually, we don't need this dummy clock,
> and we should use "<&rcar_sound 0>" as AUDIO_CLKOUT,
> like AUDIO_CLKOUT3 as "<&rcar_sound 3>" which is used on ak4613. 
> But Salvator-X and this ULCB board has very complex connection,
> especially around CS2000.
> This means cs2000 requests rcar_sound, and rcar_sound requests cs2000.
> This audio_clkout exist to avoid probe dead-lock.
> This is the reason why audio_clkout and rcar_sound::clock-frequency
> has same value.

Vladimir,

please address the above and include it when you repost the patches
that I haven't queued up.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support

[Simon Horman]

On Fri, Sep 02, 2016 at 01:19:49AM +0000, Kuninori Morimoto wrote:
> 
> Hi Vladimir
> 
> > This supports SSI sound for H3ULCB board.
> > SSI DMA mode used. CS2000 used as AUDIO_CLK_B.
> > 
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > ---
> 
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> > +	audio_clkout: audio_clkout {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <11289600>;
> > +	};
> 
> I think having commont for AUDIO_CLKOUT is better for user, like Salvator-X.
> This "audio_clkout" is dummy. Actually, we don't need this dummy clock,
> and we should use "<&rcar_sound 0>" as AUDIO_CLKOUT,
> like AUDIO_CLKOUT3 as "<&rcar_sound 3>" which is used on ak4613. 
> But Salvator-X and this ULCB board has very complex connection,
> especially around CS2000.
> This means cs2000 requests rcar_sound, and rcar_sound requests cs2000.
> This audio_clkout exist to avoid probe dead-lock.
> This is the reason why audio_clkout and rcar_sound::clock-frequency
> has same value.

Vladimir,

please address the above and include it when you repost the patches
that I haven't queued up.

Re: [PATCH v3 01/12] dt: arm: shmobile: add H3ULCB board DT bindings

[Geert Uytterhoeven]

Hi Vladimir,

On Wed, Aug 31, 2016 at 12:02 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> Add H3ULCB Device tree bindings Documentation, listing it as a supported
> board.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Changes in version 2:
> - none
> Changes in version 3:
> - none
>
>  Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
> index 5484c31d..2f0b716 100644
> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
> @@ -49,6 +49,8 @@ Boards:
>      compatible = "renesas,genmai", "renesas,r7s72100"
>    - Gose
>      compatible = "renesas,gose", "renesas,r8a7793"
> +  - H3ULCB (RTP0RC7795SKB00010S)
> +    compatible = "renesas,h3ulcb", "renesas,r8a7795";

Should this have been

        H3SK (R-Car Starter Kit Premier, RTP0RC7795SKB00010S)
        compatible = "renesas,h3sk", "renesas,r8a7795";

instead?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 01/12] dt: arm: shmobile: add H3ULCB board DT bindings

[Vladimir Barinov]

Hi Geert,

On 25.10.2016 15:48, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> On Wed, Aug 31, 2016 at 12:02 PM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
>> Add H3ULCB Device tree bindings Documentation, listing it as a supported
>> board.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Acked-by: Rob Herring <robh@kernel.org>
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> Changes in version 2:
>> - none
>> Changes in version 3:
>> - none
>>
>>   Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
>> index 5484c31d..2f0b716 100644
>> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
>> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
>> @@ -49,6 +49,8 @@ Boards:
>>       compatible = "renesas,genmai", "renesas,r7s72100"
>>     - Gose
>>       compatible = "renesas,gose", "renesas,r8a7793"
>> +  - H3ULCB (RTP0RC7795SKB00010S)
>> +    compatible = "renesas,h3ulcb", "renesas,r8a7795";
> Should this have been
>
>          H3SK (R-Car Starter Kit Premier, RTP0RC7795SKB00010S)
>          compatible = "renesas,h3sk", "renesas,r8a7795";
>
> instead?
Actually you are right, since Renesas naming policy changed: originally 
the assigned name was H3ULCB and all boards that I have labled as ULCB.
Now the official name is  "R-Car Starter Kit Premier" and "R-Car Starter 
Kit Pro" for H3/M3 respectively.

I've got this message from Renesas:
"

1. Official name for Gen3 low cost board

  R-Car Starter Kit Premier (We called "H3ULCB")
  R-Car Starter Kit Pro     (We called "M3ULCB")

  1-1. Please change the "M3ULCB/H3ULCB" to
       "R-Car Starter Kit Pro/Premier" on elinux.
  1-2. You DON'T have to change in source code.
       You can use ULCB in Kernel, u-boot, Yocto recipe.
  1-3. Please explain relations of "ULCB" and "Starter Kit" on elinux.
	Ex) R-Car Starter Kit Premier = H3ULCB
"


What do think about changing only first line and leave "compatible" as 
is, since h3ulcb have been using a while by different customers and 
renaming of the board name will confuse? (If we change it to 
"renesas,h3sk " then probably we need to rename the dts file 
r8a7795-h3ulcb.dts and its content)

-  - H3ULCB (RTP0RC7795SKB00010S)
+  - H3ULCB (R-Car Starter Kit Premier, RTP0RC7795SKB00010S)


And would be the best for M3 Starter Kit?
The M3 Starter Kit board labeled as "M3 StarterKit", bit it is the same 
board with different SiP.

Should it look like:

         M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKB00010S)
         compatible = "renesas,m3ulcb", "renesas,r8a7796";

or

         M3SK (R-Car Starter Kit Pro, RTP0RC7796SKB00010S)
         compatible = "renesas,m3sk", "renesas,r8a7796";


Regards,
Vladimir
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds

Re: [PATCH v3 01/12] dt: arm: shmobile: add H3ULCB board DT bindings

[Vladimir Barinov]

Hi Geert,

I've got this message from Renesas:
"

Please use H3ULCB/M3ULCB in upstream.
# I got an agreement among parties.

Board name in community: ULCB (= development code name)
Official name (product/brand name): Starter Kit Pro/Premier
"

Renaming  H3ULCB -> H3SK is not desired for Renesas.

What do you think to append the product/brand name only? :

-        H3ULCB (RTP0RC7795SKB00010S)
+       H3ULCB (R-Car Starter Kit Premier, RTP0RC7795SKB00010S)
          compatible = "renesas,h3ulcb", "renesas,r8a7795";

Regards,
Vladimir

On 25.10.2016 18:06, Vladimir Barinov wrote:
> Hi Geert,
>
> On 25.10.2016 15:48, Geert Uytterhoeven wrote:
>> Hi Vladimir,
>>
>> On Wed, Aug 31, 2016 at 12:02 PM, Vladimir Barinov
>> <vladimir.barinov@cogentembedded.com> wrote:
>>> Add H3ULCB Device tree bindings Documentation, listing it as a 
>>> supported
>>> board.
>>>
>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>> ---
>>> Changes in version 2:
>>> - none
>>> Changes in version 3:
>>> - none
>>>
>>>   Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt 
>>> b/Documentation/devicetree/bindings/arm/shmobile.txt
>>> index 5484c31d..2f0b716 100644
>>> --- a/Documentation/devicetree/bindings/arm/shmobile.txt
>>> +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
>>> @@ -49,6 +49,8 @@ Boards:
>>>       compatible = "renesas,genmai", "renesas,r7s72100"
>>>     - Gose
>>>       compatible = "renesas,gose", "renesas,r8a7793"
>>> +  - H3ULCB (RTP0RC7795SKB00010S)
>>> +    compatible = "renesas,h3ulcb", "renesas,r8a7795";
>> Should this have been
>>
>>          H3SK (R-Car Starter Kit Premier, RTP0RC7795SKB00010S)
>>          compatible = "renesas,h3sk", "renesas,r8a7795";
>>
>> instead?
> Actually you are right, since Renesas naming policy changed: 
> originally the assigned name was H3ULCB and all boards that I have 
> labled as ULCB.
> Now the official name is  "R-Car Starter Kit Premier" and "R-Car 
> Starter Kit Pro" for H3/M3 respectively.
>
> I've got this message from Renesas:
> "
>
> 1. Official name for Gen3 low cost board
>
>  R-Car Starter Kit Premier (We called "H3ULCB")
>  R-Car Starter Kit Pro     (We called "M3ULCB")
>
>  1-1. Please change the "M3ULCB/H3ULCB" to
>       "R-Car Starter Kit Pro/Premier" on elinux.
>  1-2. You DON'T have to change in source code.
>       You can use ULCB in Kernel, u-boot, Yocto recipe.
>  1-3. Please explain relations of "ULCB" and "Starter Kit" on elinux.
>     Ex) R-Car Starter Kit Premier = H3ULCB
> "
>
>
> What do think about changing only first line and leave "compatible" as 
> is, since h3ulcb have been using a while by different customers and 
> renaming of the board name will confuse? (If we change it to 
> "renesas,h3sk " then probably we need to rename the dts file 
> r8a7795-h3ulcb.dts and its content)
>
> -  - H3ULCB (RTP0RC7795SKB00010S)
> +  - H3ULCB (R-Car Starter Kit Premier, RTP0RC7795SKB00010S)
>
>
> And would be the best for M3 Starter Kit?
> The M3 Starter Kit board labeled as "M3 StarterKit", bit it is the 
> same board with different SiP.
>
> Should it look like:
>
>         M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKB00010S)
>         compatible = "renesas,m3ulcb", "renesas,r8a7796";
>
> or
>
>         M3SK (R-Car Starter Kit Pro, RTP0RC7796SKB00010S)
>         compatible = "renesas,m3sk", "renesas,r8a7796";
>
>
> Regards,
> Vladimir
>>
>> Gr{oetje,eeting}s,
>>
>>                          Geert
>>
>> -- 
>> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- 
>> geert@linux-m68k.org
>>
>> In personal conversations with technical people, I call myself a 
>> hacker. But
>> when I'm talking to journalists I just say "programmer" or something 
>> like that.
>>                                  -- Linus Torvalds
>
>

Re: [PATCH v3 01/12] dt: arm: shmobile: add H3ULCB board DT bindings

[Geert Uytterhoeven]

Hi Vladimir,

On Wed, Oct 26, 2016 at 12:27 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> I've got this message from Renesas:
> "
>
> Please use H3ULCB/M3ULCB in upstream.
> # I got an agreement among parties.
>
> Board name in community: ULCB (= development code name)
> Official name (product/brand name): Starter Kit Pro/Premier
> "
>
> Renaming  H3ULCB -> H3SK is not desired for Renesas.
>
> What do you think to append the product/brand name only? :
>
> -        H3ULCB (RTP0RC7795SKB00010S)
> +       H3ULCB (R-Car Starter Kit Premier, RTP0RC7795SKB00010S)
>          compatible = "renesas,h3ulcb", "renesas,r8a7795";

Looks good to me.

And then we can add

        M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKB00010S)
        compatible = "renesas,m3ulcb", "renesas,r8a7796";

later.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds