[PATCH v8 03/16] of/numa: add nid check for memory block

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Zhen Lei <thunder.leizhen@huawei.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Frank Rowand" <frowand.list@gmail.com>,
	devicetree <devicetree@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm <linux-mm@kvack.org>
Cc: Zefan Li <lizefan@huawei.com>, Xinwei Hu <huxinwei@huawei.com>,
	"Tianhong Ding" <dingtianhong@huawei.com>,
	Hanjun Guo <guohanjun@huawei.com>,
	Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH v8 03/16] of/numa: add nid check for memory block
Date: Thu, 1 Sep 2016 14:54:54 +0800	[thread overview]
Message-ID: <1472712907-12700-4-git-send-email-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <1472712907-12700-1-git-send-email-thunder.leizhen@huawei.com>

If the numa-id which was configured in memory@ devicetree node is greater
than MAX_NUMNODES, we should report a warning. We have done this for cpus
and distance-map dt nodes, this patch help them to be consistent.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 drivers/of/of_numa.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
index 7b3fbdc..c1bd62c 100644
--- a/drivers/of/of_numa.c
+++ b/drivers/of/of_numa.c
@@ -75,6 +75,11 @@ static int __init of_numa_parse_memory_nodes(void)
 			 */
 			continue;

+		if (nid >= MAX_NUMNODES) {
+			pr_warn("NUMA: Node id %u exceeds maximum value\n", nid);
+			r = -EINVAL;
+		}
+
 		for (i = 0; !r && !of_address_to_resource(np, i, &rsrc); i++)
 			r = numa_add_memblk(nid, rsrc.start, rsrc.end + 1);

--
2.5.0

WARNING: multiple messages have this Message-ID (diff)

From: Zhen Lei <thunder.leizhen@huawei.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	devicetree <devicetree@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm <linux-mm@kvack.org>
Cc: Zefan Li <lizefan@huawei.com>, Xinwei Hu <huxinwei@huawei.com>,
	Tianhong Ding <dingtianhong@huawei.com>,
	Hanjun Guo <guohanjun@huawei.com>,
	Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH v8 03/16] of/numa: add nid check for memory block
Date: Thu, 1 Sep 2016 14:54:54 +0800	[thread overview]
Message-ID: <1472712907-12700-4-git-send-email-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <1472712907-12700-1-git-send-email-thunder.leizhen@huawei.com>

If the numa-id which was configured in memory@ devicetree node is greater
than MAX_NUMNODES, we should report a warning. We have done this for cpus
and distance-map dt nodes, this patch help them to be consistent.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 drivers/of/of_numa.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
index 7b3fbdc..c1bd62c 100644
--- a/drivers/of/of_numa.c
+++ b/drivers/of/of_numa.c
@@ -75,6 +75,11 @@ static int __init of_numa_parse_memory_nodes(void)
 			 */
 			continue;

+		if (nid >= MAX_NUMNODES) {
+			pr_warn("NUMA: Node id %u exceeds maximum value\n", nid);
+			r = -EINVAL;
+		}
+
 		for (i = 0; !r && !of_address_to_resource(np, i, &rsrc); i++)
 			r = numa_add_memblk(nid, rsrc.start, rsrc.end + 1);

--
2.5.0


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)

From: thunder.leizhen@huawei.com (Zhen Lei)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 03/16] of/numa: add nid check for memory block
Date: Thu, 1 Sep 2016 14:54:54 +0800	[thread overview]
Message-ID: <1472712907-12700-4-git-send-email-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <1472712907-12700-1-git-send-email-thunder.leizhen@huawei.com>

If the numa-id which was configured in memory@ devicetree node is greater
than MAX_NUMNODES, we should report a warning. We have done this for cpus
and distance-map dt nodes, this patch help them to be consistent.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 drivers/of/of_numa.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
index 7b3fbdc..c1bd62c 100644
--- a/drivers/of/of_numa.c
+++ b/drivers/of/of_numa.c
@@ -75,6 +75,11 @@ static int __init of_numa_parse_memory_nodes(void)
 			 */
 			continue;

+		if (nid >= MAX_NUMNODES) {
+			pr_warn("NUMA: Node id %u exceeds maximum value\n", nid);
+			r = -EINVAL;
+		}
+
 		for (i = 0; !r && !of_address_to_resource(np, i, &rsrc); i++)
 			r = numa_add_memblk(nid, rsrc.start, rsrc.end + 1);

--
2.5.0

next prev parent reply	other threads:[~2016-09-01  6:56 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01  6:54 [PATCH v8 00/16] fix some type infos and bugs for arm64/of numa Zhen Lei
2016-09-01  6:54 ` Zhen Lei
2016-09-01  6:54 ` Zhen Lei
2016-09-01  6:54 ` Zhen Lei
2016-09-01  6:54 ` [PATCH v8 01/16] of/numa: remove a duplicated pr_debug information Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:54 ` [PATCH v8 02/16] of/numa: fix a memory@ node can only contains one memory block Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:54 ` Zhen Lei [this message]
2016-09-01  6:54   ` [PATCH v8 03/16] of/numa: add nid check for " Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-08 13:40   ` Rob Herring
2016-09-08 13:40     ` Rob Herring
2016-09-08 13:40     ` Rob Herring
2016-09-08 13:40     ` Rob Herring
2016-09-01  6:54 ` [PATCH v8 04/16] of/numa: remove a duplicated warning Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:54 ` [PATCH v8 05/16] arm64/numa: avoid inconsistent information to be printed Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:54 ` [PATCH v8 06/16] of_numa: Use of_get_next_parent to simplify code Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:54 ` [PATCH v8 07/16] of_numa: Use pr_fmt() Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:54 ` [PATCH v8 08/16] arm64: numa: " Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:54   ` Zhen Lei
2016-09-01  6:55 ` [PATCH v8 09/16] arm64/numa: support HAVE_SETUP_PER_CPU_AREA Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-01  6:55 ` [PATCH v8 10/16] mm/memblock: add a new function memblock_alloc_near_nid Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-09  3:49   ` Leizhen (ThunderTown)
2016-09-09  3:49     ` Leizhen (ThunderTown)
2016-09-09  3:49     ` Leizhen (ThunderTown)
2016-09-09  3:49     ` Leizhen (ThunderTown)
2016-10-11  1:44   ` Leizhen (ThunderTown)
2016-10-11  1:44     ` Leizhen (ThunderTown)
2016-10-11  1:44     ` Leizhen (ThunderTown)
2016-10-11 10:16     ` Will Deacon
2016-10-11 10:16       ` Will Deacon
2016-10-11 10:16       ` Will Deacon
2016-10-11 11:04       ` Leizhen (ThunderTown)
2016-10-11 11:04         ` Leizhen (ThunderTown)
2016-10-11 11:04         ` Leizhen (ThunderTown)
2016-10-11 11:04         ` Leizhen (ThunderTown)
2016-09-01  6:55 ` [PATCH v8 11/16] arm64/numa: support HAVE_MEMORYLESS_NODES Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-01  6:55 ` [PATCH v8 12/16] arm64/numa: remove some useless code Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-01  6:55 ` [PATCH v8 13/16] arm64/numa: remove the limitation that cpu0 must bind to node0 Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-01  6:55 ` [PATCH v8 14/16] of/numa: remove the constraint on the distances of node pairs Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-01  6:55 ` [PATCH v8 15/16] Documentation: " Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-01  6:55 ` [PATCH v8 16/16] arm64/numa: define numa_distance as array to simplify code Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-01  6:55   ` Zhen Lei
2016-09-08 11:01 ` [PATCH v8 00/16] fix some type infos and bugs for arm64/of numa Will Deacon
2016-09-08 11:01   ` Will Deacon
2016-09-08 11:01   ` Will Deacon
2016-09-08 11:01   ` Will Deacon
2016-09-09  2:07   ` Leizhen (ThunderTown)
2016-09-09  2:07     ` Leizhen (ThunderTown)
2016-09-09  2:07     ` Leizhen (ThunderTown)
2016-09-09  2:07     ` Leizhen (ThunderTown)

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:7b3fbdc dfblob:7b3fbdc dfblob:7b3fbdc dfblob:c1bd62c
dfblob:c1bd62c dfblob:c1bd62c
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472712907-12700-4-git-send-email-thunder.leizhen@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dingtianhong@huawei.com \
    --cc=frowand.list@gmail.com \
    --cc=guohanjun@huawei.com \
    --cc=huxinwei@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan@huawei.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.