From: Jeff Layton <jlayton@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available
Date: Fri, 18 Nov 2016 07:01:49 -0500 [thread overview]
Message-ID: <1479470509.2563.3.camel@redhat.com> (raw)
In-Reply-To: <25389.1479458901@warthog.procyon.org.uk>
On Fri, 2016-11-18 at 08:48 +0000, David Howells wrote:
> Jeff Layton <jlayton@redhat.com> wrote:
>
> >
> > >
> > > If neither AT_STATX_*_SYNC flag is set, the behaviour is the default for
> > > stat() on that filesystem.
> > >
> >
> > We also need to specify here what happens if both bits are set. Should
> > that be -EINVAL?
>
> Makes sense.
>
> This leads to another thought: should fstatat() be allowed to take AT_STATX_*
> flags?
>
> David
In principle, we could. fstatat currently rejects flags that it doesn't
understand with -EINVAL.
That said, I'd vote no -- if you wanted to change an application to
start setting these flags in fstatat calls, then it's just as simple to
convert it over to use statx. I don't see a lot of benefit in adding
that to a legacy syscall.
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2016-11-18 12:02 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 13:34 [RFC][PATCH 0/4] Enhanced file stat system call David Howells
2016-11-17 13:35 ` [PATCH 1/4] statx: Add a system call to make enhanced file info available David Howells
2016-11-17 18:39 ` Jeff Layton
2016-11-18 2:32 ` Andreas Dilger
2016-11-18 8:59 ` David Howells
2016-11-18 8:59 ` David Howells
2016-11-18 9:25 ` Andreas Dilger
2016-11-18 9:25 ` Andreas Dilger
2016-11-17 23:40 ` Dave Chinner
2016-11-18 3:28 ` Andreas Dilger
2016-11-18 22:07 ` Dave Chinner
2016-11-18 22:54 ` David Howells
2016-11-19 22:43 ` Dave Chinner
2016-11-21 14:30 ` One Thousand Gnomes
2016-11-21 20:43 ` Dave Chinner
2016-11-22 10:39 ` David Howells
2016-11-22 13:55 ` Jeff Layton
2016-11-22 20:58 ` Dave Chinner
2016-11-18 9:53 ` David Howells
2016-11-18 8:48 ` David Howells
2016-11-18 12:01 ` Jeff Layton [this message]
2016-11-18 9:36 ` David Howells
2016-11-18 17:17 ` Jeff Layton
2016-11-18 18:04 ` David Howells
2016-11-18 18:54 ` Jeff Layton
2016-11-18 19:08 ` David Howells
2016-11-18 9:43 ` David Howells
2016-11-18 21:41 ` Dave Chinner
2016-11-18 22:24 ` David Howells
2016-11-18 10:29 ` David Howells
2016-11-18 10:29 ` David Howells
2016-11-18 21:27 ` Dave Chinner
2016-11-18 21:48 ` David Howells
2016-11-18 21:48 ` David Howells
2016-11-18 22:17 ` Dave Chinner
2016-11-18 22:17 ` Dave Chinner
2016-11-19 10:21 ` Michael Kerrisk (man-pages)
2016-11-17 13:35 ` [PATCH 2/4] statx: Ext4: Return enhanced file attributes David Howells
2016-11-18 3:30 ` Andreas Dilger
2016-11-17 13:35 ` [PATCH 3/4] statx: NFS: " David Howells
2016-11-17 13:35 ` [PATCH 4/4] statx: AFS: " David Howells
2016-11-18 3:34 ` Andreas Dilger
2016-11-18 8:47 ` David Howells
2016-11-17 14:39 ` [RFC][PATCH 0/4] Enhanced file stat system call One Thousand Gnomes
2016-11-17 15:10 ` Michael Kerrisk
2016-11-17 16:33 ` David Howells
2016-11-17 16:45 ` David Howells
2016-11-17 20:00 ` J. Bruce Fields
2016-11-18 2:30 ` Andreas Dilger
2016-11-18 4:29 ` NeilBrown
2016-11-18 13:41 ` One Thousand Gnomes
2016-11-18 13:49 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479470509.2563.3.camel@redhat.com \
--to=jlayton@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.