[PATCH] doc: fix parameter of virtio_user for container

[PATCH] doc: fix parameter of virtio_user for container

[Yong Wang]

Update the "Virtio_user for Container Networking" doc, add the
"--file-prefix" option to testpmd in host and container to avoid
hugepage config file conflict.

Fixes: 50665deebda0 ("doc: add guide to use virtio-user for container
networking")

Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
 doc/guides/howto/virtio_user_for_container_networking.rst | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/doc/guides/howto/virtio_user_for_container_networking.rst b/doc/guides/howto/virtio_user_for_container_networking.rst
index dbb9319..d08a5e3 100644
--- a/doc/guides/howto/virtio_user_for_container_networking.rst
+++ b/doc/guides/howto/virtio_user_for_container_networking.rst
@@ -111,7 +111,8 @@ some minor changes.
     .. code-block:: console
 
         $(testpmd) -l 0-1 -n 4 --socket-mem 1024,1024 \
-            --vdev 'eth_vhost0,iface=/tmp/sock0' --no-pci -- -i
+            --vdev 'eth_vhost0,iface=/tmp/sock0' \
+            --file-prefix=host_ --no-pci -- -i
 
 #. Start a container instance with a virtio-user port.
 
@@ -121,6 +122,7 @@ some minor changes.
             -v /dev/hugepages:/dev/hugepages \
             dpdk-app-testpmd testpmd -l 6-7 -n 4 -m 1024 --no-pci \
             --vdev=virtio_user0,path=/var/run/usvhost \
+            --file-prefix=container_ \
 	    -- -i --txqflags=0xf00 --disable-hw-vlan
 
 Note: If we run all above setup on the host, it's a shm-based IPC.
-- 
1.8.3.1

Re: [PATCH] doc: fix parameter of virtio_user for container

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yong Wang
> Sent: Tuesday, March 7, 2017 1:49 PM
> To: Tan, Jianfeng <jianfeng.tan@intel.com>; yuanhan.liu@linux.intel.com
> Cc: dev@dpdk.org; Yong Wang <wang.yong19@zte.com.cn>
> Subject: [dpdk-dev] [PATCH] doc: fix parameter of virtio_user for
> container
> 
> Update the "Virtio_user for Container Networking" doc, add the "--file-
> prefix" option to testpmd in host and container to avoid hugepage config
> file conflict.
> 
> Fixes: 50665deebda0 ("doc: add guide to use virtio-user for container
> networking")
> 

Acked-by: John McNamara <john.mcnamara@intel.com>

Re: [PATCH] doc: fix parameter of virtio_user for container

[Yuanhan Liu]

On Tue, Mar 07, 2017 at 08:48:45AM -0500, Yong Wang wrote:
> Update the "Virtio_user for Container Networking" doc, add the
> "--file-prefix" option to testpmd in host and container to avoid
> hugepage config file conflict.
> 
> Fixes: 50665deebda0 ("doc: add guide to use virtio-user for container
> networking")

Fixline should be one line: don't break it to two.

> 
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
>  doc/guides/howto/virtio_user_for_container_networking.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/howto/virtio_user_for_container_networking.rst b/doc/guides/howto/virtio_user_for_container_networking.rst
> index dbb9319..d08a5e3 100644
> --- a/doc/guides/howto/virtio_user_for_container_networking.rst
> +++ b/doc/guides/howto/virtio_user_for_container_networking.rst
> @@ -111,7 +111,8 @@ some minor changes.
>      .. code-block:: console
>  
>          $(testpmd) -l 0-1 -n 4 --socket-mem 1024,1024 \
> -            --vdev 'eth_vhost0,iface=/tmp/sock0' --no-pci -- -i
> +            --vdev 'eth_vhost0,iface=/tmp/sock0' \
> +            --file-prefix=host_ --no-pci -- -i

Though it's okay to add the "_", it looks a bit weird. I'd like to
remove it.

Besides that,

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>


	--yliu
>  
>  #. Start a container instance with a virtio-user port.
>  
> @@ -121,6 +122,7 @@ some minor changes.
>              -v /dev/hugepages:/dev/hugepages \
>              dpdk-app-testpmd testpmd -l 6-7 -n 4 -m 1024 --no-pci \
>              --vdev=virtio_user0,path=/var/run/usvhost \
> +            --file-prefix=container_ \
>  	    -- -i --txqflags=0xf00 --disable-hw-vlan
>  
>  Note: If we run all above setup on the host, it's a shm-based IPC.
> -- 
> 1.8.3.1
>