From: Mark Rutland <mark.rutland@arm.com> To: linux-arm-kernel@lists.infradead.org Cc: marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, kvmarm@lists.cs.columbia.edu Subject: [PATCH 00/15] arm64/kvm: use common sysreg definitions Date: Thu, 9 Mar 2017 17:07:12 +0000 [thread overview] Message-ID: <1489079247-31092-1-git-send-email-mark.rutland@arm.com> (raw) Currently we duplicate effort in maintaining system register encodings across arm64's <asm/sysreg.h>, KVM's sysreg tables, and other places. This redundancy is unfortunate, and as encodings are encoded in-place without any mnemonic, this ends up more painful to read than necessary. This series ameliorates this by making <asm/sysreg.h> the canonical location for (architected) system register encodings, with other users building atop of this, e.g. with KVM deriving its sysreg table values from the common mnemonics. I've only attacked AArch64-native SYS encodings, and ignored CP{15,14} registers for now, but these could be handled similarly. Largely, I've stuck to only what KVM needs, though for the debug and perfmon groups it was easier to take the whole group from the ARM ARM than to filter them to only what KVM needed today. To verify that I haven't accidentally broken KVM, I've diffed sys_regs.o and sys_regs_generic_v8.o on a section-by-section basis before and after the series is applied. The .text, .data, and .rodata sections (and most others) are identical. The __bug_table section, and some .debug* sections differ, and this appears to be due to line numbers changing due to removed lines. One thing I wasn't sure how to address was banks of registers such as PMEVCNTR<n>_EL0. We currently enumerate all cases for our GICv3 definitions, but it seemed painful to expand ~30 cases for PMEVCNTR<n>_EL0 and friends, and for these I've made the macros take an 'n' parameter. It would be nice to be consistent either way, and I'm happy to expand those cases. I've pushed thes series out to a branch [1] based on v4.11-rc1. It looks like git rebase is also happy to apply the patches atop of the kvm-arm-for-4.11-rc2 tag. Thanks, Mark. Since RFC [2]: * Rebase to v4.11-rc1, solving a trivial conflict. * Handle the physical counter registers. * Verified section differences again. Thanks, Mark. [1] git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git arm64/common-sysreg [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-January/484693.html Mark Rutland (15): arm64: sysreg: sort by encoding arm64: sysreg: add debug system registers arm64: sysreg: add performance monitor registers arm64: sysreg: subsume GICv3 sysreg definitions arm64: sysreg: add physical timer registers arm64: sysreg: add register encodings used by KVM arm64: sysreg: add Set/Way sys encodings KVM: arm64: add SYS_DESC() KVM: arm64: Use common debug sysreg definitions KVM: arm64: Use common performance monitor sysreg definitions KVM: arm64: Use common GICv3 sysreg definitions KVM: arm64: Use common physical timer sysreg definitions KVM: arm64: use common invariant sysreg definitions KVM: arm64: Use common sysreg definitions KVM: arm64: Use common Set/Way sys definitions arch/arm64/include/asm/arch_gicv3.h | 81 ++------ arch/arm64/include/asm/sysreg.h | 162 +++++++++++++++- arch/arm64/kernel/head.S | 8 +- arch/arm64/kvm/sys_regs.c | 358 +++++++++++------------------------ arch/arm64/kvm/sys_regs.h | 5 + arch/arm64/kvm/sys_regs_generic_v8.c | 4 +- 6 files changed, 284 insertions(+), 334 deletions(-) -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 00/15] arm64/kvm: use common sysreg definitions Date: Thu, 9 Mar 2017 17:07:12 +0000 [thread overview] Message-ID: <1489079247-31092-1-git-send-email-mark.rutland@arm.com> (raw) Currently we duplicate effort in maintaining system register encodings across arm64's <asm/sysreg.h>, KVM's sysreg tables, and other places. This redundancy is unfortunate, and as encodings are encoded in-place without any mnemonic, this ends up more painful to read than necessary. This series ameliorates this by making <asm/sysreg.h> the canonical location for (architected) system register encodings, with other users building atop of this, e.g. with KVM deriving its sysreg table values from the common mnemonics. I've only attacked AArch64-native SYS encodings, and ignored CP{15,14} registers for now, but these could be handled similarly. Largely, I've stuck to only what KVM needs, though for the debug and perfmon groups it was easier to take the whole group from the ARM ARM than to filter them to only what KVM needed today. To verify that I haven't accidentally broken KVM, I've diffed sys_regs.o and sys_regs_generic_v8.o on a section-by-section basis before and after the series is applied. The .text, .data, and .rodata sections (and most others) are identical. The __bug_table section, and some .debug* sections differ, and this appears to be due to line numbers changing due to removed lines. One thing I wasn't sure how to address was banks of registers such as PMEVCNTR<n>_EL0. We currently enumerate all cases for our GICv3 definitions, but it seemed painful to expand ~30 cases for PMEVCNTR<n>_EL0 and friends, and for these I've made the macros take an 'n' parameter. It would be nice to be consistent either way, and I'm happy to expand those cases. I've pushed thes series out to a branch [1] based on v4.11-rc1. It looks like git rebase is also happy to apply the patches atop of the kvm-arm-for-4.11-rc2 tag. Thanks, Mark. Since RFC [2]: * Rebase to v4.11-rc1, solving a trivial conflict. * Handle the physical counter registers. * Verified section differences again. Thanks, Mark. [1] git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git arm64/common-sysreg [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-January/484693.html Mark Rutland (15): arm64: sysreg: sort by encoding arm64: sysreg: add debug system registers arm64: sysreg: add performance monitor registers arm64: sysreg: subsume GICv3 sysreg definitions arm64: sysreg: add physical timer registers arm64: sysreg: add register encodings used by KVM arm64: sysreg: add Set/Way sys encodings KVM: arm64: add SYS_DESC() KVM: arm64: Use common debug sysreg definitions KVM: arm64: Use common performance monitor sysreg definitions KVM: arm64: Use common GICv3 sysreg definitions KVM: arm64: Use common physical timer sysreg definitions KVM: arm64: use common invariant sysreg definitions KVM: arm64: Use common sysreg definitions KVM: arm64: Use common Set/Way sys definitions arch/arm64/include/asm/arch_gicv3.h | 81 ++------ arch/arm64/include/asm/sysreg.h | 162 +++++++++++++++- arch/arm64/kernel/head.S | 8 +- arch/arm64/kvm/sys_regs.c | 358 +++++++++++------------------------ arch/arm64/kvm/sys_regs.h | 5 + arch/arm64/kvm/sys_regs_generic_v8.c | 4 +- 6 files changed, 284 insertions(+), 334 deletions(-) -- 1.9.1
next reply other threads:[~2017-03-09 17:06 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-09 17:07 Mark Rutland [this message] 2017-03-09 17:07 ` [PATCH 00/15] arm64/kvm: use common sysreg definitions Mark Rutland 2017-03-09 17:07 ` [PATCH 01/15] arm64: sysreg: sort by encoding Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-09 17:07 ` [PATCH 02/15] arm64: sysreg: add debug system registers Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-09 17:07 ` [PATCH 03/15] arm64: sysreg: add performance monitor registers Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-09 17:07 ` [PATCH 04/15] arm64: sysreg: subsume GICv3 sysreg definitions Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-09 17:07 ` [PATCH 05/15] arm64: sysreg: add physical timer registers Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-09 17:07 ` [PATCH 06/15] arm64: sysreg: add register encodings used by KVM Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-09 17:07 ` [PATCH 07/15] arm64: sysreg: add Set/Way sys encodings Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-09 17:07 ` [PATCH 08/15] KVM: arm64: add SYS_DESC() Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-09 17:07 ` [PATCH 09/15] KVM: arm64: Use common debug sysreg definitions Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-09 17:07 ` [PATCH 10/15] KVM: arm64: Use common performance monitor " Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-09 17:07 ` [PATCH 11/15] KVM: arm64: Use common GICv3 " Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-09 17:07 ` [PATCH 12/15] KVM: arm64: Use common physical timer " Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-09 17:07 ` [PATCH 13/15] KVM: arm64: use common invariant " Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-09 17:07 ` [PATCH 14/15] KVM: arm64: Use common " Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-09 17:07 ` [PATCH 15/15] KVM: arm64: Use common Set/Way sys definitions Mark Rutland 2017-03-09 17:07 ` Mark Rutland 2017-03-10 8:17 ` [PATCH 00/15] arm64/kvm: use common sysreg definitions Marc Zyngier 2017-03-10 8:17 ` Marc Zyngier 2017-03-10 18:35 ` Will Deacon 2017-03-10 18:35 ` Will Deacon 2017-03-10 18:42 ` Mark Rutland 2017-03-10 18:42 ` Mark Rutland 2017-03-11 11:06 ` Marc Zyngier 2017-03-11 11:06 ` Marc Zyngier 2017-03-22 18:35 ` Mark Rutland 2017-03-22 18:35 ` Mark Rutland 2017-03-28 18:48 ` Mark Rutland 2017-03-28 18:48 ` Mark Rutland 2017-03-28 20:29 ` Christoffer Dall 2017-03-28 20:29 ` Christoffer Dall 2017-03-29 8:41 ` Will Deacon 2017-03-29 8:41 ` Will Deacon 2017-03-29 9:55 ` Mark Rutland 2017-03-29 9:55 ` Mark Rutland 2017-04-04 17:11 ` Catalin Marinas 2017-04-04 17:11 ` Catalin Marinas 2017-03-15 9:07 ` Christoffer Dall 2017-03-15 9:07 ` Christoffer Dall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1489079247-31092-1-git-send-email-mark.rutland@arm.com \ --to=mark.rutland@arm.com \ --cc=catalin.marinas@arm.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.