[PATCH] vmcore-dmesg: Define _GNU_SOURCE

[PATCH] vmcore-dmesg: Define _GNU_SOURCE

[Khem Raj]

loff_t is guarded with _GNU_SOURCE on some C library implementations
e.g. musl since this type is not defined by POSIX. Define _GNU_SOURCE to
include this define, it should help compiling on musl while nothing
changes for glibc based systems since there _GNU_SOURCE is already
defined

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 vmcore-dmesg/vmcore-dmesg.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/vmcore-dmesg/vmcore-dmesg.c b/vmcore-dmesg/vmcore-dmesg.c
index 0364636..a8f56df 100644
--- a/vmcore-dmesg/vmcore-dmesg.c
+++ b/vmcore-dmesg/vmcore-dmesg.c
@@ -1,4 +1,5 @@
 #define _XOPEN_SOURCE 600
+#define _GNU_SOURCE
 #define _LARGEFILE_SOURCE 1
 #define _FILE_OFFSET_BITS 64
 #include <endian.h>
-- 
2.7.0


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] vmcore-dmesg: Define _GNU_SOURCE

[David Woodhouse]

[-- Attachment #1.1: Type: text/plain, Size: 865 bytes --]

On Sat, 2016-01-09 at 17:21 -0800, Khem Raj wrote:
> loff_t is guarded with _GNU_SOURCE on some C library implementations
> e.g. musl since this type is not defined by POSIX. Define _GNU_SOURCE to
> include this define, it should help compiling on musl while nothing
> changes for glibc based systems since there _GNU_SOURCE is already
> defined
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

This appears to still be needed...

> ---
>  vmcore-dmesg/vmcore-dmesg.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/vmcore-dmesg/vmcore-dmesg.c b/vmcore-dmesg/vmcore-dmesg.c
> index 0364636..a8f56df 100644
> --- a/vmcore-dmesg/vmcore-dmesg.c
> +++ b/vmcore-dmesg/vmcore-dmesg.c
> @@ -1,4 +1,5 @@
>  #define _XOPEN_SOURCE 600
> +#define _GNU_SOURCE
>  #define _LARGEFILE_SOURCE 1
>  #define _FILE_OFFSET_BITS 64
>  #include 

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 4938 bytes --]

[-- Attachment #2: Type: text/plain, Size: 143 bytes --]

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] vmcore-dmesg: Define _GNU_SOURCE

[Simon Horman]

On Wed, Mar 08, 2017 at 08:44:40PM +0100, David Woodhouse wrote:
> On Sat, 2016-01-09 at 17:21 -0800, Khem Raj wrote:
> > loff_t is guarded with _GNU_SOURCE on some C library implementations
> > e.g. musl since this type is not defined by POSIX. Define _GNU_SOURCE to
> > include this define, it should help compiling on musl while nothing
> > changes for glibc based systems since there _GNU_SOURCE is already
> > defined
> > 
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> 
> This appears to still be needed...

For some reason it did not hit my inbox :(

Shall I pick up the version you reposted as PATCH 7/7 ?

> > ---
> >  vmcore-dmesg/vmcore-dmesg.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/vmcore-dmesg/vmcore-dmesg.c b/vmcore-dmesg/vmcore-dmesg.c
> > index 0364636..a8f56df 100644
> > --- a/vmcore-dmesg/vmcore-dmesg.c
> > +++ b/vmcore-dmesg/vmcore-dmesg.c
> > @@ -1,4 +1,5 @@
> >  #define _XOPEN_SOURCE 600
> > +#define _GNU_SOURCE
> >  #define _LARGEFILE_SOURCE 1
> >  #define _FILE_OFFSET_BITS 64
> >  #include 



> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] vmcore-dmesg: Define _GNU_SOURCE

[David Woodhouse]

[-- Attachment #1.1: Type: text/plain, Size: 380 bytes --]

On Fri, 2017-03-10 at 10:12 +0100, Simon Horman wrote:
> 
> For some reason it did not hit my inbox :(
> 
> Shall I pick up the version you reposted as PATCH 7/7 ?

That works. There's a github PR too if that's easier to consume. Which
wasn't *intended* to include this patch as it was for the uImage bits,
but I made it from the wrong branch and didn't bother to redo it.

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 4938 bytes --]

[-- Attachment #2: Type: text/plain, Size: 143 bytes --]

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] vmcore-dmesg: Define _GNU_SOURCE

[Simon Horman]

On Fri, Mar 10, 2017 at 10:38:35AM +0100, David Woodhouse wrote:
> On Fri, 2017-03-10 at 10:12 +0100, Simon Horman wrote:
> > 
> > For some reason it did not hit my inbox :(
> > 
> > Shall I pick up the version you reposted as PATCH 7/7 ?
> 
> That works. There's a github PR too if that's easier to consume. Which
> wasn't *intended* to include this patch as it was for the uImage bits,
> but I made it from the wrong branch and didn't bother to redo it.

Thanks, its rather convenient for me that it did include the patch in
question. I have applied the series.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec