* [PATCH] vmcore-dmesg: Define _GNU_SOURCE
@ 2016-01-10 1:21 Khem Raj
2017-03-08 19:44 ` David Woodhouse
0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2016-01-10 1:21 UTC (permalink / raw)
To: kexec; +Cc: horms, Khem Raj
loff_t is guarded with _GNU_SOURCE on some C library implementations
e.g. musl since this type is not defined by POSIX. Define _GNU_SOURCE to
include this define, it should help compiling on musl while nothing
changes for glibc based systems since there _GNU_SOURCE is already
defined
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
vmcore-dmesg/vmcore-dmesg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/vmcore-dmesg/vmcore-dmesg.c b/vmcore-dmesg/vmcore-dmesg.c
index 0364636..a8f56df 100644
--- a/vmcore-dmesg/vmcore-dmesg.c
+++ b/vmcore-dmesg/vmcore-dmesg.c
@@ -1,4 +1,5 @@
#define _XOPEN_SOURCE 600
+#define _GNU_SOURCE
#define _LARGEFILE_SOURCE 1
#define _FILE_OFFSET_BITS 64
#include <endian.h>
--
2.7.0
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] vmcore-dmesg: Define _GNU_SOURCE
2016-01-10 1:21 [PATCH] vmcore-dmesg: Define _GNU_SOURCE Khem Raj
@ 2017-03-08 19:44 ` David Woodhouse
2017-03-10 9:12 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: David Woodhouse @ 2017-03-08 19:44 UTC (permalink / raw)
To: Khem Raj, kexec; +Cc: horms
[-- Attachment #1.1: Type: text/plain, Size: 865 bytes --]
On Sat, 2016-01-09 at 17:21 -0800, Khem Raj wrote:
> loff_t is guarded with _GNU_SOURCE on some C library implementations
> e.g. musl since this type is not defined by POSIX. Define _GNU_SOURCE to
> include this define, it should help compiling on musl while nothing
> changes for glibc based systems since there _GNU_SOURCE is already
> defined
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
This appears to still be needed...
> ---
> vmcore-dmesg/vmcore-dmesg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vmcore-dmesg/vmcore-dmesg.c b/vmcore-dmesg/vmcore-dmesg.c
> index 0364636..a8f56df 100644
> --- a/vmcore-dmesg/vmcore-dmesg.c
> +++ b/vmcore-dmesg/vmcore-dmesg.c
> @@ -1,4 +1,5 @@
> #define _XOPEN_SOURCE 600
> +#define _GNU_SOURCE
> #define _LARGEFILE_SOURCE 1
> #define _FILE_OFFSET_BITS 64
> #include
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 4938 bytes --]
[-- Attachment #2: Type: text/plain, Size: 143 bytes --]
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] vmcore-dmesg: Define _GNU_SOURCE
2017-03-08 19:44 ` David Woodhouse
@ 2017-03-10 9:12 ` Simon Horman
2017-03-10 9:38 ` David Woodhouse
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2017-03-10 9:12 UTC (permalink / raw)
To: David Woodhouse; +Cc: kexec, Khem Raj
On Wed, Mar 08, 2017 at 08:44:40PM +0100, David Woodhouse wrote:
> On Sat, 2016-01-09 at 17:21 -0800, Khem Raj wrote:
> > loff_t is guarded with _GNU_SOURCE on some C library implementations
> > e.g. musl since this type is not defined by POSIX. Define _GNU_SOURCE to
> > include this define, it should help compiling on musl while nothing
> > changes for glibc based systems since there _GNU_SOURCE is already
> > defined
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
>
> This appears to still be needed...
For some reason it did not hit my inbox :(
Shall I pick up the version you reposted as PATCH 7/7 ?
> > ---
> > vmcore-dmesg/vmcore-dmesg.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/vmcore-dmesg/vmcore-dmesg.c b/vmcore-dmesg/vmcore-dmesg.c
> > index 0364636..a8f56df 100644
> > --- a/vmcore-dmesg/vmcore-dmesg.c
> > +++ b/vmcore-dmesg/vmcore-dmesg.c
> > @@ -1,4 +1,5 @@
> > #define _XOPEN_SOURCE 600
> > +#define _GNU_SOURCE
> > #define _LARGEFILE_SOURCE 1
> > #define _FILE_OFFSET_BITS 64
> > #include
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] vmcore-dmesg: Define _GNU_SOURCE
2017-03-10 9:12 ` Simon Horman
@ 2017-03-10 9:38 ` David Woodhouse
2017-03-13 9:04 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: David Woodhouse @ 2017-03-10 9:38 UTC (permalink / raw)
To: Simon Horman; +Cc: kexec, Khem Raj
[-- Attachment #1.1: Type: text/plain, Size: 380 bytes --]
On Fri, 2017-03-10 at 10:12 +0100, Simon Horman wrote:
>
> For some reason it did not hit my inbox :(
>
> Shall I pick up the version you reposted as PATCH 7/7 ?
That works. There's a github PR too if that's easier to consume. Which
wasn't *intended* to include this patch as it was for the uImage bits,
but I made it from the wrong branch and didn't bother to redo it.
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 4938 bytes --]
[-- Attachment #2: Type: text/plain, Size: 143 bytes --]
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] vmcore-dmesg: Define _GNU_SOURCE
2017-03-10 9:38 ` David Woodhouse
@ 2017-03-13 9:04 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2017-03-13 9:04 UTC (permalink / raw)
To: David Woodhouse; +Cc: kexec, Khem Raj
On Fri, Mar 10, 2017 at 10:38:35AM +0100, David Woodhouse wrote:
> On Fri, 2017-03-10 at 10:12 +0100, Simon Horman wrote:
> >
> > For some reason it did not hit my inbox :(
> >
> > Shall I pick up the version you reposted as PATCH 7/7 ?
>
> That works. There's a github PR too if that's easier to consume. Which
> wasn't *intended* to include this patch as it was for the uImage bits,
> but I made it from the wrong branch and didn't bother to redo it.
Thanks, its rather convenient for me that it did include the patch in
question. I have applied the series.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-13 9:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-10 1:21 [PATCH] vmcore-dmesg: Define _GNU_SOURCE Khem Raj
2017-03-08 19:44 ` David Woodhouse
2017-03-10 9:12 ` Simon Horman
2017-03-10 9:38 ` David Woodhouse
2017-03-13 9:04 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.