All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: gnomes@lxorguk.ukuu.org.uk, linux-efi@vger.kernel.org,
	matthew.garrett@nebula.com, gregkh@linuxfoundation.org,
	dhowells@redhat.com, linux-security-module@vger.kernel.org,
	keyrings@vger.kernel.org, Jiri Slaby <jslaby@suse.com>
Subject: [PATCH 23/24] Lock down TIOCSSERIAL
Date: Wed, 05 Apr 2017 21:17:55 +0100	[thread overview]
Message-ID: <149142347499.5101.36103180891744344.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <149142326734.5101.4596394505987813763.stgit@warthog.procyon.org.uk>

Lock down TIOCSSERIAL as that can be used to change the ioport and irq
settings on a serial port.  This only appears to be an issue for the serial
drivers that use the core serial code.  All other drivers seem to either
ignore attempts to change port/irq or give an error.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Jiri Slaby <jslaby@suse.com>
---

 drivers/tty/serial/serial_core.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 3fe56894974a..4181b0004de9 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -821,6 +821,12 @@ static int uart_set_info(struct tty_struct *tty, struct tty_port *port,
 	new_flags = new_info->flags;
 	old_custom_divisor = uport->custom_divisor;
 
+	if ((change_port || change_irq) && kernel_is_locked_down()) {
+		pr_err("Using TIOCSSERIAL to change device addresses, irqs and dma channels is not permitted when the kernel is locked down\n");
+		retval = -EPERM;
+		goto exit;
+	}
+
 	if (!capable(CAP_SYS_ADMIN)) {
 		retval = -EPERM;
 		if (change_irq || change_port ||

WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: gnomes-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	keyrings-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Jiri Slaby <jslaby-IBi9RG/b67k@public.gmane.org>
Subject: [PATCH 23/24] Lock down TIOCSSERIAL
Date: Wed, 05 Apr 2017 21:17:55 +0100	[thread overview]
Message-ID: <149142347499.5101.36103180891744344.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <149142326734.5101.4596394505987813763.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>

Lock down TIOCSSERIAL as that can be used to change the ioport and irq
settings on a serial port.  This only appears to be an issue for the serial
drivers that use the core serial code.  All other drivers seem to either
ignore attempts to change port/irq or give an error.

Reported-by: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Signed-off-by: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
cc: Jiri Slaby <jslaby-IBi9RG/b67k@public.gmane.org>
---

 drivers/tty/serial/serial_core.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 3fe56894974a..4181b0004de9 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -821,6 +821,12 @@ static int uart_set_info(struct tty_struct *tty, struct tty_port *port,
 	new_flags = new_info->flags;
 	old_custom_divisor = uport->custom_divisor;
 
+	if ((change_port || change_irq) && kernel_is_locked_down()) {
+		pr_err("Using TIOCSSERIAL to change device addresses, irqs and dma channels is not permitted when the kernel is locked down\n");
+		retval = -EPERM;
+		goto exit;
+	}
+
 	if (!capable(CAP_SYS_ADMIN)) {
 		retval = -EPERM;
 		if (change_irq || change_port ||

WARNING: multiple messages have this Message-ID (diff)
From: dhowells@redhat.com (David Howells)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 23/24] Lock down TIOCSSERIAL
Date: Wed, 05 Apr 2017 21:17:55 +0100	[thread overview]
Message-ID: <149142347499.5101.36103180891744344.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <149142326734.5101.4596394505987813763.stgit@warthog.procyon.org.uk>

Lock down TIOCSSERIAL as that can be used to change the ioport and irq
settings on a serial port.  This only appears to be an issue for the serial
drivers that use the core serial code.  All other drivers seem to either
ignore attempts to change port/irq or give an error.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Jiri Slaby <jslaby@suse.com>
---

 drivers/tty/serial/serial_core.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 3fe56894974a..4181b0004de9 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -821,6 +821,12 @@ static int uart_set_info(struct tty_struct *tty, struct tty_port *port,
 	new_flags = new_info->flags;
 	old_custom_divisor = uport->custom_divisor;
 
+	if ((change_port || change_irq) && kernel_is_locked_down()) {
+		pr_err("Using TIOCSSERIAL to change device addresses, irqs and dma channels is not permitted when the kernel is locked down\n");
+		retval = -EPERM;
+		goto exit;
+	}
+
 	if (!capable(CAP_SYS_ADMIN)) {
 		retval = -EPERM;
 		if (change_irq || change_port ||

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-04-05 20:18 UTC|newest]

Thread overview: 211+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 20:14 [PATCH 00/24] Kernel lockdown David Howells
2017-04-05 20:14 ` David Howells
2017-04-05 20:14 ` [PATCH 01/24] efi: Add EFI_SECURE_BOOT bit David Howells
2017-04-05 20:14   ` David Howells
2017-04-06  8:26   ` Ard Biesheuvel
2017-04-06  8:26     ` Ard Biesheuvel
2017-04-06  8:48   ` David Howells
2017-04-06  8:48     ` David Howells
2017-04-05 20:14 ` [PATCH 02/24] Add the ability to lock down access to the running kernel image David Howells
2017-04-05 20:14   ` David Howells
2017-04-05 20:14   ` David Howells
2017-04-05 20:14 ` [PATCH 03/24] efi: Lock down the kernel if booted in secure boot mode David Howells
2017-04-05 20:14   ` David Howells
2017-04-05 20:15 ` [PATCH 04/24] Enforce module signatures if the kernel is locked down David Howells
2017-04-05 20:15   ` David Howells
2017-04-05 20:15 ` [PATCH 05/24] Restrict /dev/mem and /dev/kmem when " David Howells
2017-04-05 20:15   ` David Howells
2017-04-05 20:15 ` [PATCH 06/24] Add a sysrq option to exit secure boot mode David Howells
2017-04-05 20:15   ` David Howells
2017-04-14 18:05   ` Thomas Gleixner
2017-04-14 18:05     ` Thomas Gleixner
2017-04-14 18:05     ` Thomas Gleixner
2017-04-14 18:15     ` Ard Biesheuvel
2017-04-14 18:15       ` Ard Biesheuvel
2017-04-14 18:15       ` Ard Biesheuvel
2017-04-14 23:16     ` David Howells
2017-04-14 23:16       ` David Howells
2017-04-14 23:16       ` David Howells
2017-04-16 20:46     ` Matt Fleming
2017-04-16 20:46       ` Matt Fleming
2017-04-16 20:46       ` Matt Fleming
2017-04-05 20:15 ` [PATCH 07/24] kexec: Disable at runtime if the kernel is locked down David Howells
2017-04-05 20:15   ` David Howells
2017-04-05 20:15   ` David Howells
2017-04-07  3:07   ` Dave Young
2017-04-07  3:07     ` Dave Young
2017-04-07  3:07     ` Dave Young
2017-04-07  3:07     ` Dave Young
2017-04-05 20:15 ` [PATCH 08/24] Copy secure_boot flag in boot params across kexec reboot David Howells
2017-04-05 20:15   ` David Howells
2017-04-05 20:15   ` David Howells
2017-04-05 20:15 ` [PATCH 09/24] kexec_file: Disable at runtime if securelevel has been set David Howells
2017-04-05 20:15   ` David Howells
2017-04-05 20:15   ` David Howells
2017-04-05 20:15   ` David Howells
2017-04-07  3:05   ` Dave Young
2017-04-07  3:05     ` Dave Young
2017-04-07  3:05     ` Dave Young
2017-04-07  3:05     ` Dave Young
2017-04-07  3:49     ` Mimi Zohar
2017-04-07  3:49       ` Mimi Zohar
2017-04-07  3:49       ` Mimi Zohar
2017-04-07  6:19       ` Dave Young
2017-04-07  6:19         ` Dave Young
2017-04-07  6:19         ` Dave Young
2017-04-07  6:19         ` Dave Young
2017-04-07  7:45         ` Mimi Zohar
2017-04-07  7:45           ` Mimi Zohar
2017-04-07  7:45           ` Mimi Zohar
2017-04-07  8:01           ` Dave Young
2017-04-07  8:01             ` Dave Young
2017-04-07  8:01             ` Dave Young
2017-04-07  7:07       ` David Howells
2017-04-07  7:07         ` David Howells
2017-04-07  7:07         ` David Howells
2017-04-07  7:41         ` Dave Young
2017-04-07  7:41           ` Dave Young
2017-04-07  7:41           ` Dave Young
2017-04-07  7:41           ` Dave Young
2017-04-07  8:28           ` Mimi Zohar
2017-04-07  8:28             ` Mimi Zohar
2017-04-07  8:28             ` Mimi Zohar
2017-04-07  8:28             ` Mimi Zohar
2017-04-07  8:42             ` Dave Young
2017-04-07  8:42               ` Dave Young
2017-04-07  8:42               ` Dave Young
2017-04-07  8:42               ` Dave Young
2017-04-07  7:09     ` David Howells
2017-04-07  7:09       ` David Howells
2017-04-07  7:09       ` David Howells
2017-04-07  7:46       ` Mimi Zohar
2017-04-07  7:46         ` Mimi Zohar
2017-04-07  7:46         ` Mimi Zohar
2017-04-07  9:17       ` David Howells
2017-04-07  9:17         ` David Howells
2017-04-07  9:17         ` David Howells
2017-04-07 12:36         ` Mimi Zohar
2017-04-07 12:36           ` Mimi Zohar
2017-04-07 12:36           ` Mimi Zohar
2017-04-10 13:19         ` David Howells
2017-04-10 13:19           ` David Howells
2017-04-10 13:19           ` David Howells
2017-05-02 19:01           ` Mimi Zohar
2017-05-02 19:01             ` Mimi Zohar
2017-05-02 19:01             ` Mimi Zohar
2017-05-02 19:01             ` Mimi Zohar
2017-04-05 20:16 ` [PATCH 10/24] hibernate: Disable when the kernel is locked down David Howells
2017-04-05 20:16   ` David Howells
2017-04-05 20:16 ` [PATCH 11/24] uswsusp: " David Howells
2017-04-05 20:16   ` David Howells
2017-04-05 23:38   ` Rafael J. Wysocki
2017-04-05 23:38     ` Rafael J. Wysocki
2017-04-05 23:38     ` Rafael J. Wysocki
2017-04-06  6:39     ` Oliver Neukum
2017-04-06  6:39       ` Oliver Neukum
2017-04-06  8:41     ` David Howells
2017-04-06  8:41       ` David Howells
2017-04-06 20:09       ` Rafael J. Wysocki
2017-04-06 20:09         ` Rafael J. Wysocki
2017-04-06 20:09         ` Rafael J. Wysocki
2017-04-06 20:12         ` Rafael J. Wysocki
2017-04-06 20:12           ` Rafael J. Wysocki
2017-04-06 20:25           ` Jiri Kosina
2017-04-06 20:25             ` Jiri Kosina
2017-04-08  3:28             ` poma
2017-04-08  3:28               ` poma
2017-04-12 13:44               ` joeyli
2017-04-12 13:44                 ` joeyli
2017-04-06  6:55   ` David Howells
2017-04-06  6:55     ` David Howells
2017-04-06 20:07     ` Rafael J. Wysocki
2017-04-06 20:07       ` Rafael J. Wysocki
2017-04-05 20:16 ` [PATCH 12/24] PCI: Lock down BAR access " David Howells
2017-04-05 20:16   ` David Howells
2017-04-18 17:50   ` Bjorn Helgaas
2017-04-18 17:50     ` Bjorn Helgaas
2017-04-18 17:50     ` Bjorn Helgaas
2017-04-05 20:16 ` [PATCH 13/24] x86: Lock down IO port " David Howells
2017-04-05 20:16   ` David Howells
2017-04-05 20:16   ` David Howells
2017-04-14 18:28   ` Thomas Gleixner
2017-04-14 18:28     ` Thomas Gleixner
2017-04-14 18:28     ` Thomas Gleixner
2017-04-05 20:16 ` [PATCH 14/24] x86: Restrict MSR " David Howells
2017-04-05 20:16   ` David Howells
2017-04-14 18:30   ` Thomas Gleixner
2017-04-14 18:30     ` Thomas Gleixner
2017-04-05 20:16 ` [PATCH 15/24] asus-wmi: Restrict debugfs interface " David Howells
2017-04-05 20:16   ` David Howells
2017-04-07 10:25   ` Andy Shevchenko
2017-04-07 10:25     ` Andy Shevchenko
2017-04-07 12:50   ` David Howells
2017-04-07 12:50     ` David Howells
2017-04-09 11:10     ` Andy Shevchenko
2017-04-09 11:10       ` Andy Shevchenko
2017-04-10 13:16     ` David Howells
2017-04-10 13:16       ` David Howells
2017-04-18  6:06       ` Andy Shevchenko
2017-04-18  6:06         ` Andy Shevchenko
2017-04-18  6:06         ` Andy Shevchenko
2017-04-18 14:34         ` Ben Hutchings
2017-04-18 14:34           ` Ben Hutchings
2017-04-18 14:55         ` David Howells
2017-04-18 14:55           ` David Howells
2017-04-18 14:55           ` David Howells
2017-04-18 15:19           ` Ben Hutchings
2017-04-18 15:19             ` Ben Hutchings
2017-04-18 15:34           ` David Howells
2017-04-18 15:34             ` David Howells
2017-04-18 15:34             ` David Howells
2017-04-18 15:30         ` David Howells
2017-04-18 15:30           ` David Howells
2017-04-18 17:39           ` Ben Hutchings
2017-04-18 17:39             ` Ben Hutchings
2017-04-18 17:39             ` Ben Hutchings
2017-04-05 20:16 ` [PATCH 16/24] ACPI: Limit access to custom_method " David Howells
2017-04-05 20:16   ` David Howells
2017-04-05 20:16 ` [PATCH 17/24] acpi: Ignore acpi_rsdp kernel param when the kernel has been " David Howells
2017-04-05 20:16   ` David Howells
2017-04-06 19:43   ` Rafael J. Wysocki
2017-04-06 19:43     ` Rafael J. Wysocki
2017-04-07  6:31     ` Dave Young
2017-04-07  6:31       ` Dave Young
     [not found]     ` <20170407063107.GA10451-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-04-07  7:05       ` David Howells
2017-04-07  7:05         ` David Howells
2017-04-07  7:05         ` David Howells
2017-04-07  7:39         ` Dave Young
2017-04-07  7:39           ` Dave Young
2017-04-05 20:17 ` [PATCH 18/24] acpi: Disable ACPI table override if the kernel is " David Howells
2017-04-05 20:17   ` David Howells
2017-04-05 20:17 ` [PATCH 19/24] acpi: Disable APEI error injection " David Howells
2017-04-05 20:17   ` David Howells
2017-04-05 20:17 ` [PATCH 20/24] bpf: Restrict kernel image access functions when " David Howells
2017-04-05 20:17   ` David Howells
2017-04-06 12:29   ` Alexei Starovoitov
2017-04-06 12:29     ` Alexei Starovoitov
2017-04-06 12:40     ` Ard Biesheuvel
2017-04-06 12:40       ` Ard Biesheuvel
2017-04-12 14:57   ` joeyli
2017-04-12 14:57     ` joeyli
2017-04-12 14:57     ` joeyli
2017-04-13  8:46   ` David Howells
2017-04-13  8:46     ` David Howells
2017-04-05 20:17 ` [PATCH 21/24] scsi: Lock down the eata driver David Howells
2017-04-05 20:17   ` David Howells
2017-04-05 20:17 ` [PATCH 22/24] Prohibit PCMCIA CIS storage when the kernel is locked down David Howells
2017-04-05 20:17   ` David Howells
2017-04-05 20:17   ` David Howells
2017-04-05 20:17 ` David Howells [this message]
2017-04-05 20:17   ` [PATCH 23/24] Lock down TIOCSSERIAL David Howells
2017-04-05 20:17   ` David Howells
2017-04-05 20:18 ` [PATCH 24/24] Lock down module params that specify hardware parameters (eg. ioport) David Howells
2017-04-05 20:18   ` David Howells
2017-04-05 20:18   ` David Howells
2017-04-07 15:59 ` [PATCH 00/24] Kernel lockdown Austin S. Hemmelgarn
2017-04-07 15:59   ` Austin S. Hemmelgarn
2017-04-07 16:29   ` Justin Forbes
2017-04-07 16:29     ` Justin Forbes
2017-04-07 16:29     ` Justin Forbes
2017-04-10 23:15 ` Why kernel lockdown? David Howells
2017-04-10 23:15   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=149142347499.5101.36103180891744344.stgit@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=matthew.garrett@nebula.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.