[Qemu-devel] [PATCH 2/3] vnc: simple clean up

[Qemu-devel] [PATCH 2/3] vnc: simple clean up

[weiqi]

From: Wei Qi <weiqi4@huawei.com>

It is unnecessary to assign 'packed_bytes' to 'estimated_bytes', because 'estimated_bytes' unused after assignment.

Signed-off-by: Wei Qi <weiqi4@huawei.com>
---
 ui/vnc-enc-zrle.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ui/vnc-enc-zrle.c b/ui/vnc-enc-zrle.c
index 5489870..fd63d4f 100644
--- a/ui/vnc-enc-zrle.c
+++ b/ui/vnc-enc-zrle.c
@@ -163,7 +163,6 @@ static void zrle_choose_palette_rle(VncState *vs, int w, int h,
             if (packed_bytes < estimated_bytes) {
                 *use_rle = false;
                 *use_palette = true;
-                estimated_bytes = packed_bytes;
             }
         }
     }
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH 2/3] vnc: simple clean up

[Sahid Orentino Ferdjaoui]

On Fri, Apr 07, 2017 at 02:58:58PM +0800, weiqi wrote:
> From: Wei Qi <weiqi4@huawei.com>
> 
> It is unnecessary to assign 'packed_bytes' to 'estimated_bytes', because 'estimated_bytes' unused after assignment.
> 
> Signed-off-by: Wei Qi <weiqi4@huawei.com>
> ---
>  ui/vnc-enc-zrle.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-By: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@redhat.com>

> 
> diff --git a/ui/vnc-enc-zrle.c b/ui/vnc-enc-zrle.c
> index 5489870..fd63d4f 100644
> --- a/ui/vnc-enc-zrle.c
> +++ b/ui/vnc-enc-zrle.c
> @@ -163,7 +163,6 @@ static void zrle_choose_palette_rle(VncState *vs, int w, int h,
>              if (packed_bytes < estimated_bytes) {
>                  *use_rle = false;
>                  *use_palette = true;
> -                estimated_bytes = packed_bytes;

I verified that 'estimated_bytes' is well a local variable defined in
'zrle_choose_palette_rle(...)'.

>              }
>          }
>      }
> -- 
> 1.8.3.1
> 
>