From: no-reply@patchew.org To: shorne@gmail.com Cc: famz@redhat.com, qemu-devel@nongnu.org, openrisc@lists.librecores.org Subject: Re: [Qemu-devel] [PATCH 0/7] Openrisc misc features / fixes Date: Sun, 16 Apr 2017 16:33:19 -0700 (PDT) [thread overview] Message-ID: <149238559853.10512.7357340442722775269@6c512846dbc7> (raw) In-Reply-To: <cover.1492384862.git.shorne@gmail.com> Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 0/7] Openrisc misc features / fixes Message-id: cover.1492384862.git.shorne@gmail.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/cover.1492384862.git.shorne@gmail.com -> patchew/cover.1492384862.git.shorne@gmail.com Switched to a new branch 'test' 10e376c target/openrisc: Implement full vmstate serialization 1c965d5 migration: Add VMSTATE_STRUCT_2DARRAY() 66d129f migration: Add VMSTATE_UINTTL_2DARRAY() da6e29e target/openrisc: implement shadow registers edd6b74 target/openrisc: add numcores and coreid support 16702b5 target/openrisc: add shutdown logic c97a00e target/openrisc: Fixes for memory debugging === OUTPUT BEGIN === Checking PATCH 1/7: target/openrisc: Fixes for memory debugging... WARNING: line over 80 characters #44: FILE: target/openrisc/mmu.c:232: + miss = cpu_openrisc_get_phys_addr(cpu, &phys_addr, &prot, addr, MMU_INST_FETCH); total: 0 errors, 1 warnings, 38 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/7: target/openrisc: add shutdown logic... Checking PATCH 3/7: target/openrisc: add numcores and coreid support... Checking PATCH 4/7: target/openrisc: implement shadow registers... ERROR: "foo * bar" should be "foo *bar" #67: FILE: target/openrisc/cpu.h:273: + target_ulong * gpr; /* General registers (backed by shadow) */ total: 1 errors, 0 warnings, 98 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 5/7: migration: Add VMSTATE_UINTTL_2DARRAY()... Checking PATCH 6/7: migration: Add VMSTATE_STRUCT_2DARRAY()... ERROR: line over 90 characters #20: FILE: include/migration/vmstate.h:502: +#define VMSTATE_STRUCT_2DARRAY_TEST(_field, _state, _n1, _n2, _test, _version, _vmsd, _type) { \ ERROR: spaces required around that '|' (ctx:VxV) #27: FILE: include/migration/vmstate.h:509: + .flags = VMS_STRUCT|VMS_ARRAY, \ ^ WARNING: line over 80 characters #38: FILE: include/migration/vmstate.h:760: +#define VMSTATE_STRUCT_2DARRAY(_field, _state, _n1, _n2, _version, _vmsd, _type) \ total: 2 errors, 1 warnings, 27 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 7/7: target/openrisc: Implement full vmstate serialization... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
WARNING: multiple messages have this Message-ID (diff)
From: no-reply@patchew.org <no-reply@patchew.org> To: openrisc@lists.librecores.org Subject: [OpenRISC] [Qemu-devel] [PATCH 0/7] Openrisc misc features / fixes Date: Sun, 16 Apr 2017 16:33:19 -0700 (PDT) [thread overview] Message-ID: <149238559853.10512.7357340442722775269@6c512846dbc7> (raw) In-Reply-To: <cover.1492384862.git.shorne@gmail.com> Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 0/7] Openrisc misc features / fixes Message-id: cover.1492384862.git.shorne at gmail.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/cover.1492384862.git.shorne at gmail.com -> patchew/cover.1492384862.git.shorne at gmail.com Switched to a new branch 'test' 10e376c target/openrisc: Implement full vmstate serialization 1c965d5 migration: Add VMSTATE_STRUCT_2DARRAY() 66d129f migration: Add VMSTATE_UINTTL_2DARRAY() da6e29e target/openrisc: implement shadow registers edd6b74 target/openrisc: add numcores and coreid support 16702b5 target/openrisc: add shutdown logic c97a00e target/openrisc: Fixes for memory debugging === OUTPUT BEGIN === Checking PATCH 1/7: target/openrisc: Fixes for memory debugging... WARNING: line over 80 characters #44: FILE: target/openrisc/mmu.c:232: + miss = cpu_openrisc_get_phys_addr(cpu, &phys_addr, &prot, addr, MMU_INST_FETCH); total: 0 errors, 1 warnings, 38 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/7: target/openrisc: add shutdown logic... Checking PATCH 3/7: target/openrisc: add numcores and coreid support... Checking PATCH 4/7: target/openrisc: implement shadow registers... ERROR: "foo * bar" should be "foo *bar" #67: FILE: target/openrisc/cpu.h:273: + target_ulong * gpr; /* General registers (backed by shadow) */ total: 1 errors, 0 warnings, 98 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 5/7: migration: Add VMSTATE_UINTTL_2DARRAY()... Checking PATCH 6/7: migration: Add VMSTATE_STRUCT_2DARRAY()... ERROR: line over 90 characters #20: FILE: include/migration/vmstate.h:502: +#define VMSTATE_STRUCT_2DARRAY_TEST(_field, _state, _n1, _n2, _test, _version, _vmsd, _type) { \ ERROR: spaces required around that '|' (ctx:VxV) #27: FILE: include/migration/vmstate.h:509: + .flags = VMS_STRUCT|VMS_ARRAY, \ ^ WARNING: line over 80 characters #38: FILE: include/migration/vmstate.h:760: +#define VMSTATE_STRUCT_2DARRAY(_field, _state, _n1, _n2, _version, _vmsd, _type) \ total: 2 errors, 1 warnings, 27 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 7/7: target/openrisc: Implement full vmstate serialization... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel at freelists.org
next prev parent reply other threads:[~2017-04-16 23:33 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-16 23:23 [Qemu-devel] [PATCH 0/7] Openrisc misc features / fixes Stafford Horne 2017-04-16 23:23 ` [OpenRISC] " Stafford Horne 2017-04-16 23:23 ` [Qemu-devel] [PATCH 1/7] target/openrisc: Fixes for memory debugging Stafford Horne 2017-04-16 23:23 ` [OpenRISC] " Stafford Horne 2017-04-18 7:47 ` [Qemu-devel] " Richard Henderson 2017-04-18 7:47 ` [OpenRISC] " Richard Henderson 2017-04-18 14:18 ` Stafford Horne 2017-04-18 14:18 ` [OpenRISC] " Stafford Horne 2017-04-18 15:00 ` Richard Henderson 2017-04-18 15:00 ` [OpenRISC] " Richard Henderson 2017-04-19 20:06 ` Stafford Horne 2017-04-19 20:06 ` [OpenRISC] " Stafford Horne 2017-04-16 23:23 ` [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic Stafford Horne 2017-04-16 23:23 ` [OpenRISC] " Stafford Horne 2017-04-18 7:52 ` [Qemu-devel] " Richard Henderson 2017-04-18 7:52 ` [OpenRISC] " Richard Henderson 2017-04-18 14:20 ` Stafford Horne 2017-04-18 14:20 ` [OpenRISC] " Stafford Horne 2017-04-22 10:09 ` Stafford Horne 2017-04-22 10:09 ` [OpenRISC] " Stafford Horne 2017-04-22 15:25 ` Richard Henderson 2017-04-22 15:25 ` [OpenRISC] " Richard Henderson 2017-04-23 21:28 ` [OpenRISC] [PATCH PMR] target/openrisc: Support non-busy idle state using PMR SPR Stafford Horne 2017-04-23 21:54 ` [Qemu-devel] [PATCH RFC] " Stafford Horne 2017-04-23 21:54 ` [OpenRISC] " Stafford Horne 2017-04-25 10:11 ` [Qemu-devel] " Richard Henderson 2017-04-25 10:11 ` [OpenRISC] " Richard Henderson 2017-04-25 14:10 ` [Qemu-devel] [PATCH RFC v2] " Stafford Horne 2017-04-25 14:10 ` [OpenRISC] " Stafford Horne 2017-04-25 14:18 ` [Qemu-devel] [PATCH RFC] " Stafford Horne 2017-04-25 14:18 ` [OpenRISC] " Stafford Horne 2017-04-25 14:51 ` [Qemu-devel] " Richard Henderson 2017-04-25 14:51 ` [OpenRISC] " Richard Henderson 2022-04-27 17:44 ` [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic Jason A. Donenfeld 2022-04-27 17:44 ` [OpenRISC] " Jason A. Donenfeld 2022-04-27 18:47 ` Peter Maydell 2022-04-27 18:47 ` [OpenRISC] " Peter Maydell 2022-04-27 21:48 ` Stafford Horne 2022-04-27 21:48 ` [OpenRISC] " Stafford Horne 2022-04-28 0:04 ` Jason A. Donenfeld 2022-04-28 0:04 ` [OpenRISC] " Jason A. Donenfeld 2022-04-28 11:16 ` Jason A. Donenfeld 2022-04-28 11:16 ` [OpenRISC] " Jason A. Donenfeld 2022-04-28 11:47 ` Stafford Horne 2022-04-28 11:47 ` [OpenRISC] " Stafford Horne 2022-04-28 9:19 ` Peter Maydell 2022-04-28 9:19 ` [OpenRISC] " Peter Maydell 2017-04-16 23:23 ` [Qemu-devel] [PATCH 3/7] target/openrisc: add numcores and coreid support Stafford Horne 2017-04-16 23:23 ` [OpenRISC] " Stafford Horne 2017-04-18 8:01 ` [Qemu-devel] " Richard Henderson 2017-04-18 8:01 ` [OpenRISC] " Richard Henderson 2017-04-16 23:23 ` [Qemu-devel] [PATCH 4/7] target/openrisc: implement shadow registers Stafford Horne 2017-04-16 23:23 ` [OpenRISC] " Stafford Horne 2017-04-18 8:11 ` [Qemu-devel] " Richard Henderson 2017-04-18 8:11 ` [OpenRISC] " Richard Henderson 2017-04-18 14:26 ` Stafford Horne 2017-04-18 14:26 ` [OpenRISC] " Stafford Horne 2017-04-16 23:23 ` [Qemu-devel] [PATCH 5/7] migration: Add VMSTATE_UINTTL_2DARRAY() Stafford Horne 2017-04-16 23:23 ` [OpenRISC] " Stafford Horne 2017-04-16 23:23 ` [Qemu-devel] [PATCH 6/7] migration: Add VMSTATE_STRUCT_2DARRAY() Stafford Horne 2017-04-16 23:23 ` [OpenRISC] " Stafford Horne 2017-04-16 23:23 ` [Qemu-devel] [PATCH 7/7] target/openrisc: Implement full vmstate serialization Stafford Horne 2017-04-16 23:23 ` [OpenRISC] " Stafford Horne 2017-04-18 8:14 ` [Qemu-devel] " Richard Henderson 2017-04-18 8:14 ` [OpenRISC] " Richard Henderson 2017-04-18 14:27 ` Stafford Horne 2017-04-18 14:27 ` [OpenRISC] " Stafford Horne 2017-04-16 23:33 ` no-reply [this message] 2017-04-16 23:33 ` [OpenRISC] [Qemu-devel] [PATCH 0/7] Openrisc misc features / fixes no-reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=149238559853.10512.7357340442722775269@6c512846dbc7 \ --to=no-reply@patchew.org \ --cc=famz@redhat.com \ --cc=openrisc@lists.librecores.org \ --cc=qemu-devel@nongnu.org \ --cc=shorne@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.