All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Wang <sean.wang@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Erin Lo <erin.lo@mediatek.com>, <srv_heupstream@mediatek.com>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 1/3] arm: dts: mt2701: Add ethernet device node
Date: Wed, 14 Jun 2017 11:08:28 +0800	[thread overview]
Message-ID: <1497409708.21216.2.camel@mtkswgap22> (raw)
In-Reply-To: <d0a1217b-7761-fea6-888a-da06573400b8@gmail.com>

On Fri, 2017-06-09 at 10:22 +0200, Matthias Brugger wrote:
> 
> On 01/06/17 08:08, Erin Lo wrote:
> > From: Sean Wang <sean.wang@mediatek.com>
> > 
> > Add ethernet device node for MT2701
> > 
> > Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> > Signed-off-by: Erin Lo <erin.lo@mediatek.com>
> > ---
> >   arch/arm/boot/dts/mt2701.dtsi | 20 ++++++++++++++++++++
> >   1 file changed, 20 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
> > index 8037210..de88bd7 100644
> > --- a/arch/arm/boot/dts/mt2701.dtsi
> > +++ b/arch/arm/boot/dts/mt2701.dtsi
> > @@ -420,6 +420,26 @@
> >   		#clock-cells = <1>;
> >   	};
> >   
> > +	eth: ethernet@1b100000 {
> > +		compatible = "mediatek,mt2701-eth", "syscon";
> > +		reg = <0 0x1b100000 0 0x20000>;
> > +		interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_SPI 199 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_SPI 198 IRQ_TYPE_LEVEL_LOW>;
> > +		clocks = <&topckgen CLK_TOP_ETHIF_SEL>,
> > +			 <&ethsys CLK_ETHSYS_ESW>,
> > +			 <&ethsys CLK_ETHSYS_GP1>,
> > +			 <&ethsys CLK_ETHSYS_GP2>,
> > +			 <&apmixedsys CLK_APMIXED_TRGPLL>;
> > +		clock-names = "ethif", "esw", "gp1", "gp2", "trgpll";
> > +		power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
> > +		mediatek,ethsys = <&ethsys>;
> > +		mediatek,pctl = <&syscfg_pctl_a>;
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		status = "disabled";
> > +	};
> > +
> 
> I'm missing the reset properties.


Hi Matthias,

Appreciate your careful reviewing, 

I'll add it for the missing which causes binding violation. 


	Sean

> 
> Regards,
> Matthias

WARNING: multiple messages have this Message-ID (diff)
From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Erin Lo <erin.lo-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
	srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/3] arm: dts: mt2701: Add ethernet device node
Date: Wed, 14 Jun 2017 11:08:28 +0800	[thread overview]
Message-ID: <1497409708.21216.2.camel@mtkswgap22> (raw)
In-Reply-To: <d0a1217b-7761-fea6-888a-da06573400b8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Fri, 2017-06-09 at 10:22 +0200, Matthias Brugger wrote:
> 
> On 01/06/17 08:08, Erin Lo wrote:
> > From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > 
> > Add ethernet device node for MT2701
> > 
> > Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > Signed-off-by: Erin Lo <erin.lo-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > ---
> >   arch/arm/boot/dts/mt2701.dtsi | 20 ++++++++++++++++++++
> >   1 file changed, 20 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
> > index 8037210..de88bd7 100644
> > --- a/arch/arm/boot/dts/mt2701.dtsi
> > +++ b/arch/arm/boot/dts/mt2701.dtsi
> > @@ -420,6 +420,26 @@
> >   		#clock-cells = <1>;
> >   	};
> >   
> > +	eth: ethernet@1b100000 {
> > +		compatible = "mediatek,mt2701-eth", "syscon";
> > +		reg = <0 0x1b100000 0 0x20000>;
> > +		interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_SPI 199 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_SPI 198 IRQ_TYPE_LEVEL_LOW>;
> > +		clocks = <&topckgen CLK_TOP_ETHIF_SEL>,
> > +			 <&ethsys CLK_ETHSYS_ESW>,
> > +			 <&ethsys CLK_ETHSYS_GP1>,
> > +			 <&ethsys CLK_ETHSYS_GP2>,
> > +			 <&apmixedsys CLK_APMIXED_TRGPLL>;
> > +		clock-names = "ethif", "esw", "gp1", "gp2", "trgpll";
> > +		power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
> > +		mediatek,ethsys = <&ethsys>;
> > +		mediatek,pctl = <&syscfg_pctl_a>;
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		status = "disabled";
> > +	};
> > +
> 
> I'm missing the reset properties.


Hi Matthias,

Appreciate your careful reviewing, 

I'll add it for the missing which causes binding violation. 


	Sean

> 
> Regards,
> Matthias


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: sean.wang@mediatek.com (Sean Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] arm: dts: mt2701: Add ethernet device node
Date: Wed, 14 Jun 2017 11:08:28 +0800	[thread overview]
Message-ID: <1497409708.21216.2.camel@mtkswgap22> (raw)
In-Reply-To: <d0a1217b-7761-fea6-888a-da06573400b8@gmail.com>

On Fri, 2017-06-09 at 10:22 +0200, Matthias Brugger wrote:
> 
> On 01/06/17 08:08, Erin Lo wrote:
> > From: Sean Wang <sean.wang@mediatek.com>
> > 
> > Add ethernet device node for MT2701
> > 
> > Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> > Signed-off-by: Erin Lo <erin.lo@mediatek.com>
> > ---
> >   arch/arm/boot/dts/mt2701.dtsi | 20 ++++++++++++++++++++
> >   1 file changed, 20 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
> > index 8037210..de88bd7 100644
> > --- a/arch/arm/boot/dts/mt2701.dtsi
> > +++ b/arch/arm/boot/dts/mt2701.dtsi
> > @@ -420,6 +420,26 @@
> >   		#clock-cells = <1>;
> >   	};
> >   
> > +	eth: ethernet at 1b100000 {
> > +		compatible = "mediatek,mt2701-eth", "syscon";
> > +		reg = <0 0x1b100000 0 0x20000>;
> > +		interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_SPI 199 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_SPI 198 IRQ_TYPE_LEVEL_LOW>;
> > +		clocks = <&topckgen CLK_TOP_ETHIF_SEL>,
> > +			 <&ethsys CLK_ETHSYS_ESW>,
> > +			 <&ethsys CLK_ETHSYS_GP1>,
> > +			 <&ethsys CLK_ETHSYS_GP2>,
> > +			 <&apmixedsys CLK_APMIXED_TRGPLL>;
> > +		clock-names = "ethif", "esw", "gp1", "gp2", "trgpll";
> > +		power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
> > +		mediatek,ethsys = <&ethsys>;
> > +		mediatek,pctl = <&syscfg_pctl_a>;
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		status = "disabled";
> > +	};
> > +
> 
> I'm missing the reset properties.


Hi Matthias,

Appreciate your careful reviewing, 

I'll add it for the missing which causes binding violation. 


	Sean

> 
> Regards,
> Matthias

  reply	other threads:[~2017-06-14  3:08 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01  6:08 [PATCH 0/3] Add some DT nodes for Mediatek MT2701 Erin Lo
2017-06-01  6:08 ` Erin Lo
2017-06-01  6:08 ` Erin Lo
2017-06-01  6:08 ` [PATCH 1/3] arm: dts: mt2701: Add ethernet device node Erin Lo
2017-06-01  6:08   ` Erin Lo
2017-06-01  6:08   ` Erin Lo
2017-06-09  8:22   ` Matthias Brugger
2017-06-09  8:22     ` Matthias Brugger
2017-06-09  8:22     ` Matthias Brugger
2017-06-14  3:08     ` Sean Wang [this message]
2017-06-14  3:08       ` Sean Wang
2017-06-14  3:08       ` Sean Wang
2017-06-01  6:08 ` [PATCH 2/3] arm: dts: mt2701: Add display bls related nodes for MT2701 Erin Lo
2017-06-01  6:08   ` Erin Lo
2017-06-01  6:08   ` Erin Lo
2017-06-09  8:12   ` Matthias Brugger
2017-06-09  8:12     ` Matthias Brugger
2017-06-15  5:34     ` Weiqing Kong
2017-06-15  5:34       ` Weiqing Kong
2017-06-15  5:34       ` Weiqing Kong
2017-06-01  6:08 ` [PATCH 3/3] arm: dts: mt2701: Add display subsystem " Erin Lo
2017-06-01  6:08   ` Erin Lo
2017-06-01  6:08   ` Erin Lo
2017-06-09  8:14   ` Matthias Brugger
2017-06-09  8:14     ` Matthias Brugger
2017-06-09  8:22     ` Philipp Zabel
2017-06-09  8:22       ` Philipp Zabel
2017-06-09  8:22       ` Philipp Zabel
2017-06-09 10:59       ` Matthias Brugger
2017-06-09 10:59         ` Matthias Brugger
2017-06-12  9:13   ` Matthias Brugger
2017-06-12  9:13     ` Matthias Brugger
2017-06-16 13:54     ` YT Shen
2017-06-16 13:54       ` YT Shen
2017-06-16 13:54       ` YT Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497409708.21216.2.camel@mtkswgap22 \
    --to=sean.wang@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=erin.lo@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=srv_heupstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.