From: Matthias Brugger <matthias.bgg@gmail.com> To: Erin Lo <erin.lo@mediatek.com> Cc: srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, YT Shen <yt.shen@mediatek.com>, Weiqing Kong <weiqing.kong@mediatek.com> Subject: Re: [PATCH 2/3] arm: dts: mt2701: Add display bls related nodes for MT2701 Date: Fri, 9 Jun 2017 10:12:50 +0200 [thread overview] Message-ID: <82c8b877-ec34-bd37-7428-8af86191a66e@gmail.com> (raw) In-Reply-To: <1496297324-21091-3-git-send-email-erin.lo@mediatek.com> On 01/06/17 08:08, Erin Lo wrote: > From: YT Shen <yt.shen@mediatek.com> I miss the Singed-off-by from YT Shen. > > This patch adds the device node of display backlight for MT2701 > > Signed-off-by: Weiqing Kong <weiqing.kong@mediatek.com> > Signed-off-by: Erin Lo <erin.lo@mediatek.com> > --- > arch/arm/boot/dts/mt2701-evb.dts | 29 +++++++++++++++++++++++++++++ > arch/arm/boot/dts/mt2701.dtsi | 9 +++++++++ > 2 files changed, 38 insertions(+) > > diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts > index a483798..e49c2b7 100644 > --- a/arch/arm/boot/dts/mt2701-evb.dts > +++ b/arch/arm/boot/dts/mt2701-evb.dts > @@ -22,6 +22,35 @@ > memory { > reg = <0 0x80000000 0 0x40000000>; > }; > + > + backlight_lcd: backlight_lcd { > + compatible = "pwm-backlight"; > + pwms = <&bls 0 100000>; > + brightness-levels = < > + 0 16 32 48 64 80 96 112 > + 128 144 160 176 192 208 224 240 > + 255 > + >; > + default-brightness-level = <9>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pwm_bls_gpio>; > + }; > +}; > + > +&bls { > + status = "okay"; > +}; > + > +&mmsys { > + status = "okay"; > +}; > + > +&pio { > + pwm_bls_gpio: pwm_bls_gpio { > + pins_cmd_dat { > + pinmux = <MT2701_PIN_208_AUD_EXT_CK1__FUNC_DISP_PWM>; > + }; > + }; > }; > > &auxadc { > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > index de88bd7..4f110d5 100644 > --- a/arch/arm/boot/dts/mt2701.dtsi > +++ b/arch/arm/boot/dts/mt2701.dtsi > @@ -366,6 +366,15 @@ > #clock-cells = <1>; > }; > > + bls: bls@1400a000 { > + compatible = "mediatek,mt2701-disp-pwm"; > + reg = <0 0x1400a000 0 0x1000>; > + #pwm-cells = <2>; > + clocks = <&mmsys CLK_MM_MDP_BLS_26M>, <&mmsys CLK_MM_DISP_BLS>; > + clock-names = "main", "mm"; > + status = "disabled"; > + }; > + Can you make this a new patch please. It's preferred to have one patch for the dtsi and another one for the actual board. Thanks, Matthias > larb0: larb@14010000 { > compatible = "mediatek,mt2701-smi-larb"; > reg = <0 0x14010000 0 0x1000>; >
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] arm: dts: mt2701: Add display bls related nodes for MT2701 Date: Fri, 9 Jun 2017 10:12:50 +0200 [thread overview] Message-ID: <82c8b877-ec34-bd37-7428-8af86191a66e@gmail.com> (raw) In-Reply-To: <1496297324-21091-3-git-send-email-erin.lo@mediatek.com> On 01/06/17 08:08, Erin Lo wrote: > From: YT Shen <yt.shen@mediatek.com> I miss the Singed-off-by from YT Shen. > > This patch adds the device node of display backlight for MT2701 > > Signed-off-by: Weiqing Kong <weiqing.kong@mediatek.com> > Signed-off-by: Erin Lo <erin.lo@mediatek.com> > --- > arch/arm/boot/dts/mt2701-evb.dts | 29 +++++++++++++++++++++++++++++ > arch/arm/boot/dts/mt2701.dtsi | 9 +++++++++ > 2 files changed, 38 insertions(+) > > diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts > index a483798..e49c2b7 100644 > --- a/arch/arm/boot/dts/mt2701-evb.dts > +++ b/arch/arm/boot/dts/mt2701-evb.dts > @@ -22,6 +22,35 @@ > memory { > reg = <0 0x80000000 0 0x40000000>; > }; > + > + backlight_lcd: backlight_lcd { > + compatible = "pwm-backlight"; > + pwms = <&bls 0 100000>; > + brightness-levels = < > + 0 16 32 48 64 80 96 112 > + 128 144 160 176 192 208 224 240 > + 255 > + >; > + default-brightness-level = <9>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pwm_bls_gpio>; > + }; > +}; > + > +&bls { > + status = "okay"; > +}; > + > +&mmsys { > + status = "okay"; > +}; > + > +&pio { > + pwm_bls_gpio: pwm_bls_gpio { > + pins_cmd_dat { > + pinmux = <MT2701_PIN_208_AUD_EXT_CK1__FUNC_DISP_PWM>; > + }; > + }; > }; > > &auxadc { > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > index de88bd7..4f110d5 100644 > --- a/arch/arm/boot/dts/mt2701.dtsi > +++ b/arch/arm/boot/dts/mt2701.dtsi > @@ -366,6 +366,15 @@ > #clock-cells = <1>; > }; > > + bls: bls at 1400a000 { > + compatible = "mediatek,mt2701-disp-pwm"; > + reg = <0 0x1400a000 0 0x1000>; > + #pwm-cells = <2>; > + clocks = <&mmsys CLK_MM_MDP_BLS_26M>, <&mmsys CLK_MM_DISP_BLS>; > + clock-names = "main", "mm"; > + status = "disabled"; > + }; > + Can you make this a new patch please. It's preferred to have one patch for the dtsi and another one for the actual board. Thanks, Matthias > larb0: larb at 14010000 { > compatible = "mediatek,mt2701-smi-larb"; > reg = <0 0x14010000 0 0x1000>; >
next prev parent reply other threads:[~2017-06-09 8:13 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-01 6:08 [PATCH 0/3] Add some DT nodes for Mediatek MT2701 Erin Lo 2017-06-01 6:08 ` Erin Lo 2017-06-01 6:08 ` Erin Lo 2017-06-01 6:08 ` [PATCH 1/3] arm: dts: mt2701: Add ethernet device node Erin Lo 2017-06-01 6:08 ` Erin Lo 2017-06-01 6:08 ` Erin Lo 2017-06-09 8:22 ` Matthias Brugger 2017-06-09 8:22 ` Matthias Brugger 2017-06-09 8:22 ` Matthias Brugger 2017-06-14 3:08 ` Sean Wang 2017-06-14 3:08 ` Sean Wang 2017-06-14 3:08 ` Sean Wang 2017-06-01 6:08 ` [PATCH 2/3] arm: dts: mt2701: Add display bls related nodes for MT2701 Erin Lo 2017-06-01 6:08 ` Erin Lo 2017-06-01 6:08 ` Erin Lo 2017-06-09 8:12 ` Matthias Brugger [this message] 2017-06-09 8:12 ` Matthias Brugger 2017-06-15 5:34 ` Weiqing Kong 2017-06-15 5:34 ` Weiqing Kong 2017-06-15 5:34 ` Weiqing Kong 2017-06-01 6:08 ` [PATCH 3/3] arm: dts: mt2701: Add display subsystem " Erin Lo 2017-06-01 6:08 ` Erin Lo 2017-06-01 6:08 ` Erin Lo 2017-06-09 8:14 ` Matthias Brugger 2017-06-09 8:14 ` Matthias Brugger 2017-06-09 8:22 ` Philipp Zabel 2017-06-09 8:22 ` Philipp Zabel 2017-06-09 8:22 ` Philipp Zabel 2017-06-09 10:59 ` Matthias Brugger 2017-06-09 10:59 ` Matthias Brugger 2017-06-12 9:13 ` Matthias Brugger 2017-06-12 9:13 ` Matthias Brugger 2017-06-16 13:54 ` YT Shen 2017-06-16 13:54 ` YT Shen 2017-06-16 13:54 ` YT Shen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=82c8b877-ec34-bd37-7428-8af86191a66e@gmail.com \ --to=matthias.bgg@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=erin.lo@mediatek.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=srv_heupstream@mediatek.com \ --cc=weiqing.kong@mediatek.com \ --cc=yt.shen@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.