* [PATCH v2 0/3] Allow ib_clients to nullify .add but still get .remove events reliably
@ 2017-07-02 8:20 ` Sagi Grimberg
0 siblings, 0 replies; 18+ messages in thread
From: Sagi Grimberg @ 2017-07-02 8:20 UTC (permalink / raw)
To: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Christoph Hellwig
Some ULPs are just interested in device removal notification with no specific
association because they work over RDMA_CM so no need for detecting appearance
of the devices. That wasn't the because the corresponding ib_client_data
was never added to the device clients list when the ib_client registers,
Patch 1 fixes it. Patches 2-3 just removes the empty .add callout nvme(t)-rdma set.
Changes from v1:
- reword patch 1 change log title
- collected review tags
Note that this will create a conflict with jens's for-4.13 which we added
ib_client registration to nvmet-rdma.
Sagi Grimberg (3):
RDMA/core: make ib_device.add method optional
nvme-rdma: remove redundant empty device add callout
nvmet-rdma: remove redundant empty device add callout
drivers/infiniband/core/device.c | 4 ++--
drivers/nvme/host/rdma.c | 5 -----
drivers/nvme/target/rdma.c | 5 -----
3 files changed, 2 insertions(+), 12 deletions(-)
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 0/3] Allow ib_clients to nullify .add but still get .remove events reliably
@ 2017-07-02 8:20 ` Sagi Grimberg
0 siblings, 0 replies; 18+ messages in thread
From: Sagi Grimberg @ 2017-07-02 8:20 UTC (permalink / raw)
Some ULPs are just interested in device removal notification with no specific
association because they work over RDMA_CM so no need for detecting appearance
of the devices. That wasn't the because the corresponding ib_client_data
was never added to the device clients list when the ib_client registers,
Patch 1 fixes it. Patches 2-3 just removes the empty .add callout nvme(t)-rdma set.
Changes from v1:
- reword patch 1 change log title
- collected review tags
Note that this will create a conflict with jens's for-4.13 which we added
ib_client registration to nvmet-rdma.
Sagi Grimberg (3):
RDMA/core: make ib_device.add method optional
nvme-rdma: remove redundant empty device add callout
nvmet-rdma: remove redundant empty device add callout
drivers/infiniband/core/device.c | 4 ++--
drivers/nvme/host/rdma.c | 5 -----
drivers/nvme/target/rdma.c | 5 -----
3 files changed, 2 insertions(+), 12 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 1/3] RDMA/core: make ib_device.add method optional
2017-07-02 8:20 ` Sagi Grimberg
@ 2017-07-02 8:20 ` Sagi Grimberg
-1 siblings, 0 replies; 18+ messages in thread
From: Sagi Grimberg @ 2017-07-02 8:20 UTC (permalink / raw)
To: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Christoph Hellwig
ib_clients can indeed fill .add to NULL, but then they will not see
any device removal notifications. The reason is that that
ib_register_client and ib_register_device checked existence of .add
before adding the creating a corresponding client_data and adding
it to the list. Simple condition reverse fixes the issue.
Reviewed-by: Johannes Thumshirn <jthumshirn-l3A5Bk7waGM@public.gmane.org>
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Signed-off-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
---
drivers/infiniband/core/device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 81d447da0048..26eb428af473 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -414,7 +414,7 @@ int ib_register_device(struct ib_device *device,
device->reg_state = IB_DEV_REGISTERED;
list_for_each_entry(client, &client_list, list)
- if (client->add && !add_client_context(device, client))
+ if (!add_client_context(device, client) && client->add)
client->add(device);
down_write(&lists_rwsem);
@@ -499,7 +499,7 @@ int ib_register_client(struct ib_client *client)
mutex_lock(&device_mutex);
list_for_each_entry(device, &device_list, core_list)
- if (client->add && !add_client_context(device, client))
+ if (!add_client_context(device, client) && client->add)
client->add(device);
down_write(&lists_rwsem);
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 1/3] RDMA/core: make ib_device.add method optional
@ 2017-07-02 8:20 ` Sagi Grimberg
0 siblings, 0 replies; 18+ messages in thread
From: Sagi Grimberg @ 2017-07-02 8:20 UTC (permalink / raw)
ib_clients can indeed fill .add to NULL, but then they will not see
any device removal notifications. The reason is that that
ib_register_client and ib_register_device checked existence of .add
before adding the creating a corresponding client_data and adding
it to the list. Simple condition reverse fixes the issue.
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
Reviewed-by: Christoph Hellwig <hch at lst.de>
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
drivers/infiniband/core/device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 81d447da0048..26eb428af473 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -414,7 +414,7 @@ int ib_register_device(struct ib_device *device,
device->reg_state = IB_DEV_REGISTERED;
list_for_each_entry(client, &client_list, list)
- if (client->add && !add_client_context(device, client))
+ if (!add_client_context(device, client) && client->add)
client->add(device);
down_write(&lists_rwsem);
@@ -499,7 +499,7 @@ int ib_register_client(struct ib_client *client)
mutex_lock(&device_mutex);
list_for_each_entry(device, &device_list, core_list)
- if (client->add && !add_client_context(device, client))
+ if (!add_client_context(device, client) && client->add)
client->add(device);
down_write(&lists_rwsem);
--
2.7.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 2/3] nvme-rdma: remove redundant empty device add callout
2017-07-02 8:20 ` Sagi Grimberg
@ 2017-07-02 8:20 ` Sagi Grimberg
-1 siblings, 0 replies; 18+ messages in thread
From: Sagi Grimberg @ 2017-07-02 8:20 UTC (permalink / raw)
To: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Christoph Hellwig
Now that its not needed, we can simply not assign it.
Reviewed-by: Johannes Thumshirn <jthumshirn-l3A5Bk7waGM@public.gmane.org>
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Signed-off-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
---
drivers/nvme/host/rdma.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 6d4119dfbdaa..934183f80fff 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1956,10 +1956,6 @@ static struct nvmf_transport_ops nvme_rdma_transport = {
.create_ctrl = nvme_rdma_create_ctrl,
};
-static void nvme_rdma_add_one(struct ib_device *ib_device)
-{
-}
-
static void nvme_rdma_remove_one(struct ib_device *ib_device, void *client_data)
{
struct nvme_rdma_ctrl *ctrl;
@@ -1981,7 +1977,6 @@ static void nvme_rdma_remove_one(struct ib_device *ib_device, void *client_data)
static struct ib_client nvme_rdma_ib_client = {
.name = "nvme_rdma",
- .add = nvme_rdma_add_one,
.remove = nvme_rdma_remove_one
};
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 2/3] nvme-rdma: remove redundant empty device add callout
@ 2017-07-02 8:20 ` Sagi Grimberg
0 siblings, 0 replies; 18+ messages in thread
From: Sagi Grimberg @ 2017-07-02 8:20 UTC (permalink / raw)
Now that its not needed, we can simply not assign it.
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
Reviewed-by: Christoph Hellwig <hch at lst.de>
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
drivers/nvme/host/rdma.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 6d4119dfbdaa..934183f80fff 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1956,10 +1956,6 @@ static struct nvmf_transport_ops nvme_rdma_transport = {
.create_ctrl = nvme_rdma_create_ctrl,
};
-static void nvme_rdma_add_one(struct ib_device *ib_device)
-{
-}
-
static void nvme_rdma_remove_one(struct ib_device *ib_device, void *client_data)
{
struct nvme_rdma_ctrl *ctrl;
@@ -1981,7 +1977,6 @@ static void nvme_rdma_remove_one(struct ib_device *ib_device, void *client_data)
static struct ib_client nvme_rdma_ib_client = {
.name = "nvme_rdma",
- .add = nvme_rdma_add_one,
.remove = nvme_rdma_remove_one
};
--
2.7.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 3/3] nvmet-rdma: remove redundant empty device add callout
2017-07-02 8:20 ` Sagi Grimberg
@ 2017-07-02 8:20 ` Sagi Grimberg
-1 siblings, 0 replies; 18+ messages in thread
From: Sagi Grimberg @ 2017-07-02 8:20 UTC (permalink / raw)
To: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Christoph Hellwig
Now that its not needed, we can simply not assign it.
Reviewed-by: Johannes Thumshirn <jthumshirn-l3A5Bk7waGM@public.gmane.org>
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Signed-off-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
---
drivers/nvme/target/rdma.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 56a4cba690b5..76d2bb793afe 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -1510,10 +1510,6 @@ static struct nvmet_fabrics_ops nvmet_rdma_ops = {
.delete_ctrl = nvmet_rdma_delete_ctrl,
};
-static void nvmet_rdma_add_one(struct ib_device *ib_device)
-{
-}
-
static void nvmet_rdma_remove_one(struct ib_device *ib_device, void *client_data)
{
struct nvmet_rdma_queue *queue;
@@ -1534,7 +1530,6 @@ static void nvmet_rdma_remove_one(struct ib_device *ib_device, void *client_data
static struct ib_client nvmet_rdma_ib_client = {
.name = "nvmet_rdma",
- .add = nvmet_rdma_add_one,
.remove = nvmet_rdma_remove_one
};
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v2 3/3] nvmet-rdma: remove redundant empty device add callout
@ 2017-07-02 8:20 ` Sagi Grimberg
0 siblings, 0 replies; 18+ messages in thread
From: Sagi Grimberg @ 2017-07-02 8:20 UTC (permalink / raw)
Now that its not needed, we can simply not assign it.
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
Reviewed-by: Christoph Hellwig <hch at lst.de>
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
drivers/nvme/target/rdma.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 56a4cba690b5..76d2bb793afe 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -1510,10 +1510,6 @@ static struct nvmet_fabrics_ops nvmet_rdma_ops = {
.delete_ctrl = nvmet_rdma_delete_ctrl,
};
-static void nvmet_rdma_add_one(struct ib_device *ib_device)
-{
-}
-
static void nvmet_rdma_remove_one(struct ib_device *ib_device, void *client_data)
{
struct nvmet_rdma_queue *queue;
@@ -1534,7 +1530,6 @@ static void nvmet_rdma_remove_one(struct ib_device *ib_device, void *client_data
static struct ib_client nvmet_rdma_ib_client = {
.name = "nvmet_rdma",
- .add = nvmet_rdma_add_one,
.remove = nvmet_rdma_remove_one
};
--
2.7.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v2 0/3] Allow ib_clients to nullify .add but still get .remove events reliably
2017-07-02 8:20 ` Sagi Grimberg
@ 2017-07-02 9:14 ` Max Gurtovoy
-1 siblings, 0 replies; 18+ messages in thread
From: Max Gurtovoy @ 2017-07-02 9:14 UTC (permalink / raw)
To: Sagi Grimberg, Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Christoph Hellwig
On 7/2/2017 11:20 AM, Sagi Grimberg wrote:
> Some ULPs are just interested in device removal notification with no specific
> association because they work over RDMA_CM so no need for detecting appearance
> of the devices. That wasn't the because the corresponding ib_client_data
> was never added to the device clients list when the ib_client registers,
> Patch 1 fixes it. Patches 2-3 just removes the empty .add callout nvme(t)-rdma set.
>
> Changes from v1:
> - reword patch 1 change log title
> - collected review tags
>
> Note that this will create a conflict with jens's for-4.13 which we added
> ib_client registration to nvmet-rdma.
>
> Sagi Grimberg (3):
> RDMA/core: make ib_device.add method optional
> nvme-rdma: remove redundant empty device add callout
> nvmet-rdma: remove redundant empty device add callout
All these patches looks fine to me,
Reviewed-by: Max Gurtovoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 0/3] Allow ib_clients to nullify .add but still get .remove events reliably
@ 2017-07-02 9:14 ` Max Gurtovoy
0 siblings, 0 replies; 18+ messages in thread
From: Max Gurtovoy @ 2017-07-02 9:14 UTC (permalink / raw)
On 7/2/2017 11:20 AM, Sagi Grimberg wrote:
> Some ULPs are just interested in device removal notification with no specific
> association because they work over RDMA_CM so no need for detecting appearance
> of the devices. That wasn't the because the corresponding ib_client_data
> was never added to the device clients list when the ib_client registers,
> Patch 1 fixes it. Patches 2-3 just removes the empty .add callout nvme(t)-rdma set.
>
> Changes from v1:
> - reword patch 1 change log title
> - collected review tags
>
> Note that this will create a conflict with jens's for-4.13 which we added
> ib_client registration to nvmet-rdma.
>
> Sagi Grimberg (3):
> RDMA/core: make ib_device.add method optional
> nvme-rdma: remove redundant empty device add callout
> nvmet-rdma: remove redundant empty device add callout
All these patches looks fine to me,
Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/3] RDMA/core: make ib_device.add method optional
2017-07-02 8:20 ` Sagi Grimberg
@ 2017-07-06 7:51 ` Sagi Grimberg
-1 siblings, 0 replies; 18+ messages in thread
From: Sagi Grimberg @ 2017-07-06 7:51 UTC (permalink / raw)
To: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: Christoph Hellwig, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
> ib_clients can indeed fill .add to NULL, but then they will not see
> any device removal notifications. The reason is that that
> ib_register_client and ib_register_device checked existence of .add
> before adding the creating a corresponding client_data and adding
> it to the list. Simple condition reverse fixes the issue.
>
> Reviewed-by: Johannes Thumshirn <jthumshirn-l3A5Bk7waGM@public.gmane.org>
> Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> Signed-off-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Any RDMA folks?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 1/3] RDMA/core: make ib_device.add method optional
@ 2017-07-06 7:51 ` Sagi Grimberg
0 siblings, 0 replies; 18+ messages in thread
From: Sagi Grimberg @ 2017-07-06 7:51 UTC (permalink / raw)
> ib_clients can indeed fill .add to NULL, but then they will not see
> any device removal notifications. The reason is that that
> ib_register_client and ib_register_device checked existence of .add
> before adding the creating a corresponding client_data and adding
> it to the list. Simple condition reverse fixes the issue.
>
> Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
Any RDMA folks?
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/3] RDMA/core: make ib_device.add method optional
2017-07-06 7:51 ` Sagi Grimberg
@ 2017-07-06 8:33 ` Leon Romanovsky
-1 siblings, 0 replies; 18+ messages in thread
From: Leon Romanovsky @ 2017-07-06 8:33 UTC (permalink / raw)
To: Sagi Grimberg
Cc: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
Christoph Hellwig, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
[-- Attachment #1: Type: text/plain, Size: 801 bytes --]
On Thu, Jul 06, 2017 at 10:51:36AM +0300, Sagi Grimberg wrote:
> > ib_clients can indeed fill .add to NULL, but then they will not see
> > any device removal notifications. The reason is that that
> > ib_register_client and ib_register_device checked existence of .add
> > before adding the creating a corresponding client_data and adding
> > it to the list. Simple condition reverse fixes the issue.
> >
> > Reviewed-by: Johannes Thumshirn <jthumshirn-l3A5Bk7waGM@public.gmane.org>
> > Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> > Signed-off-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
>
> Any RDMA folks?
It looks right and two gentlemen above already reviewed it.
Thanks,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 1/3] RDMA/core: make ib_device.add method optional
@ 2017-07-06 8:33 ` Leon Romanovsky
0 siblings, 0 replies; 18+ messages in thread
From: Leon Romanovsky @ 2017-07-06 8:33 UTC (permalink / raw)
On Thu, Jul 06, 2017@10:51:36AM +0300, Sagi Grimberg wrote:
> > ib_clients can indeed fill .add to NULL, but then they will not see
> > any device removal notifications. The reason is that that
> > ib_register_client and ib_register_device checked existence of .add
> > before adding the creating a corresponding client_data and adding
> > it to the list. Simple condition reverse fixes the issue.
> >
> > Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
> > Reviewed-by: Christoph Hellwig <hch at lst.de>
> > Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
>
> Any RDMA folks?
It looks right and two gentlemen above already reviewed it.
Thanks,
Reviewed-by: Leon Romanovsky <leonro at mellanox.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20170706/eeb4cec0/attachment.sig>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 1/3] RDMA/core: make ib_device.add method optional
2017-07-06 8:33 ` Leon Romanovsky
@ 2017-07-06 8:38 ` Sagi Grimberg
-1 siblings, 0 replies; 18+ messages in thread
From: Sagi Grimberg @ 2017-07-06 8:38 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
Christoph Hellwig, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
>> Any RDMA folks?
>
> It looks right and two gentlemen above already reviewed it.
None of them is focused on the RDMA core on a day-to-day basis.
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Awesome.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 1/3] RDMA/core: make ib_device.add method optional
@ 2017-07-06 8:38 ` Sagi Grimberg
0 siblings, 0 replies; 18+ messages in thread
From: Sagi Grimberg @ 2017-07-06 8:38 UTC (permalink / raw)
>> Any RDMA folks?
>
> It looks right and two gentlemen above already reviewed it.
None of them is focused on the RDMA core on a day-to-day basis.
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro at mellanox.com>
Awesome.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v2 0/3] Allow ib_clients to nullify .add but still get .remove events reliably
2017-07-02 9:14 ` Max Gurtovoy
@ 2017-08-18 14:46 ` Doug Ledford
-1 siblings, 0 replies; 18+ messages in thread
From: Doug Ledford @ 2017-08-18 14:46 UTC (permalink / raw)
To: Max Gurtovoy, Sagi Grimberg, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Christoph Hellwig
On Sun, 2017-07-02 at 12:14 +0300, Max Gurtovoy wrote:
>
> On 7/2/2017 11:20 AM, Sagi Grimberg wrote:
> > Some ULPs are just interested in device removal notification with
> > no specific
> > association because they work over RDMA_CM so no need for detecting
> > appearance
> > of the devices. That wasn't the because the corresponding
> > ib_client_data
> > was never added to the device clients list when the ib_client
> > registers,
> > Patch 1 fixes it. Patches 2-3 just removes the empty .add callout
> > nvme(t)-rdma set.
> >
> > Changes from v1:
> > - reword patch 1 change log title
> > - collected review tags
> >
> > Note that this will create a conflict with jens's for-4.13 which we
> > added
> > ib_client registration to nvmet-rdma.
> >
> > Sagi Grimberg (3):
> > RDMA/core: make ib_device.add method optional
> > nvme-rdma: remove redundant empty device add callout
> > nvmet-rdma: remove redundant empty device add callout
>
> All these patches looks fine to me,
>
> Reviewed-by: Max Gurtovoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Thanks, series applied.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v2 0/3] Allow ib_clients to nullify .add but still get .remove events reliably
@ 2017-08-18 14:46 ` Doug Ledford
0 siblings, 0 replies; 18+ messages in thread
From: Doug Ledford @ 2017-08-18 14:46 UTC (permalink / raw)
On Sun, 2017-07-02@12:14 +0300, Max Gurtovoy wrote:
>
> On 7/2/2017 11:20 AM, Sagi Grimberg wrote:
> > Some ULPs are just interested in device removal notification with
> > no specific
> > association because they work over RDMA_CM so no need for detecting
> > appearance
> > of the devices. That wasn't the because the corresponding
> > ib_client_data
> > was never added to the device clients list when the ib_client
> > registers,
> > Patch 1 fixes it. Patches 2-3 just removes the empty .add callout
> > nvme(t)-rdma set.
> >
> > Changes from v1:
> > - reword patch 1 change log title
> > - collected review tags
> >
> > Note that this will create a conflict with jens's for-4.13 which we
> > added
> > ib_client registration to nvmet-rdma.
> >
> > Sagi Grimberg (3):
> > RDMA/core: make ib_device.add method optional
> > nvme-rdma: remove redundant empty device add callout
> > nvmet-rdma: remove redundant empty device add callout
>
> All these patches looks fine to me,
>
> Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
Thanks, series applied.
--
Doug Ledford <dledford at redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2017-08-18 14:46 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-02 8:20 [PATCH v2 0/3] Allow ib_clients to nullify .add but still get .remove events reliably Sagi Grimberg
2017-07-02 8:20 ` Sagi Grimberg
[not found] ` <1498983652-18250-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-07-02 8:20 ` [PATCH v2 1/3] RDMA/core: make ib_device.add method optional Sagi Grimberg
2017-07-02 8:20 ` Sagi Grimberg
[not found] ` <1498983652-18250-2-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-07-06 7:51 ` Sagi Grimberg
2017-07-06 7:51 ` Sagi Grimberg
[not found] ` <14303999-2479-653c-719f-ac5a5b03fb33-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-07-06 8:33 ` Leon Romanovsky
2017-07-06 8:33 ` Leon Romanovsky
[not found] ` <20170706083301.GS1528-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-07-06 8:38 ` Sagi Grimberg
2017-07-06 8:38 ` Sagi Grimberg
2017-07-02 8:20 ` [PATCH v2 2/3] nvme-rdma: remove redundant empty device add callout Sagi Grimberg
2017-07-02 8:20 ` Sagi Grimberg
2017-07-02 8:20 ` [PATCH v2 3/3] nvmet-rdma: " Sagi Grimberg
2017-07-02 8:20 ` Sagi Grimberg
2017-07-02 9:14 ` [PATCH v2 0/3] Allow ib_clients to nullify .add but still get .remove events reliably Max Gurtovoy
2017-07-02 9:14 ` Max Gurtovoy
[not found] ` <8927ea7d-c6ba-4f32-4ede-0897e83bcda2-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-08-18 14:46 ` Doug Ledford
2017-08-18 14:46 ` Doug Ledford
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.