From: mwilck@suse.com (Martin Wilck)
Subject: [PATCH 0/3] Improve readbility of NVME "wwid" attribute
Date: Fri, 14 Jul 2017 11:41:37 +0200 [thread overview]
Message-ID: <1500025297.4808.6.camel@suse.com> (raw)
In-Reply-To: <20170714075612.GE17877@lst.de>
On Fri, 2017-07-14@09:56 +0200, Christoph Hellwig wrote:
> On Thu, Jul 13, 2017@06:57:39PM -0400, Keith Busch wrote:
> > For example, my device's wwid attribute looks like this today:
> >
> > nvme.8086-46554d42353235363030304a32383041-
> > 494e54454c2053534450454431443134304741-00000001
> >
> > But would this cause a problem for anything?
> >
> > nvme.8086-FUMB5256000J280A-INTEL_SSDPED1D140GA-00000001
>
> It would have been nicer, but it will break existing setups.
>
> Distros should instead switch to use the nqn for the char dev
> uniqueue identifier (we now fake it up even for controllers that
> don't provide it), and the EUI64/NGUID/UUID if provided for the
> block device names.
>
The "if provided" is the crucial point here. In real life currently
many people struggle with ugly overlong identifiers because these IDs
are _not_ provided by default. I daresay that this attribute is pretty
much broken in current setups, in particular linux host with linux
target.
If it's late to change this attribute for API stability reasons, we
should consider keeping it as legacy and add (yet) another one with a
saner format.
Martin
--
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
next prev parent reply other threads:[~2017-07-14 9:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 22:25 [PATCH 0/3] Improve readbility of NVME "wwid" attribute Martin Wilck
2017-07-13 22:25 ` [PATCH 1/3] nvmet: identify controller: improve standard compliance Martin Wilck
2017-07-14 7:54 ` Christoph Hellwig
2017-07-13 22:25 ` [PATCH 2/3] nvme: wwid_show: strip trailing 0-bytes Martin Wilck
2017-07-14 7:54 ` Christoph Hellwig
2017-07-13 22:25 ` [PATCH 3/3] nvme: wwid_show: copy hex string verbatim Martin Wilck
2017-07-14 7:54 ` Christoph Hellwig
2017-07-14 9:58 ` Martin Wilck
2017-07-14 12:30 ` Christoph Hellwig
2017-07-14 19:40 ` Martin Wilck
2017-07-15 8:46 ` Christoph Hellwig
2017-07-17 6:12 ` Hannes Reinecke
2017-07-13 22:57 ` [PATCH 0/3] Improve readbility of NVME "wwid" attribute Keith Busch
2017-07-14 7:54 ` Martin Wilck
2017-07-14 7:57 ` Christoph Hellwig
2017-07-14 7:56 ` Christoph Hellwig
2017-07-14 9:41 ` Martin Wilck [this message]
2017-07-14 12:28 ` Christoph Hellwig
2017-07-14 7:53 ` Christoph Hellwig
2017-07-14 8:54 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500025297.4808.6.camel@suse.com \
--to=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.