All of lore.kernel.org
 help / color / mirror / Atom feed
From: mwilck@suse.com (Martin Wilck)
Subject: [PATCH 2/3] nvme: wwid_show: strip trailing 0-bytes
Date: Fri, 14 Jul 2017 00:25:32 +0200	[thread overview]
Message-ID: <20170713222533.30794-3-mwilck@suse.com> (raw)
In-Reply-To: <20170713222533.30794-1-mwilck@suse.com>

Some broken targets (such as the current Linux target) pad
model or serial fields with 0-bytes rather than spaces. The
NVME spec disallows 0 bytes in "ASCII" fields.
Thus strip trailing 0-bytes, too.

Signed-off-by: Martin Wilck <mwilck at suse.com>
Reviewed-by: Hannes Reinecke <hare at suse.de>
---
 drivers/nvme/host/core.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index d70df1d0072d4..deced6b91442d 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2001,9 +2001,11 @@ static ssize_t wwid_show(struct device *dev, struct device_attribute *attr,
 	if (memchr_inv(ns->eui, 0, sizeof(ns->eui)))
 		return sprintf(buf, "eui.%8phN\n", ns->eui);
 
-	while (ctrl->serial[serial_len - 1] == ' ')
+	while (ctrl->serial[serial_len - 1] == ' ' ||
+	       ctrl->serial[serial_len - 1] == '\0')
 		serial_len--;
-	while (ctrl->model[model_len - 1] == ' ')
+	while (ctrl->model[model_len - 1] == ' ' ||
+	       ctrl->model[model_len - 1] == '\0')
 		model_len--;
 
 	return sprintf(buf, "nvme.%04x-%*phN-%*phN-%08x\n", ctrl->vid,
-- 
2.13.2

  parent reply	other threads:[~2017-07-13 22:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13 22:25 [PATCH 0/3] Improve readbility of NVME "wwid" attribute Martin Wilck
2017-07-13 22:25 ` [PATCH 1/3] nvmet: identify controller: improve standard compliance Martin Wilck
2017-07-14  7:54   ` Christoph Hellwig
2017-07-13 22:25 ` Martin Wilck [this message]
2017-07-14  7:54   ` [PATCH 2/3] nvme: wwid_show: strip trailing 0-bytes Christoph Hellwig
2017-07-13 22:25 ` [PATCH 3/3] nvme: wwid_show: copy hex string verbatim Martin Wilck
2017-07-14  7:54   ` Christoph Hellwig
2017-07-14  9:58     ` Martin Wilck
2017-07-14 12:30       ` Christoph Hellwig
2017-07-14 19:40         ` Martin Wilck
2017-07-15  8:46           ` Christoph Hellwig
2017-07-17  6:12             ` Hannes Reinecke
2017-07-13 22:57 ` [PATCH 0/3] Improve readbility of NVME "wwid" attribute Keith Busch
2017-07-14  7:54   ` Martin Wilck
2017-07-14  7:57     ` Christoph Hellwig
2017-07-14  7:56   ` Christoph Hellwig
2017-07-14  9:41     ` Martin Wilck
2017-07-14 12:28       ` Christoph Hellwig
2017-07-14  7:53 ` Christoph Hellwig
2017-07-14  8:54   ` Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170713222533.30794-3-mwilck@suse.com \
    --to=mwilck@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.