From: mwilck@suse.com (Martin Wilck)
Subject: [PATCH 0/3] Improve readbility of NVME "wwid" attribute
Date: Fri, 14 Jul 2017 00:25:30 +0200 [thread overview]
Message-ID: <20170713222533.30794-1-mwilck@suse.com> (raw)
With the current implementation, the default "fallback" WWID generation
code (if no nguid, euid etc. are defined) for Linux NVME host and target
results in the following WWID format:
nvme.0000-3163653363666438366239656630386200-4c696e75780000000000000000000000000000000000000000000000000000000000000000000000-00000002
This is not only hard to read, it poses real problems for multipath
(dm WWIDs are limited to 128 characters), and it's not fully standards
compliant.
With this patch series, the WWID on a Linux host connected to a Linux target
looks like this:
nvme.0000-d319fc8b2883bfec-4c696e7578-00000001
Martin Wilck (3):
nvmet: identify controller: improve standard compliance
nvme: wwid_show: strip trailing 0-bytes
nvme: wwid_show: copy hex string verbatim
drivers/nvme/host/core.c | 30 ++++++++++++++++++++++++++----
drivers/nvme/target/admin-cmd.c | 21 ++++++++++++++-------
2 files changed, 40 insertions(+), 11 deletions(-)
--
2.13.2
next reply other threads:[~2017-07-13 22:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 22:25 Martin Wilck [this message]
2017-07-13 22:25 ` [PATCH 1/3] nvmet: identify controller: improve standard compliance Martin Wilck
2017-07-14 7:54 ` Christoph Hellwig
2017-07-13 22:25 ` [PATCH 2/3] nvme: wwid_show: strip trailing 0-bytes Martin Wilck
2017-07-14 7:54 ` Christoph Hellwig
2017-07-13 22:25 ` [PATCH 3/3] nvme: wwid_show: copy hex string verbatim Martin Wilck
2017-07-14 7:54 ` Christoph Hellwig
2017-07-14 9:58 ` Martin Wilck
2017-07-14 12:30 ` Christoph Hellwig
2017-07-14 19:40 ` Martin Wilck
2017-07-15 8:46 ` Christoph Hellwig
2017-07-17 6:12 ` Hannes Reinecke
2017-07-13 22:57 ` [PATCH 0/3] Improve readbility of NVME "wwid" attribute Keith Busch
2017-07-14 7:54 ` Martin Wilck
2017-07-14 7:57 ` Christoph Hellwig
2017-07-14 7:56 ` Christoph Hellwig
2017-07-14 9:41 ` Martin Wilck
2017-07-14 12:28 ` Christoph Hellwig
2017-07-14 7:53 ` Christoph Hellwig
2017-07-14 8:54 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713222533.30794-1-mwilck@suse.com \
--to=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.