From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>,
"hch@infradead.org" <hch@infradead.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "keith.busch@intel.com" <keith.busch@intel.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [GIT PULL] nvme update for Linux 4.14, take 2
Date: Wed, 30 Aug 2017 15:28:35 +0000 [thread overview]
Message-ID: <1504106914.2526.5.camel@wdc.com> (raw)
In-Reply-To: <38ddd70f-3fec-09c0-dafb-eba1e8f9cc18@grimberg.me>
T24gV2VkLCAyMDE3LTA4LTMwIGF0IDE4OjEwICswMzAwLCBTYWdpIEdyaW1iZXJnIHdyb3RlOg0K
PiBJIGp1c3QgcmVhbGl6ZWQgdGhhdCBwYXRjaDoNCj4gLS0NCj4gY29tbWl0IGQzNTJhZTIwNWQ4
YjA1ZjNmNzU1OGQxMGY0NzRkODQzNjU4MWIzZTINCj4gQXV0aG9yOiBCYXJ0IFZhbiBBc3NjaGUg
PGJhcnQudmFuYXNzY2hlQHdkYy5jb20+DQo+IERhdGU6ICAgVGh1IEF1ZyAxNyAxNjoyMzowMyAy
MDE3IC0wNzAwDQo+IA0KPiAgICAgIGJsay1tcTogTWFrZSBibGtfbXFfcmVpbml0X3RhZ3NldCgp
IGNhbGxzIGVhc2llciB0byByZWFkDQo+IA0KPiAgICAgIFNpbmNlIGJsa19tcV9vcHMucmVpbml0
X3JlcXVlc3QgaXMgb25seSBjYWxsZWQgZnJvbSBpbnNpZGUNCj4gICAgICBibGtfbXFfcmVpbml0
X3RhZ3NldCgpLCBtYWtlIHRoaXMgZnVuY3Rpb24gcG9pbnRlciBhbiBhcmd1bWVudCBvZg0KPiAg
ICAgIGJsa19tcV9yZWluaXRfdGFnc2V0KCkgaW5zdGVhZCBvZiBhIG1lbWJlciBvZiBzdHJ1Y3Qg
YmxrX21xX29wcy4NCj4gICAgICBUaGlzIHBhdGNoIGRvZXMgbm90IGNoYW5nZSBhbnkgZnVuY3Rp
b25hbGl0eSBidXQgbWFrZXMNCj4gICAgICBibGtfbXFfcmVpbml0X3RhZ3NldCgpIGNhbGxzIGVh
c2llciB0byByZWFkIGFuZCB0byBhbmFseXplLg0KPiAtLQ0KPiANCj4gTWFrZXMgaXQgaW1wb3Nz
aWJsZSBmb3IgbWUgdG8gbW92ZSBjb250cm9sbGVyIHJlc2V0IGZsb3cgdG8NCj4gbnZtZS1jb3Jl
IHdpdGhvdXQgYWRkaW5nIGEgdHJhbXBvbGluZSAoYXMgdGhlIHJlaW5pdF9yZXF1ZXN0DQo+IGlz
IHRyYW5zcG9ydCBzcGVjaWZpYykuLi4NCg0KSGVsbG8gU2FnaSwNCg0KU29ycnkgYnV0IEkgZG91
YnQgdGhhdCB0aGF0IHBhdGNoIG1ha2VzIGl0ICJpbXBvc3NpYmxlIiB0byBtb3ZlIGNvbnRyb2xs
ZXINCnJlc2V0IGZsb3cgdG8gdGhlIE5WTWUgY29yZS4gVGhlcmUgYXJlIGFscmVhZHkgc2V2ZXJh
bCBmdW5jdGlvbiBwb2ludGVycyBpbg0KdGhlIG52bWVfY3RybF9vcHMgZGF0YSBzdHJ1Y3R1cmUg
YW5kIHRoZXJlIGlzIG9uZSBzdWNoIGRhdGEgc3RydWN0dXJlIHBlcg0KdHJhbnNwb3J0LiBIYWQg
eW91IGFscmVhZHkgY29uc2lkZXJlZCB0byBhZGQgYSBmdW5jdGlvbiBwb2ludGVyIHRvIHRoYXQN
CnN0cnVjdHVyZT8NCg0KQmFydC4=
WARNING: multiple messages have this Message-ID (diff)
From: Bart.VanAssche@wdc.com (Bart Van Assche)
Subject: [GIT PULL] nvme update for Linux 4.14, take 2
Date: Wed, 30 Aug 2017 15:28:35 +0000 [thread overview]
Message-ID: <1504106914.2526.5.camel@wdc.com> (raw)
In-Reply-To: <38ddd70f-3fec-09c0-dafb-eba1e8f9cc18@grimberg.me>
On Wed, 2017-08-30@18:10 +0300, Sagi Grimberg wrote:
> I just realized that patch:
> --
> commit d352ae205d8b05f3f7558d10f474d8436581b3e2
> Author: Bart Van Assche <bart.vanassche at wdc.com>
> Date: Thu Aug 17 16:23:03 2017 -0700
>
> blk-mq: Make blk_mq_reinit_tagset() calls easier to read
>
> Since blk_mq_ops.reinit_request is only called from inside
> blk_mq_reinit_tagset(), make this function pointer an argument of
> blk_mq_reinit_tagset() instead of a member of struct blk_mq_ops.
> This patch does not change any functionality but makes
> blk_mq_reinit_tagset() calls easier to read and to analyze.
> --
>
> Makes it impossible for me to move controller reset flow to
> nvme-core without adding a trampoline (as the reinit_request
> is transport specific)...
Hello Sagi,
Sorry but I doubt that that patch makes it "impossible" to move controller
reset flow to the NVMe core. There are already several function pointers in
the nvme_ctrl_ops data structure and there is one such data structure per
transport. Had you already considered to add a function pointer to that
structure?
Bart.
next prev parent reply other threads:[~2017-08-30 15:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 15:05 [GIT PULL] nvme update for Linux 4.14, take 2 Christoph Hellwig
2017-08-29 15:05 ` Christoph Hellwig
2017-08-29 15:10 ` Jens Axboe
2017-08-29 15:10 ` Jens Axboe
2017-08-30 15:10 ` Sagi Grimberg
2017-08-30 15:10 ` Sagi Grimberg
2017-08-30 15:28 ` Bart Van Assche [this message]
2017-08-30 15:28 ` Bart Van Assche
2017-08-30 15:33 ` Sagi Grimberg
2017-08-30 15:33 ` Sagi Grimberg
2017-08-30 15:46 ` Bart Van Assche
2017-08-30 15:46 ` Bart Van Assche
2017-08-30 15:53 ` Jens Axboe
2017-08-30 15:53 ` Jens Axboe
2017-08-30 16:05 ` Sagi Grimberg
2017-08-30 16:05 ` Sagi Grimberg
2017-08-30 16:11 ` Bart Van Assche
2017-08-30 16:11 ` Bart Van Assche
2017-08-30 16:47 ` Sagi Grimberg
2017-08-30 16:47 ` Sagi Grimberg
2017-08-30 16:56 ` Bart Van Assche
2017-08-30 16:56 ` Bart Van Assche
2017-08-30 20:59 ` Sagi Grimberg
2017-08-30 20:59 ` Sagi Grimberg
2017-08-31 13:10 ` hch
2017-08-31 13:10 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504106914.2526.5.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.