* [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h @ 2017-09-23 20:13 Pavel Machek 2017-09-23 21:10 ` Marek Vasut 0 siblings, 1 reply; 12+ messages in thread From: Pavel Machek @ 2017-09-23 20:13 UTC (permalink / raw) To: dwmw2, computersforpeace, boris.brezillon, marek.vasut, richard, cyrille.pitchen, linux-mtd, linux-kernel, trivial [-- Attachment #1: Type: text/plain, Size: 596 bytes --] C++ comments look wrong in kernel tree. Fix one. Signed-off-by: Pavel Machek <pavel@ucw.cz> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h index 6cd0f6b..849543f1 100644 --- a/include/linux/mtd/mtd.h +++ b/include/linux/mtd/mtd.h @@ -267,7 +267,7 @@ struct mtd_info { */ unsigned int bitflip_threshold; - // Kernel-only stuff starts here. + /* Kernel-only stuff starts here. */ const char *name; int index; -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --] ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h 2017-09-23 20:13 [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h Pavel Machek @ 2017-09-23 21:10 ` Marek Vasut 2017-09-24 8:20 ` Boris Brezillon 0 siblings, 1 reply; 12+ messages in thread From: Marek Vasut @ 2017-09-23 21:10 UTC (permalink / raw) To: Pavel Machek, dwmw2, computersforpeace, boris.brezillon, richard, cyrille.pitchen, linux-mtd, linux-kernel, trivial On 09/23/2017 10:13 PM, Pavel Machek wrote: > C++ comments look wrong in kernel tree. Fix one. AFAIR they are now (sadly) accepted, but this patch works for me. Would be nice if trivial could pick it. > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h > index 6cd0f6b..849543f1 100644 > --- a/include/linux/mtd/mtd.h > +++ b/include/linux/mtd/mtd.h > @@ -267,7 +267,7 @@ struct mtd_info { > */ > unsigned int bitflip_threshold; > > - // Kernel-only stuff starts here. > + /* Kernel-only stuff starts here. */ > const char *name; > int index; > > -- Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h 2017-09-23 21:10 ` Marek Vasut @ 2017-09-24 8:20 ` Boris Brezillon 2017-09-24 8:23 ` Richard Weinberger 0 siblings, 1 reply; 12+ messages in thread From: Boris Brezillon @ 2017-09-24 8:20 UTC (permalink / raw) To: Marek Vasut Cc: Pavel Machek, dwmw2, computersforpeace, richard, cyrille.pitchen, linux-mtd, linux-kernel, trivial On Sat, 23 Sep 2017 23:10:26 +0200 Marek Vasut <marek.vasut@gmail.com> wrote: > On 09/23/2017 10:13 PM, Pavel Machek wrote: > > C++ comments look wrong in kernel tree. Fix one. > > AFAIR they are now (sadly) accepted, but this patch works for me. Works for me too. Here is my Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> > Would be nice if trivial could pick it. Hm, I'd recommend not doing that, otherwise we might end up with a conflict if a patch modify something in this area. > > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > > > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h > > index 6cd0f6b..849543f1 100644 > > --- a/include/linux/mtd/mtd.h > > +++ b/include/linux/mtd/mtd.h > > @@ -267,7 +267,7 @@ struct mtd_info { > > */ > > unsigned int bitflip_threshold; > > > > - // Kernel-only stuff starts here. > > + /* Kernel-only stuff starts here. */ > > const char *name; > > int index; > > > > > > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h 2017-09-24 8:20 ` Boris Brezillon @ 2017-09-24 8:23 ` Richard Weinberger 2017-10-06 11:55 ` Pavel Machek 0 siblings, 1 reply; 12+ messages in thread From: Richard Weinberger @ 2017-09-24 8:23 UTC (permalink / raw) To: Boris Brezillon Cc: Marek Vasut, Pavel Machek, dwmw2, computersforpeace, cyrille.pitchen, linux-mtd, linux-kernel, trivial Am Sonntag, 24. September 2017, 10:20:06 CEST schrieb Boris Brezillon: > On Sat, 23 Sep 2017 23:10:26 +0200 > > Marek Vasut <marek.vasut@gmail.com> wrote: > > On 09/23/2017 10:13 PM, Pavel Machek wrote: > > > C++ comments look wrong in kernel tree. Fix one. > > > > AFAIR they are now (sadly) accepted, but this patch works for me. > > Works for me too. Here is my > > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > > Would be nice if trivial could pick it. > > Hm, I'd recommend not doing that, otherwise we might end up with a > conflict if a patch modify something in this area. Let's carry it via MTD. BTW: Shouldn't it be s/kernel/comment/ in the subject line? Thanks, //richard ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h 2017-09-24 8:23 ` Richard Weinberger @ 2017-10-06 11:55 ` Pavel Machek 2017-10-06 12:00 ` Richard Weinberger 0 siblings, 1 reply; 12+ messages in thread From: Pavel Machek @ 2017-10-06 11:55 UTC (permalink / raw) To: Richard Weinberger Cc: Boris Brezillon, Marek Vasut, dwmw2, computersforpeace, cyrille.pitchen, linux-mtd, linux-kernel, trivial [-- Attachment #1: Type: text/plain, Size: 1014 bytes --] On Sun 2017-09-24 10:23:25, Richard Weinberger wrote: > Am Sonntag, 24. September 2017, 10:20:06 CEST schrieb Boris Brezillon: > > On Sat, 23 Sep 2017 23:10:26 +0200 > > > > Marek Vasut <marek.vasut@gmail.com> wrote: > > > On 09/23/2017 10:13 PM, Pavel Machek wrote: > > > > C++ comments look wrong in kernel tree. Fix one. > > > > > > AFAIR they are now (sadly) accepted, but this patch works for me. > > > > Works for me too. Here is my > > > > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > > > > Would be nice if trivial could pick it. > > > > Hm, I'd recommend not doing that, otherwise we might end up with a > > conflict if a patch modify something in this area. > > Let's carry it via MTD. > BTW: Shouldn't it be s/kernel/comment/ in the subject line? Yes, it should. Can it be fixed while applying? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h 2017-10-06 11:55 ` Pavel Machek @ 2017-10-06 12:00 ` Richard Weinberger 2017-10-06 12:01 ` David Woodhouse 0 siblings, 1 reply; 12+ messages in thread From: Richard Weinberger @ 2017-10-06 12:00 UTC (permalink / raw) To: Pavel Machek Cc: Boris Brezillon, Marek Vasut, dwmw2, computersforpeace, cyrille.pitchen, linux-mtd, linux-kernel, trivial Am Freitag, 6. Oktober 2017, 13:55:14 CEST schrieb Pavel Machek: > > Let's carry it via MTD. > > BTW: Shouldn't it be s/kernel/comment/ in the subject line? > > Yes, it should. Can it be fixed while applying? Sure. :) Thanks, //richard ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h 2017-10-06 12:00 ` Richard Weinberger @ 2017-10-06 12:01 ` David Woodhouse 2017-10-06 12:13 ` Pavel Machek 0 siblings, 1 reply; 12+ messages in thread From: David Woodhouse @ 2017-10-06 12:01 UTC (permalink / raw) To: Richard Weinberger, Pavel Machek Cc: Boris Brezillon, Marek Vasut, computersforpeace, cyrille.pitchen, linux-mtd, linux-kernel, trivial [-- Attachment #1: Type: text/plain, Size: 365 bytes --] On Fri, 2017-10-06 at 14:00 +0200, Richard Weinberger wrote: > Am Freitag, 6. Oktober 2017, 13:55:14 CEST schrieb Pavel Machek: > > > > > > > > Let's carry it via MTD. > > > BTW: Shouldn't it be s/kernel/comment/ in the subject line? > > Yes, it should. Can it be fixed while applying? > Sure. :) You can change 'C++' to 'C99' too, while you're at it :) [-- Attachment #2: smime.p7s --] [-- Type: application/x-pkcs7-signature, Size: 4938 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h 2017-10-06 12:01 ` David Woodhouse @ 2017-10-06 12:13 ` Pavel Machek 2017-10-06 12:25 ` David Woodhouse 2017-10-06 12:32 ` Al Viro 0 siblings, 2 replies; 12+ messages in thread From: Pavel Machek @ 2017-10-06 12:13 UTC (permalink / raw) To: David Woodhouse Cc: Richard Weinberger, Boris Brezillon, Marek Vasut, computersforpeace, cyrille.pitchen, linux-mtd, linux-kernel, trivial On Fri 2017-10-06 13:01:16, David Woodhouse wrote: > On Fri, 2017-10-06 at 14:00 +0200, Richard Weinberger wrote: > > Am Freitag, 6. Oktober 2017, 13:55:14 CEST schrieb Pavel Machek: > > > > > > > > > > > Let's carry it via MTD. > > > > BTW: Shouldn't it be s/kernel/comment/ in the subject line? > > > Yes, it should. Can it be fixed while applying? > > Sure. :) > > You can change 'C++' to 'C99' too, while you're at it :) No. They are C++ comments... as in... dangerous infection that came from C++. Yes, C99 is infected, too, but still C++ is original source of infection :-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h 2017-10-06 12:13 ` Pavel Machek @ 2017-10-06 12:25 ` David Woodhouse 2017-10-12 10:31 ` Alan Cox 2017-10-06 12:32 ` Al Viro 1 sibling, 1 reply; 12+ messages in thread From: David Woodhouse @ 2017-10-06 12:25 UTC (permalink / raw) To: Pavel Machek Cc: Richard Weinberger, Boris Brezillon, Marek Vasut, computersforpeace, cyrille.pitchen, linux-mtd, linux-kernel, trivial [-- Attachment #1: Type: text/plain, Size: 571 bytes --] On Fri, 2017-10-06 at 14:13 +0200, Pavel Machek wrote: > > You can change 'C++' to 'C99' too, while you're at it :) > > No. They are C++ comments... as in... dangerous infection that came > from C++. Yes, C99 is infected, too, but still C++ is original source > of infection :-). C++ is a different language, and irrelevant here. You could call them Java comments if you want, but that would be equally silly. In the kernel, they are C99 comments. Valid, but not our preferred style (which is fair enough, unlike our idiotic refusal to use C99 integer types). [-- Attachment #2: smime.p7s --] [-- Type: application/x-pkcs7-signature, Size: 4938 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h 2017-10-06 12:25 ` David Woodhouse @ 2017-10-12 10:31 ` Alan Cox 0 siblings, 0 replies; 12+ messages in thread From: Alan Cox @ 2017-10-12 10:31 UTC (permalink / raw) To: David Woodhouse; +Cc: linux-mtd, linux-kernel On Fri, 06 Oct 2017 13:25:55 +0100 David Woodhouse <dwmw2@infradead.org> wrote: > On Fri, 2017-10-06 at 14:13 +0200, Pavel Machek wrote: > > > You can change 'C++' to 'C99' too, while you're at it :) > > > > No. They are C++ comments... as in... dangerous infection that came > > from C++. Yes, C99 is infected, too, but still C++ is original source > > of infection :-). > > C++ is a different language, and irrelevant here. You could call them > Java comments if you want, but that would be equally silly. In the > kernel, they are C99 comments. Valid, but not our preferred style > (which is fair enough, unlike our idiotic refusal to use C99 integer > types). We might as well allow them. We are using those compiler settings so the cases where your compilation produces different results in C99 and more classic C are no longer a risk 8) int main(int argc, char *argv[]) { int x = 1//**/ -1; if (x == 0) puts("Ewww C99"); exit(0); } ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h 2017-10-06 12:13 ` Pavel Machek 2017-10-06 12:25 ` David Woodhouse @ 2017-10-06 12:32 ` Al Viro 2017-10-06 13:04 ` Geert Uytterhoeven 1 sibling, 1 reply; 12+ messages in thread From: Al Viro @ 2017-10-06 12:32 UTC (permalink / raw) To: Pavel Machek Cc: David Woodhouse, Richard Weinberger, Boris Brezillon, Marek Vasut, computersforpeace, cyrille.pitchen, linux-mtd, linux-kernel, trivial On Fri, Oct 06, 2017 at 02:13:59PM +0200, Pavel Machek wrote: > On Fri 2017-10-06 13:01:16, David Woodhouse wrote: > > On Fri, 2017-10-06 at 14:00 +0200, Richard Weinberger wrote: > > > Am Freitag, 6. Oktober 2017, 13:55:14 CEST schrieb Pavel Machek: > > > > > > > > > > > > > > Let's carry it via MTD. > > > > > BTW: Shouldn't it be s/kernel/comment/ in the subject line? > > > > Yes, it should. Can it be fixed while applying? > > > Sure. :) > > > > You can change 'C++' to 'C99' too, while you're at it :) > > No. They are C++ comments... as in... dangerous infection that came > from C++. Yes, C99 is infected, too, but still C++ is original source > of infection :-). No, it is not. See https://www.bell-labs.com/usr/dmr/www/bcpl.html and scans refered therein; let's keep snobbery historically accurate... IOW, it's not C++ invention - it's BCPL one. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h 2017-10-06 12:32 ` Al Viro @ 2017-10-06 13:04 ` Geert Uytterhoeven 0 siblings, 0 replies; 12+ messages in thread From: Geert Uytterhoeven @ 2017-10-06 13:04 UTC (permalink / raw) To: Al Viro Cc: Pavel Machek, David Woodhouse, Richard Weinberger, Boris Brezillon, Marek Vasut, Brian Norris, Cyrille Pitchen, MTD Maling List, linux-kernel, Jiri Kosina On Fri, Oct 6, 2017 at 2:32 PM, Al Viro <viro@zeniv.linux.org.uk> wrote: > On Fri, Oct 06, 2017 at 02:13:59PM +0200, Pavel Machek wrote: >> On Fri 2017-10-06 13:01:16, David Woodhouse wrote: >> > On Fri, 2017-10-06 at 14:00 +0200, Richard Weinberger wrote: >> > > Am Freitag, 6. Oktober 2017, 13:55:14 CEST schrieb Pavel Machek: >> > > > > Let's carry it via MTD. >> > > > > BTW: Shouldn't it be s/kernel/comment/ in the subject line? >> > > > Yes, it should. Can it be fixed while applying? >> > > Sure. :) >> > >> > You can change 'C++' to 'C99' too, while you're at it :) >> >> No. They are C++ comments... as in... dangerous infection that came >> from C++. Yes, C99 is infected, too, but still C++ is original source >> of infection :-). > > No, it is not. See https://www.bell-labs.com/usr/dmr/www/bcpl.html and > scans refered therein; let's keep snobbery historically accurate... > > IOW, it's not C++ invention - it's BCPL one. Ah, longing for the return of BPTRs and BSTRs ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-10-12 10:31 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-09-23 20:13 [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h Pavel Machek 2017-09-23 21:10 ` Marek Vasut 2017-09-24 8:20 ` Boris Brezillon 2017-09-24 8:23 ` Richard Weinberger 2017-10-06 11:55 ` Pavel Machek 2017-10-06 12:00 ` Richard Weinberger 2017-10-06 12:01 ` David Woodhouse 2017-10-06 12:13 ` Pavel Machek 2017-10-06 12:25 ` David Woodhouse 2017-10-12 10:31 ` Alan Cox 2017-10-06 12:32 ` Al Viro 2017-10-06 13:04 ` Geert Uytterhoeven
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.