[igt-dev] [PATCH i-g-t] Remove resource streamer tests

[igt-dev] [PATCH i-g-t] Remove resource streamer tests

[Lucas De Marchi]

Resource streamer is being removed from all GENs, so just test it
returns EINVAL when a batch is submitted with I915_EXEC_RESOURCE_STREAMER.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---

Required by https://patchwork.freedesktop.org/series/46224/

 tests/gem_exec_params.c | 22 ++--------------------
 1 file changed, 2 insertions(+), 20 deletions(-)

diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
index 04c21c05..4cb7ceb0 100644
--- a/tests/gem_exec_params.c
+++ b/tests/gem_exec_params.c
@@ -374,30 +374,12 @@ igt_main
 		execbuf.num_cliprects = 0;
 	}
 
-	igt_subtest("rs-invalid-on-bsd-ring") {
-		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
+	/* Resource Streamer has been removed from all Gens */
+	igt_subtest("rs-invalid") {
 		execbuf.flags = I915_EXEC_BSD | LOCAL_I915_EXEC_RESOURCE_STREAMER;
 		RUN_FAIL(EINVAL);
 	}
 
-	igt_subtest("rs-invalid-on-blt-ring") {
-		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
-		execbuf.flags = I915_EXEC_BLT | LOCAL_I915_EXEC_RESOURCE_STREAMER;
-		RUN_FAIL(EINVAL);
-	}
-
-	igt_subtest("rs-invalid-on-vebox-ring") {
-		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
-		execbuf.flags = I915_EXEC_VEBOX | LOCAL_I915_EXEC_RESOURCE_STREAMER;
-		RUN_FAIL(EINVAL);
-	}
-
-	igt_subtest("rs-invalid-gen") {
-		igt_require(!IS_HASWELL(devid) && intel_gen(devid) < 8);
-		execbuf.flags = I915_EXEC_RENDER | LOCAL_I915_EXEC_RESOURCE_STREAMER;
-		RUN_FAIL(EINVAL);
-	}
-
 	igt_subtest("invalid-fence-in") {
 		igt_require(gem_has_exec_fence(fd));
 		execbuf.flags = LOCAL_I915_EXEC_FENCE_IN;
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for Remove resource streamer tests

[Patchwork]

== Series Details ==

Series: Remove resource streamer tests
URL   : https://patchwork.freedesktop.org/series/46439/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4476 -> IGTPW_1573 =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1573 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1573, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46439/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1573:

  === IGT changes ===

    ==== Warnings ====

    igt@pm_rpm@basic-rte:
      fi-hsw-peppy:       SKIP -> PASS +1
      fi-hsw-4770r:       SKIP -> PASS +1
      fi-bdw-5557u:       SKIP -> PASS +1
      fi-hsw-4770:        SKIP -> PASS +1

    
== Known issues ==

  Here are the changes found in IGTPW_1573 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-no-display:
      {fi-skl-iommu}:     NOTRUN -> FAIL (fdo#106066) +2

    igt@kms_frontbuffer_tracking@basic:
      fi-kbl-r:           PASS -> DMESG-WARN (fdo#105602)

    
    ==== Possible fixes ====

    igt@kms_flip@basic-flip-vs-dpms:
      fi-skl-6700hq:      DMESG-WARN (fdo#105998) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
  fdo#106066 https://bugs.freedesktop.org/show_bug.cgi?id=106066


== Participating hosts (45 -> 41) ==

  Additional (1): fi-skl-iommu 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4552 -> IGTPW_1573

  CI_DRM_4476: b818fac0878147c6df45338cb515b9b7bd878b7f @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1573: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1573/
  IGT_4552: 5175aff31e00e17786ebb97aaaf25ddd38b5e72e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@gem_exec_params@rs-invalid
-igt@gem_exec_params@rs-invalid-gen
-igt@gem_exec_params@rs-invalid-on-blt-ring
-igt@gem_exec_params@rs-invalid-on-bsd-ring
-igt@gem_exec_params@rs-invalid-on-vebox-ring

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1573/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for Remove resource streamer tests

[Patchwork]

== Series Details ==

Series: Remove resource streamer tests
URL   : https://patchwork.freedesktop.org/series/46439/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4552_full -> IGTPW_1573_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1573_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1573_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46439/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1573_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-vebox:
      shard-kbl:          SKIP -> PASS

    igt@gem_mocs_settings@mocs-rc6-ctx-dirty-render:
      shard-kbl:          PASS -> SKIP +2

    igt@pm_rpm@cursor:
      shard-hsw:          SKIP -> PASS +34

    
== Known issues ==

  Here are the changes found in IGTPW_1573_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_ctx_isolation@vecs0-s3:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)

    igt@gem_exec_schedule@pi-ringfull-blt:
      shard-glk:          NOTRUN -> FAIL (fdo#103158)

    igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
      shard-glk:          PASS -> FAIL (fdo#106765)

    igt@kms_flip@2x-plain-flip-fb-recreate:
      shard-hsw:          PASS -> FAIL (fdo#100368)

    igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
      shard-glk:          PASS -> FAIL (fdo#100368) +3

    igt@kms_flip_tiling@flip-to-x-tiled:
      shard-glk:          PASS -> FAIL (fdo#107161, fdo#103822)

    igt@prime_vgem@busy-bsd2:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    
    ==== Possible fixes ====

    igt@gem_exec_async@concurrent-writes-blt:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@gem_ppgtt@blt-vs-render-ctx0:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106023) -> PASS

    igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled:
      shard-glk:          FAIL -> PASS

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-glk:          FAIL (fdo#105189) -> PASS

    igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
      shard-hsw:          FAIL (fdo#100368) -> PASS

    igt@kms_flip_tiling@flip-y-tiled:
      shard-glk:          FAIL (fdo#107161) -> PASS

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-snb:          FAIL (fdo#103925) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105189 https://bugs.freedesktop.org/show_bug.cgi?id=105189
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106765 https://bugs.freedesktop.org/show_bug.cgi?id=106765
  fdo#107161 https://bugs.freedesktop.org/show_bug.cgi?id=107161
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4552 -> IGTPW_1573
    * Linux: CI_DRM_4475 -> CI_DRM_4476

  CI_DRM_4475: 1b6f049d73237a170919604538e747b0282b0109 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4476: b818fac0878147c6df45338cb515b9b7bd878b7f @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1573: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1573/
  IGT_4552: 5175aff31e00e17786ebb97aaaf25ddd38b5e72e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1573/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] Remove resource streamer tests

[Daniel Vetter]

On Thu, Jul 12, 2018 at 01:51:03PM -0700, Lucas De Marchi wrote:
> Resource streamer is being removed from all GENs, so just test it
> returns EINVAL when a batch is submitted with I915_EXEC_RESOURCE_STREAMER.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Erm, you're not removing the RS tests, only the ioctl flag validation
tests. Those we still want, I'd say 1 per ring, including RCS. Makes CI
mildly unhappy because we can't submit both a kernel and igt series
together, but oh well.
-Daniel

> ---
> 
> Required by https://patchwork.freedesktop.org/series/46224/
> 
>  tests/gem_exec_params.c | 22 ++--------------------
>  1 file changed, 2 insertions(+), 20 deletions(-)
> 
> diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
> index 04c21c05..4cb7ceb0 100644
> --- a/tests/gem_exec_params.c
> +++ b/tests/gem_exec_params.c
> @@ -374,30 +374,12 @@ igt_main
>  		execbuf.num_cliprects = 0;
>  	}
>  
> -	igt_subtest("rs-invalid-on-bsd-ring") {
> -		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
> +	/* Resource Streamer has been removed from all Gens */
> +	igt_subtest("rs-invalid") {
>  		execbuf.flags = I915_EXEC_BSD | LOCAL_I915_EXEC_RESOURCE_STREAMER;
>  		RUN_FAIL(EINVAL);
>  	}
>  
> -	igt_subtest("rs-invalid-on-blt-ring") {
> -		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
> -		execbuf.flags = I915_EXEC_BLT | LOCAL_I915_EXEC_RESOURCE_STREAMER;
> -		RUN_FAIL(EINVAL);
> -	}
> -
> -	igt_subtest("rs-invalid-on-vebox-ring") {
> -		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
> -		execbuf.flags = I915_EXEC_VEBOX | LOCAL_I915_EXEC_RESOURCE_STREAMER;
> -		RUN_FAIL(EINVAL);
> -	}
> -
> -	igt_subtest("rs-invalid-gen") {
> -		igt_require(!IS_HASWELL(devid) && intel_gen(devid) < 8);
> -		execbuf.flags = I915_EXEC_RENDER | LOCAL_I915_EXEC_RESOURCE_STREAMER;
> -		RUN_FAIL(EINVAL);
> -	}
> -
>  	igt_subtest("invalid-fence-in") {
>  		igt_require(gem_has_exec_fence(fd));
>  		execbuf.flags = LOCAL_I915_EXEC_FENCE_IN;
> -- 
> 2.17.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v2] Follow kernel's resource streamer removal

[Lucas De Marchi]

Resource streamer is being removed from all GENs, so just test it
returns EINVAL for all GENs when a batch is submitted with
I915_EXEC_RESOURCE_STREAMER keeping one test per ring.

v2: let one test per ring rather than just one test

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---

This requires the patch for the kernel removing RS from all gens.

 tests/gem_exec_params.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
index 04c21c05..f822297f 100644
--- a/tests/gem_exec_params.c
+++ b/tests/gem_exec_params.c
@@ -375,25 +375,21 @@ igt_main
 	}
 
 	igt_subtest("rs-invalid-on-bsd-ring") {
-		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
 		execbuf.flags = I915_EXEC_BSD | LOCAL_I915_EXEC_RESOURCE_STREAMER;
 		RUN_FAIL(EINVAL);
 	}
 
 	igt_subtest("rs-invalid-on-blt-ring") {
-		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
 		execbuf.flags = I915_EXEC_BLT | LOCAL_I915_EXEC_RESOURCE_STREAMER;
 		RUN_FAIL(EINVAL);
 	}
 
 	igt_subtest("rs-invalid-on-vebox-ring") {
-		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
 		execbuf.flags = I915_EXEC_VEBOX | LOCAL_I915_EXEC_RESOURCE_STREAMER;
 		RUN_FAIL(EINVAL);
 	}
 
-	igt_subtest("rs-invalid-gen") {
-		igt_require(!IS_HASWELL(devid) && intel_gen(devid) < 8);
+	igt_subtest("rs-invalid-on-render-ring") {
 		execbuf.flags = I915_EXEC_RENDER | LOCAL_I915_EXEC_RESOURCE_STREAMER;
 		RUN_FAIL(EINVAL);
 	}
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Follow kernel's resource streamer removal

[Chris Wilson]

Quoting Lucas De Marchi (2018-07-19 20:16:14)
> Resource streamer is being removed from all GENs, so just test it
> returns EINVAL for all GENs when a batch is submitted with
> I915_EXEC_RESOURCE_STREAMER keeping one test per ring.
> 
> v2: let one test per ring rather than just one test
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> 
> This requires the patch for the kernel removing RS from all gens.
> 
>  tests/gem_exec_params.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
> index 04c21c05..f822297f 100644
> --- a/tests/gem_exec_params.c
> +++ b/tests/gem_exec_params.c
> @@ -375,25 +375,21 @@ igt_main
>         }
>  
>         igt_subtest("rs-invalid-on-bsd-ring") {
> -               igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);

Now fails on old kernels...

igt_subtest("rs-invalid") {
	int has_rs = gem_param(HAS_RESOURCE_STREAMER);
	for_each_engine(fd, ring) {
		int expect = -EINVAL;
		if (has_rs && (ring == 0 || ring == I915_EXEC_RENDER))
			expect = 0;

		execbuf.flags = engine;
		igt_assert_eq(__gem_execbuf(fd, &execbuf), expect);
	}
}

Now if we reinterpret the param as the uabi-class bitmask...
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Follow kernel's resource streamer removal

[Lucas De Marchi]

On Thu, Jul 19, 2018 at 08:26:11PM +0100, Chris Wilson wrote:
> Quoting Lucas De Marchi (2018-07-19 20:16:14)
> > Resource streamer is being removed from all GENs, so just test it
> > returns EINVAL for all GENs when a batch is submitted with
> > I915_EXEC_RESOURCE_STREAMER keeping one test per ring.
> > 
> > v2: let one test per ring rather than just one test
> > 
> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> > ---
> > 
> > This requires the patch for the kernel removing RS from all gens.
> > 
> >  tests/gem_exec_params.c | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> > 
> > diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
> > index 04c21c05..f822297f 100644
> > --- a/tests/gem_exec_params.c
> > +++ b/tests/gem_exec_params.c
> > @@ -375,25 +375,21 @@ igt_main
> >         }
> >  
> >         igt_subtest("rs-invalid-on-bsd-ring") {
> > -               igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
> 
> Now fails on old kernels...
> 
> igt_subtest("rs-invalid") {
> 	int has_rs = gem_param(HAS_RESOURCE_STREAMER);
> 	for_each_engine(fd, ring) {
> 		int expect = -EINVAL;
> 		if (has_rs && (ring == 0 || ring == I915_EXEC_RENDER))
> 			expect = 0;

if we are removing resource streamer from the kernel, shouldn't we
expect EINVAL on all rings now?

Lucas De Marchi

> 
> 		execbuf.flags = engine;
> 		igt_assert_eq(__gem_execbuf(fd, &execbuf), expect);
> 	}
> }
> 
> Now if we reinterpret the param as the uabi-class bitmask...
> -Chris
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Follow kernel's resource streamer removal

[Lucas De Marchi]

On Mon, Jul 23, 2018 at 02:15:01PM -0700, Lucas De Marchi wrote:
> On Thu, Jul 19, 2018 at 08:26:11PM +0100, Chris Wilson wrote:
> > Quoting Lucas De Marchi (2018-07-19 20:16:14)
> > > Resource streamer is being removed from all GENs, so just test it
> > > returns EINVAL for all GENs when a batch is submitted with
> > > I915_EXEC_RESOURCE_STREAMER keeping one test per ring.
> > > 
> > > v2: let one test per ring rather than just one test
> > > 
> > > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> > > ---
> > > 
> > > This requires the patch for the kernel removing RS from all gens.
> > > 
> > >  tests/gem_exec_params.c | 6 +-----
> > >  1 file changed, 1 insertion(+), 5 deletions(-)
> > > 
> > > diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
> > > index 04c21c05..f822297f 100644
> > > --- a/tests/gem_exec_params.c
> > > +++ b/tests/gem_exec_params.c
> > > @@ -375,25 +375,21 @@ igt_main
> > >         }
> > >  
> > >         igt_subtest("rs-invalid-on-bsd-ring") {
> > > -               igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
> > 
> > Now fails on old kernels...
> > 
> > igt_subtest("rs-invalid") {
> > 	int has_rs = gem_param(HAS_RESOURCE_STREAMER);
> > 	for_each_engine(fd, ring) {
> > 		int expect = -EINVAL;
> > 		if (has_rs && (ring == 0 || ring == I915_EXEC_RENDER))
> > 			expect = 0;
> 
> if we are removing resource streamer from the kernel, shouldn't we
> expect EINVAL on all rings now?
> 
> Lucas De Marchi
> 
> > 
> > 		execbuf.flags = engine;

and "| LOCAL_I915_EXEC_RESOURCE_STREAMER" here

Lucas De Marchi

> > 		igt_assert_eq(__gem_execbuf(fd, &execbuf), expect);
> > 	}
> > }
> > 
> > Now if we reinterpret the param as the uabi-class bitmask...
> > -Chris
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Follow kernel's resource streamer removal

[Chris Wilson]

Quoting Lucas De Marchi (2018-07-23 22:15:01)
> On Thu, Jul 19, 2018 at 08:26:11PM +0100, Chris Wilson wrote:
> > Quoting Lucas De Marchi (2018-07-19 20:16:14)
> > > Resource streamer is being removed from all GENs, so just test it
> > > returns EINVAL for all GENs when a batch is submitted with
> > > I915_EXEC_RESOURCE_STREAMER keeping one test per ring.
> > > 
> > > v2: let one test per ring rather than just one test
> > > 
> > > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> > > ---
> > > 
> > > This requires the patch for the kernel removing RS from all gens.
> > > 
> > >  tests/gem_exec_params.c | 6 +-----
> > >  1 file changed, 1 insertion(+), 5 deletions(-)
> > > 
> > > diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
> > > index 04c21c05..f822297f 100644
> > > --- a/tests/gem_exec_params.c
> > > +++ b/tests/gem_exec_params.c
> > > @@ -375,25 +375,21 @@ igt_main
> > >         }
> > >  
> > >         igt_subtest("rs-invalid-on-bsd-ring") {
> > > -               igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
> > 
> > Now fails on old kernels...
> > 
> > igt_subtest("rs-invalid") {
> >       int has_rs = gem_param(HAS_RESOURCE_STREAMER);
> >       for_each_engine(fd, ring) {
> >               int expect = -EINVAL;
> >               if (has_rs && (ring == 0 || ring == I915_EXEC_RENDER))
> >                       expect = 0;
> 
> if we are removing resource streamer from the kernel, shouldn't we
> expect EINVAL on all rings now?

Some kernels have resource streamer support.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v3] Follow kernel's resource streamer removal

[Lucas De Marchi]

Resource streamer is being removed from all GENs, so rewrite the tests
so to loop over all engines and set the expected return in case the platform has
resource streamer.  This makes it compatible with both old and new
kernels (thanks Chris).

v2: let one test per ring rather than just one test
v3: check what the kernel returns for
    I915_HAS_RESOURCE_STREAMER to decide what we expect as return value
    from the the batch submission (suggested by Chris)

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 tests/gem_exec_params.c | 41 +++++++++++++++++++++--------------------
 1 file changed, 21 insertions(+), 20 deletions(-)

diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
index 04c21c05..49c56a8d 100644
--- a/tests/gem_exec_params.c
+++ b/tests/gem_exec_params.c
@@ -87,6 +87,17 @@ static bool has_exec_batch_first(int fd)
 	return val > 0;
 }
 
+static bool has_resource_streamer(int fd)
+{
+	int val = -1;
+	struct drm_i915_getparam gp = {
+		.param = I915_PARAM_HAS_RESOURCE_STREAMER,
+		.value = &val,
+	};
+	ioctl(fd, DRM_IOCTL_I915_GETPARAM , &gp);
+	return val > 0;
+}
+
 static void test_batch_first(int fd)
 {
 	const int gen = intel_gen(intel_get_drm_devid(fd));
@@ -374,28 +385,18 @@ igt_main
 		execbuf.num_cliprects = 0;
 	}
 
-	igt_subtest("rs-invalid-on-bsd-ring") {
-		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
-		execbuf.flags = I915_EXEC_BSD | LOCAL_I915_EXEC_RESOURCE_STREAMER;
-		RUN_FAIL(EINVAL);
-	}
-
-	igt_subtest("rs-invalid-on-blt-ring") {
-		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
-		execbuf.flags = I915_EXEC_BLT | LOCAL_I915_EXEC_RESOURCE_STREAMER;
-		RUN_FAIL(EINVAL);
-	}
+	igt_subtest("rs-invalid") {
+		bool has_rs = has_resource_streamer(fd);
+		unsigned int engine;
 
-	igt_subtest("rs-invalid-on-vebox-ring") {
-		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
-		execbuf.flags = I915_EXEC_VEBOX | LOCAL_I915_EXEC_RESOURCE_STREAMER;
-		RUN_FAIL(EINVAL);
-	}
+		for_each_engine(fd, engine) {
+			int expect = -EINVAL;
+			if (has_rs && (engine == 0 || engine == I915_EXEC_RENDER))
+				expect = 0;
 
-	igt_subtest("rs-invalid-gen") {
-		igt_require(!IS_HASWELL(devid) && intel_gen(devid) < 8);
-		execbuf.flags = I915_EXEC_RENDER | LOCAL_I915_EXEC_RESOURCE_STREAMER;
-		RUN_FAIL(EINVAL);
+			execbuf.flags = engine | LOCAL_I915_EXEC_RESOURCE_STREAMER;
+			igt_assert_eq(__gem_execbuf(fd, &execbuf), expect);
+		}
 	}
 
 	igt_subtest("invalid-fence-in") {
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v3] Follow kernel's resource streamer removal

[Chris Wilson]

Quoting Lucas De Marchi (2018-08-01 00:53:06)
> Resource streamer is being removed from all GENs, so rewrite the tests
> so to loop over all engines and set the expected return in case the platform has
> resource streamer.  This makes it compatible with both old and new
> kernels (thanks Chris).
> 
> v2: let one test per ring rather than just one test
> v3: check what the kernel returns for
>     I915_HAS_RESOURCE_STREAMER to decide what we expect as return value
>     from the the batch submission (suggested by Chris)
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Looks forwards/backwards compatible,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v3] Follow kernel's resource streamer removal

[Rodrigo Vivi]

On Wed, Aug 01, 2018 at 09:53:48AM +0100, Chris Wilson wrote:
> Quoting Lucas De Marchi (2018-08-01 00:53:06)
> > Resource streamer is being removed from all GENs, so rewrite the tests
> > so to loop over all engines and set the expected return in case the platform has
> > resource streamer.  This makes it compatible with both old and new
> > kernels (thanks Chris).
> > 
> > v2: let one test per ring rather than just one test
> > v3: check what the kernel returns for
> >     I915_HAS_RESOURCE_STREAMER to decide what we expect as return value
> >     from the the batch submission (suggested by Chris)
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> 
> Looks forwards/backwards compatible,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

pushed, thanks.

> -Chris
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Follow kernel's resource streamer removal

[Rodrigo Vivi]

On Thu, Jul 19, 2018 at 12:16:14PM -0700, Lucas De Marchi wrote:
> Resource streamer is being removed from all GENs, so just test it
> returns EINVAL for all GENs when a batch is submitted with
> I915_EXEC_RESOURCE_STREAMER keeping one test per ring.
> 
> v2: let one test per ring rather than just one test

I believe this patch should already remove LOCAL_I915_EXEC_RESOURCE_STREAMER

So, probably, we would be able to soon kill that on the kernel side as well?!

> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> 
> This requires the patch for the kernel removing RS from all gens.
> 
>  tests/gem_exec_params.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
> index 04c21c05..f822297f 100644
> --- a/tests/gem_exec_params.c
> +++ b/tests/gem_exec_params.c
> @@ -375,25 +375,21 @@ igt_main
>  	}
>  
>  	igt_subtest("rs-invalid-on-bsd-ring") {
> -		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
>  		execbuf.flags = I915_EXEC_BSD | LOCAL_I915_EXEC_RESOURCE_STREAMER;
>  		RUN_FAIL(EINVAL);
>  	}
>  
>  	igt_subtest("rs-invalid-on-blt-ring") {
> -		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
>  		execbuf.flags = I915_EXEC_BLT | LOCAL_I915_EXEC_RESOURCE_STREAMER;
>  		RUN_FAIL(EINVAL);
>  	}
>  
>  	igt_subtest("rs-invalid-on-vebox-ring") {
> -		igt_require(IS_HASWELL(devid) || intel_gen(devid) >= 8);
>  		execbuf.flags = I915_EXEC_VEBOX | LOCAL_I915_EXEC_RESOURCE_STREAMER;
>  		RUN_FAIL(EINVAL);
>  	}
>  
> -	igt_subtest("rs-invalid-gen") {
> -		igt_require(!IS_HASWELL(devid) && intel_gen(devid) < 8);
> +	igt_subtest("rs-invalid-on-render-ring") {
>  		execbuf.flags = I915_EXEC_RENDER | LOCAL_I915_EXEC_RESOURCE_STREAMER;
>  		RUN_FAIL(EINVAL);
>  	}
> -- 
> 2.17.1
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Follow kernel's resource streamer removal

[Chris Wilson]

Quoting Rodrigo Vivi (2018-07-19 20:51:13)
> On Thu, Jul 19, 2018 at 12:16:14PM -0700, Lucas De Marchi wrote:
> > Resource streamer is being removed from all GENs, so just test it
> > returns EINVAL for all GENs when a batch is submitted with
> > I915_EXEC_RESOURCE_STREAMER keeping one test per ring.
> > 
> > v2: let one test per ring rather than just one test
> 
> I believe this patch should already remove LOCAL_I915_EXEC_RESOURCE_STREAMER
> 
> So, probably, we would be able to soon kill that on the kernel side as well?!

We do want to keep it to document the old numbers. Otherwise we leave
unexplained holes.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Follow kernel's resource streamer removal

[Rodrigo Vivi]

On Thu, Jul 19, 2018 at 09:04:28PM +0100, Chris Wilson wrote:
> Quoting Rodrigo Vivi (2018-07-19 20:51:13)
> > On Thu, Jul 19, 2018 at 12:16:14PM -0700, Lucas De Marchi wrote:
> > > Resource streamer is being removed from all GENs, so just test it
> > > returns EINVAL for all GENs when a batch is submitted with
> > > I915_EXEC_RESOURCE_STREAMER keeping one test per ring.
> > > 
> > > v2: let one test per ring rather than just one test
> > 
> > I believe this patch should already remove LOCAL_I915_EXEC_RESOURCE_STREAMER
> > 
> > So, probably, we would be able to soon kill that on the kernel side as well?!
> 
> We do want to keep it to document the old numbers. Otherwise we leave
> unexplained holes.

oh! true... that's a sequence...

> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for Remove resource streamer tests (rev2)

[Patchwork]

== Series Details ==

Series: Remove resource streamer tests (rev2)
URL   : https://patchwork.freedesktop.org/series/46439/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4509 -> IGTPW_1609 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46439/revisions/2/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1609 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)

    
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927


== Participating hosts (46 -> 42) ==

  Additional (1): fi-kbl-7560u 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4567 -> IGTPW_1609

  CI_DRM_4509: e84aa0b47beed78a5a12db93e76fb00eab5db160 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1609: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1609/
  IGT_4567: 7f85adc4050182f490c7a5c48db3d57cdb00af4e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@gem_exec_params@rs-invalid-on-render-ring
-igt@gem_exec_params@rs-invalid-gen

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1609/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for Remove resource streamer tests (rev2)

[Patchwork]

== Series Details ==

Series: Remove resource streamer tests (rev2)
URL   : https://patchwork.freedesktop.org/series/46439/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4567_full -> IGTPW_1609_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1609_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1609_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46439/revisions/2/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1609_full:

  === IGT changes ===

    ==== Possible regressions ====

    {igt@gem_exec_params@rs-invalid-on-render-ring}:
      shard-glk:          NOTRUN -> FAIL
      shard-hsw:          NOTRUN -> FAIL
      shard-kbl:          NOTRUN -> FAIL
      shard-apl:          NOTRUN -> FAIL

    
    ==== Warnings ====

    igt@drv_suspend@shrink:
      shard-apl:          PASS -> SKIP
      shard-glk:          PASS -> SKIP

    igt@gem_exec_params@rs-invalid-on-vebox-ring:
      shard-snb:          SKIP -> PASS +2

    igt@gem_exec_schedule@deep-bsd2:
      shard-kbl:          PASS -> SKIP +1

    igt@perf_pmu@rc6:
      shard-kbl:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1609_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_workarounds@suspend-resume-context:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-glk:          NOTRUN -> FAIL (fdo#106641)

    igt@kms_flip@blocking-wf_vblank:
      shard-glk:          PASS -> FAIL (fdo#100368) +1

    igt@kms_universal_plane@cursor-fb-leak-pipe-b:
      shard-apl:          PASS -> FAIL (fdo#107241)

    igt@prime_busy@hang-vebox:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    
    ==== Possible fixes ====

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-glk:          FAIL (fdo#105189) -> PASS

    igt@kms_flip@plain-flip-fb-recreate:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          FAIL (fdo#103925) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

    igt@kms_vblank@pipe-a-ts-continuation-suspend:
      shard-hsw:          FAIL (fdo#104894) -> PASS

    igt@perf@polling:
      shard-hsw:          FAIL (fdo#102252) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#104894 https://bugs.freedesktop.org/show_bug.cgi?id=104894
  fdo#105189 https://bugs.freedesktop.org/show_bug.cgi?id=105189
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#107241 https://bugs.freedesktop.org/show_bug.cgi?id=107241
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4567 -> IGTPW_1609
    * Linux: CI_DRM_4507 -> CI_DRM_4509

  CI_DRM_4507: 3bbfaebaf3ba21d866c7823d9e4febf47b4b7b39 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4509: e84aa0b47beed78a5a12db93e76fb00eab5db160 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1609: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1609/
  IGT_4567: 7f85adc4050182f490c7a5c48db3d57cdb00af4e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1609/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for Remove resource streamer tests (rev3)

[Patchwork]

== Series Details ==

Series: Remove resource streamer tests (rev3)
URL   : https://patchwork.freedesktop.org/series/46439/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4592 -> IGTPW_1673 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46439/revisions/3/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1673 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)

    
    ==== Warnings ====

    {igt@kms_psr@primary_page_flip}:
      fi-cnl-psr:         DMESG-WARN (fdo#107372) -> DMESG-FAIL (fdo#107372)

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372


== Participating hosts (52 -> 45) ==

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u fi-byt-clapper 


== Build changes ==

    * IGT: IGT_4580 -> IGTPW_1673

  CI_DRM_4592: ed4b6c987889caf5a4041cf78eacdede85964577 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1673: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1673/
  IGT_4580: f1c868dae24056ebc27e4f3c197724ce9b956a8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@gem_exec_params@rs-invalid
-igt@gem_exec_params@rs-invalid-gen
-igt@gem_exec_params@rs-invalid-on-blt-ring
-igt@gem_exec_params@rs-invalid-on-bsd-ring
-igt@gem_exec_params@rs-invalid-on-vebox-ring

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1673/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for Remove resource streamer tests (rev3)

[Patchwork]

== Series Details ==

Series: Remove resource streamer tests (rev3)
URL   : https://patchwork.freedesktop.org/series/46439/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4580_full -> IGTPW_1673_full =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46439/revisions/3/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1673_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          PASS -> FAIL (fdo#106641)

    igt@kms_flip@2x-wf_vblank-ts-check:
      shard-glk:          PASS -> FAIL (fdo#100368) +1

    igt@testdisplay:
      shard-glk:          PASS -> INCOMPLETE (fdo#107093, fdo#103359, k.org#198133)

    
    ==== Possible fixes ====

    igt@kms_flip@plain-flip-fb-recreate-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          FAIL (fdo#103166) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4580 -> IGTPW_1673
    * Linux: CI_DRM_4562 -> CI_DRM_4592

  CI_DRM_4562: 99bbd80f75cdcf28699ffd3c93a714ca4a89b962 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4592: ed4b6c987889caf5a4041cf78eacdede85964577 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1673: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1673/
  IGT_4580: f1c868dae24056ebc27e4f3c197724ce9b956a8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1673/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev