All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manasi Navare <manasi.d.navare@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 23/23] drm/i915/dp: Disable DSC in source by disabling DSS CTL bits
Date: Mon, 30 Jul 2018 19:13:03 -0700	[thread overview]
Message-ID: <1533003183-22793-24-git-send-email-manasi.d.navare@intel.com> (raw)
In-Reply-To: <1533003183-22793-1-git-send-email-manasi.d.navare@intel.com>

From: Gaurav K Singh <gaurav.k.singh@intel.com>

1. Disable Left/right VDSC branch in DSS Ctrl reg
    depending on the number of VDSC engines being used
2. Disable joiner in DSS Ctrl reg

v4: (From  Manasi)
* Rebase on top of revised patches
v3 (From Manasi):
* Use old_crtc_state to find dsc params
* Add a condition to disable only if
dsc state compression is enabled
* Use correct DSS CTL regs
v2 (From Manasi):
* Fix tons of compilation errors like undefined
variables, incorrect use of macros and all dirty laundry

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
---
 drivers/gpu/drm/i915/intel_vdsc.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_vdsc.c b/drivers/gpu/drm/i915/intel_vdsc.c
index 6d5d410..c13f32b 100644
--- a/drivers/gpu/drm/i915/intel_vdsc.c
+++ b/drivers/gpu/drm/i915/intel_vdsc.c
@@ -1046,3 +1046,35 @@ void intel_dsc_enable(struct intel_encoder *encoder,
 
 	return;
 }
+
+void intel_dsc_disable(struct intel_encoder *encoder,
+		       struct intel_crtc_state *old_crtc_state)
+{
+	struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->base.crtc);
+	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
+	enum pipe pipe = crtc->pipe;
+	i915_reg_t dss_ctl1_reg, dss_ctl2_reg;
+	u32 dss_ctl1_val = 0, dss_ctl2_val = 0;
+
+	if (!old_crtc_state->dsc_params.compression_enable)
+		return;
+
+	if (encoder->type == INTEL_OUTPUT_EDP) {
+		dss_ctl1_reg = DSS_CTL1;
+		dss_ctl2_reg = DSS_CTL2;
+	} else {
+		dss_ctl1_reg = ICL_PIPE_DSS_CTL1(pipe);
+		dss_ctl2_reg = ICL_PIPE_DSS_CTL2(pipe);
+	}
+	dss_ctl1_val = I915_READ(dss_ctl1_reg);
+	if (dss_ctl1_val & JOINER_ENABLE)
+		dss_ctl1_val &= ~JOINER_ENABLE;
+	I915_WRITE(dss_ctl1_reg, dss_ctl1_val);
+
+	dss_ctl2_val = I915_READ(dss_ctl2_reg);
+	if (dss_ctl2_val & LEFT_BRANCH_VDSC_ENABLE ||
+	    dss_ctl2_val & RIGHT_BRANCH_VDSC_ENABLE)
+		dss_ctl2_val &= ~(LEFT_BRANCH_VDSC_ENABLE |
+				  RIGHT_BRANCH_VDSC_ENABLE);
+	I915_WRITE(dss_ctl2_reg, dss_ctl2_val);
+}
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-07-31  2:10 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31  2:12 [PATCH 00/23] Enable Display Stream Compression on eDP/DP Manasi Navare
2018-07-31  2:12 ` [PATCH 01/23] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT Manasi Navare
2018-07-31 20:53   ` Srivatsa, Anusha
2018-07-31  2:12 ` [PATCH 02/23] drm/i915/dp: Cache the DP/eDP DSC DPCD register set on Hotplug/eDP Init Manasi Navare
2018-07-31  2:12 ` [PATCH 03/23] drm/dp: DRM DP helper/macros to get DP sink DSC parameters Manasi Navare
2018-07-31  2:12 ` [PATCH 04/23] drm/i915/dp: Add helpers for Compressed BPP and Slice Count for DSC Manasi Navare
2018-07-31  2:12 ` [PATCH 05/23] drm/i915/dp: Validate modes using max Output BPP and slice count when DSC supported Manasi Navare
2018-07-31  2:12 ` [PATCH 06/23] drm/dp: Define payload size for DP SDP PPS packet Manasi Navare
2018-07-31  2:12 ` [PATCH 07/23] drm/dsc: Define Display Stream Compression PPS infoframe Manasi Navare
2018-07-31  2:12 ` [PATCH 08/23] drm/dsc: Define VESA Display Stream Compression Capabilities Manasi Navare
2018-07-31  2:12 ` [PATCH 09/23] drm/dsc: Define Rate Control values that do not change over configurations Manasi Navare
2018-07-31  2:12 ` [PATCH 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes Manasi Navare
2018-07-31  2:12 ` [PATCH 11/23] drm/i915/dp: Add DSC params and DSC config to intel_crtc_state Manasi Navare
2018-07-31  2:12 ` [PATCH 12/23] drm/i915/dp: Compute DSC pipe config in atomic check Manasi Navare
2018-07-31 17:33   ` [PATCH v2] " Manasi Navare
2018-07-31  2:12 ` [PATCH 13/23] drm/i915/dp: Do not enable PSR2 if DSC is enabled Manasi Navare
2018-08-17 20:06   ` Srivatsa, Anusha
2018-07-31  2:12 ` [PATCH 14/23] drm/dsc: Define the DSC 1.1 and 1.2 Line Buffer depth constants Manasi Navare
2018-08-28 22:04   ` Srivatsa, Anusha
2018-07-31  2:12 ` [PATCH 15/23] drm/i915/dsc: Define & Compute VESA DSC params Manasi Navare
2018-07-31  2:12 ` [PATCH 16/23] drm/i915/dsc: Compute Rate Control parameters for DSC Manasi Navare
2018-07-31  2:12 ` [PATCH 17/23] drm/i915/dp: Enable/Disable DSC in DP Sink Manasi Navare
2018-08-28 22:26   ` Srivatsa, Anusha
2018-07-31  2:12 ` [PATCH 18/23] drm/i915/dp: Configure i915 Picture parameter Set registers during DSC enabling Manasi Navare
2018-07-31  2:12 ` [PATCH 19/23] drm/i915/dp: Use the existing write_infoframe() for DSC PPS SDPs Manasi Navare
2018-07-31  2:13 ` [PATCH 20/23] drm/i915/dp: Populate DSC PPS SDP and send PPS infoframes Manasi Navare
2018-07-31  2:13 ` [PATCH 21/23] drm/i915/icl: Add Display Stream Splitter control registers Manasi Navare
2018-08-02 10:26   ` Madhav Chauhan
2018-07-31  2:13 ` [PATCH 22/23] drm/i915/dp: Configure Display stream splitter registers during DSC enable Manasi Navare
2018-07-31  2:13 ` Manasi Navare [this message]
2018-07-31  2:27 ` ✗ Fi.CI.BAT: failure for Enable Display Stream Compression on eDP/DP Patchwork
2018-07-31 17:45 ` ✗ Fi.CI.CHECKPATCH: warning for Enable Display Stream Compression on eDP/DP (rev2) Patchwork
2018-07-31 17:55 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-07-31 18:07 ` ✓ Fi.CI.BAT: success " Patchwork
2018-07-31 18:54 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533003183-22793-24-git-send-email-manasi.d.navare@intel.com \
    --to=manasi.d.navare@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.