[PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

[PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

[Yang Wei]

From: Yang Wei <yang.wei9@zte.com.cn>

dev_consume_skb_irq() should be called in dfx_xmt_done() when skb
xmit done. It makes drop profiles(dropwatch, perf) more friendly.

Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
---
 drivers/net/fddi/defxx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c
index 38ac8ef..56b7791 100644
--- a/drivers/net/fddi/defxx.c
+++ b/drivers/net/fddi/defxx.c
@@ -3512,7 +3512,7 @@ static int dfx_xmt_done(DFX_board_t *bp)
 				 bp->descr_block_virt->xmt_data[comp].long_1,
 				 p_xmt_drv_descr->p_skb->len,
 				 DMA_TO_DEVICE);
-		dev_kfree_skb_irq(p_xmt_drv_descr->p_skb);
+		dev_consume_skb_irq(p_xmt_drv_descr->p_skb);
 
 		/*
 		 * Move to start of next packet by updating completion index
-- 
2.7.4

Re: [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

[Maciej W. Rozycki]

On Wed, 6 Feb 2019, Yang Wei wrote:

> From: Yang Wei <yang.wei9@zte.com.cn>
> 
> dev_consume_skb_irq() should be called in dfx_xmt_done() when skb
> xmit done. It makes drop profiles(dropwatch, perf) more friendly.
> 
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>

Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org>

 It looks to me the driver has to be reviewed WRT `dev_kfree_skb' vs 
`kfree_skb' use too.  I'll have a look into it unless you are happy to do 
that.

 Thanks for your contribution!

  Maciej

Re:Re: [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

[albin_yang]

At 2019-02-06 03:57:34, "Maciej W. Rozycki" <macro@linux-mips.org> wrote:
>On Wed, 6 Feb 2019, Yang Wei wrote:
>
>Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org>
>
> It looks to me the driver has to be reviewed WRT `dev_kfree_skb' vs 
>`kfree_skb' use too.  I'll have a look into it unless you are happy to do 
>that.
>
> Thanks for your contribution!
>
Hi, Maciej

I think kfree_skb() should be called when skb is dropped by network drivers. 
I found that many network drivers have such problems that not use 
kfree_skb/consume_skb properly. Maybe because 'drop profiles' appears later 
than many network drivers?

The problem 'dev_kfree_skb' vs 'kfree_skb' should be fixed. I think that is 
lower priority than the current patch. Network driver should not perturb 
drop profiles when skb successful xmit.

Thanks
Yang

Re: [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

[David Miller]

From: Yang Wei <albin_yang@163.com>
Date: Wed,  6 Feb 2019 00:01:04 +0800

> From: Yang Wei <yang.wei9@zte.com.cn>
> 
> dev_consume_skb_irq() should be called in dfx_xmt_done() when skb
> xmit done. It makes drop profiles(dropwatch, perf) more friendly.
> 
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>

Applied.