* [PATCH] ethtool: thunder_bgx: use ethtool.h constants for speed and duplex
@ 2019-04-08 19:00 Michael Zhivich
2019-04-08 19:22 ` Andrew Lunn
2019-04-08 23:38 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Michael Zhivich @ 2019-04-08 19:00 UTC (permalink / raw)
To: davem; +Cc: sgoutham, rric, netdev, andrew, Michael Zhivich
Use constants provided by ethtool.h for speed and duplex values
instead of raw integer constants to increase code readability.
thunder_bgx already uses SPEED_UNKNOWN and DUPLEX_UNKNOWN constants,
also provided by ethtool.h.
Signed-off-by: Michael Zhivich <mzhivich@akamai.com>
---
drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
index 673c57b..81c281a 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
@@ -962,13 +962,13 @@ static void bgx_poll_for_sgmii_link(struct lmac *lmac)
lmac->last_duplex = (an_result >> 1) & 0x1;
switch (speed) {
case 0:
- lmac->last_speed = 10;
+ lmac->last_speed = SPEED_10;
break;
case 1:
- lmac->last_speed = 100;
+ lmac->last_speed = SPEED_100;
break;
case 2:
- lmac->last_speed = 1000;
+ lmac->last_speed = SPEED_1000;
break;
default:
lmac->link_up = false;
@@ -1012,10 +1012,10 @@ static void bgx_poll_for_link(struct work_struct *work)
!(smu_link & SMU_RX_CTL_STATUS)) {
lmac->link_up = 1;
if (lmac->lmac_type == BGX_MODE_XLAUI)
- lmac->last_speed = 40000;
+ lmac->last_speed = SPEED_40000;
else
- lmac->last_speed = 10000;
- lmac->last_duplex = 1;
+ lmac->last_speed = SPEED_10000;
+ lmac->last_duplex = DUPLEX_FULL;
} else {
lmac->link_up = 0;
lmac->last_speed = SPEED_UNKNOWN;
@@ -1105,8 +1105,8 @@ static int bgx_lmac_enable(struct bgx *bgx, u8 lmacid)
} else {
/* Default to below link speed and duplex */
lmac->link_up = true;
- lmac->last_speed = 1000;
- lmac->last_duplex = 1;
+ lmac->last_speed = SPEED_1000;
+ lmac->last_duplex = DUPLEX_FULL;
bgx_sgmii_change_link_state(lmac);
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ethtool: thunder_bgx: use ethtool.h constants for speed and duplex
2019-04-08 19:00 [PATCH] ethtool: thunder_bgx: use ethtool.h constants for speed and duplex Michael Zhivich
@ 2019-04-08 19:22 ` Andrew Lunn
2019-04-08 23:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2019-04-08 19:22 UTC (permalink / raw)
To: Michael Zhivich; +Cc: davem, sgoutham, rric, netdev
On Mon, Apr 08, 2019 at 03:00:46PM -0400, Michael Zhivich wrote:
> Use constants provided by ethtool.h for speed and duplex values
> instead of raw integer constants to increase code readability.
>
> thunder_bgx already uses SPEED_UNKNOWN and DUPLEX_UNKNOWN constants,
> also provided by ethtool.h.
>
> Signed-off-by: Michael Zhivich <mzhivich@akamai.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ethtool: thunder_bgx: use ethtool.h constants for speed and duplex
2019-04-08 19:00 [PATCH] ethtool: thunder_bgx: use ethtool.h constants for speed and duplex Michael Zhivich
2019-04-08 19:22 ` Andrew Lunn
@ 2019-04-08 23:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-04-08 23:38 UTC (permalink / raw)
To: mzhivich; +Cc: sgoutham, rric, netdev, andrew
From: Michael Zhivich <mzhivich@akamai.com>
Date: Mon, 8 Apr 2019 15:00:46 -0400
> Use constants provided by ethtool.h for speed and duplex values
> instead of raw integer constants to increase code readability.
>
> thunder_bgx already uses SPEED_UNKNOWN and DUPLEX_UNKNOWN constants,
> also provided by ethtool.h.
>
> Signed-off-by: Michael Zhivich <mzhivich@akamai.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-08 23:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-08 19:00 [PATCH] ethtool: thunder_bgx: use ethtool.h constants for speed and duplex Michael Zhivich
2019-04-08 19:22 ` Andrew Lunn
2019-04-08 23:38 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.