Re: [PATCH v2] drm/i915/selftests: Verify the LRC register layout between init and HW

[Chris Wilson <chris@chris-wilson.co.uk>]

Quoting Chris Wilson (2019-09-24 15:59:50)
> Before we submit the first context to HW, we need to construct a valid
> image of the register state. This layout is defined by the HW and should
> match the layout generated by HW when it saves the context image.
> Asserting that this should be equivalent should help avoid any undefined
> behaviour and verify that we haven't missed anything important!
> 
> Of course, having insisted that the initial register state within the
> LRC should match that returned by HW, we need to ensure that it does.
> 
> v2: Drop the RELATIVE_MMIO flag from gen11, we ignore it for
> constructing the lrc image.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Chatting with Mika, he was happy enough to give an r-b without the gen11
chunk. To REG16 or not to REG16 is a decision for later, it was not a
critical issue.

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx