All of lore.kernel.org
 help / color / mirror / Atom feed
From: Haren Myneni <haren@linux.ibm.com>
To: mpe@ellerman.id.au
Cc: hch@infradead.org, devicetree@vger.kernel.org, mikey@neuling.org,
	herbert@gondor.apana.org.au, npiggin@gmail.com,
	linuxppc-dev@lists.ozlabs.org, sukadev@linux.vnet.ibm.com
Subject: [PATCH V3 10/13] powerpc/vas: Do not use default credits for receive window
Date: Mon, 16 Dec 2019 21:58:52 -0800	[thread overview]
Message-ID: <1576562332.16318.6545.camel@hbabu-laptop> (raw)
In-Reply-To: <1576561080.16318.6531.camel@hbabu-laptop>


System checkstops if RxFIFO overruns with more requests than the
maximum possible number of CRBs allowed in FIFO at any time. So
max credits value (rxattr.wcreds_max) is set and is passed to
vas_rx_win_open() by the the driver.

Signed-off-by: Haren Myneni <haren@us.ibm.com>
---
 arch/powerpc/platforms/powernv/vas-window.c | 4 ++--
 arch/powerpc/platforms/powernv/vas.h        | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c
index 0f27ac5..8428970 100644
--- a/arch/powerpc/platforms/powernv/vas-window.c
+++ b/arch/powerpc/platforms/powernv/vas-window.c
@@ -772,7 +772,7 @@ static bool rx_win_args_valid(enum vas_cop_type cop,
 	if (attr->rx_fifo_size > VAS_RX_FIFO_SIZE_MAX)
 		return false;
 
-	if (attr->wcreds_max > VAS_RX_WCREDS_MAX)
+	if (!attr->wcreds_max)
 		return false;
 
 	if (attr->nx_win) {
@@ -878,7 +878,7 @@ struct vas_window *vas_rx_win_open(int vasid, enum vas_cop_type cop,
 	rxwin->nx_win = rxattr->nx_win;
 	rxwin->user_win = rxattr->user_win;
 	rxwin->cop = cop;
-	rxwin->wcreds_max = rxattr->wcreds_max ?: VAS_WCREDS_DEFAULT;
+	rxwin->wcreds_max = rxattr->wcreds_max;
 
 	init_winctx_for_rxwin(rxwin, rxattr, &winctx);
 	init_winctx_regs(rxwin, &winctx);
diff --git a/arch/powerpc/platforms/powernv/vas.h b/arch/powerpc/platforms/powernv/vas.h
index af03aa0..f5f45ea 100644
--- a/arch/powerpc/platforms/powernv/vas.h
+++ b/arch/powerpc/platforms/powernv/vas.h
@@ -101,11 +101,9 @@
 /*
  * Initial per-process credits.
  * Max send window credits:    4K-1 (12-bits in VAS_TX_WCRED)
- * Max receive window credits: 64K-1 (16 bits in VAS_LRX_WCRED)
  *
  * TODO: Needs tuning for per-process credits
  */
-#define VAS_RX_WCREDS_MAX		((64 << 10) - 1)
 #define VAS_TX_WCREDS_MAX		((4 << 10) - 1)
 #define VAS_WCREDS_DEFAULT		(1 << 10)
 
-- 
1.8.3.1




WARNING: multiple messages have this Message-ID (diff)
From: Haren Myneni <haren@linux.ibm.com>
To: mpe@ellerman.id.au
Cc: devicetree@vger.kernel.org, mikey@neuling.org,
	herbert@gondor.apana.org.au, npiggin@gmail.com,
	hch@infradead.org, sukadev@linux.vnet.ibm.com,
	linuxppc-dev@lists.ozlabs.org
Subject: [PATCH V3 10/13] powerpc/vas: Do not use default credits for receive window
Date: Mon, 16 Dec 2019 21:58:52 -0800	[thread overview]
Message-ID: <1576562332.16318.6545.camel@hbabu-laptop> (raw)
In-Reply-To: <1576561080.16318.6531.camel@hbabu-laptop>


System checkstops if RxFIFO overruns with more requests than the
maximum possible number of CRBs allowed in FIFO at any time. So
max credits value (rxattr.wcreds_max) is set and is passed to
vas_rx_win_open() by the the driver.

Signed-off-by: Haren Myneni <haren@us.ibm.com>
---
 arch/powerpc/platforms/powernv/vas-window.c | 4 ++--
 arch/powerpc/platforms/powernv/vas.h        | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c
index 0f27ac5..8428970 100644
--- a/arch/powerpc/platforms/powernv/vas-window.c
+++ b/arch/powerpc/platforms/powernv/vas-window.c
@@ -772,7 +772,7 @@ static bool rx_win_args_valid(enum vas_cop_type cop,
 	if (attr->rx_fifo_size > VAS_RX_FIFO_SIZE_MAX)
 		return false;
 
-	if (attr->wcreds_max > VAS_RX_WCREDS_MAX)
+	if (!attr->wcreds_max)
 		return false;
 
 	if (attr->nx_win) {
@@ -878,7 +878,7 @@ struct vas_window *vas_rx_win_open(int vasid, enum vas_cop_type cop,
 	rxwin->nx_win = rxattr->nx_win;
 	rxwin->user_win = rxattr->user_win;
 	rxwin->cop = cop;
-	rxwin->wcreds_max = rxattr->wcreds_max ?: VAS_WCREDS_DEFAULT;
+	rxwin->wcreds_max = rxattr->wcreds_max;
 
 	init_winctx_for_rxwin(rxwin, rxattr, &winctx);
 	init_winctx_regs(rxwin, &winctx);
diff --git a/arch/powerpc/platforms/powernv/vas.h b/arch/powerpc/platforms/powernv/vas.h
index af03aa0..f5f45ea 100644
--- a/arch/powerpc/platforms/powernv/vas.h
+++ b/arch/powerpc/platforms/powernv/vas.h
@@ -101,11 +101,9 @@
 /*
  * Initial per-process credits.
  * Max send window credits:    4K-1 (12-bits in VAS_TX_WCRED)
- * Max receive window credits: 64K-1 (16 bits in VAS_LRX_WCRED)
  *
  * TODO: Needs tuning for per-process credits
  */
-#define VAS_RX_WCREDS_MAX		((64 << 10) - 1)
 #define VAS_TX_WCREDS_MAX		((4 << 10) - 1)
 #define VAS_WCREDS_DEFAULT		(1 << 10)
 
-- 
1.8.3.1




  parent reply	other threads:[~2019-12-17  6:01 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17  5:38 [PATCH V3 00/13] powerpc/vas: Page fault handling for user space NX requests Haren Myneni
2019-12-17  5:38 ` Haren Myneni
2019-12-17  5:48 ` [PATCH V3 01/13] powerpc/vas: Describe vas-port and interrupts properties Haren Myneni
2019-12-17  5:48   ` Haren Myneni
2019-12-18 22:18   ` Rob Herring
2019-12-18 22:18     ` Rob Herring
2019-12-18 23:15     ` Haren Myneni
2019-12-18 23:15       ` Haren Myneni
2019-12-17  5:49 ` [PATCH V3 02/13] powerpc/vas: Define nx_fault_stamp in coprocessor_request_block Haren Myneni
2019-12-17  5:49   ` Haren Myneni
2019-12-17  5:49 ` [PATCH V3 03/13] powerpc/vas: Read interrupts and vas-port device tree properties Haren Myneni
2019-12-17  5:49   ` Haren Myneni
2019-12-17  5:54 ` [PATCH V3 04/13] powerpc/vas: Setup fault window per VAS instance Haren Myneni
2019-12-17  5:54   ` Haren Myneni
2019-12-17  5:55 ` [PATCH V3 05/13] powerpc/vas: Setup thread IRQ handler " Haren Myneni
2019-12-17  5:55   ` Haren Myneni
2019-12-17  5:55 ` [PATCH V3 06/13] powerpc/vas: Register NX with fault window ID and IRQ port value Haren Myneni
2019-12-17  5:55   ` Haren Myneni
2019-12-17  5:56 ` [PATCH V3 07/13] powerpc/vas: Take reference to PID and mm for userspace windows Haren Myneni
2019-12-17  5:56   ` Haren Myneni
2019-12-17  5:56 ` [PATCH V3 08/13] powerpc/vas: Update CSB and notify process for fault CRBs Haren Myneni
2019-12-17  5:56   ` Haren Myneni
2019-12-17  5:58 ` [PATCH V3 09/13] powerpc/vas: Print CRB and FIFO values Haren Myneni
2019-12-17  5:58   ` Haren Myneni
2019-12-17  5:58 ` Haren Myneni [this message]
2019-12-17  5:58   ` [PATCH V3 10/13] powerpc/vas: Do not use default credits for receive window Haren Myneni
2019-12-17  5:59 ` [PATCH V3 11/13] powerpc/VAS: Return credits after handling fault Haren Myneni
2019-12-17  5:59   ` Haren Myneni
2019-12-17  6:00 ` [PATCH V3 12/13] powerpc/vas: Display process stuck message Haren Myneni
2019-12-17  6:00   ` Haren Myneni
2019-12-17  6:00 ` [PATCH V3 13/13] powerpc/vas: Free send window in VAS instance after credits returned Haren Myneni
2019-12-17  6:00   ` Haren Myneni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1576562332.16318.6545.camel@hbabu-laptop \
    --to=haren@linux.ibm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=sukadev@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.