From: Haren Myneni <haren@linux.ibm.com> To: mpe@ellerman.id.au Cc: hch@infradead.org, devicetree@vger.kernel.org, mikey@neuling.org, herbert@gondor.apana.org.au, npiggin@gmail.com, linuxppc-dev@lists.ozlabs.org, sukadev@linux.vnet.ibm.com Subject: [PATCH V3 12/13] powerpc/vas: Display process stuck message Date: Mon, 16 Dec 2019 22:00:13 -0800 [thread overview] Message-ID: <1576562413.16318.6547.camel@hbabu-laptop> (raw) In-Reply-To: <1576561080.16318.6531.camel@hbabu-laptop> Process can not close send window until all requests are processed. Means wait until window state is not busy and send credits are returned. Display debug message in case taking longer to close the window. Signed-off-by: Haren Myneni <haren@us.ibm.com> --- arch/powerpc/platforms/powernv/vas-window.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c index 8d90d25..e6ea7d3 100644 --- a/arch/powerpc/platforms/powernv/vas-window.c +++ b/arch/powerpc/platforms/powernv/vas-window.c @@ -1183,6 +1183,7 @@ static void poll_window_credits(struct vas_window *window) { u64 val; int creds, mode; + int count = 0; val = read_hvwc_reg(window, VREG(WINCTL)); if (window->tx_win) @@ -1201,10 +1202,25 @@ static void poll_window_credits(struct vas_window *window) creds = GET_FIELD(VAS_LRX_WCRED, val); } + /* + * Takes around few microseconds to complete all pending requests + * and return credits. + * TODO: Issue CRB Kill to stop all pending requests. Need only + * if there is a bug in NX or fault handling in kernel. + */ if (creds < window->wcreds_max) { val = 0; set_current_state(TASK_UNINTERRUPTIBLE); schedule_timeout(msecs_to_jiffies(10)); + count++; + /* + * Process can not close send window until all credits are + * returned. + */ + if (!(count % 10000)) + pr_debug("%s() pid %d stuck? retries %d\n", __func__, + vas_window_pid(window), count); + goto retry; } } @@ -1218,6 +1234,7 @@ static void poll_window_busy_state(struct vas_window *window) { int busy; u64 val; + int count = 0; retry: val = read_hvwc_reg(window, VREG(WIN_STATUS)); @@ -1226,6 +1243,15 @@ static void poll_window_busy_state(struct vas_window *window) val = 0; set_current_state(TASK_UNINTERRUPTIBLE); schedule_timeout(msecs_to_jiffies(5)); + count++; + /* + * Takes around 5 microseconds to process all pending + * requests. + */ + if (!(count % 10000)) + pr_debug("%s() pid %d stuck? retries %d\n", __func__, + vas_window_pid(window), count); + goto retry; } } -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Haren Myneni <haren@linux.ibm.com> To: mpe@ellerman.id.au Cc: devicetree@vger.kernel.org, mikey@neuling.org, herbert@gondor.apana.org.au, npiggin@gmail.com, hch@infradead.org, sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org Subject: [PATCH V3 12/13] powerpc/vas: Display process stuck message Date: Mon, 16 Dec 2019 22:00:13 -0800 [thread overview] Message-ID: <1576562413.16318.6547.camel@hbabu-laptop> (raw) In-Reply-To: <1576561080.16318.6531.camel@hbabu-laptop> Process can not close send window until all requests are processed. Means wait until window state is not busy and send credits are returned. Display debug message in case taking longer to close the window. Signed-off-by: Haren Myneni <haren@us.ibm.com> --- arch/powerpc/platforms/powernv/vas-window.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c index 8d90d25..e6ea7d3 100644 --- a/arch/powerpc/platforms/powernv/vas-window.c +++ b/arch/powerpc/platforms/powernv/vas-window.c @@ -1183,6 +1183,7 @@ static void poll_window_credits(struct vas_window *window) { u64 val; int creds, mode; + int count = 0; val = read_hvwc_reg(window, VREG(WINCTL)); if (window->tx_win) @@ -1201,10 +1202,25 @@ static void poll_window_credits(struct vas_window *window) creds = GET_FIELD(VAS_LRX_WCRED, val); } + /* + * Takes around few microseconds to complete all pending requests + * and return credits. + * TODO: Issue CRB Kill to stop all pending requests. Need only + * if there is a bug in NX or fault handling in kernel. + */ if (creds < window->wcreds_max) { val = 0; set_current_state(TASK_UNINTERRUPTIBLE); schedule_timeout(msecs_to_jiffies(10)); + count++; + /* + * Process can not close send window until all credits are + * returned. + */ + if (!(count % 10000)) + pr_debug("%s() pid %d stuck? retries %d\n", __func__, + vas_window_pid(window), count); + goto retry; } } @@ -1218,6 +1234,7 @@ static void poll_window_busy_state(struct vas_window *window) { int busy; u64 val; + int count = 0; retry: val = read_hvwc_reg(window, VREG(WIN_STATUS)); @@ -1226,6 +1243,15 @@ static void poll_window_busy_state(struct vas_window *window) val = 0; set_current_state(TASK_UNINTERRUPTIBLE); schedule_timeout(msecs_to_jiffies(5)); + count++; + /* + * Takes around 5 microseconds to process all pending + * requests. + */ + if (!(count % 10000)) + pr_debug("%s() pid %d stuck? retries %d\n", __func__, + vas_window_pid(window), count); + goto retry; } } -- 1.8.3.1
next prev parent reply other threads:[~2019-12-17 6:02 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-17 5:38 [PATCH V3 00/13] powerpc/vas: Page fault handling for user space NX requests Haren Myneni 2019-12-17 5:38 ` Haren Myneni 2019-12-17 5:48 ` [PATCH V3 01/13] powerpc/vas: Describe vas-port and interrupts properties Haren Myneni 2019-12-17 5:48 ` Haren Myneni 2019-12-18 22:18 ` Rob Herring 2019-12-18 22:18 ` Rob Herring 2019-12-18 23:15 ` Haren Myneni 2019-12-18 23:15 ` Haren Myneni 2019-12-17 5:49 ` [PATCH V3 02/13] powerpc/vas: Define nx_fault_stamp in coprocessor_request_block Haren Myneni 2019-12-17 5:49 ` Haren Myneni 2019-12-17 5:49 ` [PATCH V3 03/13] powerpc/vas: Read interrupts and vas-port device tree properties Haren Myneni 2019-12-17 5:49 ` Haren Myneni 2019-12-17 5:54 ` [PATCH V3 04/13] powerpc/vas: Setup fault window per VAS instance Haren Myneni 2019-12-17 5:54 ` Haren Myneni 2019-12-17 5:55 ` [PATCH V3 05/13] powerpc/vas: Setup thread IRQ handler " Haren Myneni 2019-12-17 5:55 ` Haren Myneni 2019-12-17 5:55 ` [PATCH V3 06/13] powerpc/vas: Register NX with fault window ID and IRQ port value Haren Myneni 2019-12-17 5:55 ` Haren Myneni 2019-12-17 5:56 ` [PATCH V3 07/13] powerpc/vas: Take reference to PID and mm for userspace windows Haren Myneni 2019-12-17 5:56 ` Haren Myneni 2019-12-17 5:56 ` [PATCH V3 08/13] powerpc/vas: Update CSB and notify process for fault CRBs Haren Myneni 2019-12-17 5:56 ` Haren Myneni 2019-12-17 5:58 ` [PATCH V3 09/13] powerpc/vas: Print CRB and FIFO values Haren Myneni 2019-12-17 5:58 ` Haren Myneni 2019-12-17 5:58 ` [PATCH V3 10/13] powerpc/vas: Do not use default credits for receive window Haren Myneni 2019-12-17 5:58 ` Haren Myneni 2019-12-17 5:59 ` [PATCH V3 11/13] powerpc/VAS: Return credits after handling fault Haren Myneni 2019-12-17 5:59 ` Haren Myneni 2019-12-17 6:00 ` Haren Myneni [this message] 2019-12-17 6:00 ` [PATCH V3 12/13] powerpc/vas: Display process stuck message Haren Myneni 2019-12-17 6:00 ` [PATCH V3 13/13] powerpc/vas: Free send window in VAS instance after credits returned Haren Myneni 2019-12-17 6:00 ` Haren Myneni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1576562413.16318.6547.camel@hbabu-laptop \ --to=haren@linux.ibm.com \ --cc=devicetree@vger.kernel.org \ --cc=hch@infradead.org \ --cc=herbert@gondor.apana.org.au \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mikey@neuling.org \ --cc=mpe@ellerman.id.au \ --cc=npiggin@gmail.com \ --cc=sukadev@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.