From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: Moudy Ho <moudy.ho@mediatek.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Matthias Brugger <matthias.bgg@gmail.com>, Chun-Kuang Hu <chunkuang.hu@kernel.org> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com> Subject: Re: [PATCH v1 3/6] soc: mediatek: mmsys: add support for MT8195 VPPSYS Date: Tue, 4 Oct 2022 14:17:33 +0200 [thread overview] Message-ID: <15791b10-fdeb-3776-d7f5-968cb0fa85dc@collabora.com> (raw) In-Reply-To: <20221004093319.5069-4-moudy.ho@mediatek.com> Il 04/10/22 11:33, Moudy Ho ha scritto: > From: "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com> > > Add MT8195 VPPSYS0 and VPPSYS1 driver data. > > Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@mediatek.com> > --- > drivers/soc/mediatek/mtk-mmsys.c | 20 +++++++++++++++++++- > drivers/soc/mediatek/mtk-mmsys.h | 1 + > 2 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c > index d2c7a87aab87..c4d15f99f853 100644 > --- a/drivers/soc/mediatek/mtk-mmsys.c > +++ b/drivers/soc/mediatek/mtk-mmsys.c > @@ -149,11 +149,25 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = { > .clk_driver = "clk-mt8195-vdo1", > }; > > +static const struct mtk_mmsys_driver_data mt8195_vppsys0_driver_data = { > + .io_start = 0x14000000, > + .clk_driver = "clk-mt8195-vpp0", > + .is_copies = true, > +}; > + > +static const struct mtk_mmsys_driver_data mt8195_vppsys1_driver_data = { > + .io_start = 0x14f00000, > + .clk_driver = "clk-mt8195-vpp1", > + .is_copies = true, > +}; > + > static const struct mtk_mmsys_match_data mt8195_mmsys_match_data = { > - .num_drv_data = 2, > + .num_drv_data = 4, After a long discussion, it was chosen to not use the io_start way, but to change the devicetree compatible.... Check this series, and rebase on top of it: https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097 Cheers, Angelo > .drv_data = { > &mt8195_vdosys0_driver_data, > &mt8195_vdosys1_driver_data, > + &mt8195_vppsys0_driver_data, > + &mt8195_vppsys1_driver_data, > }, > }; > > @@ -360,6 +374,9 @@ static int mtk_mmsys_probe(struct platform_device *pdev) > if (IS_ERR(clks)) > return PTR_ERR(clks); > > + if (mmsys->data->is_copies) I don't get what "is_copies" means, sorry. I'm sure that there's a better name for this one. > + goto out_probe_done; > + > drm = platform_device_register_data(&pdev->dev, "mediatek-drm", > PLATFORM_DEVID_AUTO, NULL, 0); > if (IS_ERR(drm)) { Regards, Angelo
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: Moudy Ho <moudy.ho@mediatek.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Matthias Brugger <matthias.bgg@gmail.com>, Chun-Kuang Hu <chunkuang.hu@kernel.org> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com> Subject: Re: [PATCH v1 3/6] soc: mediatek: mmsys: add support for MT8195 VPPSYS Date: Tue, 4 Oct 2022 14:17:33 +0200 [thread overview] Message-ID: <15791b10-fdeb-3776-d7f5-968cb0fa85dc@collabora.com> (raw) In-Reply-To: <20221004093319.5069-4-moudy.ho@mediatek.com> Il 04/10/22 11:33, Moudy Ho ha scritto: > From: "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com> > > Add MT8195 VPPSYS0 and VPPSYS1 driver data. > > Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@mediatek.com> > --- > drivers/soc/mediatek/mtk-mmsys.c | 20 +++++++++++++++++++- > drivers/soc/mediatek/mtk-mmsys.h | 1 + > 2 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c > index d2c7a87aab87..c4d15f99f853 100644 > --- a/drivers/soc/mediatek/mtk-mmsys.c > +++ b/drivers/soc/mediatek/mtk-mmsys.c > @@ -149,11 +149,25 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = { > .clk_driver = "clk-mt8195-vdo1", > }; > > +static const struct mtk_mmsys_driver_data mt8195_vppsys0_driver_data = { > + .io_start = 0x14000000, > + .clk_driver = "clk-mt8195-vpp0", > + .is_copies = true, > +}; > + > +static const struct mtk_mmsys_driver_data mt8195_vppsys1_driver_data = { > + .io_start = 0x14f00000, > + .clk_driver = "clk-mt8195-vpp1", > + .is_copies = true, > +}; > + > static const struct mtk_mmsys_match_data mt8195_mmsys_match_data = { > - .num_drv_data = 2, > + .num_drv_data = 4, After a long discussion, it was chosen to not use the io_start way, but to change the devicetree compatible.... Check this series, and rebase on top of it: https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097 Cheers, Angelo > .drv_data = { > &mt8195_vdosys0_driver_data, > &mt8195_vdosys1_driver_data, > + &mt8195_vppsys0_driver_data, > + &mt8195_vppsys1_driver_data, > }, > }; > > @@ -360,6 +374,9 @@ static int mtk_mmsys_probe(struct platform_device *pdev) > if (IS_ERR(clks)) > return PTR_ERR(clks); > > + if (mmsys->data->is_copies) I don't get what "is_copies" means, sorry. I'm sure that there's a better name for this one. > + goto out_probe_done; > + > drm = platform_device_register_data(&pdev->dev, "mediatek-drm", > PLATFORM_DEVID_AUTO, NULL, 0); > if (IS_ERR(drm)) { Regards, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-04 12:17 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-04 9:33 [PATCH v1 0/6] add support for MT8195 VPPSYS on MMSYS and MUTEX Moudy Ho 2022-10-04 9:33 ` Moudy Ho 2022-10-04 9:33 ` [PATCH v1 1/6] dt-bindings: soc: mediatek: Add support for MT8195 VPPSYS Moudy Ho 2022-10-04 9:33 ` Moudy Ho 2022-10-05 7:58 ` Krzysztof Kozlowski 2022-10-05 7:58 ` Krzysztof Kozlowski 2022-10-04 9:33 ` [PATCH v1 2/6] dts: arm64: mt8195: add MMSYS and MUTEX configuration for VPPSYS Moudy Ho 2022-10-04 9:33 ` Moudy Ho 2022-10-04 11:46 ` Allen-KH Cheng (程冠勳) 2022-10-04 11:46 ` Allen-KH Cheng (程冠勳) 2022-10-05 1:53 ` moudy ho 2022-10-05 1:53 ` moudy ho 2022-10-05 7:57 ` Krzysztof Kozlowski 2022-10-05 7:57 ` Krzysztof Kozlowski 2022-10-04 9:33 ` [PATCH v1 3/6] soc: mediatek: mmsys: add support for MT8195 VPPSYS Moudy Ho 2022-10-04 9:33 ` Moudy Ho 2022-10-04 12:17 ` AngeloGioacchino Del Regno [this message] 2022-10-04 12:17 ` AngeloGioacchino Del Regno 2022-10-05 2:43 ` moudy ho 2022-10-05 2:43 ` moudy ho 2022-10-04 9:33 ` [PATCH v1 4/6] soc: mediatek: mmsys: add config api for RSZ switching and DCM Moudy Ho 2022-10-04 9:33 ` Moudy Ho 2022-10-04 12:17 ` AngeloGioacchino Del Regno 2022-10-04 12:17 ` AngeloGioacchino Del Regno 2022-10-05 1:48 ` moudy ho 2022-10-05 1:48 ` moudy ho 2022-10-04 9:33 ` [PATCH v1 5/6] soc: mediatek: mutex: Add mtk_mutex_set_mod support to set MOD1 Moudy Ho 2022-10-04 9:33 ` Moudy Ho 2022-10-04 12:38 ` AngeloGioacchino Del Regno 2022-10-04 12:38 ` AngeloGioacchino Del Regno 2022-10-05 2:59 ` moudy ho 2022-10-05 2:59 ` moudy ho 2022-10-04 9:33 ` [PATCH v1 6/6] soc: mediatek: mutex: support MT8195 VPPSYS Moudy Ho 2022-10-04 9:33 ` Moudy Ho
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=15791b10-fdeb-3776-d7f5-968cb0fa85dc@collabora.com \ --to=angelogioacchino.delregno@collabora.com \ --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \ --cc=chunkuang.hu@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=moudy.ho@mediatek.com \ --cc=robh+dt@kernel.org \ --cc=roy-cw.yeh@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.