From: Liu Yi L <yi.l.liu@intel.com> To: qemu-devel@nongnu.org, alex.williamson@redhat.com, peterx@redhat.com Cc: eric.auger@redhat.com, pbonzini@redhat.com, mst@redhat.com, david@gibson.dropbear.id.au, kevin.tian@intel.com, yi.l.liu@intel.com, jun.j.tian@intel.com, yi.y.sun@intel.com, kvm@vger.kernel.org, hao.wu@intel.com, jean-philippe@linaro.org, Jacob Pan <jacob.jun.pan@linux.intel.com>, Yi Sun <yi.y.sun@linux.intel.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com> Subject: [PATCH v2 17/22] intel_iommu: do not pass down pasid bind for PASID #0 Date: Sun, 29 Mar 2020 21:24:56 -0700 [thread overview] Message-ID: <1585542301-84087-18-git-send-email-yi.l.liu@intel.com> (raw) In-Reply-To: <1585542301-84087-1-git-send-email-yi.l.liu@intel.com> RID_PASID field was introduced in VT-d 3.0 spec, it is used for DMA requests w/o PASID in scalable mode VT-d. It is also known as IOVA. And in VT-d 3.1 spec, there is definition on it: "Implementations not supporting RID_PASID capability (ECAP_REG.RPS is 0b), use a PASID value of 0 to perform address translation for requests without PASID." This patch adds a check against the PASIDs which are going to be bound to device. For PASID #0, it is not necessary to pass down pasid bind request for it since PASID #0 is used as RID_PASID for DMA requests without pasid. Further reason is current Intel vIOMMU supports gIOVA by shadowing guest 2nd level page table. However, in future, if guest IOMMU driver uses 1st level page table to store IOVA mappings, then guest IOVA support will also be done via nested translation. When gIOVA is over FLPT, then vIOMMU should pass down the pasid bind request for PASID #0 to host, host needs to bind the guest IOVA page table to a proper PASID. e.g PASID value in RID_PASID field for PF/VF if ECAP_REG.RPS is clear or default PASID for ADI (Assignable Device Interface in Scalable IOV solution). IOVA over FLPT support on Intel VT-d: https://lkml.org/lkml/2019/9/23/297 Cc: Kevin Tian <kevin.tian@intel.com> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: Peter Xu <peterx@redhat.com> Cc: Yi Sun <yi.y.sun@linux.intel.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Richard Henderson <rth@twiddle.net> Cc: Eduardo Habkost <ehabkost@redhat.com> Reviewed-by: Peter Xu <peterx@redhat.com> Signed-off-by: Liu Yi L <yi.l.liu@intel.com> --- hw/i386/intel_iommu.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 883aeac..074d966 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -1895,6 +1895,16 @@ static int vtd_bind_guest_pasid(IntelIOMMUState *s, VTDBus *vtd_bus, struct iommu_gpasid_bind_data *g_bind_data; int ret = -1; + if (pasid < VTD_HPASID_MIN) { + /* + * If pasid < VTD_HPASID_MIN, this pasid is not allocated + * from host. No need to pass down the changes on it to host. + * TODO: when IOVA over FLPT is ready, this switch should be + * refined. + */ + return 0; + } + vtd_dev_icx = vtd_bus->dev_icx[devfn]; if (!vtd_dev_icx) { /* means no need to go further, e.g. for emulated devices */ -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Liu Yi L <yi.l.liu@intel.com> To: qemu-devel@nongnu.org, alex.williamson@redhat.com, peterx@redhat.com Cc: jean-philippe@linaro.org, kevin.tian@intel.com, yi.l.liu@intel.com, Yi Sun <yi.y.sun@linux.intel.com>, Eduardo Habkost <ehabkost@redhat.com>, kvm@vger.kernel.org, mst@redhat.com, jun.j.tian@intel.com, eric.auger@redhat.com, yi.y.sun@intel.com, Jacob Pan <jacob.jun.pan@linux.intel.com>, pbonzini@redhat.com, hao.wu@intel.com, Richard Henderson <rth@twiddle.net>, david@gibson.dropbear.id.au Subject: [PATCH v2 17/22] intel_iommu: do not pass down pasid bind for PASID #0 Date: Sun, 29 Mar 2020 21:24:56 -0700 [thread overview] Message-ID: <1585542301-84087-18-git-send-email-yi.l.liu@intel.com> (raw) In-Reply-To: <1585542301-84087-1-git-send-email-yi.l.liu@intel.com> RID_PASID field was introduced in VT-d 3.0 spec, it is used for DMA requests w/o PASID in scalable mode VT-d. It is also known as IOVA. And in VT-d 3.1 spec, there is definition on it: "Implementations not supporting RID_PASID capability (ECAP_REG.RPS is 0b), use a PASID value of 0 to perform address translation for requests without PASID." This patch adds a check against the PASIDs which are going to be bound to device. For PASID #0, it is not necessary to pass down pasid bind request for it since PASID #0 is used as RID_PASID for DMA requests without pasid. Further reason is current Intel vIOMMU supports gIOVA by shadowing guest 2nd level page table. However, in future, if guest IOMMU driver uses 1st level page table to store IOVA mappings, then guest IOVA support will also be done via nested translation. When gIOVA is over FLPT, then vIOMMU should pass down the pasid bind request for PASID #0 to host, host needs to bind the guest IOVA page table to a proper PASID. e.g PASID value in RID_PASID field for PF/VF if ECAP_REG.RPS is clear or default PASID for ADI (Assignable Device Interface in Scalable IOV solution). IOVA over FLPT support on Intel VT-d: https://lkml.org/lkml/2019/9/23/297 Cc: Kevin Tian <kevin.tian@intel.com> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: Peter Xu <peterx@redhat.com> Cc: Yi Sun <yi.y.sun@linux.intel.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Richard Henderson <rth@twiddle.net> Cc: Eduardo Habkost <ehabkost@redhat.com> Reviewed-by: Peter Xu <peterx@redhat.com> Signed-off-by: Liu Yi L <yi.l.liu@intel.com> --- hw/i386/intel_iommu.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 883aeac..074d966 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -1895,6 +1895,16 @@ static int vtd_bind_guest_pasid(IntelIOMMUState *s, VTDBus *vtd_bus, struct iommu_gpasid_bind_data *g_bind_data; int ret = -1; + if (pasid < VTD_HPASID_MIN) { + /* + * If pasid < VTD_HPASID_MIN, this pasid is not allocated + * from host. No need to pass down the changes on it to host. + * TODO: when IOVA over FLPT is ready, this switch should be + * refined. + */ + return 0; + } + vtd_dev_icx = vtd_bus->dev_icx[devfn]; if (!vtd_dev_icx) { /* means no need to go further, e.g. for emulated devices */ -- 2.7.4
next prev parent reply other threads:[~2020-03-30 4:19 UTC|newest] Thread overview: 160+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-30 4:24 [PATCH v2 00/22] intel_iommu: expose Shared Virtual Addressing to VMs Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 01/22] scripts/update-linux-headers: Import iommu.h Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 02/22] header file update VFIO/IOMMU vSVA APIs Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 03/22] vfio: check VFIO_TYPE1_NESTING_IOMMU support Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 9:36 ` Auger Eric 2020-03-30 9:36 ` Auger Eric 2020-03-31 6:08 ` Liu, Yi L 2020-03-31 6:08 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 04/22] hw/iommu: introduce HostIOMMUContext Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 17:22 ` Auger Eric 2020-03-30 17:22 ` Auger Eric 2020-03-31 4:10 ` Liu, Yi L 2020-03-31 4:10 ` Liu, Yi L 2020-03-31 7:47 ` Auger Eric 2020-03-31 7:47 ` Auger Eric 2020-03-31 12:43 ` Liu, Yi L 2020-03-31 12:43 ` Liu, Yi L 2020-04-06 8:04 ` Liu, Yi L 2020-04-06 8:04 ` Liu, Yi L 2020-04-06 10:30 ` Auger Eric 2020-04-06 10:30 ` Auger Eric 2020-03-30 4:24 ` [PATCH v2 05/22] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 11:02 ` Auger Eric 2020-03-30 11:02 ` Auger Eric 2020-04-02 8:52 ` Liu, Yi L 2020-04-02 8:52 ` Liu, Yi L 2020-04-02 12:41 ` Auger Eric 2020-04-02 12:41 ` Auger Eric 2020-04-02 13:37 ` Liu, Yi L 2020-04-02 13:37 ` Liu, Yi L 2020-04-02 13:49 ` Auger Eric 2020-04-02 13:49 ` Auger Eric 2020-04-06 6:27 ` Liu, Yi L 2020-04-06 6:27 ` Liu, Yi L 2020-04-06 10:04 ` Auger Eric 2020-04-06 10:04 ` Auger Eric 2020-03-30 4:24 ` [PATCH v2 06/22] hw/pci: introduce pci_device_set/unset_iommu_context() Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 17:30 ` Auger Eric 2020-03-30 17:30 ` Auger Eric 2020-03-31 12:14 ` Liu, Yi L 2020-03-31 12:14 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 07/22] intel_iommu: add set/unset_iommu_context callback Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 20:23 ` Auger Eric 2020-03-30 20:23 ` Auger Eric 2020-03-31 12:25 ` Liu, Yi L 2020-03-31 12:25 ` Liu, Yi L 2020-03-31 12:57 ` Auger Eric 2020-03-31 12:57 ` Auger Eric 2020-03-30 4:24 ` [PATCH v2 08/22] vfio/common: provide PASID alloc/free hooks Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-31 10:47 ` Auger Eric 2020-03-31 10:47 ` Auger Eric 2020-03-31 10:59 ` Liu, Yi L 2020-03-31 10:59 ` Liu, Yi L 2020-03-31 11:15 ` Auger Eric 2020-03-31 11:15 ` Auger Eric 2020-03-31 12:54 ` Liu, Yi L 2020-03-31 12:54 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 09/22] vfio/common: init HostIOMMUContext per-container Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-04-01 7:50 ` Auger Eric 2020-04-01 7:50 ` Auger Eric 2020-04-06 7:12 ` Liu, Yi L 2020-04-06 7:12 ` Liu, Yi L 2020-04-06 10:20 ` Auger Eric 2020-04-06 10:20 ` Auger Eric 2020-04-07 11:59 ` Liu, Yi L 2020-04-07 11:59 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 10/22] vfio/pci: set host iommu context to vIOMMU Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-31 14:30 ` Auger Eric 2020-03-31 14:30 ` Auger Eric 2020-04-01 3:20 ` Liu, Yi L 2020-04-01 3:20 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 11/22] intel_iommu: add virtual command capability support Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 12/22] intel_iommu: process PASID cache invalidation Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 13/22] intel_iommu: add PASID cache management infrastructure Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-04-02 0:02 ` Peter Xu 2020-04-02 0:02 ` Peter Xu 2020-04-02 6:46 ` Liu, Yi L 2020-04-02 6:46 ` Liu, Yi L 2020-04-02 13:44 ` Peter Xu 2020-04-02 13:44 ` Peter Xu 2020-04-03 15:05 ` Liu, Yi L 2020-04-03 15:05 ` Liu, Yi L 2020-04-03 16:19 ` Peter Xu 2020-04-03 16:19 ` Peter Xu 2020-04-04 11:39 ` Liu, Yi L 2020-04-04 11:39 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 14/22] vfio: add bind stage-1 page table support Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 15/22] intel_iommu: bind/unbind guest page table to host Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-04-02 18:09 ` Peter Xu 2020-04-02 18:09 ` Peter Xu 2020-04-03 14:29 ` Liu, Yi L 2020-04-03 14:29 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 16/22] intel_iommu: replay pasid binds after context cache invalidation Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-04-03 14:45 ` Peter Xu 2020-04-03 14:45 ` Peter Xu 2020-04-03 15:21 ` Liu, Yi L 2020-04-03 15:21 ` Liu, Yi L 2020-04-03 16:11 ` Peter Xu 2020-04-03 16:11 ` Peter Xu 2020-04-04 12:00 ` Liu, Yi L 2020-04-04 12:00 ` Liu, Yi L 2020-04-06 19:48 ` Peter Xu 2020-04-06 19:48 ` Peter Xu 2020-03-30 4:24 ` Liu Yi L [this message] 2020-03-30 4:24 ` [PATCH v2 17/22] intel_iommu: do not pass down pasid bind for PASID #0 Liu Yi L 2020-03-30 4:24 ` [PATCH v2 18/22] vfio: add support for flush iommu stage-1 cache Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 19/22] intel_iommu: process PASID-based iotlb invalidation Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-04-03 14:47 ` Peter Xu 2020-04-03 14:47 ` Peter Xu 2020-04-03 15:21 ` Liu, Yi L 2020-04-03 15:21 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 20/22] intel_iommu: propagate PASID-based iotlb invalidation to host Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:25 ` [PATCH v2 21/22] intel_iommu: process PASID-based Device-TLB invalidation Liu Yi L 2020-03-30 4:25 ` Liu Yi L 2020-03-30 4:25 ` [PATCH v2 22/22] intel_iommu: modify x-scalable-mode to be string option Liu Yi L 2020-03-30 4:25 ` Liu Yi L 2020-04-03 14:49 ` Peter Xu 2020-04-03 14:49 ` Peter Xu 2020-04-03 15:22 ` Liu, Yi L 2020-04-03 15:22 ` Liu, Yi L 2020-03-30 5:40 ` [PATCH v2 00/22] intel_iommu: expose Shared Virtual Addressing to VMs no-reply 2020-03-30 5:40 ` no-reply 2020-03-30 10:36 ` Auger Eric 2020-03-30 10:36 ` Auger Eric 2020-03-30 14:46 ` Peter Xu 2020-03-30 14:46 ` Peter Xu 2020-03-31 6:53 ` Liu, Yi L 2020-03-31 6:53 ` Liu, Yi L 2020-04-02 8:33 ` Jason Wang 2020-04-02 8:33 ` Jason Wang 2020-04-02 13:46 ` Peter Xu 2020-04-02 13:46 ` Peter Xu 2020-04-03 1:38 ` Jason Wang 2020-04-03 1:38 ` Jason Wang 2020-04-03 14:20 ` Liu, Yi L 2020-04-03 14:20 ` Liu, Yi L 2020-04-02 18:12 ` Peter Xu 2020-04-02 18:12 ` Peter Xu 2020-04-03 14:32 ` Liu, Yi L 2020-04-03 14:32 ` Liu, Yi L
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1585542301-84087-18-git-send-email-yi.l.liu@intel.com \ --to=yi.l.liu@intel.com \ --cc=alex.williamson@redhat.com \ --cc=david@gibson.dropbear.id.au \ --cc=ehabkost@redhat.com \ --cc=eric.auger@redhat.com \ --cc=hao.wu@intel.com \ --cc=jacob.jun.pan@linux.intel.com \ --cc=jean-philippe@linaro.org \ --cc=jun.j.tian@intel.com \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peterx@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=yi.y.sun@intel.com \ --cc=yi.y.sun@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.