From: "Liu, Yi L" <yi.l.liu@intel.com> To: Auger Eric <eric.auger@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "alex.williamson@redhat.com" <alex.williamson@redhat.com>, "peterx@redhat.com" <peterx@redhat.com> Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>, "mst@redhat.com" <mst@redhat.com>, "david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au>, "Tian, Kevin" <kevin.tian@intel.com>, "Tian, Jun J" <jun.j.tian@intel.com>, "Sun, Yi Y" <yi.y.sun@intel.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "Wu, Hao" <hao.wu@intel.com>, "jean-philippe@linaro.org" <jean-philippe@linaro.org>, Jacob Pan <jacob.jun.pan@linux.intel.com>, Yi Sun <yi.y.sun@linux.intel.com> Subject: RE: [PATCH v2 04/22] hw/iommu: introduce HostIOMMUContext Date: Mon, 6 Apr 2020 08:04:02 +0000 [thread overview] Message-ID: <A2975661238FB949B60364EF0F2C25743A2230B3@SHSMSX104.ccr.corp.intel.com> (raw) In-Reply-To: <aa1bfbd5-e6de-6475-809e-a6ca46089aaa@redhat.com> Hi Eric, > From: Auger Eric < eric.auger@redhat.com> > Sent: Tuesday, March 31, 2020 1:23 AM > To: Liu, Yi L <yi.l.liu@intel.com>; qemu-devel@nongnu.org; > Subject: Re: [PATCH v2 04/22] hw/iommu: introduce HostIOMMUContext > > Yi, > > On 3/30/20 6:24 AM, Liu Yi L wrote: > > Currently, many platform vendors provide the capability of dual stage > > DMA address translation in hardware. For example, nested translation > > on Intel VT-d scalable mode, nested stage translation on ARM SMMUv3, > > and etc. In dual stage DMA address translation, there are two stages > > address translation, stage-1 (a.k.a first-level) and stage-2 (a.k.a > > second-level) translation structures. Stage-1 translation results are > > also subjected to stage-2 translation structures. Take vSVA (Virtual > > Shared Virtual Addressing) as an example, guest IOMMU driver owns > > stage-1 translation structures (covers GVA->GPA translation), and host > > IOMMU driver owns stage-2 translation structures (covers GPA->HPA > > translation). VMM is responsible to bind stage-1 translation structures > > to host, thus hardware could achieve GVA->GPA and then GPA->HPA > > translation. For more background on SVA, refer the below links. > > - https://www.youtube.com/watch?v=Kq_nfGK5MwQ > > - https://events19.lfasiallc.com/wp-content/uploads/2017/11/\ > > Shared-Virtual-Memory-in-KVM_Yi-Liu.pdf > > [...] > > +void host_iommu_ctx_init(void *_iommu_ctx, size_t instance_size, > > + const char *mrtypename, > > + uint64_t flags) > > +{ > > + HostIOMMUContext *iommu_ctx; > > + > > + object_initialize(_iommu_ctx, instance_size, mrtypename); > > + iommu_ctx = HOST_IOMMU_CONTEXT(_iommu_ctx); > > + iommu_ctx->flags = flags; > > + iommu_ctx->initialized = true; > > +} > > + > > +static const TypeInfo host_iommu_context_info = { > > + .parent = TYPE_OBJECT, > > + .name = TYPE_HOST_IOMMU_CONTEXT, > > + .class_size = sizeof(HostIOMMUContextClass), > > + .instance_size = sizeof(HostIOMMUContext), > > + .abstract = true, > Can't we use the usual .instance_init and .instance_finalize? sorry, I somehow missed this comment. In prior patch, .instace_init was used, but the current major init method is via host_iommu_ctx_init(), so .instance_init is not really necessary. https://www.spinics.net/lists/kvm/msg210878.html Regards, Yi Liu
WARNING: multiple messages have this Message-ID (diff)
From: "Liu, Yi L" <yi.l.liu@intel.com> To: Auger Eric <eric.auger@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "alex.williamson@redhat.com" <alex.williamson@redhat.com>, "peterx@redhat.com" <peterx@redhat.com> Cc: "jean-philippe@linaro.org" <jean-philippe@linaro.org>, "Tian, Kevin" <kevin.tian@intel.com>, Jacob Pan <jacob.jun.pan@linux.intel.com>, Yi Sun <yi.y.sun@linux.intel.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mst@redhat.com" <mst@redhat.com>, "Tian, Jun J" <jun.j.tian@intel.com>, "Sun, Yi Y" <yi.y.sun@intel.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>, "Wu, Hao" <hao.wu@intel.com>, "david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au> Subject: RE: [PATCH v2 04/22] hw/iommu: introduce HostIOMMUContext Date: Mon, 6 Apr 2020 08:04:02 +0000 [thread overview] Message-ID: <A2975661238FB949B60364EF0F2C25743A2230B3@SHSMSX104.ccr.corp.intel.com> (raw) In-Reply-To: <aa1bfbd5-e6de-6475-809e-a6ca46089aaa@redhat.com> Hi Eric, > From: Auger Eric < eric.auger@redhat.com> > Sent: Tuesday, March 31, 2020 1:23 AM > To: Liu, Yi L <yi.l.liu@intel.com>; qemu-devel@nongnu.org; > Subject: Re: [PATCH v2 04/22] hw/iommu: introduce HostIOMMUContext > > Yi, > > On 3/30/20 6:24 AM, Liu Yi L wrote: > > Currently, many platform vendors provide the capability of dual stage > > DMA address translation in hardware. For example, nested translation > > on Intel VT-d scalable mode, nested stage translation on ARM SMMUv3, > > and etc. In dual stage DMA address translation, there are two stages > > address translation, stage-1 (a.k.a first-level) and stage-2 (a.k.a > > second-level) translation structures. Stage-1 translation results are > > also subjected to stage-2 translation structures. Take vSVA (Virtual > > Shared Virtual Addressing) as an example, guest IOMMU driver owns > > stage-1 translation structures (covers GVA->GPA translation), and host > > IOMMU driver owns stage-2 translation structures (covers GPA->HPA > > translation). VMM is responsible to bind stage-1 translation structures > > to host, thus hardware could achieve GVA->GPA and then GPA->HPA > > translation. For more background on SVA, refer the below links. > > - https://www.youtube.com/watch?v=Kq_nfGK5MwQ > > - https://events19.lfasiallc.com/wp-content/uploads/2017/11/\ > > Shared-Virtual-Memory-in-KVM_Yi-Liu.pdf > > [...] > > +void host_iommu_ctx_init(void *_iommu_ctx, size_t instance_size, > > + const char *mrtypename, > > + uint64_t flags) > > +{ > > + HostIOMMUContext *iommu_ctx; > > + > > + object_initialize(_iommu_ctx, instance_size, mrtypename); > > + iommu_ctx = HOST_IOMMU_CONTEXT(_iommu_ctx); > > + iommu_ctx->flags = flags; > > + iommu_ctx->initialized = true; > > +} > > + > > +static const TypeInfo host_iommu_context_info = { > > + .parent = TYPE_OBJECT, > > + .name = TYPE_HOST_IOMMU_CONTEXT, > > + .class_size = sizeof(HostIOMMUContextClass), > > + .instance_size = sizeof(HostIOMMUContext), > > + .abstract = true, > Can't we use the usual .instance_init and .instance_finalize? sorry, I somehow missed this comment. In prior patch, .instace_init was used, but the current major init method is via host_iommu_ctx_init(), so .instance_init is not really necessary. https://www.spinics.net/lists/kvm/msg210878.html Regards, Yi Liu
next prev parent reply other threads:[~2020-04-06 8:04 UTC|newest] Thread overview: 160+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-30 4:24 [PATCH v2 00/22] intel_iommu: expose Shared Virtual Addressing to VMs Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 01/22] scripts/update-linux-headers: Import iommu.h Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 02/22] header file update VFIO/IOMMU vSVA APIs Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 03/22] vfio: check VFIO_TYPE1_NESTING_IOMMU support Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 9:36 ` Auger Eric 2020-03-30 9:36 ` Auger Eric 2020-03-31 6:08 ` Liu, Yi L 2020-03-31 6:08 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 04/22] hw/iommu: introduce HostIOMMUContext Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 17:22 ` Auger Eric 2020-03-30 17:22 ` Auger Eric 2020-03-31 4:10 ` Liu, Yi L 2020-03-31 4:10 ` Liu, Yi L 2020-03-31 7:47 ` Auger Eric 2020-03-31 7:47 ` Auger Eric 2020-03-31 12:43 ` Liu, Yi L 2020-03-31 12:43 ` Liu, Yi L 2020-04-06 8:04 ` Liu, Yi L [this message] 2020-04-06 8:04 ` Liu, Yi L 2020-04-06 10:30 ` Auger Eric 2020-04-06 10:30 ` Auger Eric 2020-03-30 4:24 ` [PATCH v2 05/22] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 11:02 ` Auger Eric 2020-03-30 11:02 ` Auger Eric 2020-04-02 8:52 ` Liu, Yi L 2020-04-02 8:52 ` Liu, Yi L 2020-04-02 12:41 ` Auger Eric 2020-04-02 12:41 ` Auger Eric 2020-04-02 13:37 ` Liu, Yi L 2020-04-02 13:37 ` Liu, Yi L 2020-04-02 13:49 ` Auger Eric 2020-04-02 13:49 ` Auger Eric 2020-04-06 6:27 ` Liu, Yi L 2020-04-06 6:27 ` Liu, Yi L 2020-04-06 10:04 ` Auger Eric 2020-04-06 10:04 ` Auger Eric 2020-03-30 4:24 ` [PATCH v2 06/22] hw/pci: introduce pci_device_set/unset_iommu_context() Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 17:30 ` Auger Eric 2020-03-30 17:30 ` Auger Eric 2020-03-31 12:14 ` Liu, Yi L 2020-03-31 12:14 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 07/22] intel_iommu: add set/unset_iommu_context callback Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 20:23 ` Auger Eric 2020-03-30 20:23 ` Auger Eric 2020-03-31 12:25 ` Liu, Yi L 2020-03-31 12:25 ` Liu, Yi L 2020-03-31 12:57 ` Auger Eric 2020-03-31 12:57 ` Auger Eric 2020-03-30 4:24 ` [PATCH v2 08/22] vfio/common: provide PASID alloc/free hooks Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-31 10:47 ` Auger Eric 2020-03-31 10:47 ` Auger Eric 2020-03-31 10:59 ` Liu, Yi L 2020-03-31 10:59 ` Liu, Yi L 2020-03-31 11:15 ` Auger Eric 2020-03-31 11:15 ` Auger Eric 2020-03-31 12:54 ` Liu, Yi L 2020-03-31 12:54 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 09/22] vfio/common: init HostIOMMUContext per-container Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-04-01 7:50 ` Auger Eric 2020-04-01 7:50 ` Auger Eric 2020-04-06 7:12 ` Liu, Yi L 2020-04-06 7:12 ` Liu, Yi L 2020-04-06 10:20 ` Auger Eric 2020-04-06 10:20 ` Auger Eric 2020-04-07 11:59 ` Liu, Yi L 2020-04-07 11:59 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 10/22] vfio/pci: set host iommu context to vIOMMU Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-31 14:30 ` Auger Eric 2020-03-31 14:30 ` Auger Eric 2020-04-01 3:20 ` Liu, Yi L 2020-04-01 3:20 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 11/22] intel_iommu: add virtual command capability support Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 12/22] intel_iommu: process PASID cache invalidation Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 13/22] intel_iommu: add PASID cache management infrastructure Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-04-02 0:02 ` Peter Xu 2020-04-02 0:02 ` Peter Xu 2020-04-02 6:46 ` Liu, Yi L 2020-04-02 6:46 ` Liu, Yi L 2020-04-02 13:44 ` Peter Xu 2020-04-02 13:44 ` Peter Xu 2020-04-03 15:05 ` Liu, Yi L 2020-04-03 15:05 ` Liu, Yi L 2020-04-03 16:19 ` Peter Xu 2020-04-03 16:19 ` Peter Xu 2020-04-04 11:39 ` Liu, Yi L 2020-04-04 11:39 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 14/22] vfio: add bind stage-1 page table support Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 15/22] intel_iommu: bind/unbind guest page table to host Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-04-02 18:09 ` Peter Xu 2020-04-02 18:09 ` Peter Xu 2020-04-03 14:29 ` Liu, Yi L 2020-04-03 14:29 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 16/22] intel_iommu: replay pasid binds after context cache invalidation Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-04-03 14:45 ` Peter Xu 2020-04-03 14:45 ` Peter Xu 2020-04-03 15:21 ` Liu, Yi L 2020-04-03 15:21 ` Liu, Yi L 2020-04-03 16:11 ` Peter Xu 2020-04-03 16:11 ` Peter Xu 2020-04-04 12:00 ` Liu, Yi L 2020-04-04 12:00 ` Liu, Yi L 2020-04-06 19:48 ` Peter Xu 2020-04-06 19:48 ` Peter Xu 2020-03-30 4:24 ` [PATCH v2 17/22] intel_iommu: do not pass down pasid bind for PASID #0 Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 18/22] vfio: add support for flush iommu stage-1 cache Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:24 ` [PATCH v2 19/22] intel_iommu: process PASID-based iotlb invalidation Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-04-03 14:47 ` Peter Xu 2020-04-03 14:47 ` Peter Xu 2020-04-03 15:21 ` Liu, Yi L 2020-04-03 15:21 ` Liu, Yi L 2020-03-30 4:24 ` [PATCH v2 20/22] intel_iommu: propagate PASID-based iotlb invalidation to host Liu Yi L 2020-03-30 4:24 ` Liu Yi L 2020-03-30 4:25 ` [PATCH v2 21/22] intel_iommu: process PASID-based Device-TLB invalidation Liu Yi L 2020-03-30 4:25 ` Liu Yi L 2020-03-30 4:25 ` [PATCH v2 22/22] intel_iommu: modify x-scalable-mode to be string option Liu Yi L 2020-03-30 4:25 ` Liu Yi L 2020-04-03 14:49 ` Peter Xu 2020-04-03 14:49 ` Peter Xu 2020-04-03 15:22 ` Liu, Yi L 2020-04-03 15:22 ` Liu, Yi L 2020-03-30 5:40 ` [PATCH v2 00/22] intel_iommu: expose Shared Virtual Addressing to VMs no-reply 2020-03-30 5:40 ` no-reply 2020-03-30 10:36 ` Auger Eric 2020-03-30 10:36 ` Auger Eric 2020-03-30 14:46 ` Peter Xu 2020-03-30 14:46 ` Peter Xu 2020-03-31 6:53 ` Liu, Yi L 2020-03-31 6:53 ` Liu, Yi L 2020-04-02 8:33 ` Jason Wang 2020-04-02 8:33 ` Jason Wang 2020-04-02 13:46 ` Peter Xu 2020-04-02 13:46 ` Peter Xu 2020-04-03 1:38 ` Jason Wang 2020-04-03 1:38 ` Jason Wang 2020-04-03 14:20 ` Liu, Yi L 2020-04-03 14:20 ` Liu, Yi L 2020-04-02 18:12 ` Peter Xu 2020-04-02 18:12 ` Peter Xu 2020-04-03 14:32 ` Liu, Yi L 2020-04-03 14:32 ` Liu, Yi L
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=A2975661238FB949B60364EF0F2C25743A2230B3@SHSMSX104.ccr.corp.intel.com \ --to=yi.l.liu@intel.com \ --cc=alex.williamson@redhat.com \ --cc=david@gibson.dropbear.id.au \ --cc=eric.auger@redhat.com \ --cc=hao.wu@intel.com \ --cc=jacob.jun.pan@linux.intel.com \ --cc=jean-philippe@linaro.org \ --cc=jun.j.tian@intel.com \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peterx@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=yi.y.sun@intel.com \ --cc=yi.y.sun@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.