All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments
@ 2020-04-30  4:10 Denys Dmytriyenko
  2020-04-30  4:10 ` [PATCH 2/4] external-arm-toolchain: drop unnecessary binutils-cross-${TARGET_ARCH} in PROVIDES Denys Dmytriyenko
                   ` (4 more replies)
  0 siblings, 5 replies; 14+ messages in thread
From: Denys Dmytriyenko @ 2020-04-30  4:10 UTC (permalink / raw)
  To: meta-arm; +Cc: Denys Dmytriyenko

From: Denys Dmytriyenko <denys@ti.com>

These were there from the very beginning and they were used as crutches to
prop up the build by pointing directly to the external toolchain location,
in case early versions of external-arm-toolchain missed staging/packaging
something from there.

First of all, it is unnecessary to adjust CPPFLAGS and LDFLAGS in this way,
as external-arm-toolchain is supposed to stage everything needed from the
toolchain in internal sysroot.

And second, these settings can be harmful and conflict with component's own
CPPFLAGS/LDFLAGS. For example, OpenCV 4.1 fails to link internal libraries
because of incorrect -Wl,-rpath-link passed down the build.

After dropping these, I was able to verify that everything still builds,
including BSP, Wayland/Weston, Qt5, gstreamer, OpenCV, etc for Aarch64 and
Armv7a platforms.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
index 8ddaf53..9171380 100644
--- a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
+++ b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
@@ -44,8 +44,6 @@ PREFERRED_PROVIDER_glibc-thread-db = "external-arm-toolchain"
 PREFERRED_PROVIDER_glibc-mtrace = "external-arm-toolchain"
 PREFERRED_PROVIDER_libc-mtrace = "external-arm-toolchain"
 PREFERRED_PROVIDER_virtual/linux-libc-headers = "external-arm-toolchain"
-TARGET_CPPFLAGS_prepend = " -isystem${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/include "
-TARGET_LDFLAGS_prepend = " -L${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/lib -Wl,-rpath-link,${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/lib "
 
 TOOLCHAIN_OPTIONS = " --sysroot=${STAGING_DIR_HOST}"
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 2/4] external-arm-toolchain: drop unnecessary binutils-cross-${TARGET_ARCH} in PROVIDES
  2020-04-30  4:10 [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments Denys Dmytriyenko
@ 2020-04-30  4:10 ` Denys Dmytriyenko
  2020-04-30 10:02   ` [meta-arm] " Sumit Garg
  2020-04-30  4:10 ` [PATCH 3/4] external-arm-toolchain: add INHIBIT_AUTOTOOLS_DEPS Denys Dmytriyenko
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 14+ messages in thread
From: Denys Dmytriyenko @ 2020-04-30  4:10 UTC (permalink / raw)
  To: meta-arm; +Cc: Denys Dmytriyenko

From: Denys Dmytriyenko <denys@ti.com>

There's no need to directly provide binutils-cross-${TARGET_ARCH}, as the
PROVIDES list already contains virtual/${TARGET_PREFIX}binutils and correct
PREFERRED_PROVIDER is set in the corresponding tcmode-external-arm.inc file:

PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}binutils = "external-arm-toolchain"

Similar to the compiler:

PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}gcc = "external-arm-toolchain"
PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}gcc-initial = "external-arm-toolchain"
PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}g++ = "external-arm-toolchain"

And similar to glibc:

PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}libc-for-gcc = "external-arm-toolchain"
PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}compilerlibs = "external-arm-toolchain"

There shouldn't be any direct dependency on binutils-cross-${TARGET_ARCH}. And
if there is, it needs to be fixed to depend on virtual/${TARGET_PREFIX}binutils

During 8.x upgrade there was an attempt to clean it up:

https://git.linaro.org/openembedded/meta-linaro.git/commit/meta-linaro-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb?id=a8ce3dc47f3be9f98abc6ac98a849f918386cf9f

But unfortunately, it got re-added back w/o reasoning:

https://git.linaro.org/openembedded/meta-linaro.git/commit/?id=bb04bc8c67fd032fe04c47b2163ea5fa6b2ffa86

Also, while at it, fix indentation for glibc-mtrace in PROVIDES list.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 .../recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb  | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
index ddd3aff..33d6c35 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
@@ -15,14 +15,13 @@ PROVIDES += "\
 	virtual/${TARGET_PREFIX}g++ \
 	virtual/${TARGET_PREFIX}gcc-initial \
 	virtual/${TARGET_PREFIX}binutils \
-        binutils-cross-${TARGET_ARCH} \
 	virtual/${TARGET_PREFIX}libc-for-gcc \
 	virtual/${TARGET_PREFIX}compilerlibs \
 	virtual/libc \
 	virtual/libintl \
 	virtual/libiconv \
 	virtual/crypt \
-        glibc-mtrace \
+	glibc-mtrace \
 	glibc-thread-db \
 	glibc \
 	libc-mtrace \
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 3/4] external-arm-toolchain: add INHIBIT_AUTOTOOLS_DEPS
  2020-04-30  4:10 [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments Denys Dmytriyenko
  2020-04-30  4:10 ` [PATCH 2/4] external-arm-toolchain: drop unnecessary binutils-cross-${TARGET_ARCH} in PROVIDES Denys Dmytriyenko
@ 2020-04-30  4:10 ` Denys Dmytriyenko
  2020-04-30 10:24   ` [meta-arm] " Sumit Garg
  2020-04-30  4:10 ` [PATCH 4/4] external-arm-toolchain: drop unnecessary RDEPENDS on bash Denys Dmytriyenko
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 14+ messages in thread
From: Denys Dmytriyenko @ 2020-04-30  4:10 UTC (permalink / raw)
  To: meta-arm; +Cc: Denys Dmytriyenko

From: Denys Dmytriyenko <denys@ti.com>

Add for completeness, similar to INHIBIT_DEFAULT_DEPS, to match OE-Core, as
there's no autotools usage here.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 .../recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
index 33d6c35..adb2fdd 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
@@ -1,6 +1,7 @@
 require recipes-core/glibc/glibc-package.inc
 
 INHIBIT_DEFAULT_DEPS = "1"
+INHIBIT_AUTOTOOLS_DEPS = "1"
 
 # License applies to this recipe code, not the toolchain itself
 LICENSE = "MIT"
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 4/4] external-arm-toolchain: drop unnecessary RDEPENDS on bash
  2020-04-30  4:10 [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments Denys Dmytriyenko
  2020-04-30  4:10 ` [PATCH 2/4] external-arm-toolchain: drop unnecessary binutils-cross-${TARGET_ARCH} in PROVIDES Denys Dmytriyenko
  2020-04-30  4:10 ` [PATCH 3/4] external-arm-toolchain: add INHIBIT_AUTOTOOLS_DEPS Denys Dmytriyenko
@ 2020-04-30  4:10 ` Denys Dmytriyenko
  2020-04-30 10:41   ` [meta-arm] " Sumit Garg
  2020-04-30  9:51 ` [meta-arm] [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments Sumit Garg
  2020-05-01  6:46 ` Diego Sueiro
  4 siblings, 1 reply; 14+ messages in thread
From: Denys Dmytriyenko @ 2020-04-30  4:10 UTC (permalink / raw)
  To: meta-arm; +Cc: Denys Dmytriyenko

From: Denys Dmytriyenko <denys@ti.com>

The 2 scripts that still have /bin/bash shebang are ldd and tzselect. But
it seems upstream had fixed all bashisms in those scripts in recent years
and OE-Core versions of those scripts use /bin/sh already.

Dropping these unnecessary RDEPENDS on bash actually significantly prunes
dependency tree for simple BSP builds like u-boot, etc.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 .../external-arm-toolchain/external-arm-toolchain.bb                 | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
index adb2fdd..af75e6a 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
@@ -114,6 +114,8 @@ do_install() {
 	rm -rf ${D}${bindir}/gdbserver
 	sed -i -e 's#/arm/tools/gnu/bash/4.2/rhe6-x86_64##' ${D}${bindir}/tzselect
 	sed -i -e 's#/arm/tools/gnu/bash/4.2/rhe6-x86_64##' ${D}${bindir}/ldd
+	sed -i -e 's#/bin/bash#/bin/sh#' ${D}${bindir}/tzselect
+	sed -i -e 's#/bin/bash#/bin/sh#' ${D}${bindir}/ldd
 
 	cp ${CP_ARGS} ${EXTERNAL_TOOLCHAIN}/lib/gcc/${EAT_TARGET_SYS}/${EAT_VER_GCC}/crt*.o ${D}${libdir}/${EAT_TARGET_SYS}/${EAT_VER_GCC}/
 
@@ -421,9 +423,6 @@ FILES_libsegfault = "${base_libdir}/libSegFault*"
 FILES_catchsegv = "${bindir}/catchsegv"
 RDEPENDS_catchsegv = "libsegfault"
 
-RDEPENDS_ldd = "bash"
-RDEPENDS_tzcode = "bash"
-
 # From libgfortran.inc:
 
 FILES_libgfortran = "${libdir}/libgfortran.so.*"
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [meta-arm] [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments
  2020-04-30  4:10 [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments Denys Dmytriyenko
                   ` (2 preceding siblings ...)
  2020-04-30  4:10 ` [PATCH 4/4] external-arm-toolchain: drop unnecessary RDEPENDS on bash Denys Dmytriyenko
@ 2020-04-30  9:51 ` Sumit Garg
  2020-05-01  6:46 ` Diego Sueiro
  4 siblings, 0 replies; 14+ messages in thread
From: Sumit Garg @ 2020-04-30  9:51 UTC (permalink / raw)
  To: meta-arm; +Cc: Denys Dmytriyenko

On Thu, 30 Apr 2020 at 09:40, Denys Dmytriyenko <denis@denix.org> wrote:
>
> From: Denys Dmytriyenko <denys@ti.com>
>
> These were there from the very beginning and they were used as crutches to
> prop up the build by pointing directly to the external toolchain location,
> in case early versions of external-arm-toolchain missed staging/packaging
> something from there.
>
> First of all, it is unnecessary to adjust CPPFLAGS and LDFLAGS in this way,
> as external-arm-toolchain is supposed to stage everything needed from the
> toolchain in internal sysroot.
>
> And second, these settings can be harmful and conflict with component's own
> CPPFLAGS/LDFLAGS. For example, OpenCV 4.1 fails to link internal libraries
> because of incorrect -Wl,-rpath-link passed down the build.
>

In general I agree with you to drop these CPPFLAGS and LDFLAGS as
external-arm-toolchain already stages headers and libraries in
internal sysroot. But just out of curiosity, could you share the link
failure for OpenCV 4.1?

> After dropping these, I was able to verify that everything still builds,
> including BSP, Wayland/Weston, Qt5, gstreamer, OpenCV, etc for Aarch64 and
> Armv7a platforms.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>  meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc | 2 --
>  1 file changed, 2 deletions(-)

FWIW:

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

>
> diff --git a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> index 8ddaf53..9171380 100644
> --- a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> +++ b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> @@ -44,8 +44,6 @@ PREFERRED_PROVIDER_glibc-thread-db = "external-arm-toolchain"
>  PREFERRED_PROVIDER_glibc-mtrace = "external-arm-toolchain"
>  PREFERRED_PROVIDER_libc-mtrace = "external-arm-toolchain"
>  PREFERRED_PROVIDER_virtual/linux-libc-headers = "external-arm-toolchain"
> -TARGET_CPPFLAGS_prepend = " -isystem${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/include "
> -TARGET_LDFLAGS_prepend = " -L${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/lib -Wl,-rpath-link,${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/lib "
>
>  TOOLCHAIN_OPTIONS = " --sysroot=${STAGING_DIR_HOST}"
>
> --
> 2.7.4
>
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [meta-arm] [PATCH 2/4] external-arm-toolchain: drop unnecessary binutils-cross-${TARGET_ARCH} in PROVIDES
  2020-04-30  4:10 ` [PATCH 2/4] external-arm-toolchain: drop unnecessary binutils-cross-${TARGET_ARCH} in PROVIDES Denys Dmytriyenko
@ 2020-04-30 10:02   ` Sumit Garg
  2020-05-01  6:47     ` Diego Sueiro
  0 siblings, 1 reply; 14+ messages in thread
From: Sumit Garg @ 2020-04-30 10:02 UTC (permalink / raw)
  To: meta-arm; +Cc: Denys Dmytriyenko

On Thu, 30 Apr 2020 at 09:40, Denys Dmytriyenko <denis@denix.org> wrote:
>
> From: Denys Dmytriyenko <denys@ti.com>
>
> There's no need to directly provide binutils-cross-${TARGET_ARCH}, as the
> PROVIDES list already contains virtual/${TARGET_PREFIX}binutils and correct
> PREFERRED_PROVIDER is set in the corresponding tcmode-external-arm.inc file:
>
> PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}binutils = "external-arm-toolchain"
>
> Similar to the compiler:
>
> PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}gcc = "external-arm-toolchain"
> PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}gcc-initial = "external-arm-toolchain"
> PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}g++ = "external-arm-toolchain"
>
> And similar to glibc:
>
> PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}libc-for-gcc = "external-arm-toolchain"
> PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}compilerlibs = "external-arm-toolchain"
>
> There shouldn't be any direct dependency on binutils-cross-${TARGET_ARCH}. And
> if there is, it needs to be fixed to depend on virtual/${TARGET_PREFIX}binutils
>
> During 8.x upgrade there was an attempt to clean it up:
>
> https://git.linaro.org/openembedded/meta-linaro.git/commit/meta-linaro-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb?id=a8ce3dc47f3be9f98abc6ac98a849f918386cf9f
>
> But unfortunately, it got re-added back w/o reasoning:
>
> https://git.linaro.org/openembedded/meta-linaro.git/commit/?id=bb04bc8c67fd032fe04c47b2163ea5fa6b2ffa86
>
> Also, while at it, fix indentation for glibc-mtrace in PROVIDES list.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>  .../recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb  | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> index ddd3aff..33d6c35 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> @@ -15,14 +15,13 @@ PROVIDES += "\
>         virtual/${TARGET_PREFIX}g++ \
>         virtual/${TARGET_PREFIX}gcc-initial \
>         virtual/${TARGET_PREFIX}binutils \
> -        binutils-cross-${TARGET_ARCH} \
>         virtual/${TARGET_PREFIX}libc-for-gcc \
>         virtual/${TARGET_PREFIX}compilerlibs \
>         virtual/libc \
>         virtual/libintl \
>         virtual/libiconv \
>         virtual/crypt \
> -        glibc-mtrace \
> +       glibc-mtrace \
>         glibc-thread-db \
>         glibc \
>         libc-mtrace \
> --
> 2.7.4
>
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [meta-arm] [PATCH 3/4] external-arm-toolchain: add INHIBIT_AUTOTOOLS_DEPS
  2020-04-30  4:10 ` [PATCH 3/4] external-arm-toolchain: add INHIBIT_AUTOTOOLS_DEPS Denys Dmytriyenko
@ 2020-04-30 10:24   ` Sumit Garg
  2020-04-30 20:37     ` Denys Dmytriyenko
  0 siblings, 1 reply; 14+ messages in thread
From: Sumit Garg @ 2020-04-30 10:24 UTC (permalink / raw)
  To: meta-arm; +Cc: Denys Dmytriyenko

On Thu, 30 Apr 2020 at 09:40, Denys Dmytriyenko <denis@denix.org> wrote:
>
> From: Denys Dmytriyenko <denys@ti.com>
>
> Add for completeness, similar to INHIBIT_DEFAULT_DEPS, to match OE-Core, as
> there's no autotools usage here.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>  .../recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb    | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> index 33d6c35..adb2fdd 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> @@ -1,6 +1,7 @@
>  require recipes-core/glibc/glibc-package.inc
>
>  INHIBIT_DEFAULT_DEPS = "1"
> +INHIBIT_AUTOTOOLS_DEPS = "1"
>

IIUC, autotools are not something that are included by default under
DEPENDS. They are included if you specifically do "inherit autotools"
directly or indirectly which doesn't seem to be the case with this
recipe. So to me it seems like an unnecessary change.

-Sumit

>  # License applies to this recipe code, not the toolchain itself
>  LICENSE = "MIT"
> --
> 2.7.4
>
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [meta-arm] [PATCH 4/4] external-arm-toolchain: drop unnecessary RDEPENDS on bash
  2020-04-30  4:10 ` [PATCH 4/4] external-arm-toolchain: drop unnecessary RDEPENDS on bash Denys Dmytriyenko
@ 2020-04-30 10:41   ` Sumit Garg
  2020-05-01  6:50     ` Diego Sueiro
  0 siblings, 1 reply; 14+ messages in thread
From: Sumit Garg @ 2020-04-30 10:41 UTC (permalink / raw)
  To: meta-arm; +Cc: Denys Dmytriyenko

On Thu, 30 Apr 2020 at 09:40, Denys Dmytriyenko <denis@denix.org> wrote:
>
> From: Denys Dmytriyenko <denys@ti.com>
>
> The 2 scripts that still have /bin/bash shebang are ldd and tzselect. But
> it seems upstream had fixed all bashisms in those scripts in recent years
> and OE-Core versions of those scripts use /bin/sh already.
>
> Dropping these unnecessary RDEPENDS on bash actually significantly prunes
> dependency tree for simple BSP builds like u-boot, etc.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>  .../external-arm-toolchain/external-arm-toolchain.bb                 | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> index adb2fdd..af75e6a 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> @@ -114,6 +114,8 @@ do_install() {
>         rm -rf ${D}${bindir}/gdbserver
>         sed -i -e 's#/arm/tools/gnu/bash/4.2/rhe6-x86_64##' ${D}${bindir}/tzselect
>         sed -i -e 's#/arm/tools/gnu/bash/4.2/rhe6-x86_64##' ${D}${bindir}/ldd
> +       sed -i -e 's#/bin/bash#/bin/sh#' ${D}${bindir}/tzselect
> +       sed -i -e 's#/bin/bash#/bin/sh#' ${D}${bindir}/ldd
>
>         cp ${CP_ARGS} ${EXTERNAL_TOOLCHAIN}/lib/gcc/${EAT_TARGET_SYS}/${EAT_VER_GCC}/crt*.o ${D}${libdir}/${EAT_TARGET_SYS}/${EAT_VER_GCC}/
>
> @@ -421,9 +423,6 @@ FILES_libsegfault = "${base_libdir}/libSegFault*"
>  FILES_catchsegv = "${bindir}/catchsegv"
>  RDEPENDS_catchsegv = "libsegfault"
>
> -RDEPENDS_ldd = "bash"
> -RDEPENDS_tzcode = "bash"
> -
>  # From libgfortran.inc:
>
>  FILES_libgfortran = "${libdir}/libgfortran.so.*"
> --
> 2.7.4
>
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [meta-arm] [PATCH 3/4] external-arm-toolchain: add INHIBIT_AUTOTOOLS_DEPS
  2020-04-30 10:24   ` [meta-arm] " Sumit Garg
@ 2020-04-30 20:37     ` Denys Dmytriyenko
  0 siblings, 0 replies; 14+ messages in thread
From: Denys Dmytriyenko @ 2020-04-30 20:37 UTC (permalink / raw)
  To: meta-arm

On Thu, Apr 30, 2020 at 03:54:07PM +0530, Sumit Garg wrote:
> On Thu, 30 Apr 2020 at 09:40, Denys Dmytriyenko <denis@denix.org> wrote:
> >
> > From: Denys Dmytriyenko <denys@ti.com>
> >
> > Add for completeness, similar to INHIBIT_DEFAULT_DEPS, to match OE-Core, as
> > there's no autotools usage here.
> >
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> >  .../recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb    | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> > index 33d6c35..adb2fdd 100644
> > --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> > +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> > @@ -1,6 +1,7 @@
> >  require recipes-core/glibc/glibc-package.inc
> >
> >  INHIBIT_DEFAULT_DEPS = "1"
> > +INHIBIT_AUTOTOOLS_DEPS = "1"
> >
> 
> IIUC, autotools are not something that are included by default under
> DEPENDS. They are included if you specifically do "inherit autotools"
> directly or indirectly which doesn't seem to be the case with this
> recipe. So to me it seems like an unnecessary change.

Fair enough. This one was rather "nice to have" - I was down the rabbit hole 
for binutils-cross-${TARGET_ARCH} addressed in patch #2 and I noticed that 
binutils-cross.inc in OE-Core sets INHIBIT_AUTOTOOLS_DEPS w/o visible use of 
autotools. But I missed that binutils does use autotools for building and 
there is "inherit autotools" in binutils.inc. Yes, external-arm-toolchain 
doesn't inherit autotools, so no need for this variable - please skip this 
patch. Thanks.

-- 
Denys


> >  # License applies to this recipe code, not the toolchain itself
> >  LICENSE = "MIT"
> > --
> > 2.7.4
> >
> > 

> 


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [meta-arm] [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments
  2020-04-30  4:10 [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments Denys Dmytriyenko
                   ` (3 preceding siblings ...)
  2020-04-30  9:51 ` [meta-arm] [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments Sumit Garg
@ 2020-05-01  6:46 ` Diego Sueiro
  2020-05-01 14:03   ` Jon Mason
  4 siblings, 1 reply; 14+ messages in thread
From: Diego Sueiro @ 2020-05-01  6:46 UTC (permalink / raw)
  To: meta-arm; +Cc: Denys Dmytriyenko, nd

> -----Original Message-----
> From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>
> On Behalf Of Denys Dmytriyenko via lists.yoctoproject.org
> Sent: 30 April 2020 05:10
> To: meta-arm@lists.yoctoproject.org
> Cc: Denys Dmytriyenko <denys@ti.com>
> Subject: [meta-arm] [PATCH 1/4] tcmode-external-arm: drop unnecessary
> CPPFLAGS and LDFLAGS adjustments
> 
> From: Denys Dmytriyenko <denys@ti.com>
> 
> These were there from the very beginning and they were used as crutches to
> prop up the build by pointing directly to the external toolchain location, in
> case early versions of external-arm-toolchain missed staging/packaging
> something from there.
> 
> First of all, it is unnecessary to adjust CPPFLAGS and LDFLAGS in this way, as
> external-arm-toolchain is supposed to stage everything needed from the
> toolchain in internal sysroot.
> 
> And second, these settings can be harmful and conflict with component's
> own CPPFLAGS/LDFLAGS. For example, OpenCV 4.1 fails to link internal
> libraries because of incorrect -Wl,-rpath-link passed down the build.
> 
> After dropping these, I was able to verify that everything still builds, including
> BSP, Wayland/Weston, Qt5, gstreamer, OpenCV, etc for Aarch64 and Armv7a
> platforms.
> 
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>

Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

> ---
>  meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> index 8ddaf53..9171380 100644
> --- a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> +++ b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> @@ -44,8 +44,6 @@ PREFERRED_PROVIDER_glibc-thread-db = "external-
> arm-toolchain"
>  PREFERRED_PROVIDER_glibc-mtrace = "external-arm-toolchain"
>  PREFERRED_PROVIDER_libc-mtrace = "external-arm-toolchain"
>  PREFERRED_PROVIDER_virtual/linux-libc-headers = "external-arm-toolchain"
> -TARGET_CPPFLAGS_prepend = " -
> isystem${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/include "
> -TARGET_LDFLAGS_prepend = " -
> L${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/lib -Wl,-rpath-
> link,${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/lib "
> 
>  TOOLCHAIN_OPTIONS = " --sysroot=${STAGING_DIR_HOST}"
> 
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [meta-arm] [PATCH 2/4] external-arm-toolchain: drop unnecessary binutils-cross-${TARGET_ARCH} in PROVIDES
  2020-04-30 10:02   ` [meta-arm] " Sumit Garg
@ 2020-05-01  6:47     ` Diego Sueiro
  0 siblings, 0 replies; 14+ messages in thread
From: Diego Sueiro @ 2020-05-01  6:47 UTC (permalink / raw)
  To: meta-arm; +Cc: Denys Dmytriyenko, nd

> -----Original Message-----
> From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>
> On Behalf Of Sumit Garg via lists.yoctoproject.org
> Sent: 30 April 2020 11:02
> To: meta-arm@lists.yoctoproject.org
> Cc: Denys Dmytriyenko <denys@ti.com>
> Subject: Re: [meta-arm] [PATCH 2/4] external-arm-toolchain: drop
> unnecessary binutils-cross-${TARGET_ARCH} in PROVIDES
> 
> On Thu, 30 Apr 2020 at 09:40, Denys Dmytriyenko <denis@denix.org> wrote:
> >
> > From: Denys Dmytriyenko <denys@ti.com>
> >
> > There's no need to directly provide binutils-cross-${TARGET_ARCH}, as
> > the PROVIDES list already contains virtual/${TARGET_PREFIX}binutils
> > and correct PREFERRED_PROVIDER is set in the corresponding tcmode-
> external-arm.inc file:
> >
> > PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}binutils = "external-arm-
> toolchain"
> >
> > Similar to the compiler:
> >
> > PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}gcc = "external-arm-
> toolchain"
> > PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}gcc-initial = "external-
> arm-toolchain"
> > PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}g++ = "external-arm-
> toolchain"
> >
> > And similar to glibc:
> >
> > PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}libc-for-gcc = "external-
> arm-toolchain"
> > PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}compilerlibs = "external-
> arm-toolchain"
> >
> > There shouldn't be any direct dependency on
> > binutils-cross-${TARGET_ARCH}. And if there is, it needs to be fixed
> > to depend on virtual/${TARGET_PREFIX}binutils
> >
> > During 8.x upgrade there was an attempt to clean it up:
> >
> > https://git.linaro.org/openembedded/meta-linaro.git/commit/meta-linaro
> > -toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolch
> > ain.bb?id=a8ce3dc47f3be9f98abc6ac98a849f918386cf9f
> >
> > But unfortunately, it got re-added back w/o reasoning:
> >
> > https://git.linaro.org/openembedded/meta-
> linaro.git/commit/?id=bb04bc8
> > c67fd032fe04c47b2163ea5fa6b2ffa86
> >
> > Also, while at it, fix indentation for glibc-mtrace in PROVIDES list.
> >
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>

Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

> > ---
> >  .../recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> > | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> 
> Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
> 
> > diff --git
> > a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-
> > arm-toolchain.bb
> > b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-
> > arm-toolchain.bb
> > index ddd3aff..33d6c35 100644
> > ---
> > a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-
> > arm-toolchain.bb
> > +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/exter
> > +++ nal-arm-toolchain.bb
> > @@ -15,14 +15,13 @@ PROVIDES += "\
> >         virtual/${TARGET_PREFIX}g++ \
> >         virtual/${TARGET_PREFIX}gcc-initial \
> >         virtual/${TARGET_PREFIX}binutils \
> > -        binutils-cross-${TARGET_ARCH} \
> >         virtual/${TARGET_PREFIX}libc-for-gcc \
> >         virtual/${TARGET_PREFIX}compilerlibs \
> >         virtual/libc \
> >         virtual/libintl \
> >         virtual/libiconv \
> >         virtual/crypt \
> > -        glibc-mtrace \
> > +       glibc-mtrace \
> >         glibc-thread-db \
> >         glibc \
> >         libc-mtrace \
> > --
> > 2.7.4
> >
> >

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [meta-arm] [PATCH 4/4] external-arm-toolchain: drop unnecessary RDEPENDS on bash
  2020-04-30 10:41   ` [meta-arm] " Sumit Garg
@ 2020-05-01  6:50     ` Diego Sueiro
  0 siblings, 0 replies; 14+ messages in thread
From: Diego Sueiro @ 2020-05-01  6:50 UTC (permalink / raw)
  To: meta-arm; +Cc: Denys Dmytriyenko, nd

> -----Original Message-----
> From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>
> On Behalf Of Sumit Garg via lists.yoctoproject.org
> Sent: 30 April 2020 11:42
> To: meta-arm@lists.yoctoproject.org
> Cc: Denys Dmytriyenko <denys@ti.com>
> Subject: Re: [meta-arm] [PATCH 4/4] external-arm-toolchain: drop
> unnecessary RDEPENDS on bash
> 
> On Thu, 30 Apr 2020 at 09:40, Denys Dmytriyenko <denis@denix.org> wrote:
> >
> > From: Denys Dmytriyenko <denys@ti.com>
> >
> > The 2 scripts that still have /bin/bash shebang are ldd and tzselect.
> > But it seems upstream had fixed all bashisms in those scripts in
> > recent years and OE-Core versions of those scripts use /bin/sh already.
> >
> > Dropping these unnecessary RDEPENDS on bash actually significantly
> > prunes dependency tree for simple BSP builds like u-boot, etc.
> >
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>

Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

> > ---
> >  .../external-arm-toolchain/external-arm-toolchain.bb                 | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> 
> Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
> 
> > diff --git
> > a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-
> > arm-toolchain.bb
> > b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-
> > arm-toolchain.bb
> > index adb2fdd..af75e6a 100644
> > ---
> > a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-
> > arm-toolchain.bb
> > +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/exter
> > +++ nal-arm-toolchain.bb
> > @@ -114,6 +114,8 @@ do_install() {
> >         rm -rf ${D}${bindir}/gdbserver
> >         sed -i -e 's#/arm/tools/gnu/bash/4.2/rhe6-x86_64##'
> ${D}${bindir}/tzselect
> >         sed -i -e 's#/arm/tools/gnu/bash/4.2/rhe6-x86_64##'
> > ${D}${bindir}/ldd
> > +       sed -i -e 's#/bin/bash#/bin/sh#' ${D}${bindir}/tzselect
> > +       sed -i -e 's#/bin/bash#/bin/sh#' ${D}${bindir}/ldd
> >
> >         cp ${CP_ARGS}
> >
> ${EXTERNAL_TOOLCHAIN}/lib/gcc/${EAT_TARGET_SYS}/${EAT_VER_GCC}/crt
> *.o
> > ${D}${libdir}/${EAT_TARGET_SYS}/${EAT_VER_GCC}/
> >
> > @@ -421,9 +423,6 @@ FILES_libsegfault = "${base_libdir}/libSegFault*"
> >  FILES_catchsegv = "${bindir}/catchsegv"
> >  RDEPENDS_catchsegv = "libsegfault"
> >
> > -RDEPENDS_ldd = "bash"
> > -RDEPENDS_tzcode = "bash"
> > -
> >  # From libgfortran.inc:
> >
> >  FILES_libgfortran = "${libdir}/libgfortran.so.*"
> > --
> > 2.7.4
> >
> >

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [meta-arm] [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments
  2020-05-01  6:46 ` Diego Sueiro
@ 2020-05-01 14:03   ` Jon Mason
  2020-05-01 17:47     ` Denys Dmytriyenko
  0 siblings, 1 reply; 14+ messages in thread
From: Jon Mason @ 2020-05-01 14:03 UTC (permalink / raw)
  To: meta-arm; +Cc: Denys Dmytriyenko, nd

On Fri, May 01, 2020 at 06:46:08AM +0000, Diego Sueiro wrote:
> > -----Original Message-----
> > From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>
> > On Behalf Of Denys Dmytriyenko via lists.yoctoproject.org
> > Sent: 30 April 2020 05:10
> > To: meta-arm@lists.yoctoproject.org
> > Cc: Denys Dmytriyenko <denys@ti.com>
> > Subject: [meta-arm] [PATCH 1/4] tcmode-external-arm: drop unnecessary
> > CPPFLAGS and LDFLAGS adjustments
> > 
> > From: Denys Dmytriyenko <denys@ti.com>
> > 
> > These were there from the very beginning and they were used as crutches to
> > prop up the build by pointing directly to the external toolchain location, in
> > case early versions of external-arm-toolchain missed staging/packaging
> > something from there.
> > 
> > First of all, it is unnecessary to adjust CPPFLAGS and LDFLAGS in this way, as
> > external-arm-toolchain is supposed to stage everything needed from the
> > toolchain in internal sysroot.
> > 
> > And second, these settings can be harmful and conflict with component's
> > own CPPFLAGS/LDFLAGS. For example, OpenCV 4.1 fails to link internal
> > libraries because of incorrect -Wl,-rpath-link passed down the build.
> > 
> > After dropping these, I was able to verify that everything still builds, including
> > BSP, Wayland/Weston, Qt5, gstreamer, OpenCV, etc for Aarch64 and Armv7a
> > platforms.
> > 
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> 
> Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>

Series (except the patch you said to ignore) pulled into the master branch.

Thanks,
Jon


> 
> > ---
> >  meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> > b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> > index 8ddaf53..9171380 100644
> > --- a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> > +++ b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> > @@ -44,8 +44,6 @@ PREFERRED_PROVIDER_glibc-thread-db = "external-
> > arm-toolchain"
> >  PREFERRED_PROVIDER_glibc-mtrace = "external-arm-toolchain"
> >  PREFERRED_PROVIDER_libc-mtrace = "external-arm-toolchain"
> >  PREFERRED_PROVIDER_virtual/linux-libc-headers = "external-arm-toolchain"
> > -TARGET_CPPFLAGS_prepend = " -
> > isystem${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/include "
> > -TARGET_LDFLAGS_prepend = " -
> > L${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/lib -Wl,-rpath-
> > link,${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/lib "
> > 
> >  TOOLCHAIN_OPTIONS = " --sysroot=${STAGING_DIR_HOST}"
> > 
> > --
> > 2.7.4
> 

> 


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [meta-arm] [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments
  2020-05-01 14:03   ` Jon Mason
@ 2020-05-01 17:47     ` Denys Dmytriyenko
  0 siblings, 0 replies; 14+ messages in thread
From: Denys Dmytriyenko @ 2020-05-01 17:47 UTC (permalink / raw)
  To: meta-arm; +Cc: Jon Mason

On Fri, May 01, 2020 at 10:03:15AM -0400, Jon Mason wrote:
> On Fri, May 01, 2020 at 06:46:08AM +0000, Diego Sueiro wrote:
> > > -----Original Message-----
> > > From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>
> > > On Behalf Of Denys Dmytriyenko via lists.yoctoproject.org
> > > Sent: 30 April 2020 05:10
> > > To: meta-arm@lists.yoctoproject.org
> > > Cc: Denys Dmytriyenko <denys@ti.com>
> > > Subject: [meta-arm] [PATCH 1/4] tcmode-external-arm: drop unnecessary
> > > CPPFLAGS and LDFLAGS adjustments
> > > 
> > > From: Denys Dmytriyenko <denys@ti.com>
> > > 
> > > These were there from the very beginning and they were used as crutches to
> > > prop up the build by pointing directly to the external toolchain location, in
> > > case early versions of external-arm-toolchain missed staging/packaging
> > > something from there.
> > > 
> > > First of all, it is unnecessary to adjust CPPFLAGS and LDFLAGS in this way, as
> > > external-arm-toolchain is supposed to stage everything needed from the
> > > toolchain in internal sysroot.
> > > 
> > > And second, these settings can be harmful and conflict with component's
> > > own CPPFLAGS/LDFLAGS. For example, OpenCV 4.1 fails to link internal
> > > libraries because of incorrect -Wl,-rpath-link passed down the build.
> > > 
> > > After dropping these, I was able to verify that everything still builds, including
> > > BSP, Wayland/Weston, Qt5, gstreamer, OpenCV, etc for Aarch64 and Armv7a
> > > platforms.
> > > 
> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > 
> > Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
> 
> Series (except the patch you said to ignore) pulled into the master branch.

Thanks, Jon!

I don't see them in master, though:
http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/

Denys


> > > ---
> > >  meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> > > b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> > > index 8ddaf53..9171380 100644
> > > --- a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> > > +++ b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> > > @@ -44,8 +44,6 @@ PREFERRED_PROVIDER_glibc-thread-db = "external-
> > > arm-toolchain"
> > >  PREFERRED_PROVIDER_glibc-mtrace = "external-arm-toolchain"
> > >  PREFERRED_PROVIDER_libc-mtrace = "external-arm-toolchain"
> > >  PREFERRED_PROVIDER_virtual/linux-libc-headers = "external-arm-toolchain"
> > > -TARGET_CPPFLAGS_prepend = " -
> > > isystem${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/include "
> > > -TARGET_LDFLAGS_prepend = " -
> > > L${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/lib -Wl,-rpath-
> > > link,${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/lib "
> > > 
> > >  TOOLCHAIN_OPTIONS = " --sysroot=${STAGING_DIR_HOST}"
> > > 
> > > --
> > > 2.7.4
> > 
> 
> > 
> 

> 


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2020-05-01 17:47 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30  4:10 [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments Denys Dmytriyenko
2020-04-30  4:10 ` [PATCH 2/4] external-arm-toolchain: drop unnecessary binutils-cross-${TARGET_ARCH} in PROVIDES Denys Dmytriyenko
2020-04-30 10:02   ` [meta-arm] " Sumit Garg
2020-05-01  6:47     ` Diego Sueiro
2020-04-30  4:10 ` [PATCH 3/4] external-arm-toolchain: add INHIBIT_AUTOTOOLS_DEPS Denys Dmytriyenko
2020-04-30 10:24   ` [meta-arm] " Sumit Garg
2020-04-30 20:37     ` Denys Dmytriyenko
2020-04-30  4:10 ` [PATCH 4/4] external-arm-toolchain: drop unnecessary RDEPENDS on bash Denys Dmytriyenko
2020-04-30 10:41   ` [meta-arm] " Sumit Garg
2020-05-01  6:50     ` Diego Sueiro
2020-04-30  9:51 ` [meta-arm] [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments Sumit Garg
2020-05-01  6:46 ` Diego Sueiro
2020-05-01 14:03   ` Jon Mason
2020-05-01 17:47     ` Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.