All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yanhong Wang <yanhong.wang@starfivetech.com>,
	linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Richard Cochran <richardcochran@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v4 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names
Date: Wed, 18 Jan 2023 16:47:09 +0100	[thread overview]
Message-ID: <15a87640-d8c7-d7aa-bdfb-608fa2e497cb@linaro.org> (raw)
In-Reply-To: <20230118061701.30047-3-yanhong.wang@starfivetech.com>

On 18/01/2023 07:16, Yanhong Wang wrote:
> Some boards(such as StarFive VisionFive v2) require more than one value
> which defined by resets property, so the original definition can not
> meet the requirements. In order to adapt to different requirements,
> adjust the maxitems number definition.
> 
> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
> ---
>  Documentation/devicetree/bindings/net/snps,dwmac.yaml | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index e26c3e76ebb7..baf2c5b9e92d 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -133,12 +133,9 @@ properties:
>          - ptp_ref
>  
>    resets:
> -    maxItems: 1

Also, this does not make sense on its own and messes constraints for all
other users. So another no for entire patch.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yanhong Wang <yanhong.wang@starfivetech.com>,
	linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Richard Cochran <richardcochran@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v4 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names
Date: Wed, 18 Jan 2023 16:47:09 +0100	[thread overview]
Message-ID: <15a87640-d8c7-d7aa-bdfb-608fa2e497cb@linaro.org> (raw)
In-Reply-To: <20230118061701.30047-3-yanhong.wang@starfivetech.com>

On 18/01/2023 07:16, Yanhong Wang wrote:
> Some boards(such as StarFive VisionFive v2) require more than one value
> which defined by resets property, so the original definition can not
> meet the requirements. In order to adapt to different requirements,
> adjust the maxitems number definition.
> 
> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
> ---
>  Documentation/devicetree/bindings/net/snps,dwmac.yaml | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index e26c3e76ebb7..baf2c5b9e92d 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -133,12 +133,9 @@ properties:
>          - ptp_ref
>  
>    resets:
> -    maxItems: 1

Also, this does not make sense on its own and messes constraints for all
other users. So another no for entire patch.

Best regards,
Krzysztof


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2023-01-18 15:50 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18  6:16 [PATCH v4 0/7] Add Ethernet driver for StarFive JH7110 SoC Yanhong Wang
2023-01-18  6:16 ` Yanhong Wang
2023-01-18  6:16 ` [PATCH v4 1/7] dt-bindings: net: snps,dwmac: Add dwmac-5.20 version Yanhong Wang
2023-01-18  6:16   ` Yanhong Wang
2023-01-18  6:16 ` [PATCH v4 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names Yanhong Wang
2023-01-18  6:16   ` Yanhong Wang
2023-01-18 13:10   ` Rob Herring
2023-01-18 13:10     ` Rob Herring
2023-01-18 15:46   ` Krzysztof Kozlowski
2023-01-18 15:46     ` Krzysztof Kozlowski
2023-01-18 15:47   ` Krzysztof Kozlowski [this message]
2023-01-18 15:47     ` Krzysztof Kozlowski
2023-02-07  2:43     ` yanhong wang
2023-02-07  2:43       ` yanhong wang
2023-02-07  7:59       ` Krzysztof Kozlowski
2023-02-07  7:59         ` Krzysztof Kozlowski
2023-02-15  7:46         ` yanhong wang
2023-02-15  7:46           ` yanhong wang
2023-02-16  8:13           ` Krzysztof Kozlowski
2023-02-16  8:13             ` Krzysztof Kozlowski
2023-01-18  6:16 ` [PATCH v4 3/7] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Yanhong Wang
2023-01-18  6:16   ` Yanhong Wang
2023-01-18  6:16 ` [PATCH v4 4/7] dt-bindings: net: Add support StarFive dwmac Yanhong Wang
2023-01-18  6:16   ` Yanhong Wang
2023-01-18 15:49   ` Krzysztof Kozlowski
2023-01-18 15:49     ` Krzysztof Kozlowski
2023-02-03  5:58     ` yanhong wang
2023-02-03  5:58       ` yanhong wang
2023-01-18  6:16 ` [PATCH v4 5/7] net: stmmac: Add glue layer for StarFive JH7110 SoCs Yanhong Wang
2023-01-18  6:16   ` Yanhong Wang
2023-02-16 10:53   ` Emil Renner Berthing
2023-02-16 10:53     ` Emil Renner Berthing
2023-02-21  2:27     ` yanhong wang
2023-02-21  2:27       ` yanhong wang
2023-02-26 15:15       ` Emil Renner Berthing
2023-02-26 15:15         ` Emil Renner Berthing
2023-01-18  6:17 ` [PATCH v4 6/7] riscv: dts: starfive: jh7110: Add ethernet device node Yanhong Wang
2023-01-18  6:17   ` Yanhong Wang
2023-01-18 15:51   ` Krzysztof Kozlowski
2023-01-18 15:51     ` Krzysztof Kozlowski
2023-02-03  3:14     ` yanhong wang
2023-02-03  3:14       ` yanhong wang
2023-02-03  7:09       ` Krzysztof Kozlowski
2023-02-03  7:09         ` Krzysztof Kozlowski
2023-02-03  7:40         ` yanhong wang
2023-02-03  7:40           ` yanhong wang
2023-02-03  7:56           ` Krzysztof Kozlowski
2023-02-03  7:56             ` Krzysztof Kozlowski
2023-02-03  9:01             ` yanhong wang
2023-02-03  9:01               ` yanhong wang
2023-02-20 14:22   ` Emil Renner Berthing
2023-02-20 14:22     ` Emil Renner Berthing
2023-02-20 15:00     ` Emil Renner Berthing
2023-02-20 15:00       ` Emil Renner Berthing
2023-01-18  6:17 ` [PATCH v4 7/7] riscv: dts: starfive: visionfive-v2: Enable gmac device tree node Yanhong Wang
2023-01-18  6:17   ` Yanhong Wang
2023-02-20 14:05   ` Emil Renner Berthing
2023-02-20 14:05     ` Emil Renner Berthing
2023-01-18 23:21 ` [PATCH v4 0/7] Add Ethernet driver for StarFive JH7110 SoC Conor Dooley
2023-01-18 23:21   ` Conor Dooley
2023-02-03  3:02   ` yanhong wang
2023-02-03  3:02     ` yanhong wang
2023-02-04 14:22     ` Conor Dooley
2023-02-04 14:22       ` Conor Dooley
2023-02-04 17:16       ` Andrew Lunn
2023-02-04 17:16         ` Andrew Lunn
2023-02-05 10:11         ` Conor Dooley
2023-02-05 10:11           ` Conor Dooley
2023-02-06  1:15         ` yanhong wang
2023-02-06  1:15           ` yanhong wang
2023-02-06  1:05       ` yanhong wang
2023-02-06  1:05         ` yanhong wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15a87640-d8c7-d7aa-bdfb-608fa2e497cb@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kernel@esmil.dk \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pgwipeout@gmail.com \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=yanhong.wang@starfivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.