All of lore.kernel.org
 help / color / mirror / Atom feed
From: yanhong wang <yanhong.wang@starfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	<linux-riscv@lists.infradead.org>, <netdev@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Richard Cochran <richardcochran@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v4 6/7] riscv: dts: starfive: jh7110: Add ethernet device node
Date: Fri, 3 Feb 2023 17:01:52 +0800	[thread overview]
Message-ID: <a385e270-c217-4a29-1539-701450b32062@starfivetech.com> (raw)
In-Reply-To: <f937ed98-a65e-e75e-24b4-0219e0403ac0@linaro.org>



On 2023/2/3 15:56, Krzysztof Kozlowski wrote:
> On 03/02/2023 08:40, yanhong wang wrote:
>>>
>> 
>> Sorry, I didn't check all the bindings, only the modified ones, the command 
>> used is as follows: 
>> "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/snps,dwmac.yaml"
>> "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml"
> 
> That's good actually, except that you change binding used by others, so
> you affect other files.
> 
> However in this DTS you will have now warnings (dtbs_check with
> simple-bus or dtbs W=1) because of using non-MMIO node in your soc-bus.
> The stmmac-axi-config probably should be moved outside of soc node. Or
> you keep two of them - one in each ethernet node.
> 

Thanks. The stmmac-axi-config probably will be moved outside of soc node in the next version.

> Best regards,
> Krzysztof
> 

WARNING: multiple messages have this Message-ID (diff)
From: yanhong wang <yanhong.wang@starfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	<linux-riscv@lists.infradead.org>, <netdev@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Richard Cochran <richardcochran@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v4 6/7] riscv: dts: starfive: jh7110: Add ethernet device node
Date: Fri, 3 Feb 2023 17:01:52 +0800	[thread overview]
Message-ID: <a385e270-c217-4a29-1539-701450b32062@starfivetech.com> (raw)
In-Reply-To: <f937ed98-a65e-e75e-24b4-0219e0403ac0@linaro.org>



On 2023/2/3 15:56, Krzysztof Kozlowski wrote:
> On 03/02/2023 08:40, yanhong wang wrote:
>>>
>> 
>> Sorry, I didn't check all the bindings, only the modified ones, the command 
>> used is as follows: 
>> "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/snps,dwmac.yaml"
>> "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml"
> 
> That's good actually, except that you change binding used by others, so
> you affect other files.
> 
> However in this DTS you will have now warnings (dtbs_check with
> simple-bus or dtbs W=1) because of using non-MMIO node in your soc-bus.
> The stmmac-axi-config probably should be moved outside of soc node. Or
> you keep two of them - one in each ethernet node.
> 

Thanks. The stmmac-axi-config probably will be moved outside of soc node in the next version.

> Best regards,
> Krzysztof
> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2023-02-03  9:02 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18  6:16 [PATCH v4 0/7] Add Ethernet driver for StarFive JH7110 SoC Yanhong Wang
2023-01-18  6:16 ` Yanhong Wang
2023-01-18  6:16 ` [PATCH v4 1/7] dt-bindings: net: snps,dwmac: Add dwmac-5.20 version Yanhong Wang
2023-01-18  6:16   ` Yanhong Wang
2023-01-18  6:16 ` [PATCH v4 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names Yanhong Wang
2023-01-18  6:16   ` Yanhong Wang
2023-01-18 13:10   ` Rob Herring
2023-01-18 13:10     ` Rob Herring
2023-01-18 15:46   ` Krzysztof Kozlowski
2023-01-18 15:46     ` Krzysztof Kozlowski
2023-01-18 15:47   ` Krzysztof Kozlowski
2023-01-18 15:47     ` Krzysztof Kozlowski
2023-02-07  2:43     ` yanhong wang
2023-02-07  2:43       ` yanhong wang
2023-02-07  7:59       ` Krzysztof Kozlowski
2023-02-07  7:59         ` Krzysztof Kozlowski
2023-02-15  7:46         ` yanhong wang
2023-02-15  7:46           ` yanhong wang
2023-02-16  8:13           ` Krzysztof Kozlowski
2023-02-16  8:13             ` Krzysztof Kozlowski
2023-01-18  6:16 ` [PATCH v4 3/7] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Yanhong Wang
2023-01-18  6:16   ` Yanhong Wang
2023-01-18  6:16 ` [PATCH v4 4/7] dt-bindings: net: Add support StarFive dwmac Yanhong Wang
2023-01-18  6:16   ` Yanhong Wang
2023-01-18 15:49   ` Krzysztof Kozlowski
2023-01-18 15:49     ` Krzysztof Kozlowski
2023-02-03  5:58     ` yanhong wang
2023-02-03  5:58       ` yanhong wang
2023-01-18  6:16 ` [PATCH v4 5/7] net: stmmac: Add glue layer for StarFive JH7110 SoCs Yanhong Wang
2023-01-18  6:16   ` Yanhong Wang
2023-02-16 10:53   ` Emil Renner Berthing
2023-02-16 10:53     ` Emil Renner Berthing
2023-02-21  2:27     ` yanhong wang
2023-02-21  2:27       ` yanhong wang
2023-02-26 15:15       ` Emil Renner Berthing
2023-02-26 15:15         ` Emil Renner Berthing
2023-01-18  6:17 ` [PATCH v4 6/7] riscv: dts: starfive: jh7110: Add ethernet device node Yanhong Wang
2023-01-18  6:17   ` Yanhong Wang
2023-01-18 15:51   ` Krzysztof Kozlowski
2023-01-18 15:51     ` Krzysztof Kozlowski
2023-02-03  3:14     ` yanhong wang
2023-02-03  3:14       ` yanhong wang
2023-02-03  7:09       ` Krzysztof Kozlowski
2023-02-03  7:09         ` Krzysztof Kozlowski
2023-02-03  7:40         ` yanhong wang
2023-02-03  7:40           ` yanhong wang
2023-02-03  7:56           ` Krzysztof Kozlowski
2023-02-03  7:56             ` Krzysztof Kozlowski
2023-02-03  9:01             ` yanhong wang [this message]
2023-02-03  9:01               ` yanhong wang
2023-02-20 14:22   ` Emil Renner Berthing
2023-02-20 14:22     ` Emil Renner Berthing
2023-02-20 15:00     ` Emil Renner Berthing
2023-02-20 15:00       ` Emil Renner Berthing
2023-01-18  6:17 ` [PATCH v4 7/7] riscv: dts: starfive: visionfive-v2: Enable gmac device tree node Yanhong Wang
2023-01-18  6:17   ` Yanhong Wang
2023-02-20 14:05   ` Emil Renner Berthing
2023-02-20 14:05     ` Emil Renner Berthing
2023-01-18 23:21 ` [PATCH v4 0/7] Add Ethernet driver for StarFive JH7110 SoC Conor Dooley
2023-01-18 23:21   ` Conor Dooley
2023-02-03  3:02   ` yanhong wang
2023-02-03  3:02     ` yanhong wang
2023-02-04 14:22     ` Conor Dooley
2023-02-04 14:22       ` Conor Dooley
2023-02-04 17:16       ` Andrew Lunn
2023-02-04 17:16         ` Andrew Lunn
2023-02-05 10:11         ` Conor Dooley
2023-02-05 10:11           ` Conor Dooley
2023-02-06  1:15         ` yanhong wang
2023-02-06  1:15           ` yanhong wang
2023-02-06  1:05       ` yanhong wang
2023-02-06  1:05         ` yanhong wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a385e270-c217-4a29-1539-701450b32062@starfivetech.com \
    --to=yanhong.wang@starfivetech.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kernel@esmil.dk \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pgwipeout@gmail.com \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.