All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Daniel Palmer <daniel@0x0f.com>
Cc: DTML <devicetree@vger.kernel.org>,
	linux-clk@vger.kernel.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH 3/6] clk: mstar: MStar/SigmaStar MPLL driver
Date: Sun, 20 Dec 2020 10:43:07 -0800	[thread overview]
Message-ID: <160848978734.1580929.11702930284423878688@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <CAFr9PXmAe9o5KtTG58twpumWi3A=7YfsM7b7pOwRTk1f=jCKQQ@mail.gmail.com>

Quoting Daniel Palmer (2020-12-19 22:42:40)
> > > +
> > > +static int msc313_mpll_remove(struct platform_device *pdev)
> > > +{
> > > +       struct msc313_mpll *mpll = platform_get_drvdata(pdev);
> > > +       int i;
> > > +
> > > +       for (i = 0; i < ARRAY_SIZE(output_dividers); i++)
> > > +               clk_hw_unregister_fixed_factor(to_divider_hw(mpll, i));
> >
> > Maybe add a devm_ for this if it doesn't exist.
> 
> I did think about adding this. Would I need to do that in a separate
> series or would it be ok to roll it into this one?
> 

Can be part of the same series.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Daniel Palmer <daniel@0x0f.com>
Cc: DTML <devicetree@vger.kernel.org>, Willy Tarreau <w@1wt.eu>,
	linux-clk@vger.kernel.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/6] clk: mstar: MStar/SigmaStar MPLL driver
Date: Sun, 20 Dec 2020 10:43:07 -0800	[thread overview]
Message-ID: <160848978734.1580929.11702930284423878688@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <CAFr9PXmAe9o5KtTG58twpumWi3A=7YfsM7b7pOwRTk1f=jCKQQ@mail.gmail.com>

Quoting Daniel Palmer (2020-12-19 22:42:40)
> > > +
> > > +static int msc313_mpll_remove(struct platform_device *pdev)
> > > +{
> > > +       struct msc313_mpll *mpll = platform_get_drvdata(pdev);
> > > +       int i;
> > > +
> > > +       for (i = 0; i < ARRAY_SIZE(output_dividers); i++)
> > > +               clk_hw_unregister_fixed_factor(to_divider_hw(mpll, i));
> >
> > Maybe add a devm_ for this if it doesn't exist.
> 
> I did think about adding this. Would I need to do that in a separate
> series or would it be ok to roll it into this one?
> 

Can be part of the same series.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-12-20 18:44 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-14 13:50 [PATCH 0/6] ARM: mstar: Basic MPLL support Daniel Palmer
2020-11-14 13:50 ` Daniel Palmer
2020-11-14 13:50 ` [PATCH 1/6] dt-bindings: clk: mstar msc313 mpll binding header Daniel Palmer
2020-11-14 13:50   ` Daniel Palmer
2020-12-07 19:02   ` Rob Herring
2020-12-07 19:02     ` Rob Herring
2020-11-14 13:50 ` [PATCH 2/6] dt-bindings: clk: mstar msc313 mpll binding description Daniel Palmer
2020-11-14 13:50   ` Daniel Palmer
2020-12-07 19:03   ` Rob Herring
2020-12-07 19:03     ` Rob Herring
2020-12-20  3:39   ` Stephen Boyd
2020-12-20  3:39     ` Stephen Boyd
2020-12-20  6:35     ` Daniel Palmer
2020-12-20  6:35       ` Daniel Palmer
2020-12-20 18:44       ` Stephen Boyd
2020-12-20 18:44         ` Stephen Boyd
2020-12-21  8:51         ` Daniel Palmer
2020-12-21  8:51           ` Daniel Palmer
2021-02-10  2:29           ` Stephen Boyd
2021-02-10  2:29             ` Stephen Boyd
2021-02-11  2:28             ` Daniel Palmer
2021-02-11  2:28               ` Daniel Palmer
2021-02-11  2:55               ` Stephen Boyd
2021-02-11  2:55                 ` Stephen Boyd
2020-11-14 13:50 ` [PATCH 3/6] clk: mstar: MStar/SigmaStar MPLL driver Daniel Palmer
2020-11-14 13:50   ` Daniel Palmer
2020-12-20  4:36   ` Stephen Boyd
2020-12-20  4:36     ` Stephen Boyd
2020-12-20  6:42     ` Daniel Palmer
2020-12-20  6:42       ` Daniel Palmer
2020-12-20 18:43       ` Stephen Boyd [this message]
2020-12-20 18:43         ` Stephen Boyd
2020-12-21  8:40         ` Daniel Palmer
2020-12-21  8:40           ` Daniel Palmer
2020-11-14 13:50 ` [PATCH 4/6] ARM: mstar: Select MSTAR_MSC313_MPLL Daniel Palmer
2020-11-14 13:50   ` Daniel Palmer
2020-11-14 13:50 ` [PATCH 5/6] ARM: mstar: Add the external clocks to the base dsti Daniel Palmer
2020-11-14 13:50   ` Daniel Palmer
2020-11-14 13:50 ` [PATCH 6/6] ARM: mstar: Add mpll to base dtsi Daniel Palmer
2020-11-14 13:50   ` Daniel Palmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160848978734.1580929.11702930284423878688@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=daniel@0x0f.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.